activerecord 1.10.1 → 1.11.0

data/CHANGELOG

@@ -1,3 +1,171 @@
+*1.11.0* (5th July, 2005)
+
+* Fixed that Yaml error message in fixtures hid the real error #1623 [Nicholas Seckar]
+
+* Changed logging of SQL statements to use the DEBUG level instead of INFO
+
+* Added new Migrations framework for describing schema transformations in a way that can be easily applied across multiple databases #1604 [Tobias Luetke] See documentation under ActiveRecord::Migration and the additional support in the Rails rakefile/generator.
+
+* Added callback hooks to association collections #1549 [Florian Weber]. Example:
+
+    class Project
+      has_and_belongs_to_many :developers, :before_add => :evaluate_velocity
+    
+      def evaluate_velocity(developer)
+        ...
+      end
+    end 
+  
+  ..raising an exception will cause the object not to be added (or removed, with before_remove).
+    
+
+* Fixed Base.content_columns call for SQL Server adapter #1450 [DeLynn Berry]
+
+* Fixed Base#write_attribute to work with both symbols and strings #1190 [Paul Legato]
+
+* Fixed that has_and_belongs_to_many didn't respect single table inheritance types #1081 [Florian Weber]
+
+* Speed up ActiveRecord#method_missing for the common case (read_attribute).
+
+* Only notify observers on after_find and after_initialize if these methods are defined on the model.  #1235 [skaes@web.de]
+
+* Fixed that single-table inheritance sub-classes couldn't be used to limit the result set with eager loading #1215 [Chris McGrath]
+
+* Fixed validates_numericality_of to work with overrided getter-method when :allow_nil is on #1316 [raidel@onemail.at]
+
+* Added roots, root, and siblings to the batch of methods added by acts_as_tree #1541 [michael@schuerig.de]
+
+* Added support for limit/offset with the MS SQL Server driver so that pagination will now work #1569 [DeLynn Berry]
+
+* Added support for ODBC connections to MS SQL Server so you can connect from a non-Windows machine #1569 [Mark Imbriaco/DeLynn Berry]
+
+* Fixed that multiparameter posts ignored attr_protected #1532 [alec+rails@veryclever.net]
+
+* Fixed problem with eager loading when using a has_and_belongs_to_many association using :association_foreign_key #1504 [flash@vanklinkenbergsoftware.nl]
+
+* Fixed Base#find to honor the documentation on how :joins work and make them consistent with Base#count #1405 [pritchie@gmail.com]. What used to be:
+
+    Developer.find :all, :joins => 'developers_projects', :conditions => 'id=developer_id AND project_id=1'
+  
+  ...should instead be:
+  
+    Developer.find(
+      :all, 
+      :joins => 'LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id', 
+      :conditions => 'project_id=1'
+    )    
+
+* Fixed that validations didn't respecting custom setting for too_short, too_long messages #1437 [Marcel Molina]
+
+* Fixed that clear_association_cache doesn't delete new associations on new records (so you can safely place new records in the session with Action Pack without having new associations wiped) #1494 [cluon]
+
+* Fixed that calling Model.find([]) returns [] and doesn't throw an exception #1379
+
+* Fixed that adding a record to a has_and_belongs_to collection would always save it -- now it only saves if its a new record #1203 [Alisdair McDiarmid]
+
+* Fixed saving of in-memory association structures to happen as a after_create/after_update callback instead of after_save -- that way you can add new associations in after_create/after_update callbacks without getting them saved twice
+
+* Allow any Enumerable, not just Array, to work as bind variables #1344 [Jeremy Kemper]
+
+* Added actual database-changing behavior to collection assigment for has_many and has_and_belongs_to_many #1425 [Sebastian Kanthak].
+  Example:
+
+    david.projects = [Project.find(1), Project.new("name" => "ActionWebSearch")]
+    david.save
+  
+  If david.projects already contain the project with ID 1, this is left unchanged. Any other projects are dropped. And the new
+  project is saved when david.save is called.
+  
+  Also included is a way to do assignments through IDs, which is perfect for checkbox updating, so you get to do:
+  
+    david.project_ids = [1, 5, 7]
+
+* Corrected typo in find SQL for has_and_belongs_to_many.  #1312 [ben@bensinclair.com]
+
+* Fixed sanitized conditions for has_many finder method.  #1281 [jackc@hylesanderson.com, pragdave, Tobias Luetke]
+
+* Comprehensive PostgreSQL schema support.  Use the optional schema_search_path directive in database.yml to give a comma-separated list of schemas to search for your tables.  This allows you, for example, to have tables in a shared schema without having to use a custom table name.  See http://www.postgresql.org/docs/8.0/interactive/ddl-schemas.html to learn more.  #827 [dave@cherryville.org]
+
+* Corrected @@configurations typo #1410 [david@ruppconsulting.com]
+
+* Return PostgreSQL columns in the order they were declared #1374 [perlguy@gmail.com]
+
+* Allow before/after update hooks to work on models using optimistic locking 
+
+* Eager loading of dependent has_one associations won't delete the association #1212
+
+* Added a second parameter to the build and create method for has_one that controls whether the existing association should be replaced (which means nullifying its foreign key as well). By default this is true, but false can be passed to prevent it.
+
+* Using transactional fixtures now causes the data to be loaded only once.
+
+* Added fixture accessor methods that can be used when instantiated fixtures are disabled.
+
+    fixtures :web_sites
+
+    def test_something
+      assert_equal "Ruby on Rails", web_sites(:rubyonrails).name
+    end
+
+* Added DoubleRenderError exception that'll be raised if render* is called twice #518 [Nicholas Seckar]
+
+* Fixed exceptions occuring after render has been called #1096 [Nicholas Seckar]
+
+* CHANGED: validates_presence_of now uses Errors#add_on_blank, which will make "  " fail the validation where it didn't before #1309
+
+* Added Errors#add_on_blank which works like Errors#add_on_empty, but uses Object#blank? instead
+
+* Added the :if option to all validations that can either use a block or a method pointer to determine whether the validation should be run or not. #1324 [Duane Johnson/jhosteny]. Examples:
+
+  Conditional validations such as the following are made possible:
+    validates_numericality_of :income, :if => :employed?
+
+  Conditional validations can also solve the salted login generator problem:
+    validates_confirmation_of :password, :if => :new_password?
+  
+  Using blocks:
+    validates_presence_of :username, :if => Proc.new { |user| user.signup_step > 1 }
+
+* Fixed use of construct_finder_sql when using :join #1288 [dwlt@dwlt.net]
+
+* Fixed that :delete_sql in has_and_belongs_to_many associations couldn't access record properties #1299 [Rick Olson]
+
+* Fixed that clone would break when an aggregate had the same name as one of its attributes #1307 [Jeremy Kemper]
+
+* Changed that destroying an object will only freeze the attributes hash, which keeps the object from having attributes changed (as that wouldn't make sense), but allows for the querying of associations after it has been destroyed.
+
+* Changed the callbacks such that observers are notified before the in-object callbacks are triggered. Without this change, it wasn't possible to act on the whole object in something like a before_destroy observer without having the objects own callbacks (like deleting associations) called first.
+
+* Added option for passing an array to the find_all version of the dynamic finders and have it evaluated as an IN fragment. Example:
+
+    # SELECT * FROM topics WHERE title IN ('First', 'Second')
+    Topic.find_all_by_title(["First", "Second"])
+
+* Added compatibility with camelCase column names for dynamic finders #533 [Dee.Zsombor]
+
+* Fixed extraneous comma in count() function that made it not work with joins #1156 [jarkko/Dee.Zsombor]
+
+* Fixed incompatibility with Base#find with an array of ids that would fail when using eager loading #1186 [Alisdair McDiarmid]
+
+* Fixed that validate_length_of lost :on option when :within was specified #1195 [jhosteny@mac.com]
+
+* Added encoding and min_messages options for PostgreSQL #1205 [shugo]. Configuration example:
+
+    development:
+      adapter: postgresql
+      database: rails_development
+      host: localhost
+      username: postgres
+      password:
+      encoding: UTF8
+      min_messages: ERROR
+
+* Fixed acts_as_list where deleting an item that was removed from the list would ruin the positioning of other list items #1197 [Jamis Buck]
+
+* Added validates_exclusion_of as a negative of validates_inclusion_of
+
+* Optimized counting of has_many associations by setting the association to empty if the count is 0 so repeated calls doesn't trigger database calls
+
+
 *1.10.1* (20th April, 2005)
 
 * Fixed frivilous database queries being triggered with eager loading on empty associations and other things
@@ -72,7 +240,7 @@
 
 * Fixed boolean queries for t/f fields in PostgreSQL #995 [dave@cherryville.org]
 
-* Added that model.items.delete(child) will delete the child, not just set the foreign key to nil, if the child is dependent on the model #978 [bitsweat]
+* Added that model.items.delete(child) will delete the child, not just set the foreign key to nil, if the child is dependent on the model #978 [Jeremy Kemper]
 
 * Fixed auto-stamping of dates (created_on/updated_on) for PostgreSQL #985 [dave@cherryville.org]
 
@@ -148,7 +316,7 @@
 
 * Fixed that postgresql adapter would fails when reading bytea fields with null value #771 [rodrigo k]
 
-* Added transactional fixtures that uses rollback to undo changes to fixtures instead of DELETE/INSERT -- it's much faster. See documentation under Fixtures #760 [bitsweat]
+* Added transactional fixtures that uses rollback to undo changes to fixtures instead of DELETE/INSERT -- it's much faster. See documentation under Fixtures #760 [Jeremy Kemper]
 
 * Added destruction of dependent objects in has_one associations when a new assignment happens #742 [mindel]. Example:
 
@@ -236,7 +404,7 @@
 
 * Fixed that the dynamic finder like find_all_by_something_boolean(false) didn't work #649 [lmarlow@yahoo.com]
 
-* Added validates_each that validates each specified attribute against a block #610 [bitsweat]. Example:
+* Added validates_each that validates each specified attribute against a block #610 [Jeremy Kemper]. Example:
     
     class Person < ActiveRecord::Base
       validates_each :first_name, :last_name do |record, attr|
@@ -244,7 +412,7 @@
       end
     end
 
-* Added :allow_nil as an explicit option for validates_length_of, so unless that's set to true having the attribute as nil will also return an error if a range is specified as :within #610 [bitsweat]
+* Added :allow_nil as an explicit option for validates_length_of, so unless that's set to true having the attribute as nil will also return an error if a range is specified as :within #610 [Jeremy Kemper]
 
 * Added that validates_* now accept blocks to perform validations #618 [Tim Bates]. Example:
 
@@ -284,7 +452,7 @@
 
 * Fixed that the dynamic finders didn't treat nil as a "IS NULL" but rather "= NULL" case #515 [Demetrius]
 
-* Added bind-named arrays for interpolating a group of ids or strings in conditions #528 [bitsweat]
+* Added bind-named arrays for interpolating a group of ids or strings in conditions #528 [Jeremy Kemper]
 
 * Added that has_and_belongs_to_many associations with additional attributes also can be created between unsaved objects and only committed to the database when Base#save is called on the associator #524 [Eric Anderson]
 
@@ -367,7 +535,7 @@
 
 * Added Base#reload that reloads the attributes of an object from the database #422 [Andreas Schwarz]
 
-* Added SQLite3 compatibility through the sqlite3-ruby adapter by Jamis Buck #381 [bitsweat]
+* Added SQLite3 compatibility through the sqlite3-ruby adapter by Jamis Buck #381 [Jeremy Kemper]
 
 * Added support for the new protocol spoken by MySQL 4.1.1+ servers for the Ruby/MySQL adapter that ships with Rails #440 [Matt Mower] 
 
@@ -438,7 +606,7 @@
   <tt>Payment.find_all_by_amount(50)</tt> that is turned into <tt>Payment.find_all(["amount = ?", 50])</tt>. This is something not as equally useful,
   though, as it's not possible to specify the order in which the objects are returned.
 
-* Added block-style for callbacks #332 [bitsweat].
+* Added block-style for callbacks #332 [Jeremy Kemper].
 
     Before:
       before_destroy(Proc.new{ |record| Person.destroy_all "firm_id = #{record.id}" })
@@ -459,7 +627,7 @@
 
 * Added the final touches to the Microsoft SQL Server adapter by Joey Gibson that makes it suitable for actual use #394 [DeLynn Barry]
 
-* Added that Base#find takes an optional options hash, including :conditions. Base#find_on_conditions deprecated in favor of #find with :conditions #407 [bitsweat]
+* Added that Base#find takes an optional options hash, including :conditions. Base#find_on_conditions deprecated in favor of #find with :conditions #407 [Jeremy Kemper]
 
 * Added HasManyAssociation#count that works like Base#count #413 [intinig]
 
@@ -468,7 +636,7 @@
 * Fixed a bug in the Ruby/MySQL that caused binary content to be escaped badly and come back mangled #405 [Tobias Luetke]
 
 * Fixed that the const_missing autoload assumes the requested constant is set by require_association and calls const_get to retrieve it. 
-  If require_association did not set the constant then const_get will call const_missing, resulting in an infinite loop #380 [bitsweat]
+  If require_association did not set the constant then const_get will call const_missing, resulting in an infinite loop #380 [Jeremy Kemper]
 
 * Fixed broken transactions that were actually only running object-level and not db level transactions [andreas]
 
@@ -508,7 +676,7 @@
 
 * Added Base#clear_association_cache to empty all the cached associations #347 [Tobias Luetke]
 
-* Added more informative exceptions in establish_connection #356 [bitsweat]
+* Added more informative exceptions in establish_connection #356 [Jeremy Kemper]
 
 * Added Base#update_attributes that'll accept a hash of attributes and save the record (returning true if it passed validation, false otherwise). 
 
@@ -525,7 +693,7 @@
 
 * Added higher_item and lower_item as public methods for acts_as_list #342 [Tobias Luetke]
 
-* Fixed that options[:counter_sql] was overwritten with interpolated sql rather than original sql #355 [bitsweat]
+* Fixed that options[:counter_sql] was overwritten with interpolated sql rather than original sql #355 [Jeremy Kemper]
 
 * Fixed that overriding an attribute's accessor would be disregarded by add_on_empty and add_on_boundary_breaking because they simply used 
   the attributes[] hash instead of checking for @base.respond_to?(attr.to_s). [Marten]
@@ -689,12 +857,12 @@
 * Fixed has_and_belongs_to_many guessing of foreign key so that keys are generated correctly for models like SomeVerySpecialClient 
   [Florian Weber]
 
-* Added counter_sql option for has_many associations [bitsweat]. Documentation:
+* Added counter_sql option for has_many associations [Jeremy Kemper]. Documentation:
 
     <tt>:counter_sql</tt> - specify a complete SQL statement to fetch the size of the association. If +:finder_sql+ is
     specified but +:counter_sql+, +:counter_sql+ will be generated by replacing SELECT ... FROM with SELECT COUNT(*) FROM.
 
-* Fixed that methods wrapped in callbacks still return their original result #260 [bitsweat]
+* Fixed that methods wrapped in callbacks still return their original result #260 [Jeremy Kemper]
 
 * Fixed the Inflector to handle the movie/movies pair correctly #261 [Scott Baron]
 
@@ -720,7 +888,7 @@
 
 * Added reverse order of deleting fixtures, so referential keys can be maintained #247 [Tim Bates]
 
-* Added relative path search for sqlite dbfiles in database.yml (if RAILS_ROOT is defined) #233 [bitsweat]
+* Added relative path search for sqlite dbfiles in database.yml (if RAILS_ROOT is defined) #233 [Jeremy Kemper]
 
 * Added option to establish_connection where you'll be able to leave out the parameter to have it use the RAILS_ENV environment variable
 
@@ -819,17 +987,17 @@
     
   NOTE: The categories table doesn't have a added_on column, it's the categories_post join table that does!
 
-* Fixed that :exclusively_dependent and :dependent can't be activated at the same time on has_many associations [bitsweat]
+* Fixed that :exclusively_dependent and :dependent can't be activated at the same time on has_many associations [Jeremy Kemper]
 
-* Fixed that database passwords couldn't be all numeric [bitsweat]
+* Fixed that database passwords couldn't be all numeric [Jeremy Kemper]
 
-* Fixed that calling id would create the instance variable for new_records preventing them from being saved correctly [bitsweat]
+* Fixed that calling id would create the instance variable for new_records preventing them from being saved correctly [Jeremy Kemper]
 
 * Added sanitization feature to HasManyAssociation#find_all so it works just like Base.find_all [Sam Stephenson/bitsweat]
 
-* Added that you can pass overlapping ids to find without getting duplicated records back [bitsweat]
+* Added that you can pass overlapping ids to find without getting duplicated records back [Jeremy Kemper]
 
-* Added that Base.benchmark returns the result of the block [bitsweat]
+* Added that Base.benchmark returns the result of the block [Jeremy Kemper]
 
 * Fixed problem with unit tests on Windows with SQLite [paterno]
 

data/RUNNING_UNIT_TESTS

@@ -33,3 +33,14 @@ You can also run all the suites on a specific adapter with:
 
    cd test; all.sh "connections/native_mysql"
 
+== Faster tests
+
+If you are using a database that supports transactions, you can set the
+"AR_TX_FIXTURES" environment variable to "yes" to use transactional fixtures.
+This gives a very large speed boost. With rake:
+
+  rake AR_TX_FIXTURES=yes
+
+Or, by hand:
+
+  AR_TX_FIXTURES=yes ruby -I connections/native_sqlite3 base_test.rb

data/lib/active_record.rb

@@ -49,8 +49,8 @@ require 'active_record/migration'
 
 ActiveRecord::Base.class_eval do
   include ActiveRecord::Validations
-  include ActiveRecord::Callbacks
   include ActiveRecord::Locking
+  include ActiveRecord::Callbacks
   include ActiveRecord::Timestamp
   include ActiveRecord::Associations
   include ActiveRecord::Aggregations
@@ -67,3 +67,5 @@ require 'active_record/connection_adapters/sqlite_adapter'
 require 'active_record/connection_adapters/sqlserver_adapter'
 require 'active_record/connection_adapters/db2_adapter'
 require 'active_record/connection_adapters/oci_adapter'
+
+require 'active_record/query_cache'

data/lib/active_record/acts/list.rb

@@ -94,6 +94,7 @@ module ActiveRecord
         end
         
         def move_to_bottom
+          return unless in_list?
           self.class.transaction do
             decrement_positions_on_lower_items
             assume_bottom_position
@@ -101,6 +102,7 @@ module ActiveRecord
         end
         
         def move_to_top
+          return unless in_list?
           self.class.transaction do
             increment_positions_on_higher_items
             assume_top_position
@@ -108,37 +110,47 @@ module ActiveRecord
         end
   
         def remove_from_list
-          decrement_positions_on_lower_items
+          decrement_positions_on_lower_items if in_list?
         end
 
         def increment_position
+          return unless in_list?
           update_attribute position_column, self.send(position_column).to_i + 1
         end
   
         def decrement_position
+          return unless in_list?
           update_attribute position_column, self.send(position_column).to_i - 1
         end
   
         def first?
+          return false unless in_list?
           self.send(position_column) == 1
         end
         
         def last?
+          return false unless in_list?
           self.send(position_column) == bottom_position_in_list
         end
         
         def higher_item
-          self.class.find_first(
+          return nil unless in_list?
+          self.class.find(:first, :conditions =>
             "#{scope_condition} AND #{position_column} = #{(send(position_column).to_i - 1).to_s}"
           )
         end
 
         def lower_item
-          self.class.find_first(
+          return nil unless in_list?
+          self.class.find(:first, :conditions =>
             "#{scope_condition} AND #{position_column} = #{(send(position_column).to_i + 1).to_s}"
           )
         end
 
+        def in_list?
+          !send(position_column).nil?
+        end
+
         private
           def add_to_list_top
             increment_positions_on_all_items
@@ -157,10 +169,7 @@ module ActiveRecord
           end
 
           def bottom_item
-            self.class.find_first(
-              "#{scope_condition} ",
-              "#{position_column} DESC"
-            )
+            self.class.find(:first, :conditions => scope_condition, :order => "#{position_column} DESC")
           end
 
           def assume_bottom_position
@@ -176,10 +185,11 @@ module ActiveRecord
             self.class.update_all(
               "#{position_column} = (#{position_column} - 1)", "#{scope_condition} AND #{position_column} <= #{position}"
             )
-	       end
+          end
 
           # This has the effect of moving all the lower items up one.
           def decrement_positions_on_lower_items
+            return unless in_list?
             self.class.update_all(
               "#{position_column} = (#{position_column} - 1)", "#{scope_condition} AND #{position_column} > #{send(position_column).to_i}"
             )
@@ -187,6 +197,7 @@ module ActiveRecord
 
           # This has the effect of moving all the higher items down one.
           def increment_positions_on_higher_items
+            return unless in_list?
             self.class.update_all(
               "#{position_column} = (#{position_column} + 1)", "#{scope_condition} AND #{position_column} < #{send(position_column).to_i}"
             )
@@ -194,10 +205,10 @@ module ActiveRecord
 
           # This has the effect of moving all the lower items down one.
           def increment_positions_on_lower_items(position)
-	         self.class.update_all(
-	           "#{position_column} = (#{position_column} + 1)", "#{scope_condition} AND #{position_column} >= #{position}"
-	         )
-	       end
+            self.class.update_all(
+              "#{position_column} = (#{position_column} + 1)", "#{scope_condition} AND #{position_column} >= #{position}"
+           )
+          end
 
           def increment_positions_on_all_items
             self.class.update_all(
@@ -207,10 +218,10 @@ module ActiveRecord
 
           def insert_at_position(position)
             remove_from_list
-	         increment_positions_on_lower_items(position)
+            increment_positions_on_lower_items(position)
             self.update_attribute(position_column, position)
           end
       end     
     end
   end
-end
+end