activerecord 1.0.0 → 1.1.0

data/test/fixtures/bad_fixtures/attr_with_numeric_first_char

@@ -0,0 +1 @@
+1b => 1

data/test/fixtures/bad_fixtures/attr_with_spaces

@@ -0,0 +1 @@
+a b => 1

data/test/fixtures/bad_fixtures/blank_line

@@ -0,0 +1,3 @@
+a => 1
+
+b => 2

data/test/fixtures/bad_fixtures/duplicate_attributes

@@ -0,0 +1,3 @@
+a => 1
+b => 2
+a => 3

data/test/fixtures/bad_fixtures/missing_value

@@ -0,0 +1 @@
+a => 

data/test/fixtures/company_in_module.rb

@@ -3,7 +3,7 @@ module MyApplication
     class Company < ActiveRecord::Base
       attr_protected :rating
     end
-
+    
     class Firm < Company
       has_many :clients, :order => "id", :dependent => true
       has_many :clients_sorted_desc, :class_name => "Client", :order => "id DESC"
@@ -18,6 +18,20 @@ module MyApplication
       belongs_to :firm, :foreign_key => "client_of"
       belongs_to :firm_with_other_name, :class_name => "Firm", :foreign_key => "client_of"
     end
+    
+    class Developer < ActiveRecord::Base
+      has_and_belongs_to_many :projects
+
+      protected
+        def validate
+          errors.add_on_boundry_breaking("name", 3..20)
+      end
+    end
+    
+    class Project < ActiveRecord::Base
+      has_and_belongs_to_many :developers
+    end
+
   end
   
   module Billing

data/test/fixtures/db_definitions/mysql.sql

@@ -46,7 +46,8 @@ CREATE TABLE `projects` (
 
 CREATE TABLE `developers_projects` (
   `developer_id` int(11) NOT NULL,
-  `project_id` int(11) NOT NULL
+  `project_id` int(11) NOT NULL,
+  `joined_on` date default NULL
 );
 
 CREATE TABLE `customers` (

data/test/fixtures/db_definitions/postgresql.sql

@@ -22,7 +22,8 @@ SELECT setval('companies_id_seq', 100);
 
 CREATE TABLE developers_projects (
     developer_id integer NOT NULL,
-    project_id integer NOT NULL
+    project_id integer NOT NULL,
+    joined_on date
 );
 
 CREATE TABLE developers (

data/test/fixtures/db_definitions/sqlite.sql

@@ -41,7 +41,8 @@ CREATE TABLE 'projects' (
 
 CREATE TABLE 'developers_projects' (
   'developer_id' INTEGER NOT NULL,
-  'project_id' INTEGER NOT NULL
+  'project_id' INTEGER NOT NULL,
+  'joined_on' DATE DEFAULT NULL
 );
 
 CREATE TABLE 'customers' (

data/test/fixtures/developers_projects/david_action_controller

@@ -1,2 +1,3 @@
 developer_id => 1
-project_id => 2
+project_id => 2
+joined_on => 2004-10-10

data/test/fixtures/developers_projects/david_active_record

@@ -1,2 +1,3 @@
 developer_id => 1
-project_id => 1
+project_id => 1
+joined_on => 2004-10-10

data/test/fixtures/project.rb

@@ -1,3 +1,4 @@
 class Project < ActiveRecord::Base
-  has_and_belongs_to_many :developers
+  has_and_belongs_to_many :developers, :uniq => true
+  has_and_belongs_to_many :developers_named_david, :class_name => "Developer", :conditions => "name = 'David'", :uniq => true
 end

data/test/fixtures/projects/action_controller

@@ -1,2 +1,2 @@
 id => 2
-name => Active Record
+name => Active Controller

data/test/fixtures/topics/second

@@ -1,5 +1,5 @@
 id          => 2
-title            => The Second Topic
+title            => The Second Topic's of the day
 author_name       => Mary
 written_on        => 2003-07-15 15:28
 content          => Have a great day!

data/test/fixtures_test.rb

@@ -1,20 +1,79 @@
 require 'abstract_unit'
+require 'fixtures/topic'
+require 'fixtures/developer'
 
 class FixturesTest < Test::Unit::TestCase
+  fixtures :topics, :developers
+  
+  FIXTURES = %w( accounts companies customers
+                 developers developers_projects entrants
+                 movies projects subscribers topics )
+  MATCH_ATTRIBUTE_NAME = /[a-zA-Z][-_\w]*/
+
   def setup
-    @fixtures = create_fixtures("topics")
+    # just to annoy
+  end
+
+  def test_clean_fixtures
+    FIXTURES.each do |name|
+      fixtures = nil
+      assert_nothing_raised { fixtures = create_fixtures(name) }
+      assert_kind_of(Fixtures, fixtures)
+      fixtures.each { |name, fixture|
+        fixture.each { |key, value|
+          assert_match(MATCH_ATTRIBUTE_NAME, key)
+        }
+      }
+    end
+  end
+
+  def test_multiple_clean_fixtures
+    fixtures_array = nil
+    assert_nothing_raised { fixtures_array = create_fixtures(*FIXTURES) }
+    assert_kind_of(Array, fixtures_array)
+    fixtures_array.each { |fixtures| assert_kind_of(Fixtures, fixtures) }
   end
 
   def test_attributes
-    assert_equal("The First Topic", @fixtures["first"]["title"])
-    assert_nil(@fixtures["second"]["author_email_address"])
+    topics = create_fixtures("topics")
+    assert_equal("The First Topic", topics["first"]["title"])
+    assert_nil(topics["second"]["author_email_address"])
   end
 
   def test_inserts
+    topics = create_fixtures("topics")
     firstRow = ActiveRecord::Base.connection.select_one("SELECT * FROM topics WHERE author_name = 'David'")
     assert_equal("The First Topic", firstRow["title"])
 
     secondRow = ActiveRecord::Base.connection.select_one("SELECT * FROM topics WHERE author_name = 'Mary'")
     assert_nil(secondRow["author_email_address"])
   end
-end
+
+  def test_bad_format
+    path = File.join(File.dirname(__FILE__), 'fixtures', 'bad_fixtures')
+    Dir.entries(path).each do |file|
+      next unless File.file?(file) and file !~ %r(^.|.yaml$)
+      assert_raise(Fixture::FormatError) {
+        Fixture.new(bad_fixtures_path, file)
+      }
+    end
+  end
+
+  def test_logger_level_invariant
+    level = ActiveRecord::Base.logger.level
+    create_fixtures('topics')
+    assert_equal level, ActiveRecord::Base.logger.level
+  end
+  
+  def test_instantiation
+    topics = create_fixtures("topics")
+    assert_kind_of Topic, topics["first"].find
+  end
+  
+  def test_complete_instantiation
+    # instantiate_fixtures "topics", "developers"
+    assert_equal 2, @topics.size
+    assert_equal 2, @developers.size
+    assert_equal "The First Topic", @first.title
+  end
+end

data/test/inflector_test.rb

@@ -58,6 +58,11 @@ class InflectorTest < Test::Unit::TestCase
     "Person" => "personid",
     "MyApplication::Billing::Account" => "accountid"
   }
+  
+  ClassNameToTableName = {
+    "PrimarySpokesman" => "primary_spokesmen",
+    "NodeChild"        => "node_children"
+  }
 
   def test_pluralize
     SingularToPlural.each do |singular, plural|
@@ -101,4 +106,16 @@ class InflectorTest < Test::Unit::TestCase
       assert_equal(foreign_key, Inflector.foreign_key(klass, false))
     end
   end
+
+  def test_tableize
+    ClassNameToTableName.each do |class_name, table_name|
+      assert_equal(table_name, Inflector.tableize(class_name))
+    end
+  end
+
+  def test_classify
+    ClassNameToTableName.each do |class_name, table_name|
+      assert_equal(class_name, Inflector.classify(table_name))
+    end
+  end
 end

data/test/modules_test.rb

@@ -6,6 +6,8 @@ class ModulesTest < Test::Unit::TestCase
   def setup
     create_fixtures "accounts"
     create_fixtures "companies"
+    create_fixtures "projects"
+    create_fixtures "developers"
   end
 
   def test_module_spanning_associations
@@ -14,6 +16,12 @@ class ModulesTest < Test::Unit::TestCase
     assert_nil firm.class.table_name.match('::'), "Firm shouldn't have the module appear in its table name"
     assert_equal 2, firm.clients_count, "Firm should have two clients"
   end
+
+  def test_module_spanning_has_and_belongs_to_many_associations
+    project = MyApplication::Business::Project.find_first
+    project.developers << MyApplication::Business::Developer.create("name" => "John")
+    assert "John", project.developers.last.name
+  end
   
   def test_associations_spanning_cross_modules
     assert MyApplication::Billing::Account.find(1).has_firm?, "37signals account should be able to backtrack"

data/test/transactions_test.rb

@@ -8,18 +8,30 @@ class TransactionTest < Test::Unit::TestCase
     @first, @second = Topic.find(1, 2)
   end
 
-  def test_succesful
+  def test_successful
     Topic.transaction do
       @first.approved  = 1
       @second.approved = 0
       @first.save
       @second.save
     end
-    
+
     assert Topic.find(1).approved?, "First should have been approved"
     assert !Topic.find(2).approved?, "Second should have been unapproved"
   end
-  
+
+  def test_successful_with_instance_method
+    @first.transaction do
+      @first.approved  = 1
+      @second.approved = 0
+      @first.save
+      @second.save
+    end
+
+    assert Topic.find(1).approved?, "First should have been approved"
+    assert !Topic.find(2).approved?, "Second should have been unapproved"
+  end
+ 
   def test_failing_on_exception
     begin
       Topic.transaction do
@@ -80,4 +92,4 @@ class TransactionTest < Test::Unit::TestCase
     def remove_exception_raising_after_save_callback_to_topic
       Topic.class_eval { remove_method :after_save }
     end
-end
+end

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.8.1
 specification_version: 1
 name: activerecord
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
-date: 2004-10-25
+  version: 1.1.0
+date: 2004-11-18
 summary: Implements the ActiveRecord pattern for ORM.
 require_paths: 
   - lib
@@ -36,6 +36,7 @@ files:
   - lib/active_record/aggregations.rb
   - lib/active_record/associations
   - lib/active_record/associations.rb
+  - lib/active_record/associations.rb.orig
   - lib/active_record/base.rb
   - lib/active_record/callbacks.rb
   - lib/active_record/connection_adapters
@@ -71,6 +72,7 @@ files:
   - test/class_inheritable_attributes_test.rb
   - test/connections
   - test/deprecated_associations_test.rb
+  - test/deprecated_associations_test.rb.orig
   - test/finder_test.rb
   - test/fixtures
   - test/fixtures_test.rb
@@ -93,6 +95,7 @@ files:
   - test/connections/native_sqlite/connection.rb
   - test/fixtures/accounts
   - test/fixtures/auto_id.rb
+  - test/fixtures/bad_fixtures
   - test/fixtures/column_name.rb
   - test/fixtures/companies
   - test/fixtures/company.rb
@@ -121,6 +124,11 @@ files:
   - test/fixtures/topics
   - test/fixtures/accounts/signals37
   - test/fixtures/accounts/unknown
+  - test/fixtures/bad_fixtures/attr_with_numeric_first_char
+  - test/fixtures/bad_fixtures/attr_with_spaces
+  - test/fixtures/bad_fixtures/blank_line
+  - test/fixtures/bad_fixtures/duplicate_attributes
+  - test/fixtures/bad_fixtures/missing_value
   - test/fixtures/companies/first_client
   - test/fixtures/companies/first_firm
   - test/fixtures/companies/second_client