activerecord-virtual_attributes 7.2.0.0 → 8.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef69f0683d1cf4b95da626b2407fe42fcd2e6564053bcb424ea8c867365e6c94
-  data.tar.gz: 28d0d1506872044eae2cb1d9e84cd0044e9dae43f849facabd44024c9f1ed676
+  metadata.gz: d6a140b11204b4edf29cfe6e13fdfe53226b56e73279c63e9878ccfe5ead543b
+  data.tar.gz: 1496844f5c1ec0870fa66fc8905c6f34d0d0e8064cf71b26cb1f0b87db15917f
 SHA512:
-  metadata.gz: 2c26a6ea644c42aa0317bcf3848f31ae79d49a86f80fa2c0832642652c9195171f52fe23b52789544fd7045efbb51a398d911e39fc2f4645e2e88a2945fa1555
-  data.tar.gz: 3d59e61f9b22e9037237c1e1f8e8be91ee36dc165c54a101bf742f4a5b88cc9da6b0a13fef44dbe18dda4f0af299028179e5e37c001e7f3419f6cd988679e044
+  metadata.gz: db6751f0bad4abf5a669f035172ad6e338df09b073594e505360a16f11f5d24188c102d0cfdc2da40921eb1e67939a62715b248436bf3d4b31a07c7a6dd84994
+  data.tar.gz: 8da21356c323be6cdd90134b3f7125589b3d337ad9be2081fd43b9072fb7866e55cbafa67e53335b83b0c6265caebe92656b59562e1984b398977720fd349124

data/CHANGELOG.md

@@ -4,6 +4,18 @@ The versioning of this gem follows ActiveRecord versioning, and does not follow
 
 ## [Unreleased]
 
+## [8.0.0] - 2026-01-22
+
+* Drop unnecessary load_schema statements [#197](https://github.com/ManageIQ/activerecord-virtual_attributes/pull/197)
+* Attribute delegation [#192](https://github.com/ManageIQ/activerecord-virtual_attributes/pull/192)
+* Spec wording, better error message for bogus va :through [#202](https://github.com/ManageIQ/activerecord-virtual_attributes/pull/202)
+* Support rails 8, drop support for 7.2 [#216](https://github.com/ManageIQ/activerecord-virtual_attributes/pull/216)
+* Make the virtual_delegate deprecation warning less noisy [#217](https://github.com/ManageIQ/activerecord-virtual_attributes/pull/217)
+
+## [7.2.0.1] - 2025-07-18
+
+* Fix includes and associations with empty uses [#195](https://github.com/ManageIQ/activerecord-virtual_attributes/pull/195)
+
 ## [7.2.0.0] - 2025-06-25
 
 * virtual_delegate requires type [#185](https://github.com/ManageIQ/activerecord-virtual_attributes/pull/185)
@@ -125,7 +137,9 @@ The versioning of this gem follows ActiveRecord versioning, and does not follow
 * Initial Release
 * Extracted from ManageIQ/manageiq
 
-[Unreleased]: https://github.com/ManageIQ/activerecord-virtual_attributes/compare/v7.2.0.0...HEAD
+[Unreleased]: https://github.com/ManageIQ/activerecord-virtual_attributes/compare/v8.0.0...HEAD
+[8.0.0]: https://github.com/ManageIQ/activerecord-virtual_attributes/compare/v7.2.0.1...v8.0.0
+[7.2.0.1]: https://github.com/ManageIQ/activerecord-virtual_attributes/compare/v7.2.0.0...v7.2.0.1
 [7.2.0.0]: https://github.com/ManageIQ/activerecord-virtual_attributes/compare/v7.1.2...v7.2.0.0
 [7.1.2]: https://github.com/ManageIQ/activerecord-virtual_attributes/compare/v7.1.1...v7.1.2
 [7.1.1]: https://github.com/ManageIQ/activerecord-virtual_attributes/compare/v7.1.0...v7.1.1

data/README.md

@@ -1,8 +1,6 @@
 # VirtualAttributes
 
 [![CI](https://github.com/ManageIQ/activerecord-virtual_attributes/actions/workflows/ci.yaml/badge.svg)](https://github.com/ManageIQ/activerecord-virtual_attributes/actions/workflows/ci.yaml)
-[![Maintainability](https://codeclimate.com/github/ManageIQ/activerecord-virtual_attributes.svg)](https://codeclimate.com/github/ManageIQ/activerecord-virtual_attributes/maintainability)
-[![Test Coverage](https://codeclimate.com/github/ManageIQ/activerecord-virtual_attributes/coverage.svg)](https://codeclimate.com/github/ManageIQ/activerecord-virtual_attributes/test_coverage)
 
 VirtualAttributes allows you to define a ruby method that acts like an attribute or relation.
 
@@ -16,6 +14,17 @@ This also allows you to calculate counts and treat those as a field accessible w
 
 As of v6.1.0, the versioning of this gem follows ActiveRecord versioning, and does not follow SemVer (e.g. virtual attributes v6.1.x supports all versions of Rails 6.1). Version v3.0.0 supports Rails 6.0 and lower.
 
+Refer to the table below:
+
+Version | Rails
+--------|-------
+v3.0.x  | 6.0.x and lower
+v6.1.x  | 6.1.x
+v7.0.x  | 7.0.x
+v7.1.x  | 7.1.x
+v7.2.x  | 7.2.x
+v8.0.x  | 8.0.x
+
 Use the latest version of both this gem and Rails where the first 2 digits match.
 
 ## Installation

data/activerecord-virtual_attributes.gemspec

@@ -1,4 +1,4 @@
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.push(lib) unless $LOAD_PATH.include?(lib)
 
 require "active_record/virtual_attributes/version"
@@ -22,13 +22,13 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|bin)/}) || f.match(/^(\.)|renovate.json/) }
   end
 
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "activerecord", "~> 7.2.2", ">=7.2.2.1"
+  spec.add_runtime_dependency "activerecord", "~> 8.0.4"
 
   spec.add_development_dependency "byebug"
   spec.add_development_dependency "database_cleaner-active_record", "~> 2.1"
@@ -40,5 +40,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "simplecov", ">= 0.21.2"
-  spec.add_development_dependency "sqlite3", "< 2"
+  spec.add_development_dependency "sqlite3"
 end

data/lib/active_record/virtual_attributes/rspec/have_virtual_attribute.rb

@@ -1,7 +1,7 @@
 RSpec::Matchers.define(:have_virtual_attribute) do |name, type|
   match do |klass|
-    expect(klass.has_attribute?(name)).to be_truthy
-    expect(klass.virtual_attribute?(name)).to be_truthy
+    expect(klass.has_attribute?(name)).to(be_truthy)
+    expect(klass.virtual_attribute?(name)).to(be_truthy)
     expect(klass.type_for_attribute(name.to_s).type).to(eq(type)) if type
     klass.instance_methods.include?(name.to_sym)
   end

data/lib/active_record/virtual_attributes/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module VirtualAttributes
-    VERSION = "7.2.0.0".freeze
+    VERSION = "8.0.0".freeze
   end
 end

data/lib/active_record/virtual_attributes/virtual_arel.rb

@@ -83,7 +83,6 @@ module ActiveRecord
         # - it is an attribute that is non virtual
         # - it is an attribute that is virtual and has arel defined
         def attribute_supported_by_sql?(name)
-          load_schema
           try(:attribute_alias?, name) ||
             (has_attribute?(name) && (!virtual_attribute?(name) || !!_virtual_arel[name.to_s]))
         end

data/lib/active_record/virtual_attributes/virtual_delegates.rb

@@ -15,6 +15,7 @@ module ActiveRecord
         #
 
         def virtual_delegate(*methods, to:, type:, prefix: nil, allow_nil: nil, default: nil, uses: nil, **options) # rubocop:disable Naming/MethodParameterName
+          src_loc = caller_locations
           to = to.to_s
           if to.include?(".") && (methods.size > 1 || prefix)
             raise ArgumentError, 'Delegation only supports specifying a target method name when defining a single virtual method with no prefix'
@@ -28,12 +29,12 @@ module ActiveRecord
           # This better supports reloading of the class and changing the definitions
           methods.each do |method|
             method_name, to, method = determine_method_names(method, to, prefix)
-            unless (to_ref = reflection_with_virtual(to))
-              raise ArgumentError, "Delegation needs an association. Association #{to} does not exist"
-            end
 
-            define_delegate(method_name, method, :to => to, :allow_nil => allow_nil, :default => default)
-            virtual_attribute(method_name, type, :uses => (uses || to), :arel => virtual_delegate_arel(method, to_ref), **options)
+            # NOTE: delete_blank will remove a default of []. we only want to remove nils
+            va_params = options.merge(:uses => uses, :through => to, :source => method, :default => default).delete_if { |_n, v| v.nil? }
+
+            ActiveRecord::VirtualAttributes.deprecator.warn("virtual_delegate is deprecated in favor of virtual_attribute. Change to: #{name}.virtual_attribute #{method_name.inspect}, #{type.inspect}, #{va_params.map { |k, v| "#{k.inspect} => #{v.inspect}" }.join(", ")}", src_loc)
+            virtual_attribute(method_name, type, **va_params)
           end
         end
 
@@ -105,7 +106,7 @@ module ActiveRecord
           end
 
           method_prefix = "#{prefix == true ? to : prefix}_" if prefix
-          method_name = "#{method_prefix}#{method_name}".to_sym
+          method_name = :"#{method_prefix}#{method_name}"
 
           [method_name, to.to_sym, column]
         end

data/lib/active_record/virtual_attributes/virtual_fields.rb

@@ -6,6 +6,7 @@ module ActiveRecord
       include ActiveRecord::VirtualAttributes::VirtualReflections
 
       # rubocop:disable Style/SingleLineMethods
+      # rubocop:disable Naming/PredicateMethod
       module NonARModels
         def dangerous_attribute_method?(_); false; end
 
@@ -15,6 +16,7 @@ module ActiveRecord
 
         def belongs_to_required_by_default; false; end
       end
+      # rubocop:enable Naming/PredicateMethod
       # rubocop:enable Style/SingleLineMethods
 
       included do
@@ -183,6 +185,7 @@ module ActiveRecord
             source_records.each do |record|
               # begin virtual_attributes changes
               association = record.class.replace_virtual_fields(self.association)
+              next if association.nil?
               # end virtual_attributes changes
 
               reflection = record.class._reflect_on_association(association)

data/lib/active_record/virtual_attributes/virtual_includes.rb

@@ -18,7 +18,6 @@ module ActiveRecord
 
       module ClassMethods
         def virtual_includes(name)
-          load_schema
           _virtual_includes[name.to_s]
         end
 

data/lib/active_record/virtual_attributes.rb

@@ -56,13 +56,29 @@ module ActiveRecord
         virtual_attribute(name, type, **options)
       end
 
-      def virtual_attribute(name, type, uses: nil, arel: nil, **options)
+      def virtual_attribute(name, type, through: nil, uses: nil, arel: nil, source: name, default: nil, **options)
         name = name.to_s
         reload_schema_from_cache
 
         self.virtual_attributes_to_define =
           virtual_attributes_to_define.merge(name => [type, options])
 
+        if through
+          define_delegate(name, source, :to => through, :allow_nil => true, :default => default)
+
+          unless (to_ref = reflection_with_virtual(through))
+            raise ArgumentError, "#{self.name}.virtual_attribute #{name.inspect} references unknown :through association #{through.inspect}"
+          end
+
+          # ensure that the through table is in the uses clause
+          uses = merge_includes({through => {}}, uses)
+
+          # We can not validate target#source exists
+          #   Because we may not have loaded the class yet
+          #   And we definitely have not loaded the database yet
+          arel ||= virtual_delegate_arel(source, to_ref)
+        end
+
         define_virtual_include(name, uses)
         define_virtual_arel(name, arel)
       end
@@ -72,7 +88,6 @@ module ActiveRecord
       #
 
       def virtual_attribute?(name)
-        load_schema
         has_attribute?(name) && (
           !respond_to?(:column_for_attribute) ||
           column_for_attribute(name).kind_of?(ActiveRecord::ConnectionAdapters::NullColumn)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-virtual_attributes
 version: !ruby/object:Gem::Version
-  version: 7.2.0.0
+  version: 8.0.0
 platform: ruby
 authors:
 - Keenan Brock
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-06-26 00:00:00.000000000 Z
+date: 2026-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,20 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.2.2
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 7.2.2.1
+        version: 8.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.2.2
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 7.2.2.1
+        version: 8.0.4
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -160,16 +154,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '0'
 description: Define attributes in arel
 email:
 - keenan@thebrocks.net