activerecord-virgodb-adapter 0.1.7 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d70a70ab0e46de3acd4d283c69e7c385873c7bb9ec817423f62ff09dbc601350
-  data.tar.gz: 1f7b6259306a3d61f2e3d05fb345373a5d350b2742309804be1d91ac096886a1
+  metadata.gz: c9adcef53b08377de04eaa8a3efb42a9ef26af8c9d21d354417a9431374ffb5b
+  data.tar.gz: '089277465d82f97c0075bb1641c46bd37e02a3c44d0e3f627d02962a473bfcfd'
 SHA512:
-  metadata.gz: 64c5716aa1f9d1ea110aacd562ad131acb5d8d76bbd4e8d0ed459a2191530d7b27c6c1f924b59a70840defed6f285c668e6fc9a56f97b134719bd2033ed42b6f
-  data.tar.gz: 9f2de20a524c86e2bafc0a43b6f49b8d86bdf127a54b8a5276972f75b10e937c5c7fe3b89b88172eaca32b4aaee09aa0aa52a34f947c614dc3926c3d1878f82e
+  metadata.gz: f7c81193bd344ef5e4120c7147e4374d5421fb17e129937b829bb6f01fcc59ec8e1734916f7c85e2a07ff3b66687a09de0cc361a6489bc85459fb4e086083894
+  data.tar.gz: 5df55c10f41ff7fd8264e561e470966fa3b9aadf8e7691304f6ad0d8336fb0939780782df4c03a33b68369f691a357ca70a146261f3f812c891c7c5ada66a2e9

data/lib/active_record/connection_adapters/virgodb_adapter.rb

@@ -458,8 +458,8 @@ module ActiveRecord
         next_version = (select_value("SELECT MAX(version) FROM schema_versions WHERE table_name = #{quote(table_name)}") || 0).to_i + 1
 
         execute(<<~SQL)
-          INSERT INTO schema_versions (table_name, version, columns, applied_at)
-          VALUES (#{quote(table_name)}, #{next_version}, #{quote(cols.to_json)}, #{Time.now.to_i})
+          INSERT INTO schema_versions (table_name, version, columns)
+          VALUES (#{quote(table_name)}, #{next_version}, #{quote(cols.to_json)})
         SQL
       end
 
@@ -471,14 +471,21 @@ module ActiveRecord
       # in manifest/src/lib.rs for why (breaks a real structure_dump/
       # structure_load round trip the moment any host app's
       # ActiveRecord::SchemaDumper.ignore_tables is non-empty).
+      #
+      # No `applied_at` column (removed -- nothing ever read it back, see
+      # manifest/src/lib.rs's matching comment on `register_schema_version`).
+      # Breaking format change, no in-place migration: `IF NOT EXISTS` is a
+      # no-op against a manifest that already has the old `applied_at NOT
+      # NULL` shape, so `insert_schema_version!` above would fail against
+      # one -- deliberate, pre-production, existing manifests get dropped
+      # and recreated rather than migrated.
       def ensure_schema_versions_table!
         execute(<<~SQL)
           CREATE TABLE IF NOT EXISTS schema_versions (
             id         INTEGER PRIMARY KEY,
             table_name TEXT NOT NULL,
             version    INTEGER NOT NULL,
-            columns    TEXT NOT NULL,
-            applied_at INTEGER NOT NULL
+            columns    TEXT NOT NULL
           )
         SQL
       end

data/lib/active_record/tasks/virgodb_database_tasks.rb

@@ -134,32 +134,37 @@ module ActiveRecord
       # history here isn't a correctness requirement. It also isn't a
       # readability win: each version's `columns` re-lists every column from
       # scratch, so N migrations means N near-duplicate JSON blobs, longer
-      # every time. The version count/dates are still worth one line for
-      # orientation -- the full column list per version isn't; the
-      # migration files themselves (db/migrate_virgodb_*/*.rb, timestamped,
-      # under git blame) are already the authoritative "what changed when"
-      # record. `register_schema_version`'s additive-only check is
-      # unaffected: it only ever compares a new migration's proposed columns
-      # against the CURRENT version, which is exactly what's still dumped.
+      # every time. The migration files themselves (db/migrate_virgodb_*/*.rb,
+      # timestamped, under git blame) are already the authoritative "what
+      # changed when" record. `register_schema_version`'s additive-only check
+      # is unaffected: it only ever compares a new migration's proposed
+      # columns against the CURRENT version, which is exactly what's still
+      # dumped.
+      #
+      # `schema_versions` has no `applied_at` column as of this adapter
+      # version (removed from the manifest's own schema, see
+      # manifest/src/lib.rs's matching comment on `register_schema_version`
+      # -- nothing ever read it back). It used to carry real wall-clock data
+      # (`Time.now.to_i` at migration time), which made this file diff on
+      # every clean rebuild (`db:drop` + `db:migrate`) even when the actual
+      # schema hadn't changed at all -- that's gone now along with the
+      # column, not just papered over here.
       def dump_schema_versions!(filename)
         return unless connection.data_source_exists?("schema_versions")
 
-        rows = connection.select_all("SELECT id, table_name, version, columns, applied_at FROM schema_versions ORDER BY table_name, version")
+        rows = connection.select_all("SELECT id, table_name, version, columns FROM schema_versions ORDER BY table_name, version")
         return if rows.to_a.empty?
 
         File.open(filename, "a") do |f|
           f.puts
           rows.to_a.group_by { |r| r["table_name"] }.each do |table_name, versions|
             latest = versions.max_by { |r| r["version"] }
-            history = versions.map { |r| "v#{r['version']} (#{Time.at(r['applied_at'].to_i).utc.strftime('%Y-%m-%d')})" }.join(", ")
 
-            f.puts "-- #{table_name} schema history: #{history} -- only the current version is dumped below; see db/migrate_virgodb_*/ for the rest"
             pretty_columns = JSON.pretty_generate(JSON.parse(latest["columns"]))
             f.puts(
-              "INSERT INTO \"schema_versions\" (id, table_name, version, columns, applied_at) VALUES (\n" \
+              "INSERT INTO \"schema_versions\" (id, table_name, version, columns) VALUES (\n" \
               "  #{latest['id']}, #{connection.quote(table_name)}, #{latest['version']},\n" \
-              "  #{connection.quote(pretty_columns)},\n" \
-              "  #{latest['applied_at']}\n" \
+              "  #{connection.quote(pretty_columns)}\n" \
               ");"
             )
             f.puts
@@ -199,7 +204,7 @@ module ActiveRecord
       # `SQLiteDatabaseTasks#structure_dump`'s `ignore_tables`-triggered
       # fallback (used whenever `ActiveRecord::SchemaDumper.ignore_tables` is
       # non-empty, e.g. excluding tables owned by a separate replication/
-      # backup mechanism -- exactly hintpot's own litestream initializer)
+      # backup mechanism -- exactly a host app's own Litestream initializer)
       # runs `SELECT sql || ';' FROM sqlite_master WHERE tbl_name NOT IN
       # (...) ORDER BY tbl_name, type DESC, name` through the `sqlite3` CLI.
       # Any table with a non-INTEGER (so non-rowid-alias) PRIMARY KEY --
@@ -271,8 +276,8 @@ module ActiveRecord
 
       # Matches `db/clickhouse_structure.sql` and `db/schema.rb`'s own
       # convention (both, unprompted, separate every top-level table
-      # definition with a blank line -- confirmed directly against
-      # hintpot's real dumps of each, not assumed) rather than inventing a
+      # definition with a blank line -- confirmed directly against a real
+      # host app's dumps of each, not assumed) rather than inventing a
       # new one here. Only CREATE TABLE gets a leading blank line, not
       # CREATE INDEX/CREATE UNIQUE INDEX -- those stay glued directly under
       # their own table, same as clickhouse_structure.sql has no equivalent

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-virgodb-adapter
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.9
 platform: ruby
 authors:
 - virgodb