activerecord-typedstore 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: feff41b09759e6bba17c41f3b4ab635286d7852f
-  data.tar.gz: 8ea136dccb104e0a43ad7267d425bdc2016cf5d3
+  metadata.gz: 805a07504ab5ed0b6a41983d945f5a0bdd649726
+  data.tar.gz: c09ffc9348aa4256c439645b7d36edb0b3951705
 SHA512:
-  metadata.gz: 64a75b48fe0f9bd9e768b1fe5947f43ffee8eeef182057493e31958ede64d4f2f8c78292343c3cb8e74d48b605070cd953cbe0b3a96bcdd1b0d733a8294b0ae2
-  data.tar.gz: 4e983b5546295199cc3cbc7dcf5ce5109693bd272b7185b9d4d1af05db5538ac5443f5b05834fe911f799ed9602e2c241bc39524bbc9e0d229cd808c458f0b35
+  metadata.gz: 2c033c463261169f42b5ab7e1a4c0dade01d101c1f084695124b5e018131bbce84a389b34bfc9aedeec224383def213cd6cf4c78b609d820cffbf8fd1cdaf695
+  data.tar.gz: 6ed412a72266d529d32401c6ef99a7bfc85fd5d38cf7716f8e44035cc1b1250099b67e3aa9e153a5eab1e97e4a2669fa1f7596fa2fb271aa1404274fabf94020

data/gemfiles/Gemfile.ar-4.0

@@ -9,4 +9,3 @@ gem 'pg', '~> 0.11'
 gem 'mysql2'
 gem 'database_cleaner'
 gem 'coveralls', require: false
-gem 'debugger'

data/gemfiles/Gemfile.ar-4.1

@@ -9,4 +9,3 @@ gem 'pg', '~> 0.11'
 gem 'mysql2'
 gem 'database_cleaner'
 gem 'coveralls', require: false
-gem 'debugger'

data/lib/active_record/typed_store/dsl.rb

@@ -14,7 +14,7 @@ module ActiveRecord::TypedStore
       @columns.select(&:accessor?).map(&:name)
     end
 
-    [:string, :integer, :float, :decimal, :datetime, :date, :boolean, :any].each do |type|
+    [:string, :text, :integer, :float, :decimal, :datetime, :date, :boolean, :any].each do |type|
       define_method(type) do |name, options={}|
         @columns << Column.new(name, type, options.reverse_merge(accessor: @accessors))
       end

data/lib/active_record/typed_store/extension.rb

@@ -61,10 +61,17 @@ module ActiveRecord::TypedStore
         return if @typed_store_attribute_methods_generated
         store_accessors.each do |attribute|
           define_virtual_attribute_method(attribute)
+          undefine_before_type_cast_method(attribute)
         end
         @typed_store_attribute_methods_generated = true
       end
 
+      def undefine_before_type_cast_method(attribute)
+        # because it mess with ActionView forms, see #14.
+        method = "#{attribute}_before_type_cast"
+        undef_method(method) if method_defined?(method)
+      end
+
       def store_accessors
         return [] unless typed_store_attributes
         typed_store_attributes.values.select(&:accessor?).map(&:name).map(&:to_s)
@@ -92,7 +99,8 @@ module ActiveRecord::TypedStore
       end
 
       previous_value = read_store_attribute(store_attribute, key)
-      attribute_will_change!(key.to_s) if value != previous_value
+      new_value = column ? column.type_cast(value) : value
+      attribute_will_change!(key.to_s) if new_value != previous_value
       super
     end
 

data/lib/active_record/typed_store/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module TypedStore
-    VERSION = '0.4.3'
+    VERSION = '0.4.4'
   end
 end

data/spec/active_record/typed_store_spec.rb

@@ -27,7 +27,7 @@ shared_examples 'any model' do
 
     it 'assign attributes received by #initialize' do
       model = described_class.new(public: true)
-      expect(model.public).to be_true
+      expect(model.public).to be true
     end
 
   end
@@ -65,6 +65,38 @@ shared_examples 'any model' do
       }.to change { model.age }.from(24).to(12)
     end
 
+    it 'does not dirty track assigning the same boolean' do
+      expect(model.enabled).to be true
+      expect {
+        model.enabled = true
+      }.to_not change { model.enabled_changed? }
+    end
+
+    it 'dirty tracks when the boolean changes' do
+      expect(model.enabled).to be true
+      expect {
+        model.enabled = false
+      }.to change { model.enabled_changed? }.from(false).to(true)
+    end
+
+    it 'does not dirty track assigning the same boolean even if it is a string' do
+      expect(model.enabled).to be true
+      expect {
+        model.enabled = "true"
+      }.to_not change { model.enabled_changed? }
+    end
+
+    it 'dirty tracks when the string changes' do
+      expect {
+        model.name = "Smith"
+      }.to change { model.name_changed? }.from(false).to(true)
+    end
+
+    it 'does not dirty track assigning the same string' do
+      expect {
+        model.name = ""
+      }.to_not change { model.name_changed? }
+    end
   end
 
   describe 'unknown attribute' do
@@ -108,15 +140,15 @@ shared_examples 'any model' do
 
     it 'any string is considered present' do
       model.name = 'Peter Gibbons'
-      expect(model.name?).to be_true
+      expect(model.name?).to be true
     end
 
     it 'empty string is not considered present' do
-      expect(model.name?).to be_false
+      expect(model.name?).to be false
     end
 
     it 'nil is not considered present' do
-      expect(model.cell_phone?).to be_false
+      expect(model.cell_phone?).to be false
     end
 
     it 'not define the attributes more than one time' do
@@ -129,14 +161,14 @@ shared_examples 'any model' do
   describe 'boolean attribute' do
 
     it 'has the defined :default as initial value' do
-      expect(model.public).to be_false
+      expect(model.public).to be false
     end
 
     [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON'].each do |value|
 
       it "cast `#{value.inspect}` as `true`" do
         model.public = value
-        expect(model.public).to be_true
+        expect(model.public).to be true
       end
 
     end
@@ -145,22 +177,22 @@ shared_examples 'any model' do
 
       it "cast `#{value.inspect}` as `false`" do
         model.public = value
-        expect(model.public).to be_false
+        expect(model.public).to be false
       end
 
     end
 
     it 'properly persit the value' do
       model.update_attributes(public: false)
-      expect(model.reload.public).to be_false
+      expect(model.reload.public).to be false
       model.update_attributes(public: true)
-      expect(model.reload.public).to be_true
+      expect(model.reload.public).to be true
     end
 
     it 'initialize with default value if the column is not nullable' do
-      expect(model.public).to be_false
+      expect(model.public).to be false
       model.save
-      expect(model.reload.public).to be_false
+      expect(model.reload.public).to be false
     end
 
     it 'can store nil if the column is nullable' do
@@ -170,20 +202,20 @@ shared_examples 'any model' do
 
     it 'save the default value if the column is nullable but the value not explictly set' do
       model.save
-      expect(model.reload.enabled).to be_true
+      expect(model.reload.enabled).to be true
     end
 
     it 'true is considered present' do
-      expect(model.enabled?).to be_true
+      expect(model.enabled?).to be true
     end
 
     it 'false is not considered present' do
-      expect(model.public?).to be_false
+      expect(model.public?).to be false
     end
 
     it 'nil is not considered present' do
       model.update_attributes(enabled: nil)
-      expect(model.enabled?).to be_false
+      expect(model.enabled?).to be false
     end
 
   end
@@ -210,22 +242,22 @@ shared_examples 'any model' do
     end
 
     it 'positive values are considered present' do
-      expect(model.age?).to be_true
+      expect(model.age?).to be true
     end
 
     it 'negative values are considered present' do
       model.age = -42
-      expect(model.age?).to be_true
+      expect(model.age?).to be true
     end
 
     it '0 is not considered present' do
       model.age = 0
-      expect(model.age?).to be_false
+      expect(model.age?).to be false
     end
 
     it 'nil is not considered present' do
       model.max_length = nil
-      expect(model.max_length?).to be_false
+      expect(model.max_length?).to be false
     end
 
   end
@@ -253,20 +285,20 @@ shared_examples 'any model' do
 
     it 'positive values are considered present' do
       model.rate = 4.2
-      expect(model.rate?).to be_true
+      expect(model.rate?).to be true
     end
 
     it 'negative values are considered present' do
       model.rate = -4.2
-      expect(model.rate?).to be_true
+      expect(model.rate?).to be true
     end
 
     it '0 is not considered present' do
-      expect(model.rate?).to be_false
+      expect(model.rate?).to be false
     end
 
     it 'nil is not considered present' do
-      expect(model.price?).to be_false
+      expect(model.price?).to be false
     end
 
   end
@@ -303,21 +335,21 @@ shared_examples 'any model' do
 
     it 'positive values are considered present' do
       model.shipping_cost = BigDecimal.new('4.2')
-      expect(model.shipping_cost?).to be_true
+      expect(model.shipping_cost?).to be true
     end
 
     it 'negative values are considered present' do
       model.shipping_cost = BigDecimal.new('-4.2')
-      expect(model.shipping_cost?).to be_true
+      expect(model.shipping_cost?).to be true
     end
 
     it '0 is not considered present' do
       model.shipping_cost = BigDecimal.new('0')
-      expect(model.shipping_cost?).to be_false
+      expect(model.shipping_cost?).to be false
     end
 
     it 'nil is not considered present' do
-      expect(model.shipping_cost?).to be_false
+      expect(model.shipping_cost?).to be false
     end
 
   end
@@ -352,11 +384,11 @@ shared_examples 'any model' do
 
     it 'any non-nil value is considered present' do
       model.remind_on = Date.new
-      expect(model.remind_on?).to be_true
+      expect(model.remind_on?).to be true
     end
 
     it 'nil is not considered present' do
-      expect(model.remind_on?).to be_false
+      expect(model.remind_on?).to be false
     end
 
   end
@@ -437,11 +469,11 @@ shared_examples 'any model' do
 
     it 'any non-nil value is considered present' do
       model.remind_at = DateTime.new
-      expect(model.remind_at?).to be_true
+      expect(model.remind_at?).to be true
     end
 
     it 'nil is not considered present' do
-      expect(model.remind_at?).to be_false
+      expect(model.remind_at?).to be false
     end
 
   end
@@ -489,6 +521,10 @@ shared_examples 'a store' do |retain_type=true|
 
     end
 
+    it 'do not respond to <attribute>_before_type_cast' do
+      expect(model).to_not respond_to :nickname_before_type_cast
+    end
+
   end
 
   describe 'attributes without accessors' do
@@ -538,7 +574,7 @@ shared_examples 'a store' do |retain_type=true|
       begin
         model.class::SettingsHash.columns['brand_new'] = new_column
         model.reload
-        expect(model.settings[:brand_new]).to be_true
+        expect(model.settings[:brand_new]).to be true
       ensure
         model.class::SettingsHash.columns.delete('brand_new')
       end

data/spec/spec_helper.rb

@@ -16,8 +16,5 @@ require 'activerecord-typedstore'
 Dir[File.expand_path(File.join(File.dirname(__FILE__), 'support', '**', '*.rb'))].each { |f| require f }
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
   config.order = 'random'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-typedstore
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-20 00:00:00.000000000 Z
+date: 2014-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -189,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: ActiveRecord::Store but with type definition