activerecord-typedstore 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4576d86d981102fb975b790007a6c030d1023e80
-  data.tar.gz: 04265638898e9a80318d931fcfbe4291026f63ee
+  metadata.gz: feff41b09759e6bba17c41f3b4ab635286d7852f
+  data.tar.gz: 8ea136dccb104e0a43ad7267d425bdc2016cf5d3
 SHA512:
-  metadata.gz: eb80e3bfe74bf53c36a4e9c12c2aea8cc5bf612af892dccc2b9c9d52ff3863b9f797ae86634937fb5a99504e1a439520f25dc8a97bf8f1e46619eee6a368fc12
-  data.tar.gz: 5bc7ab0513420edd67af9821ce47947f70b31873b8e74f539fd0eefc5aacb2b327a4c92834e54e183e17a590c2fdd67837e2eaee031506eb9493b4aa57966ee8
+  metadata.gz: 64a75b48fe0f9bd9e768b1fe5947f43ffee8eeef182057493e31958ede64d4f2f8c78292343c3cb8e74d48b605070cd953cbe0b3a96bcdd1b0d733a8294b0ae2
+  data.tar.gz: 4e983b5546295199cc3cbc7dcf5ce5109693bd272b7185b9d4d1af05db5538ac5443f5b05834fe911f799ed9602e2c241bc39524bbc9e0d229cd808c458f0b35

data/.travis.yml

@@ -2,6 +2,7 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.1.1
 gemfile:
   - gemfiles/Gemfile.ar-3.2
   - gemfiles/Gemfile.ar-4.0

data/README.md

@@ -99,6 +99,57 @@ Actually the only difference is that you wont be able to query on these attribut
 
 If not, please fill an issue.
 
+## Serialization methods
+
+Just like for store, you can use any custom coder:
+
+```ruby
+module Base64MarshalCoder
+  extend self
+
+  def load(data)
+    return {} unless data
+    Marshal.load(Base64.decode64(data))
+  end
+
+  def dump(data)
+    Base64.encode64(Marshal.dump(data || {}))
+  end
+
+end
+
+typed_store :settings, coder: Base64MarshalCoder do |s|
+  # ...
+end
+```
+
+If you want to use Postgres HStore or JSON column types, then you need a very simple coder:
+```ruby
+module DumbCoder
+  extend self
+
+  def load(data)
+    data || {}
+  end
+
+  def dump(data)
+    data || {}
+  end
+
+end
+```
+
+## HStore limitations
+
+If you want to persist your store in a Postgres HStore, then there is some limitations imposed by the current HStore implementation in Postgres.
+Since HStore can only store strings:
+
+  - `array` attributes won't work
+  - `any` attributes will be converted to string
+
+If you use HStore because you need to be able to query the store from SQL, and any of these limitations are an issue for you,
+than you could probably use the JSON column type, which do not suffer from these limitations and is also queriable. 
+
 ## Contributing
 
 1. Fork it

data/lib/active_record/typed_store/coder.rb

@@ -19,6 +19,10 @@ module ActiveRecord::TypedStore
 
     delegate :as_indifferent_hash, to: 'self.class'
 
+    def dump(obj)
+      @coder.dump(obj.try(:to_hash) || {})
+    end
+
   end
 
 end

data/lib/active_record/typed_store/extension.rb

@@ -70,10 +70,6 @@ module ActiveRecord::TypedStore
         typed_store_attributes.values.select(&:accessor?).map(&:name).map(&:to_s)
       end
 
-      def hstore?(store_attribute)
-        columns_hash[store_attribute.to_s].try(:type) == :hstore
-      end
-
       def create_time_zone_conversion_attribute?(name, column)
         column ||= typed_store_attributes[name]
         super(name, column)

data/lib/active_record/typed_store/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module TypedStore
-    VERSION = '0.4.2'
+    VERSION = '0.4.3'
   end
 end

data/spec/active_record/typed_store_spec.rb

@@ -529,6 +529,23 @@ shared_examples 'a store' do |retain_type=true|
 
   end
 
+  describe 'updated defaults' do
+
+    it 'update defaults for outdated serials' do
+      model.save!
+      expect(model.settings[:brand_new]).to be_nil
+      new_column = ActiveRecord::TypedStore::Column.new(:brand_new, :boolean, null: false, default: true)
+      begin
+        model.class::SettingsHash.columns['brand_new'] = new_column
+        model.reload
+        expect(model.settings[:brand_new]).to be_true
+      ensure
+        model.class::SettingsHash.columns.delete('brand_new')
+      end
+    end
+
+  end
+
 end
 
 shared_examples 'a db backed model' do
@@ -628,7 +645,7 @@ describe PostgresqlRegularARModel do
 end if defined?(PostgresqlRegularARModel)
 
 describe PostgresHstoreTypedStoreModel do
-  if AR_VERSION >= AR_4_0
+  if AR_VERSION >= AR_4_1
     pending('TODO: Rails edge HStore compatibiliy')
   else
     it_should_behave_like 'any model'

data/spec/support/models.rb

@@ -94,7 +94,7 @@ class ColumnCoder
   end
 
   def load(data)
-    return {} unless data
+    return {} if data.blank?
     @coder.load(data)
   end
 
@@ -135,7 +135,7 @@ if ENV['POSTGRES']
     class PostgresHstoreTypedStoreModel < ActiveRecord::Base
       establish_connection ENV['POSTGRES_URL'] || 'test_postgresql'
       store :untyped_settings, accessors: [:title]
-      typed_store :settings do |s|
+      typed_store :settings, coder: ColumnCoder.new(AsJson) do |s|
         define_store_columns(s)
       end
     end
@@ -176,6 +176,7 @@ module MarshalCoder
   extend self
 
   def load(serial)
+    return unless serial.present?
     Marshal.load(Base64.decode64(serial))
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-typedstore
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-14 00:00:00.000000000 Z
+date: 2014-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord