activerecord-typedstore 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 497e66e991da7941c1769d7152e95ba2947e0a10
-  data.tar.gz: 91085d4d5f1563bd97f7becc775468ef2a70f706
+  metadata.gz: 4576d86d981102fb975b790007a6c030d1023e80
+  data.tar.gz: 04265638898e9a80318d931fcfbe4291026f63ee
 SHA512:
-  metadata.gz: 764da6e7280e7f0f4a48fbd3ee5de62c82a643db98ae6609259340a4a7a8b46092178d6660e95f0679e9d0c1e0e9178ef6213658ee66fe377e267f6d7339391a
-  data.tar.gz: 12b13ab9453e9c43220614b597e54befe9db493a517accf1e39a13e94630a7f3859ab3055be43f1204ee1b116b6eaadb81c8e2dcb6b21bff827be15d914f6a05
+  metadata.gz: eb80e3bfe74bf53c36a4e9c12c2aea8cc5bf612af892dccc2b9c9d52ff3863b9f797ae86634937fb5a99504e1a439520f25dc8a97bf8f1e46619eee6a368fc12
+  data.tar.gz: 5bc7ab0513420edd67af9821ce47947f70b31873b8e74f539fd0eefc5aacb2b327a4c92834e54e183e17a590c2fdd67837e2eaee031506eb9493b4aa57966ee8

data/lib/active_record/typed_store/coder.rb

@@ -17,6 +17,8 @@ module ActiveRecord::TypedStore
 
     end
 
+    delegate :as_indifferent_hash, to: 'self.class'
+
   end
 
 end

data/lib/active_record/typed_store/extension.rb

@@ -102,6 +102,16 @@ module ActiveRecord::TypedStore
 
     private
 
+    def write_attribute(attr_name, value)
+      if coder = self.class.serialized_attributes[attr_name]
+        if coder.is_a?(ActiveRecord::TypedStore::Coder)
+          return super(attr_name, coder.as_indifferent_hash(value))
+        end
+      end
+
+      super
+    end
+
     def store_column(store_attribute, key)
       store = store_columns(store_attribute)
       store && store[key]

data/lib/active_record/typed_store/typed_hash.rb

@@ -47,7 +47,7 @@ module ActiveRecord::TypedStore
     def cast_value(key, value)
       key = convert_key(key)
       column = columns[key]
-      return value unless columns
+      return value unless column
 
       casted_value = column.cast(value)
 

data/lib/active_record/typed_store/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module TypedStore
-    VERSION = '0.4.1'
+    VERSION = '0.4.2'
   end
 end

data/spec/active_record/typed_store/typed_hash_spec.rb

@@ -196,9 +196,16 @@ describe ActiveRecord::TypedStore::TypedHash do
         hash.merge!(source: '')
         expect(hash[:source]).to be == 'web'
       end
-
     end
-
   end
 
+  context 'unknown columns' do
+    let(:column) { ['age', :integer] }
+
+    it 'can be assigned' do
+      hash = hash_class.new
+      hash[:unknown_key] = 42
+      expect(hash[:unknown_key]).to be == 42
+    end
+  end
 end

data/spec/active_record/typed_store_spec.rb

@@ -452,6 +452,22 @@ shared_examples 'a store' do |retain_type=true|
 
   let(:model) { described_class.new }
 
+  describe 'assigning the store' do
+
+    it 'coerce it to the proper typed hash' do
+      expect {
+        model.settings = {}
+      }.to_not change { model.settings.class }
+    end
+
+    it 'still handle default values' do
+      expect {
+        model.settings = {}
+      }.to_not change { model.settings['nickname'] }
+    end
+
+  end
+
   describe 'attributes' do
 
     it 'retrieve default if assigned nil and null not allowed' do
@@ -459,9 +475,18 @@ shared_examples 'a store' do |retain_type=true|
       expect(model.age).to be == 12
     end
 
-    it 'retreive default if assigned a blank value and column cannot be blank' do
-      model.update_attributes(nickname: '')
-      expect(model.reload.nickname).to be == 'Please enter your nickname'
+    context 'when column cannot be blank' do
+
+      it 'retreive default if not persisted yet, and nothing was assigned' do
+        expect(model.nickname).to be == 'Please enter your nickname'
+      end
+
+      it 'retreive default if assigned a blank value' do
+        model.update_attributes(nickname: '')
+        expect(model.nickname).to be == 'Please enter your nickname'
+        expect(model.reload.nickname).to be == 'Please enter your nickname'
+      end
+
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-typedstore
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-13 00:00:00.000000000 Z
+date: 2014-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord