activerecord-typedstore 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6afeb6ff2bb89ff627f8705a5e7006db18f056f2
-  data.tar.gz: 502372b9082fb76972f43abc216d4cc8d95c4be2
+  metadata.gz: 542197f677322bd49dc623661de6f72adae6e259
+  data.tar.gz: 8612b393a7cbc50203a8848c9928dfade4776ef2
 SHA512:
-  metadata.gz: 0218e36856f3c37c08c0997f349ab7c610b528a1de19dd9bf24d312559922648a5ac9271fba86696254911688a51b62c0ee11500ed6b4af4d392834cda115126
-  data.tar.gz: cc586d21280e82597c3cdd11390737ca7286997fc87f6cdac785749fcda3754b10fdd9174eea633da2078dca0605c6b00fa2ec35e44f7e72da314eab6247632f
+  metadata.gz: a06189e792adec4ac11a2bc6020439135051a1d7194f21d43008d9077fcef511ddcf9f8d252f5f25478aa9220425b38bc03655462a6138b04e9e941bcfdcc566
+  data.tar.gz: dfc9469b4dd7c9e1dbb611db6db1e150ac643d6f52f890f58665308f384457cf5a0b2f6a7e885af51ff7db48f16d996971a3b12229bf8e226bd53a9c188c0bcb

data/README.md

@@ -66,6 +66,12 @@ shop.update_attributes(
 shop.age                # => 42
 shop.published_at.class #= DateTime
 
+# And changes are tracked
+shop.age_changed? # => false
+shop.age = 12
+shop.age_changed? # => true
+shop.age_was      # => 42
+
 # You can still use it as a regular store
 shop.settings[:unknown] = 'Hello World'
 shop.save

data/lib/active_record/typed_store/ar_32_fallbacks.rb

@@ -3,6 +3,11 @@ module ActiveRecord::TypedStore
   module AR32Fallbacks
     extend ActiveSupport::Concern
 
+    included do
+      cattr_accessor :virtual_attribute_methods
+      self.virtual_attribute_methods = []
+    end
+
     module ClassMethods
 
       def typed_store(store_attribute, options={}, &block)
@@ -12,6 +17,24 @@ module ActiveRecord::TypedStore
 
       protected
 
+      def define_virtual_attribute_method(name)
+        virtual_attribute_methods << name
+        define_attribute_method(name)
+      end
+
+      # ActiveModel override heavilly inspired from the original code
+      def define_attribute_method(attr_name)
+        return super unless virtual_attribute_methods.include?(attr_name)
+
+        attribute_method_matchers.each do |matcher|
+          method_name = matcher.method_name(attr_name)
+          unless instance_method_already_implemented?(method_name)
+            define_optimized_call generated_attribute_methods, method_name, matcher.method_missing_target, attr_name.to_s
+          end
+        end
+        attribute_method_matchers_cache.clear
+      end
+
       def _ar_32_fallback_accessors(store_attribute, columns)
         _ar_32_fallback_initializer(store_attribute, columns)
         columns.each do |column|
@@ -39,7 +62,9 @@ module ActiveRecord::TypedStore
 
       def _ar_32_fallback_writer(store_attribute, column)
         define_method("#{column.name}_with_type_casting=") do |value|
-          self.send("#{column.name}_without_type_casting=", column.cast(value))
+          casted_value = column.cast(value)
+          attribute_will_change!(column.name.to_s) if casted_value != send(column.name)
+          send("#{column.name}_without_type_casting=", casted_value)
         end
         alias_method_chain "#{column.name}=", :type_casting
       end

data/lib/active_record/typed_store/extension.rb

@@ -7,6 +7,10 @@ module ActiveRecord::TypedStore
   IS_AR_4_0 = AR_VERSION >= Gem::Version.new('4.0') && AR_VERSION < Gem::Version.new('4.1.0.beta')
   IS_AR_4_1 = AR_VERSION >= Gem::Version.new('4.1.0.beta')
 
+  unless IS_AR_3_2
+    ActiveModel::AttributeMethods::ClassMethods.send(:alias_method, :define_virtual_attribute_method, :define_attribute_method)
+  end
+
   module Extension
     extend ActiveSupport::Concern
 
@@ -27,6 +31,8 @@ module ActiveRecord::TypedStore
         stored_typed_attributes[store_attribute] ||= {}
         stored_typed_attributes[store_attribute].merge!(dsl.columns.index_by(&:name))
 
+        dsl.column_names.each { |c| define_virtual_attribute_method(c.to_s) }
+
         dsl
       end
 
@@ -42,6 +48,7 @@ module ActiveRecord::TypedStore
         end
       end
 
+      attribute_will_change!(key.to_s) if casted_value != read_store_attribute(store_attribute, key)
       super(store_attribute, key, casted_value)
     end
 

data/lib/active_record/typed_store/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module TypedStore
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

data/spec/active_record/typed_store_spec.rb

@@ -26,6 +26,41 @@ shared_examples 'any model' do
 
   end
 
+  describe 'dirty tracking' do
+
+    it 'track changed attributes' do
+      expect {
+        model.age = 24
+      }.to change { model.age_changed? }.from(false).to(true)
+    end
+
+    it 'keep track of what the attribute was' do
+      model.age = 24
+      expect(model.age_was).to be == 12
+    end
+
+    it 'keep track of the whole changes' do
+      expect {
+        model.age = 24
+      }.to change { model.changes['age'] }.from(nil).to([12, 24])
+    end
+
+    it 'reset recorded changes after successful save' do
+      model.age = 24
+      expect {
+        model.save
+      }.to change { model.age_changed? }.from(true).to(false)
+    end
+
+    it 'can be reset individually' do
+      model.age = 24
+      expect {
+        model.reset_age!
+      }.to change { model.age }.from(24).to(12)
+    end
+
+  end
+
   describe 'unknown attribute' do
 
     it 'raise an ActiveRecord::UnknownAttributeError on save attemps' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-typedstore
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-03 00:00:00.000000000 Z
+date: 2013-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord