activerecord-turntable 3.0.0.alpha3 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41a37244828a78c777c27525202b50624b38fe3d
-  data.tar.gz: 5c641a6137de50b3b86994b76ec711f074e078f0
+  metadata.gz: 6cfc2457a7b8212bbeef4d49d4b84b8b40877396
+  data.tar.gz: ed7b1f0e36e61aa3104ec0bebd1cd4d67e31dcdb
 SHA512:
-  metadata.gz: 1fa1f1bd2cbfeb0152f235feb507bcfc5ab2efc6b6aa722bc1ae711d21e1fe4e682b5c471422c71fe6189388fe16b7a68006b5eb99629ddcaba2f691f03647c4
-  data.tar.gz: 931b27608861d82164a1271ae28ffd4abda9374b67d0f71625c9eaa1f6a17f53bcfb6fc765ddf7157128abb38c99dc98835aa118ea622a5f050eec279431ccc4
+  metadata.gz: ba0296ccb842d6f10069cc875a2aacd0bd2bd7b3b3766cd7fc3701b795c16c3f05f64531b279a1cac2a13649dac832ce932c7ba3478326aaf03f1698f5757e46
+  data.tar.gz: 497202d000a232456c5c786ec1202920773069a684760d2c3bcb9eb3e6e55c761d19ff1fb64ac6f3f333401ebc31a1b527b7cb299d603ab22b52413f9376e9ba

data/.gitmodules

@@ -0,0 +1,3 @@
+[submodule "tmp/rails"]
+	path = tmp/rails
+	url = https://github.com/rails/rails.git

data/.rubocop.yml

@@ -3,5 +3,23 @@ inherit_gem:
     - "config/rubocop.yml"
     - "config/rspec.yml"
 
+inherit_from:
+  - ".rubocop_todo.yml"
+
 AllCops:
   TargetRubyVersion: 2.2
+  Exclude:
+    - "test/**/*"
+    - "tmp/**/*"
+    - "activerecord.rake"
+
+RSpec/NestedGroups:
+  Max: 4
+
+Style/ExtraSpacing:
+  Exclude:
+    - "activerecord-turntable.gemspec"
+
+Style/SpaceAroundOperators:
+  Exclude:
+    - "activerecord-turntable.gemspec"

data/.rubocop_todo.yml

@@ -0,0 +1,153 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-02-10 00:09:09 +0900 using RuboCop version 0.47.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'lib/active_record/turntable/active_record_ext/connection_handler_extension.rb'
+    - 'lib/active_record/turntable/active_record_ext/schema_dumper.rb'
+
+# Offense count: 4
+Lint/RescueException:
+  Exclude:
+    - 'lib/active_record/turntable/connection_proxy.rb'
+    - 'lib/active_record/turntable/mixer.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Lint/UnneededSplatExpansion:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 14
+Metrics/AbcSize:
+  Max: 106
+
+# Offense count: 2
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 88
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 202
+
+# Offense count: 5
+Metrics/CyclomaticComplexity:
+  Max: 20
+
+# Offense count: 2
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 246
+
+# Offense count: 10
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 56
+
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 6
+
+# Offense count: 9
+Metrics/PerceivedComplexity:
+  Max: 24
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Performance/TimesMap:
+  Exclude:
+    - 'script/performance/algorithm'
+    - 'spec/active_record/turntable/active_record_ext/association_preloader_spec.rb'
+    - 'spec/active_record/turntable/active_record_ext/association_spec.rb'
+    - 'spec/active_record/turntable/cluster_helper_methods_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: CustomIncludeMethods.
+RSpec/EmptyExampleGroup:
+  Exclude:
+    - 'spec/active_record/turntable/mixer/fader_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/active_record/turntable/active_record_ext/fixture_set_spec.rb'
+    - 'spec/active_record/turntable/active_record_ext/test_fixtures_spec.rb'
+
+# Offense count: 21
+# Configuration parameters: Max.
+RSpec/NestedGroups:
+  Exclude:
+    - 'spec/active_record/turntable/active_record_ext/association_preloader_spec.rb'
+    - 'spec/active_record/turntable/active_record_ext/association_spec.rb'
+    - 'spec/active_record/turntable/active_record_ext/clever_load_spec.rb'
+    - 'spec/active_record/turntable/connection_proxy_spec.rb'
+    - 'spec/active_record/turntable/finder_spec.rb'
+    - 'spec/active_record/turntable/mixer_spec.rb'
+
+# Offense count: 15
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/active_record/turntable/active_record_ext/acts_as_archive_extension.rb'
+    - 'lib/active_record/turntable/active_record_ext/clever_load.rb'
+    - 'lib/active_record/turntable/active_record_ext/database_tasks.rb'
+    - 'lib/active_record/turntable/active_record_ext/fixtures.rb'
+    - 'lib/active_record/turntable/algorithm/range_bsearch_algorithm.rb'
+    - 'lib/active_record/turntable/cluster_helper_methods.rb'
+    - 'lib/active_record/turntable/connection_proxy.rb'
+    - 'script/performance/algorithm'
+
+# Offense count: 2
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/active_record/turntable/sql_tree_patch.rb'
+
+# Offense count: 4
+Style/MethodCalledOnDoEndBlock:
+  Exclude:
+    - 'lib/active_record/turntable/migration.rb'
+    - 'lib/active_record/turntable/mixer.rb'
+    - 'lib/active_record/turntable/mixer/fader/update_shards_merge_result.rb'
+    - 'lib/active_record/turntable/sql_tree_patch.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'lib/active_record/turntable/sql_tree_patch.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
+# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
+Style/TernaryParentheses:
+  Exclude:
+    - 'lib/active_record/turntable/sequencer.rb'
+    - 'lib/active_record/turntable/sql_tree_patch.rb'

data/.travis.yml

@@ -1,16 +1,32 @@
 language: ruby
+sudo: false
+
+cache:
+  bundler: true
+
 rvm:
   - 2.2.6
   - 2.3.3
   - 2.4.0
   - ruby-head
+
 gemfile:
   - gemfiles/rails5_0.gemfile
+  - gemfiles/rails_edge.gemfile
+
+env:
+  - SETUP_TASK=turntable:db:reset BUILD_TASK=spec
+  - SETUP_TASK=turntable:activerecord:setup BUILD_TASK=turntable:activerecord:test
+
+before_install: gem update --system
+
 before_script:
-  - bundle exec rake turntable:db:reset
-script: bundle exec rake spec
+  - bundle exec rake $SETUP_TASK
+
+script:
+  - bundle exec rake $BUILD_TASK
+
 matrix:
   allow_failures:
     - rvm: ruby-head
-sudo: false
-cache: bundler
+    - gemfile: gemfiles/rails_edge.gemfile

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+## activerecord-turntable 3.0.0 ##
+
+### Bugfixes
+
+* Fixes schema dumper patches that dumps tables options incorrectly.
+* Re-enable the `AR::LogSubscriber::IGNORE_PAYLOAD_NAMES` (thx @misoobu)
+* Make cluster transaction helpers to preserve transaction options(e.g. :requires_new)
+* Fixes shard names are not written to logs correctly (thx @i2bskn)
+* Fixes ConnectionNotEstablished Error with STI subclasses #48
+
+### Improvements
+
+* Update activerecord-import patches for performance improvements (thx @misoobu)
+
+
 ## activerecord-turntable 3.0.0.alpha3 ##
 
 ### Bugfix
@@ -18,6 +33,23 @@
   * Minimum ruby requirement version is `2.2.2`
   * Rails 4.x support has been dropped.
 
+## activerecord-turntable 2.5.0 ##
+
+### Improvement
+
+* Fix to propagate shard conditions to `AssociationRelation` too
+
+## activerecord-turntable 2.4.0 ##
+
+### Incompatible Change
+
+* Drop support for ruby 1.9.3
+
+### Bugfix
+
+* Update activerecord 4.2 patches
+  * Fixes optimistic locking with a serialized column causes JSON::Error.
+
 ## activerecord-turntable 2.3.3 ##
 
 ### Bugfix

data/Guardfile

@@ -2,7 +2,7 @@
 # More info at https://github.com/guard/guard#readme
 
 guard "rspec",
-      cmd: "bundle exec rspec",
+      cmd: "rspec",
       all_after_pass: true,
       all_on_start: true do
   watch(%r{^spec/.+_spec\.rb$})
@@ -11,6 +11,6 @@ guard "rspec",
 end
 
 guard :rubocop do
-  watch(%r{.+\.rb$})
+  watch(/.+\.rb$/)
   watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
 end

data/README.md

@@ -13,8 +13,8 @@ activerecord(>=5.0.0, <6.0)
 
 If you are using with older activerecord versions, use following versions.
 
-* activerecord 3.x - use activerecord-turntable version 1.x.
-* activerecord 4.x - use activerecord-turntable version 2.x.
+* activerecord 4.x - use activerecord-turntable version 2.x.([stable-2-x branch](https://github.com/drecom/activerecord-turntable/tree/stable-2-x))
+* activerecord 3.x - use activerecord-turntable version 1.x.([stable-1-x branch](https://github.com/drecom/activerecord-turntable/tree/stable-1-x))
 
 ## Supported Database
 
@@ -25,7 +25,7 @@ Currently supports mysql only.
 Add to Gemfile:
 
 ```ruby
-gem 'activerecord-turntable', '~> 3.0.0.alpha1'
+gem 'activerecord-turntable', '~> 3.0.0'
 ```
 
 Run a bundle install:
@@ -179,13 +179,13 @@ Those rake tasks would be executed to shards too.
 Add turntable [shard_key_name] to the model class:
 
 ```ruby
-class User < ActiveRecord::Base
+class User < ApplicationRecord
   turntable :user_cluster, :id
   sequencer :user_seq
   has_one :status
 end
 
-class Status < ActiveRecord::Base
+class Status < ApplicationRecord
   turntable :user_cluster, :user_id
   sequencer :user_seq
   belongs_to :user
@@ -297,7 +297,7 @@ create_sequence_for(:users) # <-- this line creates sequence table named `users_
 Next, add sequencer definition to the model:
 
 ```ruby
-  class User < ActiveRecord::Base
+  class User < ApplicationRecord
     turntable :id
     sequencer :user_seq # <-- this line enables sequencer module
     has_one :status
@@ -341,7 +341,7 @@ Then, add configuration to turntable.yml:
 Next, add sequencer definition to the model:
 
 ```ruby
-  class User < ActiveRecord::Base
+  class User < ApplicationRecord
     turntable :id
     sequencer :barrage_seq # <-- this line enables sequencer module
     has_one :status
@@ -369,7 +369,7 @@ end
 
 ### cluster_transaction
 
-transaction helper to execute transaction to all shards in the cluster:
+When executing transaction on all shards in the cluster, use `#{cluster_name}_transaction` method:
 
 ```ruby
 User.user_cluster_transaction do
@@ -404,8 +404,7 @@ to specify shard:
 ## Limitations
 
 * Queries includes "ORDER BY", "GROUP BY" and "LIMIT" clauses cannot be distributed.
-* "has many through" and "habtm" relationships may causes wrong results. ex) `User-Friend-User` relation
-
+* "has many through" and "habtm" relationships may returns unexpected results. ex) `User-Friend-User` relation
 
 ## TIPS
 
@@ -414,25 +413,80 @@ to specify shard:
 Use `with_shard` method:
 
 ```ruby
-    AR::Base.connection.with_shard(shard1) do
+    AR::Base.with_shard(shard1) do
       # something queries to shard1
     end
 ```
 
+`with_shard` method accepts following types to specify a shard:
+
+* ActiveRecord::Turntable::Shard object
+* AcitveRecord::Base object - `AR::Base#turntable_shard` will be used
+* Numeric, String - a shard key value
+* Symbol - shard name symbol
+
 To access shard objects, use below:
 
 * AR::Base.connection.shards # \\{shard_name => shard_obj,....}
 * AR::Base#turntable_shard # Returns current object's shard
-* AR::Base.connection.select_shard(shard_key_value) #=> shard
+* AR::Base.connection.shard_for(shard_key_value) #=> shard
 
 ### Send query to all shards
 
 Use with_all method:
 
 ```ruby
-  User.connection.with_all do
+  User.with_all do
     User.order("created_at DESC").limit(3).all
-  end
+  end # => Returns Array of results
+```
+
+### Cannot specify error is raised between associations
+
+Normally, activerecord-turntable detects shard keys on associated models, but auto-detection will fail with following conditions:
+
+* foreign key column != shard key column
+* Using different shard key names
+
+For example:
+
+```ruby
+class User
+  # shard key:
+  # foreign key: main_user_item_id
+  belongs_to :main_user_item, class_name: "UserItem", required: false
+end
+
+class UserItem
+  # shard key name: :user_id
+  turntable :user_cluster, :user_id
+end
+```
+
+This example raises CannotSpecifyShardError
+
+```ruby
+> user.main_user_item
+  User Load [Shard: master] (0.4ms)  SELECT  `users`.* FROM `users` ORDER BY `users`.`id` ASC LIMIT 1
+[ActiveRecord::Turntable] Error on Building Fader: SELECT  `user_items`.* FROM `user_items` WHERE `user_items`.`id` = 2198059200000 LIMIT 1, on_method: select_all, err: cannot specifyshard for query: SELECT "user_items".* FROM `user_items` WHERE (`user_items`.`id` = 2198059200000) LIMIT 1
+ActiveRecord::Turntable::CannotSpecifyShardError: cannot specify shard for query: SELECT "user_items".* FROM `user_items` WHERE (`user_items`.`id` = 2198059200000) LIMIT 1
+```
+
+Use foreign_shard_key option to pass a shard key condition:
+
+```
+-belongs_to :main_user_item, class_name: "UserItem"
++belongs_to :main_user_item, class_name: "UserItem", foreign_shard_key: :id
+```
+
+```ruby
+> user.main_user_item
+  User Load [Shard: master] (0.2ms)  SELECT  `users`.* FROM `users` ORDER BY `users`.`id` ASC LIMIT 1
+[ActiveRecord::Turntable] Sending method: select_all, sql: #<Arel::SelectManager:0x007f8080bd0670>, shards: ["user_shard_1"]
+Changing UserItem's shard to user_shard_1
+  UserItem Load [Shard: user_shard_1] (0.2ms)  SELECT  `user_items`.* FROM `user_items` WHERE `user_items`.`user_id` = 1 AND `user_items`.`id` = 2198059200000 LIMIT 1
+Changing UserItem's shard to master
+=> #<UserItem id: 2198059200000, user_id: 1, item_id: 1, created_at: "2017-05-23 04:41:13", updated_at: "2017-05-23 04:41:13">
 ```
 
 ### Performance Exception

data/Rakefile

@@ -62,6 +62,7 @@ namespace :turntable do
           t.belongs_to :user, :null => false
           t.integer    :hp,   :null => false, :default => 0
           t.integer    :mp,   :null => false, :default => 0
+          t.text       :data
           t.integer    :lock_version, :null => false, :default => 0
           t.datetime   :deleted_at, :default => nil
           t.timestamps
@@ -109,6 +110,7 @@ namespace :turntable do
           t.belongs_to :events_user, :null => false
           t.belongs_to :cards_user,    :null => false
           t.belongs_to :user, :null => false
+          t.string :type, :default => nil
           t.timestamps
         end
         ActiveRecord::Base.connection.create_sequence_for :events_users_histories
@@ -123,4 +125,44 @@ namespace :turntable do
     desc "reset turntable test databases"
     task :reset => ["turntable:db:drop", "turntable:db:create", "turntable:db:migrate"]
   end
+
+  namespace :activerecord do
+    task(:env) do
+      ENV["ARCONFIG"] ||= File.expand_path("spec/config/activerecord_config.yml", __dir__)
+      ENV["ARVERSION"] ||= if ActiveRecord.gem_version.prerelease?
+                             "origin/master"
+                           else
+                             "v#{ActiveRecord.gem_version}"
+                           end
+    end
+
+    namespace :setup do
+      task :rails => :env do
+        system(*%w|git submodule update --init|)
+        system(*%w|git submodule foreach git fetch origin|)
+        Dir.chdir("tmp/rails") do
+          system(*%W|git checkout #{ENV['ARVERSION']}|)
+        end
+        FileUtils.cp_r("tmp/rails/activerecord/test", ".")
+        FileUtils.cp_r("tmp/rails/activerecord/Rakefile", "activerecord.rake")
+        File.open("test/cases/helper.rb", "a") do |f|
+          f << "require '#{File.expand_path("spec/activerecord_helper", __dir__)}'"
+        end
+      end
+
+      task :db => :rails do
+        system(*%w|bundle exec rake -f activerecord.rake db:mysql:rebuild|)
+      end
+    end
+
+    desc "setup activerecord test"
+    task :setup => ["setup:rails", "setup:db"]
+
+    desc "run unit tests on activerecord"
+    task :test => :env do
+      unless system(*%w|bundle exec rake -f activerecord.rake test:mysql2|)
+        exit(1)
+      end
+    end
+  end
 end

data/activerecord-turntable.gemspec

@@ -1,6 +1,5 @@
 $LOAD_PATH.push File.expand_path("../lib", __FILE__)
 require "active_record/turntable/version"
-
 Gem::Specification.new do |spec|
   spec.name = "activerecord-turntable"
   spec.version = ActiveRecord::Turntable::VERSION
@@ -17,9 +16,10 @@ Gem::Specification.new do |spec|
     "CHANGELOG.md",
   ]
 
-  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+    f.match(%r{^(test|spec|features|tmp)/})
+  end
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
   spec.required_ruby_version = ">= 2.2.2"
 
@@ -42,12 +42,22 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pry"
   spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rack"
+  spec.add_development_dependency "rails"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.5.0"
   spec.add_development_dependency "rspec-collection_matchers"
   spec.add_development_dependency "rspec-its"
+  spec.add_development_dependency "rspec-parameterized"
+  spec.add_development_dependency "rspec-rails"
   spec.add_development_dependency "rubocop"
   spec.add_development_dependency "rubocop-rspec"
   spec.add_development_dependency "timecop"
   spec.add_development_dependency "webmock"
+
+  # activerecord testing dependencies
+  spec.add_development_dependency "actionview"
+  spec.add_development_dependency "bcrypt", "~> 3.1.11"
+  spec.add_development_dependency "minitest", "< 5.3.4"
+  spec.add_development_dependency "mocha", "~> 0.14"
+  spec.add_development_dependency "sqlite3", "~> 1.3.6"
 end

data/gemfiles/rails_edge.gemfile

@@ -0,0 +1,8 @@
+source "https://rubygems.org"
+
+gem "arel", github: "rails/arel"
+gem "activerecord", github: "rails/rails"
+gem "actionview", github: "rails/rails"
+gem "activesupport", github: "rails/rails"
+
+gemspec :path => '../'

data/lib/active_record/turntable/active_record_ext/abstract_adapter.rb

@@ -14,6 +14,7 @@ module ActiveRecord::Turntable
       end
 
       # @note override for append current shard name
+      # rubocop:disable Style/HashSyntax, Style/MultilineMethodCallBraceLayout
       def log(sql, name = "SQL", binds = [], statement_name = nil)
         @instrumenter.instrument(
           "sql.active_record",
@@ -26,6 +27,7 @@ module ActiveRecord::Turntable
       rescue => e
         raise translate_exception_class(e, sql)
       end
+      # rubocop:enable Style/HashSyntax, Style/MultilineMethodCallBraceLayout
 
       protected :translate_exception_class, :log
 
@@ -34,7 +36,7 @@ module ActiveRecord::Turntable
       end
 
       def turntable_shard_name
-        @turntable_shard_name
+        instance_variable_defined?(:@turntable_shard_name) ? @turntable_shard_name : nil
       end
     end
   end

data/lib/active_record/turntable/active_record_ext/activerecord_import_ext.rb

@@ -3,9 +3,11 @@ module ActiveRecord::Turntable
     # activerecord-import extension
     module ActiverecordImportExt
       # @note override for sequencer injection
-      # @see https://github.com/zdennis/activerecord-import/blob/ba909fed5a4785fe9c7cce89e48e1242bb6804ea/lib/activerecord-import/import.rb#L558-L581
+      # @see https://github.com/zdennis/activerecord-import/blob/b325ebb644160a09db6e269e414f33561cb21272/lib/activerecord-import/import.rb#L661-L689
       private def values_sql_for_columns_and_attributes(columns, array_of_attributes)
         connection_memo = connection
+        type_caster_memo = type_caster if respond_to?(:type_caster)
+
         array_of_attributes.map do |arr|
           my_values = arr.each_with_index.map do |val, j|
             column = columns[j]
@@ -18,11 +20,7 @@ module ActiveRecord::Turntable
                 connection_memo.next_value_for_sequence(sequence_name)
               end
             elsif column
-              if respond_to?(:type_caster) && type_caster.respond_to?(:type_cast_for_database) # Rails 5.0 and higher
-                connection_memo.quote(type_caster.type_cast_for_database(column.name, val))
-              else # Rails 4.2 and higher
-                connection_memo.quote(column.type_cast_from_user(val), column)
-              end
+              connection_memo.quote(type_caster_memo.type_cast_for_database(column.name, val))
             end
           end
           "(#{my_values.join(',')})"
@@ -34,7 +32,7 @@ module ActiveRecord::Turntable
       require "activerecord-import"
       require "activerecord-import/base"
       (class << ActiveRecord::Base; self; end).prepend(ActiverecordImportExt)
-    rescue LoadError
+    rescue LoadError # rubocop:disable Lint/HandleExceptions
     end
   end
 end

data/lib/active_record/turntable/active_record_ext/acts_as_archive_extension.rb

@@ -23,9 +23,9 @@ module ActiveRecord::Turntable
     end
 
     begin
-      require 'acts_as_archive'
+      require "acts_as_archive"
       ActsAsArchive.prepend ActsAsArchiveExt
-    rescue LoadError
+    rescue LoadError # rubocop:disable Lint/HandleExceptions
     end
   end
 end

data/lib/active_record/turntable/active_record_ext/association.rb

@@ -16,9 +16,9 @@ module ActiveRecord::Turntable
           return super unless should_use_shard_key?
 
           scope = klass.where(
-                    klass.turntable_shard_key =>
-                      owner.send(foreign_shard_key)
-                  )
+            klass.turntable_shard_key =>
+              owner.send(foreign_shard_key)
+          )
           super.merge!(scope)
         end
 

data/lib/active_record/turntable/active_record_ext/clever_load.rb

@@ -30,11 +30,11 @@ module ActiveRecord::Turntable
           self.each do |obj|
             matched_object = case reflection.macro
                              when :has_one
-                               foreign_objects.find {|fo|
+                               foreign_objects.find { |fo|
                                  obj.send(reflection.association_primary_key) == fo.send(reflection.foreign_key)
                                }
                              when :belongs_to
-                               foreign_objects.find {|fo|
+                               foreign_objects.find { |fo|
                                  obj.send(reflection.foreign_key) == fo.send(reflection.association_primary_key)
                                }
                              end