activerecord-turntable 3.0.0.alpha3 → 3.0.0

data/lib/active_record/turntable/active_record_ext/database_tasks.rb

@@ -18,7 +18,7 @@ module ActiveRecord
       end
 
       def create_current_turntable_cluster(environment = env)
-        each_current_turntable_cluster_configuration(true, environment) { |_name, configuration|
+        each_current_turntable_cluster_configuration(environment) { |_name, configuration|
           puts "[turntable] *** executing to database: #{configuration['database']}"
           create configuration
         }
@@ -26,26 +26,27 @@ module ActiveRecord
       end
 
       def drop_current_turntable_cluster(environment = env)
-        each_current_turntable_cluster_configuration(true, environment) { |_name, configuration|
+        each_current_turntable_cluster_configuration(environment) { |_name, configuration|
           puts "[turntable] *** executing to database: #{configuration['database']}"
           drop configuration
         }
       end
 
-      def each_current_turntable_cluster_connected(with_test = false, environment = env)
-        each_current_turntable_cluster_configuration(with_test, environment) do |name, configuration|
+      def each_current_turntable_cluster_connected(environment)
+        old_connection_pool = ActiveRecord::Base.connection_pool
+        each_current_turntable_cluster_configuration(environment) do |name, configuration|
           ActiveRecord::Base.clear_active_connections!
           ActiveRecord::Base.establish_connection(configuration)
           ActiveRecord::Migration.current_shard = name
           yield(name, configuration)
         end
         ActiveRecord::Base.clear_active_connections!
-        ActiveRecord::Base.establish_connection environment.to_sym
+        ActiveRecord::Base.establish_connection old_connection_pool.spec.config
       end
 
-      def each_current_turntable_cluster_configuration(with_test = false, environment = env)
+      def each_current_turntable_cluster_configuration(environment)
         environments = [environment]
-        environments << "test" if with_test && environment == "development"
+        environments << "test" if environment == "development"
 
         current_turntable_cluster_configurations(*environments).each do |name, configuration|
           yield(name, configuration) unless configuration["database"].blank?
@@ -70,8 +71,9 @@ module ActiveRecord
         configurations = []
         environments.each do |environ|
           config = ActiveRecord::Base.configurations[environ]
+          next unless config
           %w(shards seq).each do |name|
-            configurations += config[name].to_a
+            configurations += config[name].to_a if config.has_key?(name)
           end
         end
         configurations

data/lib/active_record/turntable/active_record_ext/fixtures.rb

@@ -7,6 +7,7 @@ module ActiveRecord
   class FixtureSet
     extend ActiveRecord::Turntable::Util
 
+    # rubocop:disable Style/MultilineMethodCallBraceLayout
     def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
       fixture_set_names = Array(fixture_set_names).map(&:to_s)
       class_names = ClassCache.new class_names, config
@@ -24,7 +25,7 @@ module ActiveRecord
 
           fixture_sets = files_to_read.map do |fs_name|
             klass = class_names[fs_name]
-            conn = klass.is_a?(String) ? connection : klass.connection
+            conn = klass ? klass.connection : connection
             fixtures_map[fs_name] = new( # ActiveRecord::FixtureSet.new
               conn,
               fs_name,
@@ -35,12 +36,16 @@ module ActiveRecord
           update_all_loaded_fixtures fixtures_map
 
           ActiveRecord::Base.force_transaction_all_shards!(requires_new: true) do
+            deleted_tables = Hash.new { |h, k| h[k] = Set.new }
             fixture_sets.each do |fs|
               conn = fs.model_class.respond_to?(:connection) ? fs.model_class.connection : connection
               table_rows = fs.table_rows
 
               table_rows.each_key do |table|
-                conn.delete "DELETE FROM #{conn.quote_table_name(table)}", "Fixture Delete"
+                unless deleted_tables[conn].include? table
+                  conn.delete "DELETE FROM #{conn.quote_table_name(table)}", "Fixture Delete"
+                end
+                deleted_tables[conn] << table
               end
 
               table_rows.each do |fixture_set_name, rows|
@@ -48,11 +53,9 @@ module ActiveRecord
                   conn.insert_fixture(row, fixture_set_name)
                 end
               end
-            end
 
-            # Cap primary key sequences to max(pk).
-            if connection.respond_to?(:reset_pk_sequence!)
-              fixture_sets.each do |fs|
+              # Cap primary key sequences to max(pk).
+              if connection.respond_to?(:reset_pk_sequence!)
                 connection.reset_pk_sequence!(fs.table_name)
               end
             end
@@ -63,16 +66,14 @@ module ActiveRecord
       end
       cached_fixtures(connection, fixture_set_names)
     end
+    # rubocop:enable Style/MultilineMethodCallLayout
   end
 
   module TestFixtures
-    include ActiveRecord::Turntable::Util
-
+    # rubocop:disable Style/ClassVars, Style/RedundantException
     def setup_fixtures(config = ActiveRecord::Base)
-      return if ActiveRecord::Base.configurations.blank?
-
       if pre_loaded_fixtures && !use_transactional_fixtures
-        raise "pre_loaded_fixtures requires use_transactional_fixtures"
+        raise RuntimeError, "pre_loaded_fixtures requires use_transactional_fixtures"
       end
 
       @fixture_cache = {}
@@ -94,14 +95,15 @@ module ActiveRecord
         end
       # Load fixtures for every test.
       else
-        ActiveRecord::Fixtures.reset_cache
+        ActiveRecord::FixtureSet.reset_cache
         @@already_loaded_fixtures[self.class] = nil
         @loaded_fixtures = load_fixtures(config)
       end
 
       # Instantiate fixtures for every test if requested.
-      instantiate_fixtures(config) if use_instantiated_fixtures
+      instantiate_fixtures if use_instantiated_fixtures
     end
+    # rubocop:enable Style/ClassVars, Style/RedundantException
 
     def enlist_fixture_connections
       ActiveRecord::Base.connection_handler.connection_pool_list.map(&:connection) +

data/lib/active_record/turntable/active_record_ext/log_subscriber.rb

@@ -6,6 +6,12 @@ module ActiveRecord::Turntable
       # @note prepend to add shard name logging
       def sql(event)
         payload = event.payload
+
+        if self.class::IGNORE_PAYLOAD_NAMES.include?(payload[:name])
+          self.class.runtime += event.duration
+          return
+        end
+
         if payload[:turntable_shard_name]
           payload[:name] = "#{payload[:name]} [Shard: #{payload[:turntable_shard_name]}]"
         end

data/lib/active_record/turntable/active_record_ext/persistence.rb

@@ -27,8 +27,9 @@ module ActiveRecord::Turntable
         end
 
         # @note Override to add sharding scope on `touch`
+        # rubocop:disable Style/UnlessElse
         def touch(*names, time: nil)
-          raise ActiveRecordError, "cannot touch on a new record object" unless persisted?
+          raise ActiveRecord::ActiveRecordError, "cannot touch on a new record object" unless persisted?
 
           time ||= current_time_from_proper_timezone
           attributes = timestamp_attributes_for_update_in_model
@@ -68,11 +69,12 @@ module ActiveRecord::Turntable
             true
           end
         end
+        # rubocop:enable Style/UnlessElse
 
         # @note Override to add sharding scope on `update_columns`
         def update_columns(attributes)
-          raise ActiveRecordError, "cannot update a new record" if new_record?
-          raise ActiveRecordError, "cannot update a destroyed record" if destroyed?
+          raise ActiveRecord::ActiveRecordError, "cannot update a new record" if new_record?
+          raise ActiveRecord::ActiveRecordError, "cannot update a destroyed record" if destroyed?
 
           attributes.each_key do |key|
             verify_readonly_attribute(key.to_s)
@@ -95,30 +97,30 @@ module ActiveRecord::Turntable
 
         private
 
-        # @note Override to add sharding scope on destroying
-        def relation_for_destroy
-          klass = self.class
-          relation = klass.unscoped.where(klass.primary_key => id)
+          # @note Override to add sharding scope on destroying
+          def relation_for_destroy
+            klass = self.class
+            relation = klass.unscoped.where(klass.primary_key => id)
 
-          if klass.turntable_enabled? && klass.primary_key != klass.turntable_shard_key.to_s
-            relation = relation.where(klass.turntable_shard_key => self[klass.turntable_shard_key])
+            if klass.turntable_enabled? && klass.primary_key != klass.turntable_shard_key.to_s
+              relation = relation.where(klass.turntable_shard_key => self[klass.turntable_shard_key])
+            end
+            relation
           end
-          relation
-        end
 
-        # @note Override to add sharding scope on updating
-        def _update_record(attribute_names = self.attribute_names)
-          klass = self.class
-          attributes_values = arel_attributes_with_values_for_update(attribute_names)
-          if attributes_values.empty?
-            0
-          else
-            scope = if klass.turntable_enabled? and klass.primary_key != klass.turntable_shard_key.to_s
-                      klass.unscoped.where(klass.turntable_shard_key => self.send(turntable_shard_key))
-                    end
-            klass.unscoped._update_record attributes_values, id, id_was, scope
+          # @note Override to add sharding scope on updating
+          def _update_record(attribute_names = self.attribute_names)
+            klass = self.class
+            attributes_values = arel_attributes_with_values_for_update(attribute_names)
+            if attributes_values.empty?
+              0
+            else
+              scope = if klass.turntable_enabled? && (klass.primary_key != klass.turntable_shard_key.to_s)
+                        klass.unscoped.where(klass.turntable_shard_key => self.send(turntable_shard_key))
+                      end
+              klass.unscoped._update_record attributes_values, id, id_was, scope
+            end
           end
-        end
       end
     end
   end

data/lib/active_record/turntable/active_record_ext/schema_dumper.rb

@@ -2,93 +2,26 @@
 module ActiveRecord::Turntable
   module ActiveRecordExt
     module SchemaDumper
+      SEQUENCE_TABLE_REGEXP = /\A(.*)_id_seq\z/
 
       private
 
         # @note Override to dump database sequencer method
         def table(table, stream)
-          columns = @connection.columns(table)
+          unless matchdata = table.match(SEQUENCE_TABLE_REGEXP)
+            return super
+          end
+
           begin
             tbl = StringIO.new
 
-            # first dump primary key column
-            if @connection.respond_to?(:primary_keys)
-              pk = @connection.primary_keys(table)
-              pk = pk.first unless pk.size > 1
-            else
-              pk = @connection.primary_key(table)
-            end
-
-            if table =~ /\A(.*)_id_seq\z/
-              tbl.print "  create_sequence_for #{remove_prefix_and_suffix(Regexp.last_match(1)).inspect}"
-            else
-              tbl.print "  create_table #{remove_prefix_and_suffix(table).inspect}"
-            end
-
-            case pk
-            when String
-              tbl.print ", primary_key: #{pk.inspect}" unless pk == 'id'
-              pkcol = columns.detect { |c| c.name == pk }
-              pkcolspec = @connection.column_spec_for_primary_key(pkcol)
-              if pkcolspec.present?
-                pkcolspec.each do |key, value|
-                  tbl.print ", #{key}: #{value}"
-                end
-              end
-            when Array
-              tbl.print ", primary_key: #{pk.inspect}"
-            else
-              tbl.print ", id: false"
-            end
+            tbl.print "  create_sequence_for #{remove_prefix_and_suffix(matchdata[1]).inspect}"
             tbl.print ", force: :cascade"
 
             table_options = @connection.table_options(table)
-            tbl.print ", options: #{table_options.inspect}" unless table_options.blank?
-
-            if comment = @connection.table_comment(table).presence
-              tbl.print ", comment: #{comment.inspect}"
-            end
-
-            tbl.puts " do |t|"
-
-            # then dump all non-primary key columns
-            column_specs = columns.map do |column|
-              raise StandardError, "Unknown type '#{column.sql_type}' for column '#{column.name}'" unless @connection.valid_type?(column.type)
-              next if column.name == pk
-              @connection.column_spec(column)
-            end.compact
-
-            # find all migration keys used in this table
-            keys = @connection.migration_keys
-
-            # figure out the lengths for each column based on above keys
-            lengths = keys.map { |key|
-              column_specs.map { |spec|
-                spec[key] ? spec[key].length + 2 : 0
-              }.max
-            }
-
-            # the string we're going to sprintf our values against, with standardized column widths
-            format_string = lengths.map{ |len| "%-#{len}s" }
-
-            # find the max length for the 'type' column, which is special
-            type_length = column_specs.map{ |column| column[:type].length }.max
-
-            # add column type definition to our format string
-            format_string.unshift "    t.%-#{type_length}s "
-
-            format_string *= ''
-
-            column_specs.each do |colspec|
-              values = keys.zip(lengths).map{ |key, len| colspec.key?(key) ? colspec[key] + ", " : " " * len }
-              values.unshift colspec[:type]
-              tbl.print((format_string % values).gsub(/,\s*$/, ''))
-              tbl.puts
+            if table_options.present?
+              tbl.print ", #{format_options(table_options)}"
             end
-
-            indexes_in_create(table, tbl)
-
-            tbl.puts "  end"
             tbl.puts
 
             tbl.rewind

data/lib/active_record/turntable/algorithm/range_algorithm.rb

@@ -18,17 +18,16 @@ module ActiveRecord::Turntable::Algorithm
 
     # { connection_name => weight, ... }
     def calculate_used_shards_with_weight(sequence_value)
-      idx = calculate_idx(sequence_value)
-      last_connection = calculate(sequence_value)
-      shards = @config[:shards][0..idx]
+      current_shard_idx = calculate_idx(sequence_value)
+      shards = @config[:shards][0..current_shard_idx]
       weighted_hash = Hash.new { |h, k| h[k] = 0 }
       prev_max = 0
       shards.each_with_index do |h, idx|
         weighted_hash[h[:connection]] += if idx < shards.size - 1
-                                            h[:less_than] - prev_max - 1
-                                          else
-                                            sequence_value - prev_max
-                                          end
+                                           h[:less_than] - prev_max - 1
+                                         else
+                                           sequence_value - prev_max
+                                         end
         prev_max = h[:less_than] - 1
       end
       weighted_hash

data/lib/active_record/turntable/algorithm/range_bsearch_algorithm.rb

@@ -22,17 +22,16 @@ module ActiveRecord::Turntable::Algorithm
 
     # { connection_name => weight, ... }
     def calculate_used_shards_with_weight(sequence_value)
-      idx = calculate_idx(sequence_value)
-      last_connection = calculate(sequence_value)
-      shards = @config[:shards][0..idx]
+      current_shard_idx = calculate_idx(sequence_value)
+      shards = @config[:shards][0..current_shard_idx]
       weighted_hash = Hash.new { |h, k| h[k] = 0 }
       prev_max = 0
       shards.each_with_index do |h, idx|
         weighted_hash[h[:connection]] += if idx < shards.size - 1
-                                            h[:less_than] - prev_max - 1
-                                          else
-                                            sequence_value - prev_max
-                                          end
+                                           h[:less_than] - prev_max - 1
+                                         else
+                                           sequence_value - prev_max
+                                         end
         prev_max = h[:less_than] - 1
       end
       weighted_hash

data/lib/active_record/turntable/base.rb

@@ -22,21 +22,6 @@ module ActiveRecord::Turntable
       include ClusterHelperMethods
     end
 
-    module ConnectionExtension
-      module ClassMethods
-        def connection_specification_name
-          return super unless turntable_enabled?
-          self.connection_specification_name = "turntable_pool_proxy::#{name}"
-        end
-      end
-
-      def self.prepended(base)
-        class << base
-          prepend ClassMethods
-        end
-      end
-    end
-
     module ClassMethods
       # @param [Symbol] cluster_name cluster name for this class
       # @param [Symbol] shard_key_name shard key attribute name
@@ -52,8 +37,7 @@ module ActiveRecord::Turntable
           self.turntable_clusters[cluster_name] ||= Cluster.new(
             turntable_config[:clusters][cluster_name],
             options
-        )
-        prepend ConnectionExtension
+          )
         turntable_replace_connection_pool
       end
 
@@ -62,6 +46,7 @@ module ActiveRecord::Turntable
         cp = ConnectionProxy.new(self, turntable_cluster)
         pp = PoolProxy.new(cp)
 
+        self.connection_specification_name = "turntable_pool_proxy::#{name}"
         ch.send(:owner_to_pool)[connection_specification_name] = pp
       end
 

data/lib/active_record/turntable/cluster_helper_methods.rb

@@ -30,7 +30,9 @@ module ActiveRecord::Turntable
       end
 
       def force_connect_all_shards!
-        conf = configurations[Rails.env]
+        conf = configurations[::ActiveRecord::ConnectionHandling::DEFAULT_ENV.call.to_sym]
+        return unless conf
+
         shards = HashWithIndifferentAccess.new
         shards = shards.merge(conf[:shards]) if conf[:shards]
         shards = shards.merge(conf[:seq]) if conf[:seq]
@@ -44,20 +46,21 @@ module ActiveRecord::Turntable
         shards_weight = self.turntable_cluster.weighted_shards(self.current_sequence)
         sum = shards_weight.values.inject(&:+)
         idx = rand(sum)
-        shard, weight = shards_weight.find {|_k, v|
+        shard, _weight = shards_weight.find { |_k, v|
           (idx -= v) < 0
         }
+        shard ||= shards_weight.keys.first
         self.connection.with_recursive_shards(shard.name, *klasses, &block)
       end
 
       def all_cluster_transaction(options = {})
         clusters = turntable_clusters.values
-        recursive_cluster_transaction(clusters) { yield }
+        recursive_cluster_transaction(clusters, options) { yield }
       end
 
       def recursive_cluster_transaction(clusters, options = {}, &block)
         current_cluster = clusters.shift
-        current_cluster.shards_transaction do
+        current_cluster.shards_transaction([], options) do
           if clusters.present?
             recursive_cluster_transaction(clusters, options, &block)
           else

data/lib/active_record/turntable/connection_proxy.rb

@@ -53,6 +53,7 @@ module ActiveRecord::Turntable
       end
     end
 
+    # rubocop:disable Style/MethodMissing
     def method_missing(method, *args, &block)
       clear_query_cache_if_needed(method)
       if shard_fixed?
@@ -69,6 +70,7 @@ module ActiveRecord::Turntable
         connection.send(method, *args, &block)
       end
     end
+    # rubocop:enable Style/MethodMissing
 
     def respond_to_missing?(method, include_private = false)
       connection.send(:respond_to?, method, include_private)
@@ -198,7 +200,7 @@ module ActiveRecord::Turntable
     end
 
     delegate :connected?, :automatic_reconnect, :automatic_reconnect=, :checkout_timeout, :dead_connection_timeout,
-             :spec, :connections, :size, :reaper, :table_exists?, to: :connection_pool
+             :spec, :connections, :size, :reaper, to: :connection_pool
 
     %w(columns columns_hash column_defaults primary_keys).each do |name|
       define_method(name.to_sym) do
@@ -206,7 +208,7 @@ module ActiveRecord::Turntable
       end
     end
 
-    %w(table_exists?).each do |name|
+    %w(data_source_exists?).each do |name|
       define_method(name.to_sym) do |*args|
         master.connection_pool.with_connection do |c|
           c.schema_cache.send(name.to_sym, *args)

data/lib/active_record/turntable/migration.rb

@@ -52,7 +52,6 @@ module ActiveRecord::Turntable::Migration
       options = options.merge(id: false)
 
       # TODO: pkname should be pulled from table definitions
-      pkname = "id"
       sequence_table_name = ActiveRecord::Turntable::Sequencer.sequence_name(table_name, "id")
       create_table(sequence_table_name, options) do |t|
         t.integer :id, limit: 8
@@ -62,7 +61,6 @@ module ActiveRecord::Turntable::Migration
 
     def drop_sequence_for(table_name, options = {})
       # TODO: pkname should be pulled from table definitions
-      pkname = "id"
       sequence_table_name = ActiveRecord::Turntable::Sequencer.sequence_name(table_name, "id")
       drop_table(sequence_table_name)
     end
@@ -108,7 +106,7 @@ module ActiveRecord::Turntable::Migration
       def up(migrations_paths, target_version = nil)
         super
 
-        ActiveRecord::Tasks::DatabaseTasks.each_current_turntable_cluster_connected do |name, configuration|
+        ActiveRecord::Tasks::DatabaseTasks.each_current_turntable_cluster_connected(current_environment) do |name, configuration|
           puts "[turntable] *** Migrating database: #{configuration['database']}(Shard: #{name})"
           super(migrations_paths, target_version)
         end
@@ -117,7 +115,7 @@ module ActiveRecord::Turntable::Migration
       def down(migrations_paths, target_version = nil, &block)
         super
 
-        ActiveRecord::Tasks::DatabaseTasks.each_current_turntable_cluster_connected do |name, configuration|
+        ActiveRecord::Tasks::DatabaseTasks.each_current_turntable_cluster_connected(current_environment) do |name, configuration|
           puts "[turntable] *** Migrating database: #{configuration['database']}(Shard: #{name})"
           super(migrations_paths, target_version, &block)
         end
@@ -126,7 +124,7 @@ module ActiveRecord::Turntable::Migration
       def run(*args)
         super
 
-        ActiveRecord::Tasks::DatabaseTasks.each_current_turntable_cluster_connected do |name, configuration|
+        ActiveRecord::Tasks::DatabaseTasks.each_current_turntable_cluster_connected(current_environment) do |name, configuration|
           puts "[turntable] *** Migrating database: #{configuration['database']}(Shard: #{name})"
           super(*args)
         end

data/lib/active_record/turntable/mixer.rb

@@ -1,3 +1,4 @@
+# rubocop:disable Style/CaseEquality
 require "active_support/core_ext/object/try"
 require "active_record/turntable/sql_tree_patch"
 
@@ -11,7 +12,7 @@ module ActiveRecord::Turntable
 
     delegate :logger, to: ActiveRecord::Base
 
-    NOT_USED_FOR_SHARDING_OPERATORS_REGEXP = /\A(NOT IN|IS|IS NOT|BETWEEN|LIKE|\!\=|<<|>>|<>|>\=|<=|[\*\+\-\/\%\|\&><])\z/
+    NOT_USED_FOR_SHARDING_OPERATORS_REGEXP = /\A(NOT IN|IS|IS NOT|BETWEEN|LIKE|!=|<<|>>|<>|>=|<=|[*+%|&><-])\z/
 
     def initialize(proxy)
       @proxy = proxy
@@ -60,7 +61,7 @@ module ActiveRecord::Turntable
         lkeys = find_shard_keys(tree.lhs, table_name, shard_key)
         rkeys = find_shard_keys(tree.rhs, table_name, shard_key)
         if lkeys.present? && rkeys.present?
-          lkeys + rkeys
+          (lkeys + rkeys).uniq
         else
           []
         end
@@ -68,22 +69,22 @@ module ActiveRecord::Turntable
         lkeys = find_shard_keys(tree.lhs, table_name, shard_key)
         rkeys = find_shard_keys(tree.rhs, table_name, shard_key)
         if lkeys.present? || rkeys.present?
-          lkeys + rkeys
+          (lkeys + rkeys).uniq
         else
           []
         end
       when "IN", "=", "=="
         field = tree.lhs.respond_to?(:table) ? tree.lhs : nil
         if tree.rhs.is_a?(SQLTree::Node::SubQuery)
-          if field.try(:table) == table_name and field.name == shard_key
+          if (field.try(:table) == table_name) && (field.name == shard_key)
             find_shard_keys(tree.rhs.where, table_name, shard_key)
           else
             []
           end
         else
           values = Array(tree.rhs)
-          if field.try(:table) == table_name and field.name == shard_key and
-              !tree.rhs.is_a?(SQLTree::Node::SubQuery)
+          if (field.try(:table) == table_name) && (field.name == shard_key) &&
+             !tree.rhs.is_a?(SQLTree::Node::SubQuery)
             values.map(&:value).compact
           else
             []
@@ -113,14 +114,15 @@ module ActiveRecord::Turntable
       end
 
       def bind_sql(sql, binds)
+        binds = binds ? binds.dup : []
         # TODO: substitution value should be determined by adapter
-        query = sql.is_a?(String) ? sql : @proxy.to_sql(sql, binds ? binds.dup : [])
-        query = if query.include?("\0") && binds.is_a?(Array) && binds[0].is_a?(Array) && binds[0][0].is_a?(ActiveRecord::ConnectionAdapters::Column)
-                  binds = binds.dup
-                  query.gsub("\0") { @proxy.master.connection.quote(*binds.shift.reverse) }
-                else
-                  query
-                end
+        query = sql.is_a?(String) ? sql : @proxy.to_sql(sql, binds)
+        if query.include?("\0") && binds.is_a?(Array) && binds[0].is_a?(Array) && binds[0][0].is_a?(ActiveRecord::ConnectionAdapters::Column)
+          binds = binds.dup
+          query.gsub("\0") { @proxy.master.connection.quote(*binds.shift.reverse) }
+        else
+          query
+        end
       end
 
       def build_select_fader(tree, method, query, *args, &block)
@@ -133,6 +135,7 @@ module ActiveRecord::Turntable
                                        @proxy.klass.table_name,
                                        @proxy.klass.turntable_shard_key.to_s)
                      end
+        shard_keys.uniq!
 
         if shard_keys.size == 1 # shard
           return Fader::SpecifiedShard.new(@proxy,
@@ -142,8 +145,7 @@ module ActiveRecord::Turntable
               tree.select.first.to_sql == '1 AS "one"' # for `SELECT 1 AS one` (AR::Base.exists?)
           return Fader::SelectShardsMergeResult.new(@proxy,
                                                     build_shards_with_same_query(@proxy.shards.values, query),
-                                                    method, query, *args, &block
-                                                   )
+                                                    method, query, *args, &block)
         elsif tree.group_by || tree.order_by || tree.limit.try(:value).to_i > 0
           raise CannotSpecifyShardError, "cannot specify shard for query: #{tree.to_sql}"
         elsif shard_keys.present?
@@ -155,8 +157,7 @@ module ActiveRecord::Turntable
           else
             return Fader::SelectShardsMergeResult.new(@proxy,
                                                       Hash[shard_keys.map { |k| [@proxy.cluster.shard_for(k), query] }],
-                                                      method, query, *args, &block
-                                                     )
+                                                      method, query, *args, &block)
           end
         else # scan all shards
           if SQLTree::Node::SelectDeclaration === tree.select.first &&
@@ -177,8 +178,7 @@ module ActiveRecord::Turntable
             end
             return Fader::SelectShardsMergeResult.new(@proxy,
                                                       build_shards_with_same_query(@proxy.shards.values, query),
-                                                      method, query, *args, &block
-                                                     )
+                                                      method, query, *args, &block)
           else
             raise CannotSpecifyShardError, "cannot specify shard for query: #{tree.to_sql}"
           end
@@ -231,3 +231,4 @@ module ActiveRecord::Turntable
       end
   end
 end
+# rubocop:enable Style/CaseEquality