activerecord-turntable 1.1.2 → 2.0.0.rc1

data/spec/active_record/turntable/connection_proxy_spec.rb

@@ -7,59 +7,46 @@ describe ActiveRecord::Turntable::ConnectionProxy do
 
   context "When initialized" do
     before do
-      establish_connection_to("test")
+      establish_connection_to(:test)
       truncate_shard
     end
+
     let(:cluster) { ActiveRecord::Turntable::Cluster.new(User, ActiveRecord::Base.turntable_config[:clusters][:user_cluster]) }
     subject { ActiveRecord::Turntable::ConnectionProxy.new(cluster) }
-    its(:master_connection) { should == ActiveRecord::Base.connection }
-  end
 
-  context "AR3.1" do
-    it "should proxies columns" do
-      pending "spec not implemented yet"
-    end
-
-    it "should proxies columns_hash" do
-      pending "spec not implemented yet"
-    end
+    its(:master_connection) { is_expected.to eql(ActiveRecord::Base.connection) }
   end
 
   context "User insert with id" do
     before do
-      establish_connection_to("test")
+      establish_connection_to(:test)
       truncate_shard
-      ActiveRecord::Base.logger = Logger.new(STDOUT)
     end
 
     it "should be saved to user_shard_1 with id = 1" do
       user = User.new
       user.id = 1
-      # mock(User.turntable_cluster).select_shard(1) { User.turntable_cluster.shards[:user_shard_1] }
-      lambda {
+      expect {
         user.save!
-      }.should_not raise_error
+      }.not_to raise_error
     end
 
     it "should be saved to user_shard_2 with id = 30000" do
       user = User.new
       user.id = 30000
-      # mock(User.turntable_cluster).select_shard(30000) { User.turntable_cluster.shards[:user_shard_2] }
-      lambda {
+      expect {
         user.save!
-      }.should_not raise_error
+      }.not_to raise_error
     end
 
     it "should be saved to user_shard_2 with id = 30000 with SQL injection attack" do
       user = User.new
       user.id = 30000
       user.nickname = "hogehgoge'00"
-      # mock(User.turntable_cluster).select_shard(30000) { User.turntable_cluster.shards[:user_shard_2] }
-      lambda {
+      expect {
         user.save!
-      }.should_not raise_error
+      }.not_to raise_error
       user.reload
-
     end
 
     it "should should be saved the same string when includes escaped string" do
@@ -68,13 +55,28 @@ describe ActiveRecord::Turntable::ConnectionProxy do
       user.nickname = "hoge@\n@\\@@\\nhoge\\\nhoge\\n"
       user.save!
       user.reload
-      user.nickname.should == "hoge@\n@\\@@\\nhoge\\\nhoge\\n"
+      expect(user.nickname).to eq("hoge@\n@\\@@\\nhoge\\\nhoge\\n")
+    end
+  end
+
+  context "When have no users" do
+    before do
+      establish_connection_to(:test)
+      truncate_shard
+    end
+
+    it "User.#count should be zero" do
+      expect(User.count).to be_zero
+    end
+
+    it "User.all should have no item" do
+      expect(User.all.to_a).to have(0).items
     end
   end
 
   context "When have 2 Users in different shards" do
     before do
-      establish_connection_to("test")
+      establish_connection_to(:test)
       truncate_shard
       @user1 = User.new
       @user1.id = 1
@@ -86,35 +88,35 @@ describe ActiveRecord::Turntable::ConnectionProxy do
 
     it "should be saved to user_shard_1 with id = 1" do
       @user1.nickname = "foobar"
-      lambda {
+      expect {
         @user1.save!
-      }.should_not raise_error
+      }.not_to raise_error
 
     end
 
     it "should be saved to user_shard_2 with id = 30000" do
       @user2.nickname = "hogehoge"
-      lambda {
+      expect {
         @user2.save!
-      }.should_not raise_error
+      }.not_to raise_error
     end
 
     it "User.where('id IN (1, 30000)') returns 2 record" do
-      User.where(:id => [1, 30000]).all.size.should == 2
+      expect(User.where(:id => [1, 30000]).all.size).to eq(2)
     end
 
     it "count should be 2" do
-      User.count.should == 2
+      expect(User.count).to eq(2)
     end
 
     it "User.all returns 2 User object" do
-      User.all.size.should == 2
+      expect(User.all.size).to eq(2)
     end
   end
 
   context "When calling with_all" do
     before do
-      establish_connection_to("test")
+      establish_connection_to(:test)
       truncate_shard
       @user1 = User.new
       @user1.id = 1
@@ -132,12 +134,12 @@ describe ActiveRecord::Turntable::ConnectionProxy do
           User.count
         end
       }
-      it { should have(3).items }
+      it { is_expected.to have(3).items }
 
       it "returns User.count of each shards" do
-        subject[0].should == 1
-        subject[1].should == 1
-        subject[2].should == 0
+        expect(subject[0]).to eq(1)
+        expect(subject[1]).to eq(1)
+        expect(subject[2]).to eq(0)
       end
     end
 
@@ -148,11 +150,11 @@ describe ActiveRecord::Turntable::ConnectionProxy do
             raise "Unko Error"
           end
         }
-        it { lambda { subject }.should_not raise_error }
-        it { should have(3).items }
+        it { expect { subject }.not_to raise_error }
+        it { is_expected.to have(3).items }
         it "collection " do
           subject.each do |s|
-            s.should be_instance_of(RuntimeError)
+            expect(s).to be_instance_of(RuntimeError)
           end
         end
       end
@@ -160,27 +162,92 @@ describe ActiveRecord::Turntable::ConnectionProxy do
   end
 
   context "When calling exists? with shard_key" do
+    before do
+      establish_connection_to(:test)
+      truncate_shard
+      @user1 = User.new
+      @user1.id = 1
+      @user1.nickname = 'user1'
+      @user1.save!
+      @user2 = User.new
+      @user2.id = 30000
+      @user2.nickname = 'user2'
+      @user2.save!
+    end
+
     subject { User.exists?(id: 1) }
-    it { should be_true }
+    it { is_expected.to be_truthy }
   end
 
   context "When calling exists? with non-existed shard_key" do
+    before do
+      establish_connection_to(:test)
+      truncate_shard
+      @user1 = User.new
+      @user1.id = 1
+      @user1.nickname = 'user1'
+      @user1.save!
+      @user2 = User.new
+      @user2.id = 30000
+      @user2.nickname = 'user2'
+      @user2.save!
+    end
+
     subject { User.exists?(id: 3) }
-    it { should be_false }
+    it { is_expected.to be_falsey }
   end
 
   context "When calling exists? with non shard_key" do
+    before do
+      establish_connection_to(:test)
+      truncate_shard
+      @user1 = User.new
+      @user1.id = 1
+      @user1.nickname = 'user1'
+      @user1.save!
+      @user2 = User.new
+      @user2.id = 30000
+      @user2.nickname = 'user2'
+      @user2.save!
+    end
+
     subject { User.exists?(nickname: 'user2') }
-    it { should be_true }
+    it { is_expected.to be_truthy }
   end
 
   context "When calling exists? with non-existed non shard_key" do
+    before do
+      establish_connection_to(:test)
+      truncate_shard
+      @user1 = User.new
+      @user1.id = 1
+      @user1.nickname = 'user1'
+      @user1.save!
+      @user2 = User.new
+      @user2.id = 30000
+      @user2.nickname = 'user2'
+      @user2.save!
+    end
+
     subject { User.exists?(nickname: 'user999') }
-    it { should be_false }
+    it { is_expected.to be_falsey }
   end
 
   context "#table_exists?" do
+    before do
+      establish_connection_to(:test)
+      truncate_shard
+      @user1 = User.new
+      @user1.id = 1
+      @user1.nickname = 'user1'
+      @user1.save!
+      @user2 = User.new
+      @user2.id = 30000
+      @user2.nickname = 'user2'
+      @user2.save!
+    end
+
     subject { User.connection.table_exists?(:users) }
-    it { should be_true }
+    it { is_expected.to be_truthy }
   end
 end

data/spec/active_record/turntable/finder_spec.rb

@@ -7,21 +7,34 @@ describe "ActiveRecord::FinderMethods" do
 
   context "User insert with id" do
     before do
-      establish_connection_to("test")
+      establish_connection_to(:test)
       truncate_shard
-      ActiveRecord::Base.logger = Logger.new(STDOUT)
-      @user = User.new
-      @user.id = 1
-      @user.save
+      user
     end
 
-    it "#find(1) should be == user" do
-      User.find(1).should == @user
-    end
+    let(:user) {
+      u = User.new
+      u.id = 1
+      u.save
+      u
+    }
+
+    describe "User#find" do
+      context "With existing users.id" do
+        subject { User.find(1) }
+
+        it "#find should be returns user" do
+          is_expected.to eq(user)
+        end
+      end
 
-    it "#find(2) should raise error" do
-      lambda { User.find(2) }.should raise_error
+      context "With users.id not existing" do
+        subject { User.find(2) }
+
+        it "#find should raise error" do
+          expect { subject }.to raise_error
+        end
+      end
     end
   end
 end
-

data/spec/active_record/turntable/mixer_spec.rb

@@ -6,7 +6,7 @@ describe ActiveRecord::Turntable::Mixer do
   end
 
   before do
-    establish_connection_to("test")
+    establish_connection_to(:test)
     truncate_shard
     @cluster = ActiveRecord::Turntable::Cluster.new(User, ActiveRecord::Base.turntable_config[:clusters][:user_cluster])
     @connection_proxy = ActiveRecord::Turntable::ConnectionProxy.new(@cluster)
@@ -24,9 +24,9 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.send(:divide_insert_values, tree, "id")
         }
 
-        it { should be_instance_of(Hash) }
-        it { should have_key(1) }
-        it { [1].should have(1).item }
+        it { is_expected.to be_instance_of(Hash) }
+        it { is_expected.to have_key(1) }
+        it { expect([1]).to have(1).item }
       end
 
       context "When call divide_insert_values with Bulk INSERT and shard_key 'id'" do
@@ -35,11 +35,11 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.send(:divide_insert_values, tree, "id")
         }
 
-        it { should be_instance_of(Hash) }
-        it { should have_key(3) }
-        it { [1].should have(1).item }
-        it { [2].should have(1).item }
-        it { [3].should have(1).item }
+        it { is_expected.to be_instance_of(Hash) }
+        it { is_expected.to have_key(3) }
+        it { expect([1]).to have(1).item }
+        it { expect([2]).to have(1).item }
+        it { expect([3]).to have(1).item }
       end
     end
 
@@ -50,8 +50,8 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.find_shard_keys(tree.where, "users", "id")
         }
 
-        it { should be_instance_of Array }
-        it { should == [1] }
+        it { is_expected.to be_instance_of Array }
+        it { is_expected.to eq([1]) }
       end
     end
 
@@ -62,8 +62,8 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.find_shard_keys(tree.where, "users", "id")
         }
 
-        it { should be_instance_of Array }
-        it { should == [1] }
+        it { is_expected.to be_instance_of Array }
+        it { is_expected.to eq([1]) }
       end
     end
 
@@ -74,8 +74,8 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.find_shard_keys(tree.where, "users", "id")
         }
 
-        it { should be_instance_of Array }
-        it { should == [1] }
+        it { is_expected.to be_instance_of Array }
+        it { is_expected.to eq([1]) }
       end
 
       context "When call find_shard_keys with shardkey collection condition" do
@@ -84,8 +84,8 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.find_shard_keys(tree.where, "users", "id")
         }
 
-        it { should be_instance_of Array }
-        it { should == [1,2,3,4,5] }
+        it { is_expected.to be_instance_of Array }
+        it { is_expected.to eq([1,2,3,4,5]) }
       end
 
       context "When call find_shard_keys with not determine shardkey condition" do
@@ -94,8 +94,8 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.find_shard_keys(tree.where, "users", "id")
         }
 
-        it { should be_instance_of Array }
-        it { should == [] }
+        it { is_expected.to be_instance_of Array }
+        it { is_expected.to eq([]) }
       end
 
       context "When call find_shard_keys with except table definition SQL" do
@@ -104,8 +104,8 @@ describe ActiveRecord::Turntable::Mixer do
           @mixer.find_shard_keys(tree.where, "users", "id")
         }
 
-        it { should be_instance_of Array }
-        it { should == [] }
+        it { is_expected.to be_instance_of Array }
+        it { is_expected.to eq([]) }
       end
     end
 

data/spec/active_record/turntable/rack/query_cache_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe ActiveRecord::Turntable::Rack::QueryCache do
+  before(:all) do
+    reload_turntable!(File.join(File.dirname(__FILE__), "../../../config/turntable.yml"))
+  end
+
+  before do
+    establish_connection_to(:test)
+    truncate_shard
+  end
+
+  let(:mw) { ActiveRecord::Turntable::Rack::QueryCache.new lambda {|env| [200, {}]} }
+  subject { mw.call({}) }
+
+  it "should returns 200 response" do
+    expect(subject.first).to eq(200)
+  end
+end

data/spec/active_record/turntable/sequencer/api_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe ActiveRecord::Turntable::Sequencer::Api do
+  before(:all) do
+    reload_turntable!(File.join(File.dirname(__FILE__), "../../../config/turntable.yml"))
+  end
+
+  let(:sequencer) { ActiveRecord::Turntable::Sequencer::Api.new(klass, options) }
+  let(:sequence_name) { "hogefuga" }
+  let(:klass) { Class.new }
+  let(:api_host) { "example.example" }
+  let(:api_port) { 80 }
+  let(:options) { { "api_host" => api_host, "api_port" => api_port } }
+  let(:api_response) { 1024 }
+
+  let(:next_sequence_uri) { "http://#{api_host}/sequences/#{sequence_name}/new" }
+  let(:current_sequence_uri) { "http://#{api_host}/sequences/#{sequence_name}" }
+
+  describe "#next_sequence_value" do
+    before do
+      stub_request(:get, next_sequence_uri).to_return(:body => api_response.to_s)
+    end
+
+    subject { sequencer.next_sequence_value(sequence_name) }
+    it { is_expected.to be_kind_of(Integer) }
+    it { is_expected.to eq api_response }
+  end
+
+  describe "#current_sequence_value" do
+    before do
+      stub_request(:get, current_sequence_uri).to_return(:body => api_response.to_s)
+    end
+
+    subject { sequencer.current_sequence_value(sequence_name) }
+    it { is_expected.to be_kind_of(Integer) }
+    it { is_expected.to eq api_response }
+  end
+end

data/spec/active_record/turntable/sequencer/barrage_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe ActiveRecord::Turntable::Sequencer::Barrage do
+  before(:all) do
+    reload_turntable!(File.join(File.dirname(__FILE__), "../../../config/turntable.yml"))
+  end
+
+  let(:sequencer) { ActiveRecord::Turntable::Sequencer::Barrage.new(klass, options) }
+  let(:sequence_name) { "hogefuga" }
+  let(:options) { { "options" => { "generators" => [ {"name" => "sequence", "length" => 16} ] } } }
+  let(:klass) { Class.new }
+
+  describe "#next_sequence_value" do
+    subject { sequencer.next_sequence_value("hogefuga") }
+    it { is_expected.to be_kind_of(Integer) }
+  end
+
+  describe "#current_sequence_value" do
+    subject { sequencer.current_sequence_value("hogefuga") }
+    it { is_expected.to be_kind_of(Integer) }
+  end
+end

data/spec/active_record/turntable/sequencer/mysql_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe ActiveRecord::Turntable::Sequencer::Mysql do
+  before(:all) do
+    reload_turntable!(File.join(File.dirname(__FILE__), "../../../config/turntable.yml"))
+  end
+
+  let(:sequencer) { ActiveRecord::Turntable::Sequencer::Mysql.new(klass, options) }
+  let(:sequence_name) { "users_id_seq" }
+  let(:options) { {} }
+  let(:klass) { User }
+
+  describe "#next_sequence_value" do
+    subject { sequencer.next_sequence_value(sequence_name) }
+    it { is_expected.to be_kind_of(Integer) }
+  end
+
+  describe "#current_sequence_value" do
+    subject { sequencer.current_sequence_value(sequence_name) }
+    it { is_expected.to be_kind_of(Integer) }
+  end
+end

data/spec/active_record/turntable/shard_spec.rb

@@ -7,7 +7,7 @@ describe ActiveRecord::Turntable::Shard do
 
   context "When initialized" do
     before do
-      establish_connection_to("test")
+      establish_connection_to(:test)
       truncate_shard
     end
 

data/spec/active_record/turntable/transaction_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe "transaction" do
+  before(:all) do
+    reload_turntable!(File.join(File.dirname(__FILE__), "../../config/turntable.yml"))
+  end
+
+  before(:each) do
+    establish_connection_to(:test)
+    truncate_shard
+  end
+  let(:clusters) { ActiveRecord::Base.turntable_clusters }
+
+  describe "all_cluster_transaction" do
+    let(:all_clusters) { clusters.values.map { |v| v.values.first } }
+    let(:shards) { all_clusters.map { |c| c.shards.values }.flatten(1) }
+
+    it "all shards should begin transaction" do
+      User.all_cluster_transaction {
+        expect(shards.map(&:connection).map(&:open_transactions)).to all(be == 1)
+      }
+    end
+  end
+
+  describe "cluster_transaction" do
+    let(:cluster) { clusters[:user_cluster].values.first }
+    let(:shards) { cluster.shards.values }
+
+    it "all shards in the cluster should begin transaction" do
+      User.user_cluster_transaction {
+        expect(shards.map(&:connection).map(&:open_transactions)).to all(be == 1)
+      }
+    end
+  end
+end

data/spec/active_record/turntable_spec.rb

@@ -8,9 +8,9 @@ describe ActiveRecord::Turntable do
   context "#config_file" do
     it "should return Rails.root/config/turntable.yml default" do
       unless defined?(::Rails); class ::Rails; end; end
-      stub(Rails).root { "/path/to/rails_root" }
+      allow(Rails).to receive(:root) { "/path/to/rails_root" }
       ActiveRecord::Base.turntable_config_file = nil
-      ActiveRecord::Base.turntable_config_file.should == "/path/to/rails_root/config/turntable.yml"
+      expect(ActiveRecord::Base.turntable_config_file).to eq("/path/to/rails_root/config/turntable.yml")
     end
   end
 
@@ -19,12 +19,12 @@ describe ActiveRecord::Turntable do
       ActiveRecord::Base.send(:include, ActiveRecord::Turntable)
       filename = "hogefuga"
       ActiveRecord::Base.turntable_config_file = filename
-      ActiveRecord::Base.turntable_config_file.should == filename
+      expect(ActiveRecord::Base.turntable_config_file).to eq(filename)
     end
   end
 
   context "#config" do
     subject { ActiveRecord::Base.turntable_config }
-    it { should be_instance_of(ActiveRecord::Turntable::Config) }
+    it { is_expected.to be_instance_of(ActiveRecord::Turntable::Config) }
   end
 end

data/spec/config/database.yml

@@ -1,45 +1,35 @@
-test:
+default: &default
   adapter: mysql2
   username: root
   password:
   host: localhost
   port: 3306
   encoding: utf8
-  database: turntable_master_test
+  database: turntable_test
+
+test:
+  <<: *default
+  database: turntable_test
   seq:
-    user_seq_1:
-      adapter: mysql2
-      username: root
-      password:
-      host: localhost
-      port: 3306
-      encoding: utf8
-      database: turntable_seq_test
-#     seq_type: api
-      api_host: localhost
-      api_port: 9292
+    user_seq:
+      <<: *default
+      database: turntable_user_seq_test
   shards:
     user_shard_1:
-      adapter: mysql2
-      username: root
-      password:
-      host: localhost
-      port: 3306
-      encoding: utf8
-      database: turntable1_test
+      <<: *default
+      database: turntable_user_shard_1_test
     user_shard_2:
-      adapter: mysql2
-      username: root
-      password:
-      host: localhost
-      port: 3306
-      encoding: utf8
-      database: turntable2_test
+      <<: *default
+      database: turntable_user_shard_2_test
     user_shard_3:
-      adapter: mysql2
-      username: root
-      password:
-      host: localhost
-      port: 3306
-      encoding: utf8
-      database: turntable3_test
+      <<: *default
+      database: turntable_user_shard_3_test
+    user_shard_4:
+      <<: *default
+      database: turntable_user_shard_4_test
+    user_shard_5:
+      <<: *default
+      database: turntable_user_shard_5_test
+    user_shard_6:
+      <<: *default
+      database: turntable_user_shard_6_test