activerecord-trilogis-adapter 8.0.0 → 8.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d6986c4a92cdff8495b93cf837edbc946a9401c1a12a2b639bc7440c974d0d6
-  data.tar.gz: b5663960d9aa5514a8c495d6603871c20acbdfdbdd534d78da2c70eb8f4e154d
+  metadata.gz: c62868490c8dbbca1486797b7f451fe16da47e250d97d9578bc28bd405f88979
+  data.tar.gz: 53635558156147dadcf07913b4faeec937b0c8d1fd09548a82ac8168d10c3c45
 SHA512:
-  metadata.gz: 784de6dc127d3c4f584ed540d37391e1bbb88496ff1e05c9e0229686356b4bd69af33635910b7c81dd12844b649f9db9808458d4251734a4531b7261c2ee99bc
-  data.tar.gz: 3e9e4ddea564f8e6843baa1f36104b83f5679b5ecb0ed46e8e0edb5c7f97f942534640f5a35d582dbae3a5c6332c59af828eb7a14b41c21b92f6f2637ae53123
+  metadata.gz: 12824854fd79269b2f00231712267db378e642579ea462a2aee7c1e377961ee65a0f03d2d47227484b9bfaa1800549fa2b207c7e8c5e29d9b1059b7deafed4bd
+  data.tar.gz: 1bb9c83957682886cb09eb343fe82ef2e9e9c2a4eb6998f01ecfe0d5c3c8a52659bfccd7344433260e1de3c66d15f8579ed2132286471fe9b9f235b042ef2b1e

data/lib/active_record/connection_adapters/trilogis/schema_creation.rb

@@ -9,7 +9,15 @@ module ActiveRecord
         def add_column_options!(sql, options)
           # Add SRID option for spatial columns in MySQL 8.0+
           # Format: /*!80003 SRID #{srid} */
-          sql << " /*!80003 SRID #{options[:srid]} */" if options[:srid]
+          if options[:srid]
+            sql_result = "#{sql} /*!80003 SRID #{options[:srid]} */"
+            sql.replace(sql_result)
+
+            # MySQL does not support DEFAULT values for spatial columns
+            # Remove :default option before calling super to prevent SQL errors
+            options = options.dup
+            options.delete(:default)
+          end
 
           super
         end

data/lib/active_record/connection_adapters/trilogis/schema_statements.rb

@@ -77,18 +77,21 @@ module ActiveRecord
           if spatial_type?(type.to_s)
             # Build ALTER TABLE statement for spatial column
             sql_type = spatial_sql_type(type, options[:type])
-            sql = "ALTER TABLE #{quote_table_name(table_name)} ADD #{quote_column_name(column_name)} #{sql_type}"
+            base_sql = "ALTER TABLE #{quote_table_name(table_name)} " \
+                       "ADD #{quote_column_name(column_name)} #{sql_type}"
+            sql_parts = [base_sql]
 
             # Add SRID if specified
-            sql << " SRID #{options[:srid]}" if options[:srid] && options[:srid] != 0
+            sql_parts << " SRID #{options[:srid]}" if options[:srid] && options[:srid] != 0
 
             # Add NULL constraint
-            sql << " NOT NULL" if options[:null] == false
+            sql_parts << " NOT NULL" if options[:null] == false
 
-            # Add DEFAULT if specified (allow falsy values like 0/false)
-            sql << " DEFAULT #{quote_default_expression(options[:default], nil)}" if options.key?(:default)
+            # MySQL does not support DEFAULT values for spatial/geometry columns
+            # Silently ignore :default option to prevent SQL syntax errors
+            # Users should handle defaults at application level instead
 
-            execute sql
+            execute sql_parts.join
 
             # Clear memoized spatial column info for this table
             clear_spatial_cache_for(table_name)
@@ -163,10 +166,10 @@ module ActiveRecord
 
           SpatialColumn.new(
             field_name,
-            extract_field_value(field, :Default, :default),
+            nil, # MySQL spatial columns cannot have DEFAULT values
             type_metadata,
             extract_field_value(field, :Null, :null) == "YES",
-            extract_field_value(field, :Extra, :extra),
+            nil, # MySQL spatial columns cannot have DEFAULT functions
             collation: extract_field_value(field, :Collation, :collation),
             comment: extract_field_value(field, :Comment, :comment).presence,
             spatial_info: spatial_info
@@ -180,14 +183,17 @@ module ActiveRecord
         def visit_ColumnDefinition(o)
           if spatial_column?(o)
             sql_type = spatial_sql_type(o.sql_type, o.options[:type])
-            column_sql = "#{quote_column_name(o.name)} #{sql_type}"
+            column_sql_parts = ["#{quote_column_name(o.name)} #{sql_type}"]
 
             # Add SRID if specified (MySQL 8.0+ syntax: COLUMN TYPE SRID value)
-            column_sql << " SRID #{o.options[:srid]}" if o.options[:srid] && o.options[:srid] != 0
+            column_sql_parts << " SRID #{o.options[:srid]}" if o.options[:srid] && o.options[:srid] != 0
 
-            column_sql << " NOT NULL" unless o.null
-            column_sql << " DEFAULT #{quote_default_expression(o.default, o)}" unless o.default.nil?
-            column_sql
+            column_sql_parts << " NOT NULL" unless o.null
+
+            # MySQL does not support DEFAULT values for spatial/geometry columns
+            # Silently ignore default to prevent SQL syntax errors
+
+            column_sql_parts.join
           else
             super
           end

data/lib/active_record/connection_adapters/trilogis/spatial_column.rb

@@ -13,7 +13,7 @@ module ActiveRecord
 
     module Trilogis
       class SpatialColumn < ActiveRecord::ConnectionAdapters::MySQL::Column
-        attr_reader :geometric_type, :srid
+        attr_reader :geometric_type, :srid, :geo_type_name
 
         # Map SQL type strings to RGeo type classes
         GEOMETRIC_TYPES = {
@@ -27,24 +27,24 @@ module ActiveRecord
           "geometrycollection" => RGeo::Feature::GeometryCollection
         }.freeze
 
-        def initialize(name, default, sql_type_metadata = nil, null = true, default_function = nil, collation: nil,
-                       comment: nil, spatial_info: nil, **)
+        def initialize(name, default, sql_type_metadata = nil, null = true,
+                       default_function = nil, collation: nil, comment: nil, spatial_info: nil, **)
           super(name, default, sql_type_metadata, null, default_function, collation: collation, comment: comment)
 
           return unless spatial?
 
           if spatial_info
             # Use spatial info from INFORMATION_SCHEMA if available
-            geo_type_str = spatial_info[:type].to_s.downcase
-            @geometric_type = GEOMETRIC_TYPES[geo_type_str] || RGeo::Feature::Geometry
+            @geo_type_name = spatial_info[:type].to_s.downcase
+            @geometric_type = GEOMETRIC_TYPES[@geo_type_name] || RGeo::Feature::Geometry
             @srid = spatial_info[:srid] || 0
             @has_z = spatial_info[:has_z] || false
             @has_m = spatial_info[:has_m] || false
           else
             # Fallback to extracting from SQL type
-            type_info = Type::Spatial.new(sql_type_metadata.sql_type)
-            geo_type_str = type_info.geo_type.to_s.downcase
-            @geometric_type = GEOMETRIC_TYPES[geo_type_str] || RGeo::Feature::Geometry
+            @geo_type_name = sql_type_metadata.sql_type.to_s.downcase
+            type_info = Type::Spatial.new(@geo_type_name)
+            @geometric_type = GEOMETRIC_TYPES[@geo_type_name] || RGeo::Feature::Geometry
             @srid = type_info.srid || 0
             @has_z = false
             @has_m = false
@@ -63,14 +63,45 @@ module ActiveRecord
           @has_m || false
         end
 
+        # Return Rails type for schema dumper
+        # Returns the actual geometric type (point, linestring, etc.) as symbol
+        # This allows schema dumper to generate t.point, t.linestring, etc.
+        def type
+          return super unless spatial?
+
+          # Return actual geometric type as symbol
+          # This matches PostGIS approach and enables proper schema dumping
+          @geo_type_name&.to_sym || :geometry
+        end
+
         # Return limit as hash with spatial metadata for schema dumper
+        # Only includes SRID (type is already in column type)
         def limit
           return super unless spatial?
 
-          {
-            type: sql_type_metadata.sql_type.downcase,
-            srid: @srid
-          }
+          # Only include SRID in limit
+          # Type information is in the type() method
+          { srid: @srid }.compact
+        end
+
+        # Override default to always return nil for spatial columns
+        # MySQL does not support DEFAULT values for spatial/geometry columns
+        def default
+          return super unless spatial?
+
+          # Always return nil for spatial columns to prevent schema dumper
+          # from generating invalid DEFAULT clauses
+          nil
+        end
+
+        # Override default_function to always return nil for spatial columns
+        # MySQL does not support DEFAULT values for spatial/geometry columns
+        def default_function
+          return super unless spatial?
+
+          # Always return nil for spatial columns to prevent schema dumper
+          # from generating invalid DEFAULT clauses
+          nil
         end
       end
     end

data/lib/active_record/connection_adapters/trilogis/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module Trilogis
-      VERSION = "8.0.0"
+      VERSION = "8.0.2"
     end
   end
 end

data/lib/active_record/connection_adapters/trilogis_adapter.rb

@@ -104,9 +104,6 @@ module ActiveRecord
         # Override the visitor for spatial support
         @visitor = Arel::Visitors::Trilogis.new(self)
 
-        # Register spatial types
-        register_spatial_types
-
         # Configure RGeo factory generator for SRID-based factory selection
         configure_rgeo_factory_generator
       end
@@ -138,6 +135,11 @@ module ActiveRecord
         Trilogis::SchemaCreation.new(self)
       end
 
+      # Override valid_type? to include spatial types
+      def valid_type?(type)
+        SPATIAL_COLUMN_TYPES.include?(type.to_s) || super
+      end
+
       def native_database_types
         super.merge(
           geometry: { name: "geometry" },
@@ -188,16 +190,6 @@ module ActiveRecord
 
       private
 
-      def register_spatial_types
-        SPATIAL_COLUMN_TYPES.each do |geo_type|
-          ActiveRecord::Type.register(
-            geo_type.to_sym,
-            Type::Spatial.new(geo_type),
-            adapter: :trilogis
-          )
-        end
-      end
-
       def configure_rgeo_factory_generator
         # Register Geographic factories for geographic SRIDs in RGeo::ActiveRecord::SpatialFactoryStore
         # This ensures the correct factory (Geographic vs Cartesian) is used based on SRID
@@ -264,6 +256,15 @@ module ActiveRecord
   end
 end
 
+# Register spatial types globally
+ActiveRecord::ConnectionAdapters::TrilogisAdapter::SPATIAL_COLUMN_TYPES.each do |geo_type|
+  ActiveRecord::Type.register(
+    geo_type.to_sym,
+    ActiveRecord::Type::Spatial,
+    adapter: :trilogis
+  )
+end
+
 # Register the adapter with ActiveRecord
 ActiveRecord::ConnectionAdapters.register(
   "trilogis",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-trilogis-adapter
 version: !ruby/object:Gem::Version
-  version: 8.0.0
+  version: 8.0.2
 platform: ruby
 authors:
 - Ether Moon
@@ -13,22 +13,16 @@ dependencies:
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '8.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '9.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '8.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '9.0'
 - !ruby/object:Gem::Dependency
   name: rgeo
   requirement: !ruby/object:Gem::Requirement