activerecord-tablefree 3.1.2 → 3.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9050219b074d636ea977dde8d3c3725f7bae889
-  data.tar.gz: 3b7fa7a1cadfd4645d4ece6b90b95f1752782473
+  metadata.gz: bd641bf62d44d61669232874c115223d670525dc
+  data.tar.gz: e77eb3bc55b531d724c863d9368e36a9ff54b66f
 SHA512:
-  metadata.gz: 0f759624174cecc91229bf7c2d15d04b7075f24f2f01c7aa76d1b7bc6ae60664391da59722ff0dc39cfa611763c016e35e4dec3bd74edddf8853131892d50bff
-  data.tar.gz: 36429a10d2a5aa374b3bc86d12d294c2d670565e8557cad39379c26988e47c859feff79a0e8f932667f3015ecfc754a376384ff911325dc810890233b018a65c
+  metadata.gz: d747f17d5693c762b2511296a875bf63a71cf378fd62b8c662357cdf37e3343c96968e1cce39df072e3cda1637dd98fe194e87f6ae5defcbf605b70d16bc28b5
+  data.tar.gz: 936bf5a5f9ff23a685b55c604687eb8f18c43499c18333f95392c552e5a651022bb3c1f34305fa1ebc7427e21e7c585bef4a81a998299c05c891e7f1fc574065

data/README.md

@@ -64,23 +64,25 @@ Define a model like this:
       has_no_table
       column :name, :string
       column :email, :string
-      validates_presence_of :name, :email
+      column :message, :string
+      validates_presence_of :name, :email, :message
     end
 
 You can now use the model in a view like this:
 
-    <%= form_for :message, @message do |f| %>
+    <%= form_for :contact_message, @contact_message do |f| %>
       Your name: <%= f.text_field :name %>
       Your email: <%= f.text_field :email %>
+      Your message: <%= f.text_field :message %>
     <% end %>
 
 And in the controller:
 
-    def message
-      @message = ContactMessage.new
+    def contact_message
+      @contact_message = ContactMessage.new
       if request.post?
-        @message.attributes = params[:message]
-        if @message.valid?
+        @contact_message.attributes = params[:contact_message]
+        if @contact_message.valid?
           # Process the message...
         end
       end
@@ -90,6 +92,34 @@ If you wish (this is not recommended), you can pretend you have a succeeding dat
 
     has_no_table :database => :pretend_success
 
+Associations
+------------
+
+Some model as before, but with an association to a real DB-backed model.
+
+```
+    class ContactMessage < ActiveRecord::Base
+      has_no_table
+      column :message, :string
+      column :email, :string
+      validates_presence_of :name, :email
+      belongs_to :contact, foreign_key: :email, primary_key: :email
+    end
+
+    class Contact < ActiveRecord::Base
+      validates_presence_of :name, :email
+      has_one :contact_message, foreign_key: :email, primary_key: :email, dependent: nil
+    end
+```
+
+Obviously the association is not full-fledged, as some traversals just won't make sense with one side not being loadable from the database.  From the `ContactMessage` you can get to the `Contact`, but not vice versa.
+
+```
+>> contact = Contact.new(name: 'Boo', email: 'boo@example.com')
+>> contact_message = ContactMessage.new(contact: contact)
+>> contact_message.email
+=> 'boo@example.com'
+```
 
 Development
 -----------

data/lib/activerecord/tablefree/connection.rb

@@ -1,5 +1,19 @@
 module ActiveRecord::Tablefree
-  class Connection
+  class Connection < ActiveRecord::ConnectionAdapters::AbstractAdapter
+    def initialize
+      @connection          = Object.new # The Raw Connection
+      @owner               = nil
+      @instrumenter        = ActiveSupport::Notifications.instrumenter
+      @logger              = Object.new
+      @config              = Object.new
+      @pool                = nil
+      @schema_cache        = ActiveRecord::Tablefree::SchemaCache.new
+      @quoted_column_names, @quoted_table_names = {}, {}
+      @visitor = Object.new
+      @lock = Object.new
+      @prepared_statements = false
+    end
+
     def quote_table_name(*_args)
       ''
     end
@@ -12,10 +26,6 @@ module ActiveRecord::Tablefree
       nil
     end
 
-    def schema_cache(*_args)
-      @_schema_cache ||= ActiveRecord::Tablefree::SchemaCache.new
-    end
-
     # Fixes Issue #17. https://github.com/softace/activerecord-tablefree/issues/17
     # The following method is from the ActiveRecord gem:
     #   /lib/active_record/connection_adapters/abstract/database_statements.rb .
@@ -57,14 +67,9 @@ module ActiveRecord::Tablefree
       {}
     end
 
-    # This is used in the StatementCache object. It returns an object that
-    # can be used to query the database repeatedly.
+    # This is used in the StatementCache object.
     def cacheable_query(arel) # :nodoc:
-      if prepared_statements
-        ActiveRecord::StatementCache.query visitor, arel.ast
-      else
-        ActiveRecord::StatementCache.partial_query visitor, arel.ast, collector
-      end
+      ActiveRecord::Tablefree::StatementCache.partial_query visitor, arel.ast, collector
     end
   end
 end

data/lib/activerecord/tablefree/statement_cache.rb

@@ -0,0 +1,22 @@
+module ActiveRecord::Tablefree
+  class StatementCache < ActiveRecord::StatementCache
+    def self.create(*_args)
+      new Object.new, ActiveRecord::Tablefree::StatementCache::BindMap.new
+    end
+
+    def execute
+      nil
+    end
+
+    class BindMap
+      def initialize(*_args)
+        @indexes = []
+        @bound_attributes = []
+      end
+
+      def bind(*_args)
+        []
+      end
+    end
+  end
+end

data/lib/activerecord/tablefree/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Tablefree
-    VERSION = '3.1.2'.freeze
+    VERSION = '3.1.3'.freeze
   end
 end

data/lib/activerecord/tablefree.rb

@@ -36,6 +36,7 @@ module ActiveRecord
   module Tablefree
     class NoDatabase < StandardError; end
     class Unsupported < StandardError; end
+    class InvalidColumnType < ArgumentError; end
 
     def self.included(base) #:nodoc:
       base.send :extend, ActsMethods
@@ -86,7 +87,9 @@ module ActiveRecord
 
       # Register a new column.
       def column(name, sql_type = nil, default = nil, null = true)
-        cast_type = "ActiveRecord::Type::#{sql_type.to_s.camelize}".constantize.new
+        cast_class = "ActiveRecord::Type::#{sql_type.to_s.camelize}".constantize rescue nil
+        raise InvalidColumnType, "sql_type is #{sql_type} (#{sql_type.class}), which is not supported" unless cast_class.respond_to?(:new)
+        cast_type = cast_class.new
         tablefree_options[:columns_hash][name.to_s] = ActiveRecord::ConnectionAdapters::Column.new(name.to_s, default, cast_type, sql_type.to_s, null)
       end
 

data/spec/activerecord/tablefree_spec.rb

@@ -255,7 +255,6 @@ shared_examples_for 'an instance with succeeding database' do
 end
 
 describe 'ActiveRecord with real database' do
-  # This is only here to ensure that the shared examples are actually behaving like a real database.
   before(:context) do
     FileUtils.mkdir_p 'tmp'
     ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: 'tmp/test.db')
@@ -276,6 +275,36 @@ describe 'ActiveRecord with real database' do
     subject { Chair.new(name: 'Jarl') }
     it_behaves_like 'an instance with succeeding database'
   end
+
+  describe 'association' do
+    before(:context) do
+      # reopen the chair to add an association
+      class Chair < ActiveRecord::Base
+        has_one :arm_rest, primary_key: :name, foreign_key: :name, dependent: nil
+      end
+      class ArmRest < ActiveRecord::Base
+        has_no_table
+        column :name, :string
+        belongs_to :chair, primary_key: :name, foreign_key: :name
+      end
+    end
+    it 'can be traversed by setting association' do
+      chair = Chair.create(name: 'A')
+      arm_rest = ArmRest.new(chair: chair)
+      expect(arm_rest.chair).to eq chair
+    end
+    it 'sets foreign key from association' do
+      chair = Chair.create(name: 'A')
+      arm_rest = ArmRest.new(chair: chair)
+      expect(arm_rest.name).to eq 'A'
+    end
+    it 'can be traversed by setting foreign key' do
+      pending('more effort to implement')
+      Chair.create(name: 'B')
+      arm_rest = ArmRest.new(name: 'B')
+      expect { arm_rest.chair }.to_not raise_error
+    end
+  end
 end
 
 describe 'Tablefree model with succeeding database' do
@@ -306,3 +335,17 @@ describe 'Tablefree model can access connection transaction' do
     it { is_expected.to be_a(ActiveRecord::Tablefree::Transaction) }
   end
 end
+
+describe 'Bad column type' do
+  describe 'association' do
+    subject { -> {
+      class ArmRest < ActiveRecord::Base
+        has_no_table
+        column :chair_id
+      end
+    }}
+    it 'raises an InvalidColumnType error' do
+      expect { subject.call }.to raise_error ActiveRecord::Tablefree::InvalidColumnType, 'sql_type is  (NilClass), which is not supported'
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-tablefree
 version: !ruby/object:Gem::Version
-  version: 3.1.2
+  version: 3.1.3
 platform: ruby
 authors:
 - Jarl Friis
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-20 00:00:00.000000000 Z
+date: 2017-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -284,6 +284,7 @@ files:
 - lib/activerecord/tablefree/cast_type.rb
 - lib/activerecord/tablefree/connection.rb
 - lib/activerecord/tablefree/schema_cache.rb
+- lib/activerecord/tablefree/statement_cache.rb
 - lib/activerecord/tablefree/transaction.rb
 - lib/activerecord/tablefree/version.rb
 - spec/activerecord/tablefree/version_spec.rb