activerecord-sqlserver-adapter 7.2.7 → 8.0.0

data/test/cases/coerced_tests.rb

@@ -376,18 +376,6 @@ module ActiveRecord
 end
 
 class CalculationsTest < ActiveRecord::TestCase
-  # SELECT columns must be in the GROUP clause.
-  coerce_tests! :test_should_count_with_group_by_qualified_name_on_loaded
-  def test_should_count_with_group_by_qualified_name_on_loaded_coerced
-    accounts = Account.group("accounts.id").select("accounts.id")
-    expected = { 1 => 1, 2 => 1, 3 => 1, 4 => 1, 5 => 1, 6 => 1 }
-    assert_not_predicate accounts, :loaded?
-    assert_equal expected, accounts.count
-    accounts.load
-    assert_predicate accounts, :loaded?
-    assert_equal expected, accounts.count(:id)
-  end
-  
   # Fix randomly failing test. The loading of the model's schema was affecting the test.
   coerce_tests! :test_offset_is_kept
   def test_offset_is_kept_coerced
@@ -532,6 +520,9 @@ class CalculationsTest < ActiveRecord::TestCase
 
   # SELECT columns must be in the GROUP clause. Since since `ids` only selects the primary key you cannot perform this query in SQL Server.
   coerce_tests! :test_ids_with_includes_and_non_primary_key_order
+
+  # To limit the results in SQL Server we use `FETCH NEXT @0 ROWS ONLY` instead of `LIMIT @0`. To use `FETCH NEXT` an order must be provided.
+  coerce_tests! :test_no_order_by_when_counting_all
 end
 
 module ActiveRecord
@@ -1349,6 +1340,20 @@ module ActiveRecord
     def test_registering_new_handlers_for_association_coerced
       assert_match %r{#{Regexp.escape(topic_title)} ~ N'rails'}i, Reply.joins(:topic).where(topics: { title: /rails/ }).to_sql
     end
+
+    # Same as original test except string has `N` prefix to indicate unicode string.
+    coerce_tests! :test_registering_new_handlers_for_joins
+    def test_registering_new_handlers_for_joins_coerced
+      Reply.belongs_to :regexp_topic, -> { where(title: /rails/) }, class_name: "Topic", foreign_key: "parent_id"
+
+      assert_match %r{#{Regexp.escape(quote_table_name("regexp_topic.title"))} ~ N'rails'}i, Reply.joins(:regexp_topic).references(Arel.sql("regexp_topic")).to_sql
+    end
+
+    private
+
+    def topic_title
+      Topic.lease_connection.quote_table_name("topics.title")
+    end
   end
 end
 
@@ -2180,17 +2185,6 @@ class EnumTest < ActiveRecord::TestCase
     Book.lease_connection.add_index(:books, [:author_id, :name], unique: true)
   end
 
-  # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
-  coerce_tests! %r{declare multiple enums at a time}
-  test "declare multiple enums at a time coerced" do
-    Book.lease_connection.remove_index(:books, column: [:author_id, :name])
-
-    send(:'original_declare multiple enums at a time')
-  ensure
-    Book.where(author_id: nil, name: nil).delete_all
-    Book.lease_connection.add_index(:books, [:author_id, :name], unique: true)
-  end
-
   # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
   coerce_tests! %r{serializable\? with large number label}
   test "serializable? with large number label coerced" do
@@ -2262,14 +2256,6 @@ class LogSubscriberTest < ActiveRecord::TestCase
   def test_verbose_query_logs_coerced
     original_test_verbose_query_logs
   end
-
-  # Bindings logged slightly differently.
-  coerce_tests! :test_where_in_binds_logging_include_attribute_names
-  def test_where_in_binds_logging_include_attribute_names_coerced
-    Developer.where(id: [1, 2, 3, 4, 5]).load
-    wait
-    assert_match(%{@0 = 1, @1 = 2, @2 = 3, @3 = 4, @4 = 5  [["id", nil], ["id", nil], ["id", nil], ["id", nil], ["id", nil]]}, @logger.logged(:debug).last)
-  end
 end
 
 class ReloadModelsTest < ActiveRecord::TestCase
@@ -2431,7 +2417,9 @@ class QueryLogsTest < ActiveRecord::TestCase
   # SQL requires double single-quotes.
   coerce_tests! :test_sql_commenter_format
   def test_sql_commenter_format_coerced
-    ActiveRecord::QueryLogs.update_formatter(:sqlcommenter)
+    ActiveRecord::QueryLogs.tags_formatter = :sqlcommenter
+    ActiveRecord::QueryLogs.tags = [:application]
+
     assert_queries_match(%r{/\*application=''active_record''\*/}) do
       Dashboard.first
     end
@@ -2440,7 +2428,7 @@ class QueryLogsTest < ActiveRecord::TestCase
   # SQL requires double single-quotes.
   coerce_tests! :test_sqlcommenter_format_value
   def test_sqlcommenter_format_value_coerced
-    ActiveRecord::QueryLogs.update_formatter(:sqlcommenter)
+    ActiveRecord::QueryLogs.tags_formatter = :sqlcommenter
 
     ActiveRecord::QueryLogs.tags = [
       :application,
@@ -2455,7 +2443,7 @@ class QueryLogsTest < ActiveRecord::TestCase
   # SQL requires double single-quotes.
   coerce_tests! :test_sqlcommenter_format_value_string_coercible
   def test_sqlcommenter_format_value_string_coercible_coerced
-    ActiveRecord::QueryLogs.update_formatter(:sqlcommenter)
+    ActiveRecord::QueryLogs.tags_formatter = :sqlcommenter
 
     ActiveRecord::QueryLogs.tags = [
       :application,
@@ -2470,7 +2458,7 @@ class QueryLogsTest < ActiveRecord::TestCase
   # SQL requires double single-quotes.
   coerce_tests! :test_sqlcommenter_format_allows_string_keys
   def test_sqlcommenter_format_allows_string_keys_coerced
-    ActiveRecord::QueryLogs.update_formatter(:sqlcommenter)
+    ActiveRecord::QueryLogs.tags_formatter = :sqlcommenter
 
     ActiveRecord::QueryLogs.tags = [
       :application,
@@ -2505,6 +2493,17 @@ class InsertAllTest < ActiveRecord::TestCase
     result = Book.insert_all! [{ name: "Rework", author_id: 1 }], returning: Arel.sql("UPPER(INSERTED.name) as name")
     assert_equal %w[ REWORK ], result.pluck("name")
   end
+
+  # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
+  coerce_tests! :test_insert_with_type_casting_and_serialize_is_consistent
+  def test_insert_with_type_casting_and_serialize_is_consistent_coerced
+    connection.remove_index(:books, column: [:author_id, :name])
+
+    original_test_insert_with_type_casting_and_serialize_is_consistent
+  ensure
+    Book.where(author_id: nil, name: '["Array"]').delete_all
+    Book.lease_connection.add_index(:books, [:author_id, :name], unique: true)
+  end
 end
 
 module ActiveRecord
@@ -2667,6 +2666,28 @@ module ActiveRecord
   end
 end
 
+module ActiveRecord
+  module ConnectionAdapters
+    class RegistrationIsolatedTest < ActiveRecord::TestCase
+      # SQL Server was not included in the list of available adapters in the error message.
+      coerce_tests! %r{resolve raises if the adapter is using the pre 7.2 adapter registration API}
+      def resolve_raises_if_the_adapter_is_using_the_pre_7_2_adapter_registration_API
+        exception = assert_raises(ActiveRecord::AdapterNotFound) do
+          ActiveRecord::ConnectionAdapters.resolve("fake_legacy")
+        end
+
+        assert_equal(
+          "Database configuration specifies nonexistent 'ridiculous' adapter. Available adapters are: abstract, fake, mysql2, postgresql, sqlite3, sqlserver, trilogy. Ensure that the adapter is spelled correctly in config/database.yml and that you've added the necessary adapter gem to your Gemfile if it's not in the list of available adapters.",
+          exception.message
+        )
+      ensure
+        ActiveRecord::ConnectionAdapters.instance_variable_get(:@adapters).delete("fake_legacy")
+      end
+    end
+  end
+end
+
+
 module ActiveRecord
   class TableMetadataTest < ActiveSupport::TestCase
     # Adapter returns an object that is subclass of what is expected in the original test.

data/test/cases/optimizer_hints_test_sqlserver.rb

@@ -36,7 +36,6 @@ class OptimizerHitsTestSQLServer < ActiveRecord::TestCase
     end
   end
 
-
   it "support order" do
     assert_queries_match(%r{\ASELECT .+ FROM .+ ORDER .+ OPTION .+\z}) do
       companies = Company.optimizer_hints("LABEL='FindCompanies'")

data/test/cases/schema_test_sqlserver.rb

@@ -101,11 +101,5 @@ class SchemaTestSQLServer < ActiveRecord::TestCase
         assert_equal "[with].[select notation]", connection.send(:get_raw_table_name, "INSERT INTO [with].[select notation] SELECT * FROM [table_name]")
       end
     end
-
-    describe 'CREATE VIEW statements' do
-      it do
-        assert_equal "test_table_as", connection.send(:get_raw_table_name, "CREATE VIEW test_views ( test_table_a_id, test_table_b_id ) AS SELECT test_table_as.id as test_table_a_id, test_table_bs.id as test_table_b_id FROM (test_table_as with(nolock) LEFT JOIN test_table_bs with(nolock) ON (test_table_as.id = test_table_bs.test_table_a_id))")
-      end
-    end
   end
 end

data/test/cases/view_test_sqlserver.rb

@@ -48,17 +48,11 @@ class ViewTestSQLServer < ActiveRecord::TestCase
     end
   end
 
-  describe "identity insert" do
-    it "creates table record through a view" do
-      assert_difference("SSTestCustomersView.count", 2) do
+  describe 'identity insert' do
+    it "identity insert works with views" do
+      assert_difference("SSTestCustomersView.count", 1) do
         SSTestCustomersView.create!(id: 5, name: "Bob")
-        SSTestCustomersView.create!(id: 6, name: "Tim")
       end
     end
-
-    it "creates table records through a view using fixtures" do
-      ActiveRecord::FixtureSet.create_fixtures(File.join(ARTest::SQLServer.test_root_sqlserver, "fixtures"), ["sst_customers_view"])
-      assert_equal SSTestCustomersView.all.count, 2
-    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 7.2.7
+  version: 8.0.0
 platform: ruby
 authors:
 - Ken Collins
@@ -12,9 +12,10 @@ authors:
 - Joe Rafaniello
 - Tom Ward
 - Aidan Haran
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2024-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -22,14 +23,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.2.0
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.2.0
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: tiny_tds
   requirement: !ruby/object:Gem::Requirement
@@ -78,7 +79,6 @@ files:
 - lib/active_record/connection_adapters/sqlserver/core_ext/abstract_adapter.rb
 - lib/active_record/connection_adapters/sqlserver/core_ext/active_record.rb
 - lib/active_record/connection_adapters/sqlserver/core_ext/attribute_methods.rb
-- lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb
 - lib/active_record/connection_adapters/sqlserver/core_ext/explain.rb
 - lib/active_record/connection_adapters/sqlserver/core_ext/explain_subscriber.rb
 - lib/active_record/connection_adapters/sqlserver/core_ext/finder_methods.rb
@@ -176,8 +176,6 @@ files:
 - test/cases/schema_test_sqlserver.rb
 - test/cases/showplan_test_sqlserver.rb
 - test/cases/specific_schema_test_sqlserver.rb
-- test/cases/temp_test_sqlserver.rb
-- test/cases/temporary_table_test_sqlserver.rb
 - test/cases/transaction_test_sqlserver.rb
 - test/cases/trigger_test_sqlserver.rb
 - test/cases/utils_test_sqlserver.rb
@@ -186,7 +184,6 @@ files:
 - test/config.yml
 - test/debug.rb
 - test/fixtures/1px.gif
-- test/fixtures/sst_customers_view.yml
 - test/migrations/create_clients_and_change_column_collation.rb
 - test/migrations/create_clients_and_change_column_null.rb
 - test/migrations/transaction_table/1_table_will_never_be_created.rb
@@ -241,8 +238,9 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues
-  changelog_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/v7.2.7/CHANGELOG.md
-  source_code_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/tree/v7.2.7
+  changelog_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/v8.0.0/CHANGELOG.md
+  source_code_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/tree/v8.0.0
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -250,14 +248,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.1.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.5.21
+signing_key:
 specification_version: 4
 summary: ActiveRecord SQL Server Adapter.
 test_files:
@@ -295,8 +294,6 @@ test_files:
 - test/cases/schema_test_sqlserver.rb
 - test/cases/showplan_test_sqlserver.rb
 - test/cases/specific_schema_test_sqlserver.rb
-- test/cases/temp_test_sqlserver.rb
-- test/cases/temporary_table_test_sqlserver.rb
 - test/cases/transaction_test_sqlserver.rb
 - test/cases/trigger_test_sqlserver.rb
 - test/cases/utils_test_sqlserver.rb
@@ -305,7 +302,6 @@ test_files:
 - test/config.yml
 - test/debug.rb
 - test/fixtures/1px.gif
-- test/fixtures/sst_customers_view.yml
 - test/migrations/create_clients_and_change_column_collation.rb
 - test/migrations/create_clients_and_change_column_null.rb
 - test/migrations/transaction_table/1_table_will_never_be_created.rb

data/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb

@@ -1,29 +0,0 @@
-# frozen_string_literal: true
-
-require "active_record/relation"
-require "active_record/version"
-
-module ActiveRecord
-  module ConnectionAdapters
-    module SQLServer
-      module CoreExt
-        module Calculations
-
-          private
-          
-          def build_count_subquery(relation, column_name, distinct)
-            klass.with_connection do |connection|
-              relation = relation.unscope(:order) if connection.sqlserver?
-              super(relation, column_name, distinct)
-            end
-          end
-        end
-      end
-    end
-  end
-end
-
-ActiveSupport.on_load(:active_record) do
-  mod = ActiveRecord::ConnectionAdapters::SQLServer::CoreExt::Calculations
-  ActiveRecord::Relation.include(mod)
-end

data/test/cases/temp_test_sqlserver.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-require "cases/helper_sqlserver"
-
-class TempTestSQLServer < ActiveRecord::TestCase
-  # it "assert true" do
-  #   assert true
-  # end
-end

data/test/cases/temporary_table_test_sqlserver.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-require "cases/helper_sqlserver"
-
-class TemporaryTableSQLServer < ActiveRecord::TestCase
-  def test_insert_into_temporary_table
-    ActiveRecord::Base.with_connection do |conn|
-      conn.exec_query("CREATE TABLE #temp_users (id INT IDENTITY(1,1), name NVARCHAR(100))")
-
-      result = conn.exec_query("SELECT * FROM #temp_users")
-      assert_equal 0, result.count
-
-      conn.exec_query("INSERT INTO #temp_users (name) VALUES ('John'), ('Doe')")
-
-      result = conn.exec_query("SELECT * FROM #temp_users")
-      assert_equal 2, result.count
-    end
-  end
-end

data/test/fixtures/sst_customers_view.yml

@@ -1,6 +0,0 @@
-david:
-  name: "David"
-  balance: 2,004
-aidan:
-  name: "Aidan"
-  balance: 10,191