activerecord-sqlserver-adapter 7.2.7 → 7.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4cecbb9e30775c962ac1ce665548b88081fc41501177c3e96abb3739d5d3c8a
-  data.tar.gz: 46b36bbe894e2023475765deebcb2b0ff38af31c6341aff3c56920d5bed77e00
+  metadata.gz: 388f899978fa08e71bc46c3b654dd2d41ac1e3dd49e4a3b781c1d20d983698b3
+  data.tar.gz: b4df1bd77d215f3c0c1d1d6ea3ca101b04588ce08bdcbe4f79a446f3c5b88370
 SHA512:
-  metadata.gz: f978e149eb3c53fe1bd199fcbe533aef919dbbb6b076530e8a8d6e5e7dab9735a3f4ce98d3e27057ec2de18ba28c6a810b465f1b1525de14f75261226ca35b78
-  data.tar.gz: 8f30ad18a93884f2779d29850b19c2510c6a8c75455be38a25121912665355d799f2f1bb5d94664eb773b715ff45bb85e8244ec3afb4797f8dc5826b6c8f3f78
+  metadata.gz: d407a6ef73809b08a2a7f59c04575e5986b1a788fa891f028d3e25757aa71802e4bb2e98459e45f42ddf6c316974516b3b08ba3c79e20ac5424ab4e5df99db67
+  data.tar.gz: 4106b42012e5d0596ae1924055a3d8f92989fc35fa7882c70877b4ba35a5233e26d35a7ed1265ed8f15abbc8f2483967449c3923096a6457f8e9681c47dec7bf

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v7.2.8
+
+#### Fixed
+
+- [#1365](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1365) Verify connection before retrieving the database version.
+
 ## v7.2.7
 
 #### Changed

data/VERSION

@@ -1 +1 @@
-7.2.7
+7.2.8

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -490,19 +490,19 @@ module ActiveRecord
       end
 
       def version_year
-        @version_year ||= begin
-          if sqlserver_version =~ /vNext/
+        @version_year ||=
+          if /vNext/.match?(sqlserver_version)
             2016
           else
             /SQL Server (\d+)/.match(sqlserver_version).to_a.last.to_s.to_i
           end
-        rescue StandardError
-          2016
-        end
       end
 
       def sqlserver_version
-        @sqlserver_version ||= _raw_select("SELECT @@version", @raw_connection).first.first.to_s
+        @sqlserver_version ||= begin
+          verify!
+          _raw_select("SELECT @@version", @raw_connection).first.first.to_s
+        end
       end
 
       private

data/test/cases/helper_sqlserver.rb

@@ -15,6 +15,14 @@ require "support/connection_reflection"
 require "support/query_assertions"
 require "mocha/minitest"
 
+Minitest.after_run do
+  puts "\n\n"
+  puts "=" * 80
+  puts ActiveRecord::Base.lease_connection.send(:sqlserver_version)
+  puts "\nSQL Server Version Year: #{ActiveRecord::Base.lease_connection.get_database_version}"
+  puts "=" * 80
+end
+
 module ActiveSupport
   class TestCase < ::Minitest::Test
     include ARTest::SQLServer::CoerceableTest

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 7.2.7
+  version: 7.2.8
 platform: ruby
 authors:
 - Ken Collins
@@ -241,8 +241,8 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues
-  changelog_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/v7.2.7/CHANGELOG.md
-  source_code_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/tree/v7.2.7
+  changelog_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/v7.2.8/CHANGELOG.md
+  source_code_uri: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/tree/v7.2.8
 rdoc_options: []
 require_paths:
 - lib