activerecord-sqlserver-adapter 6.0.0.rc1 → 6.0.0.rc2

data/test/cases/trigger_test_sqlserver.rb

@@ -1,30 +1,30 @@
 # frozen_string_literal: true
 
-require 'cases/helper_sqlserver'
+require "cases/helper_sqlserver"
 
 class SQLServerTriggerTest < ActiveRecord::TestCase
-  after  { exclude_output_inserted_table_names.clear }
+  after { exclude_output_inserted_table_names.clear }
 
   let(:exclude_output_inserted_table_names) do
     ActiveRecord::ConnectionAdapters::SQLServerAdapter.exclude_output_inserted_table_names
   end
 
-  it 'can insert into a table with output inserted - with a true setting for table name' do
-    exclude_output_inserted_table_names['sst_table_with_trigger'] = true
+  it "can insert into a table with output inserted - with a true setting for table name" do
+    exclude_output_inserted_table_names["sst_table_with_trigger"] = true
     assert SSTestTriggerHistory.all.empty?
-    obj = SSTestTrigger.create! event_name: 'test trigger'
-    _(['Fixnum', 'Integer']).must_include obj.id.class.name
-    _(obj.event_name).must_equal 'test trigger'
+    obj = SSTestTrigger.create! event_name: "test trigger"
+    _(["Fixnum", "Integer"]).must_include obj.id.class.name
+    _(obj.event_name).must_equal "test trigger"
     _(obj.id).must_be :present?
     _(obj.id.to_s).must_equal SSTestTriggerHistory.first.id_source
   end
 
-  it 'can insert into a table with output inserted - with a uniqueidentifier value' do
-    exclude_output_inserted_table_names['sst_table_with_uuid_trigger'] = 'uniqueidentifier'
+  it "can insert into a table with output inserted - with a uniqueidentifier value" do
+    exclude_output_inserted_table_names["sst_table_with_uuid_trigger"] = "uniqueidentifier"
     assert SSTestTriggerHistory.all.empty?
-    obj = SSTestTriggerUuid.create! event_name: 'test uuid trigger'
-    _(obj.id.class.name).must_equal 'String'
-    _(obj.event_name).must_equal 'test uuid trigger'
+    obj = SSTestTriggerUuid.create! event_name: "test uuid trigger"
+    _(obj.id.class.name).must_equal "String"
+    _(obj.event_name).must_equal "test uuid trigger"
     _(obj.id).must_be :present?
     _(obj.id.to_s).must_equal SSTestTriggerHistory.first.id_source
   end

data/test/cases/utils_test_sqlserver.rb

@@ -1,61 +1,62 @@
 # frozen_string_literal: true
 
-require 'cases/helper_sqlserver'
+require "cases/helper_sqlserver"
 
 class UtilsTestSQLServer < ActiveRecord::TestCase
-
-  it '.quote_string' do
+  it ".quote_string" do
     _(SQLServer::Utils.quote_string("I'll store this in C:\\Users")).must_equal "I''ll store this in C:\\Users"
   end
 
-  it '.unquote_string' do
+  it ".unquote_string" do
     _(SQLServer::Utils.unquote_string("I''ll store this in C:\\Users")).must_equal "I'll store this in C:\\Users"
   end
 
-  it '.quoted_raw' do
+  it ".quoted_raw" do
     _(SQLServer::Utils.quoted_raw("some.Name")).must_equal "[some.Name]"
   end
 
-  describe '.extract_identifiers constructor and thus SQLServer::Utils::Name value object' do
-
+  describe ".extract_identifiers constructor and thus SQLServer::Utils::Name value object" do
     let(:valid_names) { valid_names_unquoted + valid_names_quoted }
 
-    let(:valid_names_unquoted) {[
-      'server.database.schema.object',
-      'server.database..object',
-      'server..schema.object',
-      'server...object',
-      'database.schema.object',
-      'database..object',
-      'schema.object',
-      'object'
-    ]}
-
-    let(:valid_names_quoted) {[
-      '[server].[database].[schema].[object]',
-      '[server].[database]..[object]',
-      '[server]..[schema].[object]',
-      '[server]...[object]',
-      '[database].[schema].[object]',
-      '[database]..[object]',
-      '[schema].[object]',
-      '[object]'
-    ]}
+    let(:valid_names_unquoted) {
+      [
+        "server.database.schema.object",
+        "server.database..object",
+        "server..schema.object",
+        "server...object",
+        "database.schema.object",
+        "database..object",
+        "schema.object",
+        "object"
+      ]
+    }
+
+    let(:valid_names_quoted) {
+      [
+        "[server].[database].[schema].[object]",
+        "[server].[database]..[object]",
+        "[server]..[schema].[object]",
+        "[server]...[object]",
+        "[database].[schema].[object]",
+        "[database]..[object]",
+        "[schema].[object]",
+        "[object]"
+      ]
+    }
 
     let(:server_names)   { valid_names.partition { |name| name =~ /server/ } }
     let(:database_names) { valid_names.partition { |name| name =~ /database/ } }
     let(:schema_names)   { valid_names.partition { |name| name =~ /schema/ } }
 
-    it 'extracts and returns #object identifier unquoted by default or quoted as needed' do
+    it "extracts and returns #object identifier unquoted by default or quoted as needed" do
       valid_names.each do |n|
         name = extract_identifiers(n)
-        _(name.object).must_equal 'object', "With #{n.inspect} for #object"
-        _(name.object_quoted).must_equal '[object]', "With #{n.inspect} for #object_quoted"
+        _(name.object).must_equal "object", "With #{n.inspect} for #object"
+        _(name.object_quoted).must_equal "[object]", "With #{n.inspect} for #object_quoted"
       end
     end
 
     [:schema, :database, :server].each do |part|
-
       it "extracts and returns #{part} identifier unquoted by default or quoted as needed" do
         present, blank = send(:"#{part}_names")
         present.each do |n|
@@ -69,57 +70,55 @@ class UtilsTestSQLServer < ActiveRecord::TestCase
           _(name.send(:"#{part}_quoted")).must_be_nil "With #{n.inspect} for ##{part}_quoted method"
         end
       end
-
     end
 
-    it 'does not blow up on nil or blank string name' do
+    it "does not blow up on nil or blank string name" do
       _(extract_identifiers(nil).object).must_be_nil
-      _(extract_identifiers(' ').object).must_be_nil
+      _(extract_identifiers(" ").object).must_be_nil
     end
 
-    it 'has a #quoted that returns a fully quoted name with all identifiers as orginially passed in' do
-      _(extract_identifiers('object').quoted).must_equal '[object]'
-      _(extract_identifiers('server.database..object').quoted).must_equal '[server].[database]..[object]'
-      _(extract_identifiers('[server]...[object]').quoted).must_equal '[server]...[object]'
+    it "has a #quoted that returns a fully quoted name with all identifiers as orginially passed in" do
+      _(extract_identifiers("object").quoted).must_equal "[object]"
+      _(extract_identifiers("server.database..object").quoted).must_equal "[server].[database]..[object]"
+      _(extract_identifiers("[server]...[object]").quoted).must_equal "[server]...[object]"
     end
 
-    it 'can take a symbol argument' do
-      _(extract_identifiers(:object).object).must_equal 'object'
+    it "can take a symbol argument" do
+      _(extract_identifiers(:object).object).must_equal "object"
     end
 
-    it 'allows identifiers with periods to work' do
-      _(extract_identifiers('[obj.name]').quoted).must_equal '[obj.name]'
-      _(extract_identifiers('[obj.name].[foo]').quoted).must_equal '[obj.name].[foo]'
+    it "allows identifiers with periods to work" do
+      _(extract_identifiers("[obj.name]").quoted).must_equal "[obj.name]"
+      _(extract_identifiers("[obj.name].[foo]").quoted).must_equal "[obj.name].[foo]"
     end
 
-    it 'should indicate if a name is fully qualitified' do
-      _(extract_identifiers('object').fully_qualified?).must_equal false
-      _(extract_identifiers('schema.object').fully_qualified?).must_equal false
-      _(extract_identifiers('database.schema.object').fully_qualified?).must_equal false
-      _(extract_identifiers('database.object').fully_qualified?).must_equal false
-      _(extract_identifiers('server...object').fully_qualified?).must_equal false
-      _(extract_identifiers('server.database..object').fully_qualified?).must_equal false
-      _(extract_identifiers('server.database.schema.object').fully_qualified?).must_equal true
-      _(extract_identifiers('server.database.schema.').fully_qualified?).must_equal true
-      _(extract_identifiers('[obj.name]').fully_qualified?).must_equal false
-      _(extract_identifiers('[schema].[obj.name]').fully_qualified?).must_equal false
-      _(extract_identifiers('[database].[schema].[obj.name]').fully_qualified?).must_equal false
-      _(extract_identifiers('[database].[obj.name]').fully_qualified?).must_equal false
-      _(extract_identifiers('[server.name]...[obj.name]').fully_qualified?).must_equal false
-      _(extract_identifiers('[server.name].[database]..[obj.name]').fully_qualified?).must_equal false
-      _(extract_identifiers('[server.name].[database].[schema].[obj.name]').fully_qualified?).must_equal true
-      _(extract_identifiers('[server.name].[database].[schema].').fully_qualified?).must_equal true
+    it "should indicate if a name is fully qualitified" do
+      _(extract_identifiers("object").fully_qualified?).must_equal false
+      _(extract_identifiers("schema.object").fully_qualified?).must_equal false
+      _(extract_identifiers("database.schema.object").fully_qualified?).must_equal false
+      _(extract_identifiers("database.object").fully_qualified?).must_equal false
+      _(extract_identifiers("server...object").fully_qualified?).must_equal false
+      _(extract_identifiers("server.database..object").fully_qualified?).must_equal false
+      _(extract_identifiers("server.database.schema.object").fully_qualified?).must_equal true
+      _(extract_identifiers("server.database.schema.").fully_qualified?).must_equal true
+      _(extract_identifiers("[obj.name]").fully_qualified?).must_equal false
+      _(extract_identifiers("[schema].[obj.name]").fully_qualified?).must_equal false
+      _(extract_identifiers("[database].[schema].[obj.name]").fully_qualified?).must_equal false
+      _(extract_identifiers("[database].[obj.name]").fully_qualified?).must_equal false
+      _(extract_identifiers("[server.name]...[obj.name]").fully_qualified?).must_equal false
+      _(extract_identifiers("[server.name].[database]..[obj.name]").fully_qualified?).must_equal false
+      _(extract_identifiers("[server.name].[database].[schema].[obj.name]").fully_qualified?).must_equal true
+      _(extract_identifiers("[server.name].[database].[schema].").fully_qualified?).must_equal true
     end
 
-    it 'can return fully qualified quoted table name' do
-      name = extract_identifiers('[my.server].db.schema.')
-      _(name.fully_qualified_database_quoted).must_equal '[my.server].[db]'
-      name = extract_identifiers('[server.name].[database].[schema].[object]')
-      _(name.fully_qualified_database_quoted).must_equal '[server.name].[database]'
-      name = extract_identifiers('server.database.schema.object')
-      _(name.fully_qualified_database_quoted).must_equal '[server].[database]'
+    it "can return fully qualified quoted table name" do
+      name = extract_identifiers("[my.server].db.schema.")
+      _(name.fully_qualified_database_quoted).must_equal "[my.server].[db]"
+      name = extract_identifiers("[server.name].[database].[schema].[object]")
+      _(name.fully_qualified_database_quoted).must_equal "[server.name].[database]"
+      name = extract_identifiers("server.database.schema.object")
+      _(name.fully_qualified_database_quoted).must_equal "[server].[database]"
     end
-
   end
 
   private
@@ -127,5 +126,4 @@ class UtilsTestSQLServer < ActiveRecord::TestCase
   def extract_identifiers(name)
     SQLServer::Utils.extract_identifiers(name)
   end
-
 end

data/test/cases/uuid_test_sqlserver.rb

@@ -1,48 +1,46 @@
 # frozen_string_literal: true
 
-require 'cases/helper_sqlserver'
+require "cases/helper_sqlserver"
 
 class SQLServerUuidTest < ActiveRecord::TestCase
-
   let(:acceptable_uuid) { ActiveRecord::ConnectionAdapters::SQLServer::Type::Uuid::ACCEPTABLE_UUID }
 
-  it 'has a uuid primary key' do
-    _(SSTestUuid.columns_hash['id'].type).must_equal :uuid
+  it "has a uuid primary key" do
+    _(SSTestUuid.columns_hash["id"].type).must_equal :uuid
     assert SSTestUuid.primary_key
   end
 
-  it 'can create with a new pk' do
+  it "can create with a new pk" do
     obj = SSTestUuid.create!
     _(obj.id).must_be :present?
     _(obj.id).must_match acceptable_uuid
   end
 
-  it 'can create other uuid column on reload' do
+  it "can create other uuid column on reload" do
     obj = SSTestUuid.create!
     obj.reload
     _(obj.other_uuid).must_match acceptable_uuid
   end
 
-  it 'can find uuid pk via connection' do
-    _(connection.primary_key(SSTestUuid.table_name)).must_equal 'id'
+  it "can find uuid pk via connection" do
+    _(connection.primary_key(SSTestUuid.table_name)).must_equal "id"
   end
 
-  it 'changing column default' do
+  it "changing column default" do
     table_name = SSTestUuid.table_name
     connection.add_column table_name, :thingy, :uuid, null: false, default: "NEWSEQUENTIALID()"
     SSTestUuid.reset_column_information
-    column = SSTestUuid.columns_hash['thingy']
+    column = SSTestUuid.columns_hash["thingy"]
     _(column.default_function).must_equal "newsequentialid()"
     # Now to a different function.
     connection.change_column table_name, :thingy, :uuid, null: false, default: "NEWID()"
     SSTestUuid.reset_column_information
-    column = SSTestUuid.columns_hash['thingy']
+    column = SSTestUuid.columns_hash["thingy"]
     _(column.default_function).must_equal "newid()"
   end
 
-  it 'can insert even when use_output_inserted to false ' do
+  it "can insert even when use_output_inserted to false " do
     obj = with_use_output_inserted_disabled { SSTestUuid.create!(name: "😢") }
     _(obj.id).must_be :nil?
   end
-
 end

data/test/debug.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 # require 'rails/all'
-require 'tiny_tds'
+require "tiny_tds"
 
 c = TinyTds::Client.new(
-  host: ENV['CI_AZURE_HOST'],
-  username: 'rails',
-  password: ENV['CI_AZURE_PASS'],
-  database: 'activerecord_unittest',
+  host: ENV["CI_AZURE_HOST"],
+  username: "rails",
+  password: ENV["CI_AZURE_PASS"],
+  database: "activerecord_unittest",
   azure: true,
-  tds_version: '7.3'
+  tds_version: "7.3"
 )
 
 puts c.execute("SELECT 1 AS [one]").each

data/test/migrations/create_clients_and_change_column_null.rb

@@ -11,7 +11,7 @@ class CreateClientsAndChangeColumnNull < ActiveRecord::Migration[5.2]
     end
 
     change_column :clients, :name, :string, limit: 15
-    change_column :clients, :code, :string, default: 'n/a'
+    change_column :clients, :code, :string, default: "n/a"
     change_column :clients, :value, :decimal, precision: 32, scale: 8
 
     change_column_null :clients, :name, false

data/test/migrations/transaction_table/1_table_will_never_be_created.rb

@@ -1,13 +1,11 @@
 # frozen_string_literal: true
 
 class TableWillNeverBeCreated < ActiveRecord::Migration
-
   def self.up
-    create_table(:sqlserver_trans_table1) {  }
-    create_table(:sqlserver_trans_table2) { raise('HELL') }
+    create_table(:sqlserver_trans_table1) {}
+    create_table(:sqlserver_trans_table2) { raise("HELL") }
   end
 
   def self.down
   end
-
 end

data/test/models/sqlserver/booking.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestBooking < ActiveRecord::Base
-  self.table_name = 'sst_bookings'
+  self.table_name = "sst_bookings"
 end

data/test/models/sqlserver/customers_view.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestCustomersView < ActiveRecord::Base
-  self.table_name = 'sst_customers_view'
+  self.table_name = "sst_customers_view"
 end

data/test/models/sqlserver/dollar_table_name.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestDollarTableName < ActiveRecord::Base
-  self.table_name = 'sst_my$strange_table'
+  self.table_name = "sst_my$strange_table"
 end

data/test/models/sqlserver/edge_schema.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
 class SSTestEdgeSchema < ActiveRecord::Base
-
-  self.table_name = 'sst_edge_schemas'
+  self.table_name = "sst_edge_schemas"
 
   def with_spaces
     read_attribute :'with spaces'
@@ -11,5 +10,4 @@ class SSTestEdgeSchema < ActiveRecord::Base
   def with_spaces=(value)
     write_attribute :'with spaces', value
   end
-
 end

data/test/models/sqlserver/fk_has_fk.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestHasFk < ActiveRecord::Base
-  self.table_name = 'sst_has_fks'
+  self.table_name = "sst_has_fks"
 end

data/test/models/sqlserver/fk_has_pk.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestHasPk < ActiveRecord::Base
-  self.table_name = 'sst_has_pks'
+  self.table_name = "sst_has_pks"
 end

data/test/models/sqlserver/natural_pk_data.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 class SSTestNaturalPkData < ActiveRecord::Base
-  self.table_name = 'sst_natural_pk_data'
-  self.primary_key = 'legacy_id'
+  self.table_name = "sst_natural_pk_data"
+  self.primary_key = "legacy_id"
 end

data/test/models/sqlserver/natural_pk_int_data.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestNaturalPkIntData < ActiveRecord::Base
-  self.table_name = 'sst_natural_pk_int_data'
+  self.table_name = "sst_natural_pk_int_data"
 end

data/test/models/sqlserver/no_pk_data.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestNoPkData < ActiveRecord::Base
-  self.table_name = 'sst_no_pk_data'
+  self.table_name = "sst_no_pk_data"
 end

data/test/models/sqlserver/object_default.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestObjectDefault < ActiveRecord::Base
-  self.table_name = 'sst_defaultobjects'
+  self.table_name = "sst_defaultobjects"
 end

data/test/models/sqlserver/quoted_table.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 class SSTestQuotedTable < ActiveRecord::Base
-  self.table_name = '[sst_quoted-table]'
+  self.table_name = "[sst_quoted-table]"
 end
 
 class SSTestQuotedTableUser < ActiveRecord::Base
-  self.table_name = '[dbo].[sst_quoted-table]'
+  self.table_name = "[dbo].[sst_quoted-table]"
 end

data/test/models/sqlserver/quoted_view_1.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SSTestQuotedView1 < ActiveRecord::Base
-  self.table_name = 'sst_quoted-view1'
+  self.table_name = "sst_quoted-view1"
 end