activerecord-sqlserver-adapter 5.2.0.rc2 → 6.0.0

data/lib/active_record/connection_adapters/sqlserver/type/data.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Data
-
           attr_reader :value, :type
 
           def initialize(value, type)
@@ -27,7 +28,6 @@ module ActiveRecord
             self.class == other.class && self.value == other.value
           end
           alias :== :eql?
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/date.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Date < ActiveRecord::Type::Date
-
           def sqlserver_type
-            'date'.freeze
+            "date"
           end
 
           def serialize(value)
             return unless value.present?
+
             date = super(value).to_s(:_sqlserver_dateformat)
             Data.new date, self
           end
@@ -37,7 +39,6 @@ module ActiveRecord
           def fast_string_to_date_format
             ::Date::DATE_FORMATS[:_sqlserver_dateformat]
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/datetime.rb

@@ -1,22 +1,22 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class DateTime < ActiveRecord::Type::DateTime
-
           include TimeValueFractional
 
           def sqlserver_type
-            'datetime'.freeze
+            "datetime"
           end
 
           def serialize(value)
             value = super
             return value unless value.acts_like?(:time)
-            datetime = value.to_s(:_sqlserver_datetime).tap do |v|
-              fraction = quote_fractional(value)
-              v << ".#{fraction}"
-            end
+
+            datetime = "#{value.to_s(:_sqlserver_datetime)}.#{quote_fractional(value)}"
+
             Data.new datetime, self
           end
 
@@ -35,7 +35,7 @@ module ActiveRecord
           private
 
           def fast_string_to_time(string)
-            time = ActiveSupport::TimeZone['UTC'].strptime(string, fast_string_to_time_format)
+            time = ActiveSupport::TimeZone["UTC"].strptime(string, fast_string_to_time_format)
             new_time(time.year, time.month, time.day, time.hour,
                      time.min, time.sec, Rational(time.nsec, 1_000))
           rescue ArgumentError
@@ -43,7 +43,7 @@ module ActiveRecord
           end
 
           def fast_string_to_time_format
-            "#{::Time::DATE_FORMATS[:_sqlserver_datetime]}.%N".freeze
+            "#{::Time::DATE_FORMATS[:_sqlserver_datetime]}.%N"
           end
         end
       end

data/lib/active_record/connection_adapters/sqlserver/type/datetime2.rb

@@ -1,15 +1,15 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class DateTime2 < DateTime
-
           include TimeValueFractional2
 
           def sqlserver_type
             "datetime2(#{precision.to_i})"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/datetimeoffset.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class DateTimeOffset < DateTime2
-
           def type
             :datetimeoffset
           end
@@ -15,7 +16,6 @@ module ActiveRecord
           def quoted(value)
             Utils.quote_string_single(value)
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/decimal.rb

@@ -1,19 +1,20 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Decimal < ActiveRecord::Type::Decimal
-
           def sqlserver_type
-            'decimal'.tap do |type|
-              type << "(#{precision.to_i},#{scale.to_i})" if precision || scale
+            "decimal".yield_self do |type|
+              type += "(#{precision.to_i},#{scale.to_i})" if precision || scale
+              type
             end
           end
 
           def type_cast_for_schema(value)
             value.is_a?(BigDecimal) ? value.to_s : value.inspect
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/float.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Float < ActiveRecord::Type::Float
-
           def type
             :float
           end
 
           def sqlserver_type
-            'float'.freeze
+            "float"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/integer.rb

@@ -1,13 +1,13 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Integer < ActiveRecord::Type::Integer
-
           def sqlserver_type
-            'int'.freeze
+            "int"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/json.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Json < ActiveRecord::Type::Json
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/money.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Money < Decimal
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @precision = 19
             @scale = 4
@@ -15,9 +16,8 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'money'.freeze
+            "money"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/real.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Real < Float
-
           def type
             :real
           end
 
           def sqlserver_type
-            'real'.freeze
+            "real"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/small_integer.rb

@@ -1,13 +1,13 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class SmallInteger < Integer
-
           def sqlserver_type
-            'smallint'.freeze
+            "smallint"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/small_money.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class SmallMoney < Money
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @precision = 10
             @scale = 4
@@ -15,9 +16,8 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'smallmoney'.freeze
+            "smallmoney"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/smalldatetime.rb

@@ -1,15 +1,16 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class SmallDateTime < DateTime
-
           def type
             :smalldatetime
           end
 
           def sqlserver_type
-            'smalldatetime'.freeze
+            "smalldatetime"
           end
 
           private
@@ -21,7 +22,6 @@ module ActiveRecord
           def apply_seconds_precision(value)
             value.change usec: 0 if value
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/string.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class String < ActiveRecord::Type::String
-
           def changed_in_place?(raw_old_value, new_value)
             if raw_old_value.is_a?(Data)
               raw_old_value.value != new_value
@@ -11,7 +12,6 @@ module ActiveRecord
               super
             end
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/text.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Text < VarcharMax
-
           def type
             :text_basic
           end
 
           def sqlserver_type
-            'text'.freeze
+            "text"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/time.rb

@@ -1,18 +1,18 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Time < ActiveRecord::Type::Time
-
           include TimeValueFractional2
 
           def serialize(value)
             value = super
             return value unless value.acts_like?(:time)
-            time = value.to_s(:_sqlserver_time).tap do |v|
-              fraction = quote_fractional(value)
-              v << ".#{fraction}"
-            end
+
+            time = "#{value.to_s(:_sqlserver_time)}.#{quote_fractional(value)}"
+
             Data.new time, self
           end
 
@@ -37,6 +37,7 @@ module ActiveRecord
           def cast_value(value)
             value = super
             return if value.blank?
+
             value = value.change year: 2000, month: 01, day: 01
             apply_seconds_precision(value)
           end
@@ -44,7 +45,6 @@ module ActiveRecord
           def fractional_scale
             precision
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/time_value_fractional.rb

@@ -1,19 +1,21 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
-
         module TimeValueFractional
-
           private
 
           def apply_seconds_precision(value)
             return value if !value.respond_to?(fractional_property) || value.send(fractional_property).zero?
+
             value.change fractional_property => seconds_precision(value)
           end
 
           def seconds_precision(value)
             return 0 if fractional_scale == 0
+
             seconds = value.send(fractional_property).to_f / fractional_operator.to_f
             seconds = ((seconds * (1 / fractional_precision)).round / (1 / fractional_precision)).round(fractional_scale)
             (seconds * fractional_operator).round(0).to_i
@@ -21,9 +23,10 @@ module ActiveRecord
 
           def quote_fractional(value)
             return 0 if fractional_scale == 0
+
             frac_seconds = seconds_precision(value)
             seconds = (frac_seconds.to_f / fractional_operator.to_f).round(fractional_scale)
-            seconds.to_d.to_s.split('.').last.to(fractional_scale-1)
+            seconds.to_d.to_s.split(".").last.to(fractional_scale - 1)
           end
 
           def fractional_property
@@ -35,7 +38,7 @@ module ActiveRecord
           end
 
           def fractional_operator
-            10 ** fractional_digits
+            10**fractional_digits
           end
 
           def fractional_precision
@@ -45,11 +48,9 @@ module ActiveRecord
           def fractional_scale
             3
           end
-
         end
 
         module TimeValueFractional2
-
           include TimeValueFractional
 
           private
@@ -80,11 +81,9 @@ module ActiveRecord
           end
 
           def fractional_scale_max
-            ('9' * fractional_scale) + ('0' * (fractional_digits - fractional_scale))
+            ("9" * fractional_scale) + ("0" * (fractional_digits - fractional_scale))
           end
-
         end
-
       end
     end
   end