activerecord-sqlserver-adapter 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b5143ee7d732b5af4ef584e9d462d1bce08ab112
-  data.tar.gz: f117c34a2a6ffaa6a156e3ce513e0767f2f53d21
+  metadata.gz: b31a0ea33247aafc00f6d836c4de3a1c76dca176
+  data.tar.gz: a66c59a131675c4cf381717e00e5211c4263fe7b
 SHA512:
-  metadata.gz: 2ecdf97d6de086bbd9c2dbd0762f02c79bd190d788a947639db5cc24d10236a458936068a6259e0dcdf44f3f0924149b3472eb90e37745a1958e9c0d0ddc51b2
-  data.tar.gz: 25de68a67a59689818cdd60ba13ba36598fff1be2b06194c68d481335c9c26af13cd8a021e6e54df677cf9d02e8a363db4b8549af0dbbf54ba408093ef38fb2e
+  metadata.gz: b6a8fc99daef2bbd923eb5aa7ccee8f1dcdab3dcd4b3edbda58242201ae93a4cd5bf453996a568a8af847c0f72ec230df0b06185bdc70eeb4981c184656e7bb7
+  data.tar.gz: 3a68c7e45dd613fc89901d61cf1ab82cd3cc02cda3f93d2f37f95ff52d3f9ea8aed0d2dad61faf552996c5355fc53a457b020f55b277f4a0f2e096eb55a83701

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## v5.0.1
+
+#### Changed
+
+* Set `tds_version` fallback to `7.3`.
+
+#### Fixed
+
+* Support 2014, 2012 drop table statement.
+
 
 ## v5.0.0
 

data/Gemfile

@@ -3,7 +3,7 @@ gemspec
 
 gem 'sqlite3'
 gem 'minitest', '< 5.3.4'
-gem 'bcrypt', platforms: [:mri]
+gem 'bcrypt'
 gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
 
 if RbConfig::CONFIG["host_os"] =~ /darwin/

data/README.md

@@ -7,95 +7,19 @@
 * [![Gem Version](http://img.shields.io/gem/v/activerecord-sqlserver-adapter.svg)](https://rubygems.org/gems/activerecord-sqlserver-adapter) - Gem Version
 * [![Gitter chat](https://img.shields.io/badge/%E2%8A%AA%20GITTER%20-JOIN%20CHAT%20%E2%86%92-brightgreen.svg?style=flat)](https://gitter.im/rails-sqlserver/activerecord-sqlserver-adapter) - Community
 
-## RAILS v5 COMING!!!
 
-2017-01-04 - All core adapter tests are passing on Rails v5. We have ~60 failures under the full AcitveRecord suite. At this time, the foundation of the adapter is considered to be solid and the remaining tests will not likely require any refactors of the adapter internals.
+The SQL Server adapter for ActiveRecord v5.0 using SQL Server 2012 or higher.
 
-This means you can technically bundle to the adapter's master branch and work with Rails 5. However, but reports should not be given till we have a release and pass all ActiveRecord tests. Please follow the `RAILS5-TODO.md` and `RAILS5-FAILS.txt` notes before filing issues.
-
-* [RAILS5-TODO.md](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/master/RAILS5-TODO.md)
-* [RAILS5-FAILS.txt](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/master/RAILS5-FAILS.txt)
-* [All Rails 5.0 Issues - Closed](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues?q=label%3A%22Rails+5.0%22+is%3Aclosed)
-* [All Rails 5.0 Issues - Open](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/labels/Rails%205.0)
-
-* **Can I help?** - Thanks so much! Feel free to jump in. I suggest chatting on Gitter or GitHub to make sure we are not dupliating work.
-* **What is the ETA of an initial release?** - My guess is that we can have an initial release by mid January easily.
-
-
-#### Using Rails v4
-
-Use these commands to use the latest of Rails v4 till our v5 release is ready.
-
-```shell
-$ gem install rails -v 4.2.7.1
-$ rails _4.2.7.1_ new MYAPP --database=sqlserver
-```
-
-![kantishna-wide](https://cloud.githubusercontent.com/assets/2381/5895051/aa6a57e0-a4e1-11e4-95b9-23627af5876a.jpg)
-
-## Code Name Kantishna
-
-The SQL Server adapter for ActiveRecord v4.2 using SQL Server 2012 or higher.
-
-Interested in older versions? We follow a rational versioning policy that tracks Rails. That means that our 4.2.x version of the adapter is only for the latest 4.2 version of Rails. If you need the adapter for SQL Server 2008 or 2005, you are still in the right spot. Just install the latest 3.2.x to 4.1.x version of the adapter that matches your Rails version. We also have stable branches for each major/minor release of ActiveRecord.
-
-
-#### Executing Stored Procedures
-
-Every class that sub classes ActiveRecord::Base will now have an execute_procedure class method to use. This method takes the name of the stored procedure which can be a string or symbol and any number of variables to pass to the procedure. Arguments will automatically be quoted per the connection's standards as normal. For example:
-
-```ruby
-Account.execute_procedure :update_totals, 'admin', nil, true
-# Or with named parameters.
-Account.execute_procedure :update_totals, named: 'params'
-```
+Interested in older versions? We follow a rational versioning policy that tracks Rails. That means that our 5.0.x version of the adapter is only for the latest 5.0 version of Rails. If you need the adapter for SQL Server 2008 or 2005, you are still in the right spot. Just install the latest 3.2.x to 4.1.x version of the adapter that matches your Rails version. We also have stable branches for each major/minor release of ActiveRecord.
 
 
 #### Native Data Type Support
 
-We support every data type supported by FreeTDS and then a few more. All simplified Rails types in migrations will coorespond to a matching SQL Server national (unicode) data type. Here is a basic chart. Always check the `initialize_native_database_types` method for an updated list.
-
-```ruby
-integer:        { name: 'int', limit: 4 }
-bigint:         { name: 'bigint' }
-boolean:        { name: 'bit' }
-decimal:        { name: 'decimal' }
-money:          { name: 'money' }
-smallmoney:     { name: 'smallmoney' }
-float:          { name: 'float' }
-real:           { name: 'real' }
-date:           { name: 'date' }
-datetime:       { name: 'datetime' }
-datetime2:      { name: 'datetime2', precision: 7 }
-datetimeoffset: { name: 'datetimeoffset', precision: 7 }
-smalldatetime:  { name: 'smalldatetime' }
-timestamp:      { name: 'datetime' }
-time:           { name: 'time' }
-char:           { name: 'char' }
-varchar:        { name: 'varchar', limit: 8000 }
-varchar_max:    { name: 'varchar(max)' }
-text_basic:     { name: 'text' }
-nchar:          { name: 'nchar' }
-string:         { name: 'nvarchar', limit: 4000 }
-text:           { name: 'nvarchar(max)' }
-ntext:          { name: 'ntext' }
-binary_basic:   { name: 'binary' }
-varbinary:      { name: 'varbinary', limit: 8000 }
-binary:         { name: 'varbinary(max)' }
-uuid:           { name: 'uniqueidentifier' }
-ss_timestamp:   { name: 'timestamp' }
-```
-
-The following types require TDS version 7.3 with TinyTDS. This requires the latest FreeTDS v0.95 or higher.
+We support every data type supported by FreeTDS. All simplified Rails types in migrations will coorespond to a matching SQL Server national (unicode) data type. Always check the `initialize_native_database_types` [(here)](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/master/lib/active_record/connection_adapters/sqlserver/schema_statements.rb#L243) for an updated list.
 
-* date
-* datetime2
-* datetimeoffset
-* time
+The following types (date, datetime2, datetimeoffset, time) all require TDS version 7.3 with TinyTDS. We recommend using FreeTDS 1.0 or higher which default to using `TDSVER` to "7.3". The adapter also sets TinyTDS's `tds_version` to this as well if non is specified.
 
-Set `tds_version` in your database.yml or the `TDSVER` environment variable to `7.3` to ensure you are using the proper protocol version till 7.3 becomes the default.
-
-**Zone Conversion** - The `[datetimeoffset]` type is the only ActiveRecord time based datatype that does not cast the zone to ActiveRecord's default - typically UTC. As intended, this datatype is meant to maintain the zone you pass to it and/or retreived from the database.
+The Rails v5 adapter supports ActiveRecord's `datetime_with_precision` setting. This means that passing `:precision` to a datetime column is supported. Using a pecision with the `:datetime` type will signal the adapter to use the `datetime2` type under the hood.
 
 
 #### Force Schema To Lowercase
@@ -138,6 +62,16 @@ module ActiveRecord
 end
 ```
 
+#### Executing Stored Procedures
+
+Every class that sub classes ActiveRecord::Base will now have an execute_procedure class method to use. This method takes the name of the stored procedure which can be a string or symbol and any number of variables to pass to the procedure. Arguments will automatically be quoted per the connection's standards as normal. For example:
+
+```ruby
+Account.execute_procedure :update_totals, 'admin', nil, true
+# Or with named parameters.
+Account.execute_procedure :update_totals, named: 'params'
+```
+
 #### Explain Support (SHOWPLAN)
 
 The 3.2 version of the adapter support ActiveRecord's explain features. In SQL Server, this is called the showplan. By default we use the `SHOWPLAN_ALL` option and format it using a simple table printer. So the following ruby would log the plan table below it.
@@ -170,18 +104,13 @@ ActiveRecord::ConnectionAdapters::SQLServerAdapter.showplan_option = 'SHOWPLAN_X
 **NOTE:** The method we utilize to make SHOWPLANs work is very brittle to complex SQL. There is no getting around this as we have to deconstruct an already prepared statement for the sp_executesql method. If you find that explain breaks your app, simple disable it. Do not open a github issue unless you have a patch.  Please [consult the Rails guides](http://guides.rubyonrails.org/active_record_querying.html#running-explain) for more info.
 
 
-## Versions
-
-The adapter follows a rational versioning policy that also tracks ActiveRecord's major and minor version. That means the latest 3.1.x version of the adapter will always work for the latest 3.1.x version of ActiveRecord.
-
-
 ## Installation
 
 The adapter has no strict gem dependencies outside of ActiveRecord. You will have to pick a connection mode, the default is dblib which uses the TinyTDS gem. Just bundle the gem and the adapter will use it.
 
 ```ruby
 gem 'tiny_tds'
-gem 'activerecord-sqlserver-adapter', '~> 4.2.0'
+gem 'activerecord-sqlserver-adapter'
 ```
 
 
@@ -199,6 +128,7 @@ Many many people have contributed. If you do not see your name here and it shoul
 
 
 ## Contributers
+
 Up-to-date list of contributors: http://github.com/rails-sqlserver/activerecord-sqlserver-adapter/contributors
 
 * metaskills (Ken Collins)
@@ -221,5 +151,5 @@ Up-to-date list of contributors: http://github.com/rails-sqlserver/activerecord-
 
 ## License
 
-Copyright © 2008-2016. It is free software, and may be redistributed under the terms specified in the MIT-LICENSE file.
+Copyright © 2008-2017. It is free software, and may be redistributed under the terms specified in the MIT-LICENSE file.
 

data/VERSION

@@ -1 +1 @@
-5.0.0
+5.0.1

data/appveyor.yml

@@ -12,6 +12,8 @@ install:
   - ruby --version
   - gem --version
   - bundle install
+  - gem uninstall bcrypt
+  - gem install bcrypt --platform=ruby
 build: off
 test_script:
   - powershell -File "%APPVEYOR_BUILD_FOLDER%\test\appveyor\dbsetup.ps1"

data/lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -42,6 +42,14 @@ module ActiveRecord
           res
         end
 
+        def drop_table(table_name, options = {})
+          if options[:if_exists] && @version_year != 2016
+            execute "IF EXISTS(SELECT * FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = #{quote(table_name)}) DROP TABLE #{quote_table_name(table_name)}"
+          else
+            super
+          end
+        end
+
         def indexes(table_name, name = nil)
           data = select("EXEC sp_helpindex #{quote(table_name)}", name) rescue []
           data.reduce([]) do |indexes, index|

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -339,6 +339,7 @@ module ActiveRecord
                         dblib_connect(config)
                       end
         @spid = _raw_select('SELECT @@SPID', fetch: :rows).first.first
+        @version_year = version_year
         configure_connection
       end
 
@@ -356,7 +357,7 @@ module ActiveRecord
           username: config[:username],
           password: config[:password],
           database: config[:database],
-          tds_version: config[:tds_version],
+          tds_version: config[:tds_version] || '7.3',
           appname: config_appname(config),
           login_timeout: config_login_timeout(config),
           timeout: config_timeout(config),
@@ -415,6 +416,13 @@ module ActiveRecord
         }
       end
 
+      def version_year
+        vstring = _raw_select('SELECT @@version', fetch: :rows).first.first.to_s
+        /SQL Server (\d+)/.match(vstring).to_a.last.to_s.to_i
+      rescue Exception => e
+        2016
+      end
+
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - Ken Collins
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-16 00:00:00.000000000 Z
+date: 2017-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord