activerecord-sqlserver-adapter 4.2.2 → 4.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5811725caa7db8c0ded035b59882c3e2826b6a6
-  data.tar.gz: 0637b1351f167da700e236db923a624fe0a35a98
+  metadata.gz: 1c8606998a19306cd6a40b95820dcfc2f1f84982
+  data.tar.gz: 1890a0231b4a9c1e3545b5171d0e84fa2461d72a
 SHA512:
-  metadata.gz: bfef051e6a63017c57bd179dfebb7d04ab612b1a008caabe86b7a2281093a713aa302781a17f9f735f6da8ae046ebd9f9648244aa50f1ce1569ce4e518e99a6b
-  data.tar.gz: d0e8537fbc6a3be2f406e18ac6aa64e9e5e2eec51d0aaaed57469104bdb98652cff1b8647d7f0e6d913422273463143ff7e3ba4fc315bcf90211f5436a5eb2fb
+  metadata.gz: 13d82553f8f91bfd76b755b925b3098b3882ed0921288ef9cf117d9edd68f60cd981d984e2d4831a51b64b0737a2d39f7b879a27b77e4746f9a9b61db76bc56d
+  data.tar.gz: c06d4c021c47236b83d79a132a19e72b89f7fc7fcb4dcd62751a63c858eafb8a28f9c4d01f566abcddb75a32dcb8229f29b9a874d6fbbd3afa7e5fd1c8ae9eff

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v4.2.3
+
+* Fix SET defaults when using Azure.
+* Test insert 4-byte unicode chars.
+* Make rollback transaction transcount aware for implicit error rollbacks. Fixes #390
+
 
 ## v4.2.2
 

data/lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -66,7 +66,7 @@ module ActiveRecord
         end
 
         def rollback_db_transaction
-          do_execute 'ROLLBACK TRANSACTION'
+          do_execute 'IF @@TRANCOUNT > 0 ROLLBACK TRANSACTION'
         end
 
         include Savepoints

data/lib/active_record/connection_adapters/sqlserver/version.rb

@@ -3,7 +3,7 @@ module ActiveRecord
     module SQLServer
       module Version
 
-        VERSION = '4.2.2'
+        VERSION = '4.2.3'
 
       end
     end

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -297,7 +297,7 @@ module ActiveRecord
             client.execute('SET ANSI_NULL_DFLT_ON ON').do
             client.execute('SET IMPLICIT_TRANSACTIONS OFF').do
             client.execute('SET ANSI_PADDING ON').do
-            client.execute('SET QUOTED_IDENTIFIER ON')
+            client.execute('SET QUOTED_IDENTIFIER ON').do
             client.execute('SET ANSI_WARNINGS ON').do
           else
             client.execute('SET ANSI_DEFAULTS ON').do

data/test/cases/helper_sqlserver.rb

@@ -33,6 +33,13 @@ module ActiveRecord
       ActiveRecord::Base.connection
     end
 
+    def with_use_output_inserted_disabled
+      ActiveRecord::ConnectionAdapters::SQLServerAdapter.use_output_inserted = false
+      yield
+    ensure
+      ActiveRecord::ConnectionAdapters::SQLServerAdapter.use_output_inserted = true
+    end
+
   end
 end
 

data/test/cases/transaction_test_sqlserver.rb

@@ -1,3 +1,4 @@
+# encoding: UTF-8
 require 'cases/helper_sqlserver'
 require 'models/ship'
 require 'models/developer'

data/test/cases/uuid_test_sqlserver.rb

@@ -1,3 +1,4 @@
+# encoding: UTF-8
 require 'cases/helper_sqlserver'
 
 class SQLServerUuidTest < ActiveRecord::TestCase
@@ -10,6 +11,7 @@ class SQLServerUuidTest < ActiveRecord::TestCase
   end
 
   it 'can create with a new pk' do
+    # Type::Uuid::ACCEPTABLE_UUID
     obj = SSTestUuid.create!
     obj.id.must_be :present?
     obj.id.must_match acceptable_uuid
@@ -38,4 +40,9 @@ class SQLServerUuidTest < ActiveRecord::TestCase
     column.default_function.must_equal "newid()"
   end
 
+  it 'can insert even when use_output_inserted to false ' do
+    obj = with_use_output_inserted_disabled { SSTestUuid.create!(name: "😢") }
+    obj.id.must_be :nil?
+  end
+
 end

data/test/config.yml

@@ -10,6 +10,7 @@ default_connection_info: &default_connection_info
   password: <%= ENV['ACTIVERECORD_UNITTEST_PASS'] || '' %>
   azure: <%= !ENV['ACTIVERECORD_UNITTEST_AZURE'].nil? %>
   collation: <%= ENV['ACTIVERECORD_UNITTEST_COLLATION'] || nil %>
+  encoding: utf8
 
 connections:
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 4.2.2
+  version: 4.2.3
 platform: ruby
 authors:
 - Ken Collins
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-02 00:00:00.000000000 Z
+date: 2015-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord