activerecord-spanner-adapter 1.6.2 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2daeef21393399532473625549d008d1a4cfcf791be1a347c98909c3e3973dde
-  data.tar.gz: 16caacb8cde7a9dfd2d2e22a8500d9a25b21f22fe392bb3c2631af892d35168a
+  metadata.gz: e521009bd7ee056c90e4147edd3e6dfe012e7808abf8dcf2b9a0145f380d669d
+  data.tar.gz: 9be31f9f418a9ca5f80531924bc299a75c64826d09989c7318aff88eaccf8a41
 SHA512:
-  metadata.gz: da334e1c10da6bbd60c6ececee046889b33e045df31838b8a0939f56cf93240b44c20002aa2b61bbcb6b961907b1f1ed73aa0fc9de8b1283faef427db84fce94
-  data.tar.gz: 52c05cfca494e311aa7049591a2258acf93880434d548834667742440ba9a7ddc283183dedb16227fc5b469fbc2b1cd50ed333c30f86e6f2fda0bf3ae1473e72
+  metadata.gz: a529d5691fdcecc54e6a090a807c5b5ff561aa2a355d268a605c91b54705a9a093544129da76df2bb5341953a55dfac792be77079aa1b63121260eb8ed9559c3
+  data.tar.gz: 0f6be5f7de6113d16ce2f5e0474924ee4af6bdf3599c84050382f5c47a64f24876b656522e57ebb1e35742e6154221174b0a1e7487fa82034a5a4a5acfa527c2

data/.github/workflows/acceptance-tests-on-emulator.yaml

@@ -18,16 +18,14 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: ["2.7", "3.0", "3.1", "3.2"]
-        ar: ["~> 6.0.6", "~> 6.1.7", "~> 7.0.4", "~> 7.1.0"]
+        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3"]
+        ar: ["~> 6.1.0", "~> 7.0.0", "~> 7.1.0", "~> 7.2.0"]
         # Exclude combinations that are not supported.
         exclude:
+          - ruby: "2.7"
+            ar: "~> 7.2.0"
           - ruby: "3.0"
-            ar: "~> 6.0.6"
-          - ruby: "3.1"
-            ar: "~> 6.0.6"
-          - ruby: "3.2"
-            ar: "~> 6.0.6"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

data/.github/workflows/acceptance-tests-on-production.yaml

@@ -24,7 +24,7 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: [3.0]
+        ruby: [3.3]
     steps:
     - uses: actions/checkout@v4
     - name: Set up Ruby

data/.github/workflows/ci.yaml

@@ -10,16 +10,14 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: ["2.7", "3.0", "3.1", "3.2"]
-        ar: ["~> 6.0.6", "~> 6.1.7", "~> 7.0.4", "~> 7.1.0"]
+        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3"]
+        ar: ["~> 6.1.0", "~> 7.0.0", "~> 7.1.0", "~> 7.2.0"]
         # Exclude combinations that are not supported.
         exclude:
+          - ruby: "2.7"
+            ar: "~> 7.2.0"
           - ruby: "3.0"
-            ar: "~> 6.0.6"
-          - ruby: "3.1"
-            ar: "~> 6.0.6"
-          - ruby: "3.2"
-            ar: "~> 6.0.6"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

data/.github/workflows/nightly-acceptance-tests-on-emulator.yaml

@@ -18,41 +18,14 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        # Run acceptance tests all supported combinations of Ruby and ActiveRecord.
-        ruby: [2.7, 3.0, 3.1, 3.2]
-        ar: [6.0.0, 6.0.1, 6.0.2.2, 6.0.3.7, 6.0.4, 6.1.3.2, 6.1.4.7, 6.1.5.1, 6.1.6.1, 7.0.2.4, 7.0.3.1, 7.0.4, 7.0.5, 7.0.6, 7.0.7, 7.1.0, 7.1.1, 7.1.2]
+        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3"]
+        ar: ["~> 6.1.0", "~> 7.0.0", "~> 7.1.0", "~> 7.2.0"]
         # Exclude combinations that are not supported.
         exclude:
-          - ruby: 3.0
-            ar: 6.0.0
-          - ruby: 3.0
-            ar: 6.0.1
-          - ruby: 3.0
-            ar: 6.0.2.2
-          - ruby: 3.0
-            ar: 6.0.3.7
-          - ruby: 3.0
-            ar: 6.0.4
-          - ruby: 3.1
-            ar: 6.0.0
-          - ruby: 3.1
-            ar: 6.0.1
-          - ruby: 3.1
-            ar: 6.0.2.2
-          - ruby: 3.1
-            ar: 6.0.3.7
-          - ruby: 3.1
-            ar: 6.0.4
-          - ruby: 3.2
-            ar: 6.0.0
-          - ruby: 3.2
-            ar: 6.0.1
-          - ruby: 3.2
-            ar: 6.0.2.2
-          - ruby: 3.2
-            ar: 6.0.3.7
-          - ruby: 3.2
-            ar: 6.0.4
+          - ruby: "2.7"
+            ar: "~> 7.2.0"
+          - ruby: "3.0"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

data/.github/workflows/nightly-acceptance-tests-on-production.yaml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: [3.0]
+        ruby: [3.3]
     steps:
     - uses: actions/checkout@v4
     - name: Set up Ruby

data/.github/workflows/nightly-unit-tests.yaml

@@ -10,41 +10,15 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        # Run unit tests all supported combinations of Ruby and ActiveRecord.
-        ruby: [2.7, 3.0, 3.1, 3.2]
-        ar: [6.0.0, 6.0.1, 6.0.2.2, 6.0.3.7, 6.0.4, 6.1.3.2, 6.1.4.7, 6.1.5.1, 6.1.6.1, 7.0.2.4, 7.0.3.1, 7.0.4, 7.0.5, 7.1.0, 7.1.1, 7.1.2]
+        # Run acceptance tests all supported combinations of Ruby and ActiveRecord.
+        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3"]
+        ar: ["~> 6.1.0", "~> 7.0.0", "~> 7.1.0", "~> 7.2.0"]
         # Exclude combinations that are not supported.
         exclude:
-          - ruby: 3.0
-            ar: 6.0.0
-          - ruby: 3.0
-            ar: 6.0.1
-          - ruby: 3.0
-            ar: 6.0.2.2
-          - ruby: 3.0
-            ar: 6.0.3.7
-          - ruby: 3.0
-            ar: 6.0.4
-          - ruby: 3.1
-            ar: 6.0.0
-          - ruby: 3.1
-            ar: 6.0.1
-          - ruby: 3.1
-            ar: 6.0.2.2
-          - ruby: 3.1
-            ar: 6.0.3.7
-          - ruby: 3.1
-            ar: 6.0.4
-          - ruby: 3.2
-            ar: 6.0.0
-          - ruby: 3.2
-            ar: 6.0.1
-          - ruby: 3.2
-            ar: 6.0.2.2
-          - ruby: 3.2
-            ar: 6.0.3.7
-          - ruby: 3.2
-            ar: 6.0.4
+          - ruby: "2.7"
+            ar: "~> 7.2.0"
+          - ruby: "3.0"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

data/.kokoro/populate-secrets.sh

@@ -24,6 +24,10 @@ function msg { println "$*" >&2 ;}
 function println { printf '%s\n' "$(now) $*" ;}
 
 # Populates requested secrets set in SECRET_MANAGER_KEYS
+if [[ -z "${SECRET_MANAGER_PROJECT_ID-}" ]]; then
+  msg "SECRET_MANAGER_PROJECT_ID is not set in environment variables, using default"
+  SECRET_MANAGER_PROJECT_ID="cloud-devrel-kokoro-resources"
+fi
 
 # In Kokoro CI builds, we use the service account attached to the
 # Kokoro VM. This means we need to setup auth on other CI systems.
@@ -65,7 +69,7 @@ do
     msg "Retrieving secret ${key}"
     "${GCLOUD_COMMANDS[@]}" \
         secrets versions access latest \
-        --project cloud-devrel-kokoro-resources \
+        --project "${SECRET_MANAGER_PROJECT_ID}" \
         --secret $key > \
         "$SECRET_LOCATION/$key"
     if [[ $? == 0 ]]; then

data/.kokoro/release.cfg

@@ -7,19 +7,13 @@ action {
   }
 }
 
-# Download resources for system tests (service account key, etc.)
-gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-ruby"
-
-# Download trampoline resources.
-gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline"
-
 # Use the trampoline script to run in docker.
 build_file: "ruby-spanner-activerecord/.kokoro/trampoline_v2.sh"
 
 # Configure the docker image for kokoro-trampoline.
 env_vars: {
   key: "TRAMPOLINE_IMAGE"
-  value: "gcr.io/cloud-devrel-kokoro-resources/yoshi-ruby/release"
+  value: "us-central1-docker.pkg.dev/cloud-sdk-release-custom-pool/release-images/ruby-multi"
 }
 
 env_vars: {
@@ -27,16 +21,32 @@ env_vars: {
   value: ".kokoro/release.sh"
 }
 
+env_vars: {
+  key: "SECRET_MANAGER_PROJECT_ID"
+  value: "cloud-sdk-release-custom-pool"
+}
+
 env_vars: {
   key: "SECRET_MANAGER_KEYS"
   value: "releasetool-publish-reporter-app,releasetool-publish-reporter-googleapis-installation,releasetool-publish-reporter-pem,docuploader_service_account"
 }
 
+# Pick up Rubygems key from internal keystore
+before_action {
+  fetch_keystore {
+    keystore_resource {
+      keystore_config_id: 73713
+      keyname: "rubygems-publish-key"
+      backend: "blade:keystore-fastconfigpush"
+    }
+  }
+}
+
 # Store the packages uploaded to rubygems.org, which
 # we can later use to generate SBOMs and attestations.
 action {
- define_artifacts {
-   regex: "github/ruby-spanner-activerecord/pkg/*.gem"
-   strip_prefix: "github"
- }
-}
+  define_artifacts {
+    regex: "github/ruby-spanner-activerecord/pkg/*.gem"
+    strip_prefix: "github"
+  }
+}

data/.kokoro/trampoline_v2.sh

@@ -138,18 +138,26 @@ if [[ -n "${KOKORO_BUILD_ID:-}" ]]; then
     RUNNING_IN_CI="true"
     TRAMPOLINE_CI="kokoro"
     if [[ "${TRAMPOLINE_USE_LEGACY_SERVICE_ACCOUNT:-}" == "true" ]]; then
-	if [[ ! -f "${KOKORO_GFILE_DIR}/kokoro-trampoline.service-account.json" ]]; then
-	    log_red "${KOKORO_GFILE_DIR}/kokoro-trampoline.service-account.json does not exist. Did you forget to mount cloud-devrel-kokoro-resources/trampoline? Aborting."
-	    exit 1
-	fi
-	# This service account will be activated later.
-	TRAMPOLINE_SERVICE_ACCOUNT="${KOKORO_GFILE_DIR}/kokoro-trampoline.service-account.json"
+        if [[ ! -f "${KOKORO_GFILE_DIR}/kokoro-trampoline.service-account.json" ]]; then
+            log_red "${KOKORO_GFILE_DIR}/kokoro-trampoline.service-account.json does not exist. Did you forget to mount cloud-devrel-kokoro-resources/trampoline? Aborting."
+            exit 1
+        fi
+        # This service account will be activated later.
+        TRAMPOLINE_SERVICE_ACCOUNT="${KOKORO_GFILE_DIR}/kokoro-trampoline.service-account.json"
     else
-	if [[ "${TRAMPOLINE_VERBOSE:-}" == "true" ]]; then
-	    gcloud auth list
-	fi
-	log_yellow "Configuring Container Registry access"
-	gcloud auth configure-docker --quiet
+        if [[ "${TRAMPOLINE_VERBOSE:-}" == "true" ]]; then
+            gcloud auth list
+        fi
+        log_yellow "Configuring Container Registry access"
+        TRAMPOLINE_HOST=$(echo "${TRAMPOLINE_IMAGE}" | cut -d/ -f1)
+        if [[ ! "${TRAMPOLINE_HOST}" =~ "gcr.io" ]]; then
+            # If you need to specificy a host other than gcr.io, you have to run on an update version of gcloud.
+            echo "TRAMPOLINE_HOST: ${TRAMPOLINE_HOST}"
+            gcloud components update
+            gcloud auth configure-docker "${TRAMPOLINE_HOST}"
+        else
+            gcloud auth configure-docker --quiet
+        fi
     fi
     pass_down_envvars+=(
 	# KOKORO dynamic variables.

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.6.2"
+  ".": "1.8.0"
 }

data/.trampolinerc

@@ -18,7 +18,12 @@ required_envvars+=(
 
 # Add env vars which are passed down into the container here.
 pass_down_envvars+=(
-    "AUTORELEASE_PR" "RELEASE_DRY_RUN" "RELEASE_PACKAGE" "KOKORO_GIT_COMMIT" "RUBY_VERSIONS" "EXTRA_CI_ARGS"
+    "AUTORELEASE_PR"
+    "EXTRA_CI_ARGS"
+    "KOKORO_GIT_COMMIT"
+    "RELEASE_DRY_RUN"
+    "RELEASE_PACKAGE"
+    "RUBY_VERSIONS"
 )
 
 # Prevent unintentional override on the default image.

data/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+### 1.8.0 (2024-12-12)
+
+#### Features
+
+* INSERT OR [IGNORE|UPDATE] ([#332](https://github.com/googleapis/ruby-spanner-activerecord/issues/332)) 
+#### Bug Fixes
+
+* Fixed incorrect argument handling. ([#333](https://github.com/googleapis/ruby-spanner-activerecord/issues/333)) 
+
+### 1.7.0 (2024-12-11)
+
+#### Features
+
+* support Rails 7.2.0 ([#328](https://github.com/googleapis/ruby-spanner-activerecord/issues/328)) 
+#### Bug Fixes
+
+* `SpannerAdapter` requires prepared statements to be enabled ([#323](https://github.com/googleapis/ruby-spanner-activerecord/issues/323)) 
+* local emulator test ([#320](https://github.com/googleapis/ruby-spanner-activerecord/issues/320)) 
+
+### 1.6.3 (2024-08-31)
+
+#### Bug Fixes
+
+* a few Ruby DSL schema dump bug fixes ([#308](https://github.com/googleapis/ruby-spanner-activerecord/issues/308)) 
+#### Documentation
+
+* update bit-reversed sequence sample ([#303](https://github.com/googleapis/ruby-spanner-activerecord/issues/303)) 
+
 ### 1.6.2 (2024-02-19)
 
 #### Bug Fixes

data/Gemfile

@@ -3,16 +3,17 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in activerecord-spanner.gemspec
 gemspec
 
-gem "activerecord", ENV.fetch("AR_VERSION", "~> 6.1.6.1")
-gem "minitest", "~> 5.20.0"
+gem "activerecord", ENV.fetch("AR_VERSION", "~> 7.1.0")
+gem "ostruct"
+gem "minitest", "~> 5.25.0"
 gem "minitest-rg", "~> 5.3.0"
 gem "pry", "~> 0.13.0"
 gem "pry-byebug", "~> 3.9.0"
 # Add sqlite3 for testing for compatibility with other adapters.
-gem "sqlite3"
+gem 'sqlite3', '~> 1.4'
 
 # Required for samples and testing.
-install_if -> { ENV.fetch("AR_VERSION", "~> 6.1.6.1").dup.to_s.sub("~>", "").strip < "7.1.0" && !ENV["SKIP_COMPOSITE_PK"] } do
+install_if -> { ENV.fetch("AR_VERSION", "~> 7.1.0").dup.to_s.sub("~>", "").strip < "7.1.0" && !ENV["SKIP_COMPOSITE_PK"] } do
   gem "composite_primary_keys"
 end
 

data/README.md

@@ -77,6 +77,7 @@ __NOTE__: You do need to have [Docker](https://docs.docker.com/get-docker/) inst
 Some noteworthy examples in the snippets directory:
 - [quickstart](examples/snippets/quickstart): A simple application that shows how to create and query a simple database containing two tables.
 - [migrations](examples/snippets/migrations): Shows a best-practice for executing migrations on Cloud Spanner.
+- [bit-reversed-sequences](examples/snippets/bit-reversed-sequence): Shows how to use bit-reversed sequences for primary keys.
 - [read-write-transactions](examples/snippets/read-write-transactions): Shows how to execute transactions on Cloud Spanner.
 - [read-only-transactions](examples/snippets/read-only-transactions): Shows how to execute read-only transactions on Cloud Spanner.
 - [bulk-insert](examples/snippets/bulk-insert): Shows the best way to insert a large number of new records.

data/Rakefile

@@ -56,8 +56,8 @@ task :acceptance, [:project, :keyfile, :instance, :tests] do |t, args|
   tests ||= "**"
 
   # always overwrite when running tests
-  ENV["SPANNER_PROJECT"] = project
-  ENV["SPANNER_KEYFILE_JSON"] = keyfile
+  ENV["SPANNER_TEST_PROJECT"] = project
+  ENV["SPANNER_TEST_KEYFILE_JSON"] = keyfile
   ENV["SPANNER_TEST_INSTANCE"] = instance
   ENV["SPANNER_EMULATOR_HOST"] = emulator_host
 

data/acceptance/cases/migration/schema_dumper_test.rb

@@ -17,15 +17,27 @@ module ActiveRecord
         ActiveRecord::gem_version >= Gem::Version.create('7.1.0')
       end
 
+      def is_7_2_or_higher?
+        ActiveRecord::gem_version >= Gem::Version.create('7.2.0')
+      end
+
+      def pool_or_connection
+        if is_7_2_or_higher?
+          ActiveRecord::Base.connection_pool
+        else
+          ActiveRecord::Base.connection
+        end
+      end
+
       def test_dump_schema_contains_start_batch_ddl
-        connection = ActiveRecord::Base.connection
+        connection = pool_or_connection
         schema = StringIO.new
         ActiveRecord::SchemaDumper.dump connection, schema
         assert schema.string.include?("connection.start_batch_ddl")
       end
 
       def test_dump_schema_contains_run_batch
-        connection = ActiveRecord::Base.connection
+        connection = pool_or_connection
         schema = StringIO.new
         ActiveRecord::SchemaDumper.dump connection, schema
         assert schema.string.include?("  connection.run_batch\n"\
@@ -35,7 +47,7 @@ module ActiveRecord
       end
 
       def test_dump_schema_contains_albums_table
-        connection = ActiveRecord::Base.connection
+        connection = pool_or_connection
         schema = StringIO.new
         ActiveRecord::SchemaDumper.dump connection, schema
         sql = schema.string
@@ -47,32 +59,46 @@ module ActiveRecord
       end
 
       def test_dump_schema_contains_interleaved_index
-        connection = ActiveRecord::Base.connection
+        connection = pool_or_connection
         schema = StringIO.new
         ActiveRecord::SchemaDumper.dump connection, schema
         assert schema.string.include?("t.index [\"singerid\", \"albumid\", \"title\"], name: \"index_tracks_on_singerid_and_albumid_and_title\", order: { singerid: :asc, albumid: :asc, title: :asc }, null_filtered: true, interleave_in: \"albums\""), schema.string
       end
 
       def test_dump_schema_should_not_contain_id_limit
-        connection = ActiveRecord::Base.connection
+        connection = pool_or_connection
         schema = StringIO.new
         ActiveRecord::SchemaDumper.dump connection, schema
         assert !schema.string.include?("id: { limit: 8 }")
       end
 
       def test_dump_schema_contains_commit_timestamp
-        connection = ActiveRecord::Base.connection
+        connection = pool_or_connection
         schema = StringIO.new
         ActiveRecord::SchemaDumper.dump connection, schema
         assert schema.string.include?("t.time \"last_updated\", allow_commit_timestamp: true"), schema.string
       end
 
       def test_dump_schema_contains_virtual_column
-        connection = ActiveRecord::Base.connection
+        connection = pool_or_connection
         schema = StringIO.new
         ActiveRecord::SchemaDumper.dump connection, schema
         assert schema.string.include?("t.virtual \"full_name\", type: :string, as: \"COALESCE(first_name || ' ', '') || last_name\", stored: true"), schema.string
       end
+
+      def test_dump_schema_contains_string_array
+        connection = pool_or_connection
+        schema = StringIO.new
+        ActiveRecord::SchemaDumper.dump connection, schema
+        assert schema.string.include?("t.string \"col_array_string\", array: true"), schema.string
+      end
+
+      def test_dump_schema_index_storing
+        connection = pool_or_connection
+        schema = StringIO.new
+        ActiveRecord::SchemaDumper.dump connection, schema
+        assert schema.string.include?("t.index [\"last_name\"], name: \"index_singers_on_last_name\", order: { last_name: :asc }, storing: [\"first_name\", \"tracks_count\"]"), schema.string
+      end
     end
   end
 end

data/acceptance/cases/models/insert_all_test.rb

@@ -30,13 +30,24 @@ module ActiveRecord
           { id: Author.next_sequence_value, name: "Carol" },
         ]
 
-        assert_raise(NotImplementedError) { Author.insert_all(values) }
+        Author.insert_all(values)
+
+        authors = Author.all.order(:name)
+
+        assert_equal "Alice", authors[0].name
+        assert_equal "Bob", authors[1].name
+        assert_equal "Carol", authors[2].name
       end
 
       def test_insert
         value = { id: Author.next_sequence_value, name: "Alice" }
 
-        assert_raise(NotImplementedError) { Author.insert(value) }
+        Author.insert(value)
+
+        authors = Author.all.order(:name)
+
+        assert_equal 1, authors.length
+        assert_equal "Alice", authors[0].name
       end
 
       def test_insert_all!
@@ -136,12 +147,16 @@ module ActiveRecord
           { id: Author.next_sequence_value, name: "Carol" },
         ]
 
-        err = assert_raise(NotImplementedError) do
-          ActiveRecord::Base.transaction do
-            Author.upsert_all(values)
-          end
+        ActiveRecord::Base.transaction do
+          Author.upsert_all(values)
         end
-        assert_match "Use upsert outside a transaction block", err.message
+
+        authors = Author.all.order(:name)
+
+        assert_equal 3, authors.length
+        assert_equal "Alice", authors[0].name
+        assert_equal "Bob", authors[1].name
+        assert_equal "Carol", authors[2].name
       end
 
       def test_upsert_all_with_buffered_mutation_transaction

data/acceptance/cases/sessions/session_not_found_test.rb

@@ -51,6 +51,8 @@ module ActiveRecord
         sessions.each do |session|
           client.delete_session Google::Cloud::Spanner::V1::DeleteSessionRequest.new name: session.name
         end
+        # Wait a bit to ensure that the sessions are really deleted.
+        sleep 5 unless ENV["SPANNER_EMULATOR_HOST"]
       end
 
       def test_single_read

data/acceptance/cases/tasks/database_tasks_test.rb

@@ -48,6 +48,7 @@ module ActiveRecord
       end
 
       def teardown
+        drop_database
         ActiveRecord::Base.connection_pool.disconnect!
         FileUtils.rm_rf ActiveRecord::Tasks::DatabaseTasks.db_dir
         ActiveRecord::Tasks::DatabaseTasks.db_dir = @original_db_dir
@@ -226,6 +227,7 @@ CREATE TABLE singers (
   lock_version INT64,
   full_name STRING(MAX) AS (COALESCE(first_name || ' ', '') || last_name) STORED,
 ) PRIMARY KEY(singerid);
+CREATE INDEX index_singers_on_last_name ON singers(last_name) STORING (tracks_count, first_name);
 CREATE TABLE albums (
   albumid INT64 NOT NULL,
   singerid INT64 NOT NULL,
@@ -383,6 +385,7 @@ CREATE TABLE singers (
   lock_version INT64,
   full_name STRING(MAX) AS (COALESCE(first_name || ' ', '') || last_name) STORED,
 ) PRIMARY KEY(singerid);
+CREATE INDEX index_singers_on_last_name ON singers(last_name) STORING (tracks_count, first_name);
 CREATE TABLE albums (
   singerid INT64 NOT NULL,
   albumid INT64 NOT NULL,
@@ -547,6 +550,7 @@ CREATE TABLE singers (
   lock_version INT64,
   full_name STRING(MAX) AS (COALESCE(first_name || ' ', '') || last_name) STORED,
 ) PRIMARY KEY(singerid);
+CREATE INDEX index_singers_on_last_name ON singers(last_name) STORING (tracks_count, first_name);
 CREATE TABLE albums (
   albumid INT64 NOT NULL,
   singerid INT64 NOT NULL,
@@ -707,6 +711,7 @@ CREATE TABLE singers (
   lock_version INT64,
   full_name STRING(MAX) AS (COALESCE(first_name || ' ', '') || last_name) STORED,
 ) PRIMARY KEY(singerid);
+CREATE INDEX index_singers_on_last_name ON singers(last_name) STORING (tracks_count, first_name);
 CREATE TABLE albums (
   singerid INT64 NOT NULL,
   albumid INT64 NOT NULL,

data/acceptance/schema/schema.rb

@@ -126,6 +126,7 @@ def create_tables_in_test_schema
         t.integer :lock_version
         t.virtual :full_name, type: :string, as: "COALESCE(first_name || ' ', '') || last_name", stored: true
       end
+      add_index :singers, :last_name, storing: %i[tracks_count first_name]
 
       if is_7_1_or_higher?
         create_table :albums, primary_key: [:singerid, :albumid] do |t|

data/acceptance/test_helper.rb

@@ -8,6 +8,7 @@ gem "minitest"
 require "minitest/autorun"
 require "minitest/focus"
 require "minitest/rg"
+require "ostruct"
 require "active_support"
 require "google/cloud/spanner"
 require "active_record"
@@ -18,7 +19,10 @@ require "securerandom"
 require "composite_primary_keys" if ActiveRecord::gem_version < Gem::Version.create('7.1.0')
 
 # rubocop:disable Style/GlobalVars
-
+#
+if ActiveRecord.gem_version >= Gem::Version.create("7.2.0")
+  ActiveRecord::ConnectionAdapters.register("spanner", "ActiveRecord::ConnectionAdapters::SpannerAdapter")
+end
 $spanner_test_database = "ar-test-#{SecureRandom.hex 4}"
 
 def connector_config

data/activerecord-spanner-adapter.gemspec

@@ -25,7 +25,9 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = ">= 2.7"
 
   spec.add_dependency "google-cloud-spanner", "~> 2.18"
-  spec.add_runtime_dependency "activerecord", [">= 6.0.0", "< 7.2"]
+  # Pin gRPC to 1.64.3, as 1.65 and 1.66 cause test runs to hang randomly.
+  spec.add_dependency "grpc", "1.64.3"
+  spec.add_runtime_dependency "activerecord", [">= 6.1", "< 7.3"]
 
   spec.add_development_dependency "autotest-suffix", "~> 1.1"
   spec.add_development_dependency "bundler", "~> 2.0"

data/examples/snippets/bit-reversed-sequence/README.md

@@ -5,6 +5,12 @@ This example shows how to use a bit-reversed sequence to generate the primary ke
 See https://cloud.google.com/spanner/docs/primary-key-default-value#bit-reversed-sequence for more information
 about bit-reversed sequences in Cloud Spanner.
 
+## Requirements
+Using bit-reversed sequences for generating primary key values in ActiveRecord has the following requirements:
+1. You must use __ActiveRecord version 7.1 or higher__.
+2. Your models must include a sequence name like this: `self.sequence_name = :singer_sequence`
+3. You must create the bit-reversed sequence using a SQL statement in your migrations.
+
 ## Creating Tables with Bit-Reversed Sequences in ActiveRecord
 You can create bit-reversed sequences using migrations in ActiveRecord by executing a SQL statement using the underlying
 connection.

data/examples/snippets/bit-reversed-sequence/db/migrate/01_create_tables.rb

@@ -8,15 +8,12 @@ class CreateTables < ActiveRecord::Migration[7.1]
   def change
     # Execute the entire migration as one DDL batch.
     connection.ddl_batch do
-      # TODO: Uncomment when bit-reversed sequences are supported in the emulator.
-      # connection.execute "create sequence singer_sequence OPTIONS (sequence_kind = 'bit_reversed_positive')"
+      connection.execute "create sequence singer_sequence OPTIONS (sequence_kind = 'bit_reversed_positive')"
 
       # Explicitly define the primary key.
       create_table :singers, id: false, primary_key: :singerid do |t|
-        # TODO: Uncomment when bit-reversed sequences are supported in the emulator.
-        # t.integer :singerid, primary_key: true, null: false,
-        #           default: -> { "GET_NEXT_SEQUENCE_VALUE(SEQUENCE singer_sequence)" }
-        t.integer :singerid, primary_key: true, null: false, default: -> { "FARM_FINGERPRINT(GENERATE_UUID())" }
+        t.integer :singerid, primary_key: true, null: false,
+                  default: -> { "GET_NEXT_SEQUENCE_VALUE(SEQUENCE singer_sequence)" }
         t.string :first_name
         t.string :last_name
       end

data/examples/snippets/bit-reversed-sequence/db/schema.rb

@@ -19,7 +19,7 @@ ActiveRecord::Schema[7.1].define(version: 1) do
     t.string "title"
   end
 
-  create_table "singers", primary_key: "singerid", default: -> { "FARM_FINGERPRINT(GENERATE_UUID())" }, force: :cascade do |t|
+  create_table "singers", primary_key: "singerid", default: -> { "GET_NEXT_SEQUENCE_VALUE(SEQUENCE singer_sequence)" }, force: :cascade do |t|
     t.string "first_name"
     t.string "last_name"
   end

data/lib/active_record/connection_adapters/spanner/database_statements.rb

@@ -21,15 +21,15 @@ module ActiveRecord
           internal_execute sql, name, binds
         end
 
-        def internal_exec_query sql, name = "SQL", binds = [], prepare: false, async: false
-          result = internal_execute sql, name, binds, prepare: prepare, async: async
+        def internal_exec_query sql, name = "SQL", binds = [], prepare: false, async: false, allow_retry: false
+          result = internal_execute sql, name, binds, prepare: prepare, async: async, allow_retry: allow_retry
           ActiveRecord::Result.new(
             result.fields.keys.map(&:to_s), result.rows.map(&:values)
           )
         end
 
         def internal_execute sql, name = "SQL", binds = [],
-                             prepare: false, async: false # rubocop:disable Lint/UnusedMethodArgument
+                             prepare: false, async: false, allow_retry: false # rubocop:disable Lint/UnusedMethodArgument, Metrics/LineLength
           statement_type = sql_statement_type sql
           # Call `transform` to invoke any query transformers that might have been registered.
           sql = transform sql
@@ -320,6 +320,8 @@ module ActiveRecord
             elsif bind.class == Symbol
               # This ensures that for example :environment is sent as the string 'environment' to Cloud Spanner.
               type = :STRING
+            elsif bind.class == TrueClass || bind.class == FalseClass
+              type = :BOOL
             end
             [
               # Generates binds for named parameters in the format `@p1, @p2, ...`

data/lib/active_record/connection_adapters/spanner/quoting.rb

@@ -30,17 +30,29 @@
 
 module ActiveRecord
   module ConnectionAdapters
+    QUOTED_COLUMN_NAMES = Concurrent::Map.new # :nodoc:
+    QUOTED_TABLE_NAMES = Concurrent::Map.new # :nodoc:
+
+    module Quoting
+      module ClassMethods
+        # This is used for ActiveRecord v8 and higher.
+        def quote_column_name name
+          QUOTED_COLUMN_NAMES[name] ||= "`#{name.to_s.gsub '`', '``'}`".freeze
+        end
+
+        def quote_table_name name
+          QUOTED_TABLE_NAMES[name] ||= "`#{name.to_s.gsub '.', '`.`'}`".freeze
+        end
+      end
+    end
     module Spanner
       module Quoting
-        QUOTED_COLUMN_NAMES = Concurrent::Map.new # :nodoc:
-        QUOTED_TABLE_NAMES = Concurrent::Map.new # :nodoc:
-
         def quote_column_name name
-          QUOTED_COLUMN_NAMES[name] ||= "`#{super.gsub '`', '``'}`".freeze
+          QUOTED_COLUMN_NAMES[name] ||= "`#{name.to_s.gsub '`', '``'}`".freeze
         end
 
         def quote_table_name name
-          QUOTED_TABLE_NAMES[name] ||= super.gsub(".", "`.`").freeze
+          QUOTED_TABLE_NAMES[name] ||= "`#{name.to_s.gsub '.', '`.`'}`".freeze
         end
 
         STR_ESCAPE_REGX = /[\n\r'\\]/.freeze

data/lib/active_record/connection_adapters/spanner/schema_dumper.rb

@@ -27,6 +27,8 @@ module ActiveRecord
             spec = { type: schema_type(column).inspect }.merge! spec
           end
 
+          spec[:array] = true if column.sql_type.start_with? "ARRAY<"
+
           spec
         end
 
@@ -54,7 +56,7 @@ module ActiveRecord
           index_parts = super
           index_parts << "null_filtered: #{index.null_filtered.inspect}" if index.null_filtered
           index_parts << "interleave_in: #{index.interleave_in.inspect}" if index.interleave_in
-          index_parts << "storing: #{format_index_parts index.storing}" if index.storing.present?
+          index_parts << "storing: #{format_index_parts index.storing.sort}" if index.storing.present?
           index_parts
         end
 

data/lib/active_record/connection_adapters/spanner/schema_statements.rb

@@ -23,6 +23,7 @@ module ActiveRecord
       module SchemaStatements
         VERSION_6_1_0 = Gem::Version.create "6.1.0"
         VERSION_6_0_3 = Gem::Version.create "6.0.3"
+        VERSION_7_2 = Gem::Version.create "7.2.0"
 
         def current_database
           @connection.database_id
@@ -401,6 +402,16 @@ module ActiveRecord
           information_schema { |i| i.check_constraints table_name }
         end
 
+        if ActiveRecord.gem_version >= VERSION_7_2
+          def migration_context
+            pool.migration_context
+          end
+
+          def schema_migration
+            pool.schema_migration
+          end
+        end
+
         def assume_migrated_upto_version version
           version = version.to_i
           sm_table = quote_table_name schema_migration.table_name

data/lib/active_record/connection_adapters/spanner_adapter.rb

@@ -28,16 +28,18 @@ require "activerecord_spanner_adapter/primary_key"
 require "activerecord_spanner_adapter/transaction"
 
 module ActiveRecord
-  module ConnectionHandling # :nodoc:
-    def spanner_connection config
-      connection = ActiveRecordSpannerAdapter::Connection.new config
-      connection.connect!
-      ConnectionAdapters::SpannerAdapter.new connection, logger, nil, config
-    rescue Google::Cloud::Error => error
-      if error.instance_of? Google::Cloud::NotFoundError
-        raise ActiveRecord::NoDatabaseError
-      end
-      raise error
+  if ActiveRecord.version < Gem::Version.new("7.2")
+    module ConnectionHandling # :nodoc:
+      def spanner_connection config
+        connection = ActiveRecordSpannerAdapter::Connection.new config
+        connection.connect!
+        ConnectionAdapters::SpannerAdapter.new connection, logger, nil, config
+      rescue Google::Cloud::Error => error
+        if error.instance_of? Google::Cloud::NotFoundError
+          raise ActiveRecord::NoDatabaseError
+        end
+        raise error
+      end
     end
   end
 
@@ -69,11 +71,21 @@ module ActiveRecord
       # Determines whether or not to log query binds when executing statements
       class_attribute :log_statement_binds, instance_writer: false, default: false
 
-      def initialize connection, logger, connection_options, config
-        @connection = connection
-        @connection_options = connection_options
-        super connection, logger, config
-        @raw_connection ||= connection
+      def initialize config_or_deprecated_connection, deprecated_logger = nil,
+                     deprecated_connection_options = nil, deprecated_config = nil
+        if config_or_deprecated_connection.is_a? Hash
+          @connection = ActiveRecordSpannerAdapter::Connection.new config_or_deprecated_connection
+          @connection.connect!
+          super config_or_deprecated_connection
+          @raw_connection ||= @connection
+        else
+          @connection = config_or_deprecated_connection
+          @connection_options = deprecated_connection_options
+          super config_or_deprecated_connection, deprecated_logger, deprecated_config
+          @raw_connection ||= config_or_deprecated_connection
+        end
+        # Spanner does not support unprepared statements
+        @prepared_statements = true
       end
 
       def max_identifier_length
@@ -197,12 +209,14 @@ module ActiveRecord
           raise "ActiveRecordSpannerAdapter does not support insert_sql with buffered_mutations transaction."
         end
 
-        if insert.skip_duplicates? || insert.update_duplicates?
-          raise NotImplementedError, "CloudSpanner does not support skip_duplicates and update_duplicates."
-        end
-
         values_list, = insert.values_list
-        "INSERT #{insert.into} #{values_list}"
+        prefix = "INSERT"
+        if insert.update_duplicates?
+          prefix += " OR UPDATE"
+        elsif insert.skip_duplicates?
+          prefix += " OR IGNORE"
+        end
+        "#{prefix} #{insert.into} #{values_list}"
       end
 
       module TypeMapBuilder

data/lib/activerecord-spanner-adapter.rb

@@ -15,7 +15,11 @@ if defined?(Rails)
         end
 
         ActiveSupport.on_load :active_record do
-          require "active_record/connection_adapters/spanner_adapter"
+          if Rails.version >= "7.2.0"
+            ActiveRecord::ConnectionAdapters.register("spanner", "ActiveRecord::ConnectionAdapters::SpannerAdapter")
+          else
+            require "active_record/connection_adapters/spanner_adapter"
+          end
         end
       end
     end

data/lib/activerecord_spanner_adapter/base.rb

@@ -16,6 +16,7 @@ module ActiveRecord
 
   class Base
     VERSION_7_1 = Gem::Version.create "7.1.0"
+    VERSION_7_2 = Gem::Version.create "7.2.0"
 
     # Creates an object (or multiple objects) and saves it to the database. This method will use mutations instead
     # of DML if there is no active transaction, or if the active transaction has been created with the option
@@ -48,8 +49,26 @@ module ActiveRecord
       spanner_adapter? && connection&.current_spanner_transaction&.isolation == :buffered_mutations
     end
 
-    def self._insert_record values, returning = []
-      if !(buffered_mutations? || (primary_key && values.is_a?(Hash))) || !spanner_adapter?
+    def self._should_use_standard_insert_record? values
+      !(buffered_mutations? || (primary_key && values.is_a?(Hash))) || !spanner_adapter?
+    end
+
+    def self._internal_insert_record values
+      if ActiveRecord.gem_version < VERSION_7_2
+        _insert_record values
+      else
+        _insert_record nil, values
+      end
+    end
+
+    def self._insert_record *args
+      if ActiveRecord.gem_version < VERSION_7_2
+        values, returning = args
+      else
+        _connection, values, returning = args
+      end
+
+      if _should_use_standard_insert_record? values
         return super values if ActiveRecord.gem_version < VERSION_7_1
         return super
       end
@@ -111,8 +130,20 @@ module ActiveRecord
       _buffer_record values, :insert_or_update, returning
     end
 
-    def self.insert_all _attributes, **_kwargs
-      raise NotImplementedError, "Cloud Spanner does not support skip_duplicates. Use insert! or upsert instead."
+    def self.insert_all attributes, returning: nil, **_kwargs
+      if active_transaction? && buffered_mutations?
+        raise NotImplementedError,
+              "Spanner does not support skip_duplicates for mutations. " \
+              "Use a transaction that uses DML, or use insert! or upsert instead."
+      end
+      super
+    end
+
+    def self.insert! attributes, returning: nil, **kwargs
+      return super unless spanner_adapter?
+      return super if active_transaction? && !buffered_mutations?
+
+      insert_all! [attributes], returning: returning, **kwargs
     end
 
     def self.insert_all! attributes, returning: nil, **_kwargs
@@ -123,24 +154,27 @@ module ActiveRecord
       # The mutations will be sent as one batch when the transaction is committed.
       if active_transaction?
         attributes.each do |record|
-          _insert_record record
+          _internal_insert_record record
         end
       else
         transaction isolation: :buffered_mutations do
           attributes.each do |record|
-            _insert_record record
+            _internal_insert_record record
           end
         end
       end
     end
 
-    def self.upsert_all attributes, returning: nil, unique_by: nil, **_kwargs
+    def self.upsert attributes, returning: nil, **kwargs
       return super unless spanner_adapter?
-      if active_transaction? && !buffered_mutations?
-        raise NotImplementedError, "Cloud Spanner does not support upsert using DML. " \
-                                   "Use upsert outside a transaction block or in a transaction " \
-                                   "block with isolation: :buffered_mutations"
-      end
+      return super if active_transaction? && !buffered_mutations?
+
+      upsert_all [attributes], returning: returning, **kwargs
+    end
+
+    def self.upsert_all attributes, returning: nil, unique_by: nil, **kwargs
+      return super unless spanner_adapter?
+      return super if active_transaction? && !buffered_mutations?
 
       # This might seem inefficient, but is actually not, as it is only buffering a mutation locally.
       # The mutations will be sent as one batch when the transaction is committed.

data/lib/activerecord_spanner_adapter/version.rb

@@ -5,5 +5,5 @@
 # https://opensource.org/licenses/MIT.
 
 module ActiveRecordSpannerAdapter
-  VERSION = "1.6.2".freeze
+  VERSION = "1.8.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-spanner-adapter
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.8.0
 platform: ruby
 authors:
 - Google LLC
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-19 00:00:00.000000000 Z
+date: 2024-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-cloud-spanner
@@ -24,26 +24,40 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.18'
+- !ruby/object:Gem::Dependency
+  name: grpc
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.64.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.64.3
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '7.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '7.3'
 - !ruby/object:Gem::Dependency
   name: autotest-suffix
   requirement: !ruby/object:Gem::Requirement
@@ -230,8 +244,6 @@ files:
 - ".github/workflows/nightly-acceptance-tests-on-emulator.yaml"
 - ".github/workflows/nightly-acceptance-tests-on-production.yaml"
 - ".github/workflows/nightly-unit-tests.yaml"
-- ".github/workflows/release-please-label.yml"
-- ".github/workflows/release-please.yml"
 - ".github/workflows/rubocop.yaml"
 - ".gitignore"
 - ".kokoro/populate-secrets.sh"
@@ -577,7 +589,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.5.23
 signing_key: 
 specification_version: 4
 summary: Rails ActiveRecord connector for Google Spanner Database

data/.github/workflows/release-please-label.yml

@@ -1,25 +0,0 @@
-name: release-please-label
-on:
-  pull_request_target:
-    branches:
-      - main
-    types:
-      - opened
-jobs:
-  release-please-label:
-    if: "${{ github.event.sender.login == 'yoshi-code-bot' && startsWith(github.event.pull_request.title, 'chore(main): release ') }}"
-    runs-on: ubuntu-latest
-    steps:
-      - name: ReleaseLabel
-        uses: actions/github-script@v7
-        with:
-          github-token: ${{secrets.YOSHI_APPROVER_TOKEN}}
-          script: |
-            core.info('Labeling release');
-            await github.rest.issues.addLabels({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: context.payload.pull_request.number,
-              labels: ['autorelease: pending']
-            });
-            core.info('Labeled');

data/.github/workflows/release-please.yml

@@ -1,38 +0,0 @@
-name: Release-Please
-on:
-  workflow_dispatch:
-    inputs:
-      gem:
-        description: "Name of single gem to release. Leave blank to check all gems."
-        required: false
-      args:
-        description: "Extra command line arguments."
-        required: false
-
-jobs:
-  release-please:
-    if: ${{ github.repository == 'googleapis/ruby-spanner-activerecord' }}
-    runs-on: ubuntu-latest
-    env:
-      GITHUB_TOKEN: ${{ secrets.YOSHI_CODE_BOT_TOKEN }}
-      RELEASE_PLEASE_DISABLE: ${{ secrets.RELEASE_PLEASE_DISABLE }}
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v4
-      - name: Install Ruby 3.0
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: "3.0"
-      - name: Install NodeJS 16.x
-        uses: actions/setup-node@v4
-        with:
-          node-version: "16.x"
-      - name: Install tools
-        run: "gem install --no-document toys"
-      - name: execute
-        run: |
-          toys release manifest -v \
-            --fork --skip-labeling \
-            --github-event-name=${{ github.event_name }} \
-            ${{ github.event.inputs.args }} \
-            -- ${{ github.event.inputs.gem }}