activerecord-spanner-adapter 1.4.3 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecc586f0beee665e45413d64af184d69ed9814b17465ab68be04767c3312d69a
-  data.tar.gz: 061c3c4b433b673ab848b8f5e67652a0e3f991b99fdae1ed7fdc118e622e3139
+  metadata.gz: f1a935693a8621d55fd7f51a17ba93dcc598f97789e6b7825ca7c916fbc0c9e1
+  data.tar.gz: 671717a9df5b2d7b6bbf388faea2c9ec6f982906a6456271a8696c2980d62684
 SHA512:
-  metadata.gz: 6c69f17a06d188ca69fe942756ded71f245a0398d67fa0c1e0bb915cc03a8cd51147851edcf352697670b3999539b178c1d1542d30659ef6110b096faa3c36d9
-  data.tar.gz: 339ae0975ff7ac256cba1d98b68379a47de1d7187f82e2ebfdd83ad0c940c3ca3af52c4bc5e30f334ba63e48d001baebe373e9a121f4593ad09daf941f7e3e22
+  metadata.gz: 5fa701ba551c2072ad60e6a7aadde8a4c4e20e3262d091c4854fd37d3663cfa353595017a8de229404c37dc7145ef5852c4ac16f531655c54462e419b217d86b
+  data.tar.gz: 24733bae08d92cd3ad8c7ae4cbbdbf016dc845f3f8b1a962bdde535b8df2627c9dc8a62d4d41cad3ec58a295c22de9ccb01924f95c985d1bf6741d647a0fcf4d

data/.github/workflows/nightly-acceptance-tests-on-emulator.yaml

@@ -20,7 +20,7 @@ jobs:
       matrix:
         # Run acceptance tests all supported combinations of Ruby and ActiveRecord.
         ruby: [2.6, 2.7, 3.0, 3.1, 3.2]
-        ar: [6.0.0, 6.0.1, 6.0.2.2, 6.0.3.7, 6.0.4, 6.1.3.2, 6.1.4.7, 6.1.5.1, 6.1.6.1, 7.0.2.4, 7.0.3.1, 7.0.4, 7.0.5]
+        ar: [6.0.0, 6.0.1, 6.0.2.2, 6.0.3.7, 6.0.4, 6.1.3.2, 6.1.4.7, 6.1.5.1, 6.1.6.1, 7.0.2.4, 7.0.3.1, 7.0.4, 7.0.5, 7.0.6, 7.0.7]
         # Exclude combinations that are not supported.
         exclude:
           - ruby: 3.0
@@ -61,6 +61,10 @@ jobs:
             ar: 7.0.4
           - ruby: 2.6
             ar: 7.0.5
+          - ruby: 2.6
+            ar: 7.0.6
+          - ruby: 2.6
+            ar: 7.0.7
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

data/.github/workflows/nightly-acceptance-tests-on-production.yaml

@@ -29,7 +29,7 @@ jobs:
     - name: Install dependencies
       run: bundle install
     - name: Run acceptance tests on production
-      run: bundle exec rake acceptance
+      run: bundle exec rake acceptance\[,,,"exclude cases/migration"\]
       env:
         SPANNER_TEST_PROJECT: ${{ secrets.GCP_PROJECT_ID }}
         SPANNER_TEST_INSTANCE: ruby-activerecord-test

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.4.3"
+  ".": "1.4.4"
 }

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+### 1.4.4 (2023-09-06)
+
+#### Bug Fixes
+
+* Support for changes in Rails 7.0.7. ([#260](https://github.com/googleapis/ruby-spanner-activerecord/issues/260)) 
+
 ### 1.4.3 (2023-06-09)
 
 #### Bug Fixes

data/acceptance/cases/migration/rename_column_test.rb

@@ -23,21 +23,23 @@ module ActiveRecord
         skip_test_table_create!
         super
 
-        connection.drop_table :rename_column_comments, if_exists: true
-        connection.drop_table :rename_column_posts, if_exists: true
-
-        connection.create_table(:rename_column_posts) do |t|
-          t.string :name, limit: 128
-          t.integer :comment_count
-        end
-
-        connection.create_table(:rename_column_comments) do |t|
-          t.string :comment
-          # The Spanner ActiveRecord adapter does not support creating an index on a column that also has a foreign key,
-          # as Cloud Spanner automatically creates a managed index for the foreign key. The index is therefore created
-          # separately.
-          t.references :rename_column_post, foreign_key: true
-          t.index :rename_column_post_id
+        connection.ddl_batch do
+          connection.drop_table :rename_column_comments, if_exists: true
+          connection.drop_table :rename_column_posts, if_exists: true
+
+          connection.create_table(:rename_column_posts) do |t|
+            t.string :name, limit: 128
+            t.integer :comment_count
+          end
+
+          connection.create_table(:rename_column_comments) do |t|
+            t.string :comment
+            # The Spanner ActiveRecord adapter does not support creating an index on a column that also has a foreign key,
+            # as Cloud Spanner automatically creates a managed index for the foreign key. The index is therefore created
+            # separately.
+            t.references :rename_column_post, foreign_key: true
+            t.index :rename_column_post_id
+          end
         end
 
         RenameColumnPost.reset_column_information

data/acceptance/test_helpers/with_separate_database.rb

@@ -20,6 +20,7 @@ module TestHelpers
 
     def teardown
       spanner_adapter_connection.database.drop
+      ActiveRecord::Base.connection_pool.disconnect!
     end
 
     def connection_config

data/lib/active_record/connection_adapters/spanner/quoting.rb

@@ -32,12 +32,15 @@ module ActiveRecord
   module ConnectionAdapters
     module Spanner
       module Quoting
+        QUOTED_COLUMN_NAMES = Concurrent::Map.new # :nodoc:
+        QUOTED_TABLE_NAMES = Concurrent::Map.new # :nodoc:
+
         def quote_column_name name
-          self.class.quoted_column_names[name] ||= "`#{super.gsub '`', '``'}`".freeze
+          QUOTED_COLUMN_NAMES[name] ||= "`#{super.gsub '`', '``'}`".freeze
         end
 
         def quote_table_name name
-          self.class.quoted_table_names[name] ||= super.gsub(".", "`.`").freeze
+          QUOTED_TABLE_NAMES[name] ||= super.gsub(".", "`.`").freeze
         end
 
         STR_ESCAPE_REGX = /[\n\r'\\]/.freeze

data/lib/activerecord_spanner_adapter/version.rb

@@ -5,5 +5,5 @@
 # https://opensource.org/licenses/MIT.
 
 module ActiveRecordSpannerAdapter
-  VERSION = "1.4.3".freeze
+  VERSION = "1.4.4".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-spanner-adapter
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.4.4
 platform: ruby
 authors:
 - Google LLC
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-06-09 00:00:00.000000000 Z
+date: 2023-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-cloud-spanner
@@ -539,7 +539,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.2
+rubygems_version: 3.4.19
 signing_key: 
 specification_version: 4
 summary: Rails ActiveRecord connector for Google Spanner Database