activerecord-spanner-adapter 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 499376d85989274623aa1cda4cb9197e14636b42cd5cf5d5bda4b3fbdb2a6494
-  data.tar.gz: 4e0f7e384b4450b28581523a79540416567aa44745e44377a1f7744e11ff95e7
+  metadata.gz: 2f432fe0aba4f4aaa5d2bcc689d8337fb944b393a8f71e11731f21bd2bc1aad5
+  data.tar.gz: 3dd03abd67174f3b7239d2c19a18ae0df756ad009988ae8ecddbd2369eb7164b
 SHA512:
-  metadata.gz: a3d5ff8b79e774c6eb6c74431162366543d2476a8f2e7eb3f3f2d81dac249b0493a773b09cd787cdf5a8dd5b287d85170021b2e7c47c2aba9d06f76a77c2b9d6
-  data.tar.gz: 28bebd4c40535b80239992f66aed5030744623c21c00f875b548fac2c0318280871e83c294e8b87681a2376d34446050cee60283da469ff4fe175b2ad78685a6
+  metadata.gz: d99d549f841dcb2facf0438335b06449f70e033ad9c030fa2396fff16650e8a9ee653157ee8699cd9e473515630766e2f9b3e117acc73d6ddf35fb8ee83724a1
+  data.tar.gz: 4e207e65e60ab191c7479f7ae47c9fdd0ebac9a5ca54505841155428b88dc60c379dae96db6e43cd17e8c2bc2af9d9b7b5b4c5ae091281416cdf9d7616edaf9c

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.4.0"
+  ".": "1.4.1"
 }

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+### 1.4.1 (2023-03-01)
+
+#### Bug Fixes
+
+* wrap default values in () as required ([#238](https://github.com/googleapis/ruby-spanner-activerecord/issues/238)) 
+#### Documentation
+
+* call out best practices and dialect compatibility ([#240](https://github.com/googleapis/ruby-spanner-activerecord/issues/240)) 
+
 ### 1.4.0 (2023-01-18)
 
 #### Features

data/README.md

@@ -4,6 +4,9 @@
 
 ![rubocop](https://github.com/googleapis/ruby-spanner-activerecord/workflows/rubocop/badge.svg)
 
+__This adapter only supports GoogleSQL-dialect Cloud Spanner databases. PostgreSQL-dialect
+databases are not supported.__
+
 This project provides a Cloud Spanner adapter for ActiveRecord. It supports the following versions:
 
 - ActiveRecord 6.0.x with Ruby 2.6 and 2.7.
@@ -13,9 +16,6 @@ This project provides a Cloud Spanner adapter for ActiveRecord. It supports the
 Known limitations are listed in the [Limitations](#limitations) section.
 Please report any problems that you might encounter by [creating a new issue](https://github.com/googleapis/ruby-spanner-activerecord/issues/new).
 
-This adapter only supports GoogleSQL-dialect Cloud Spanner databases. PostgreSQL-dialect
-databases are not supported.
-
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -36,6 +36,14 @@ And then execute:
 
 ## Usage
 
+### Migrations
+__Use DDL batching when executing migrations for the best possible performance.__
+
+Executing multiple schema changes on Cloud Spanner can take a long time. It is therefore
+strongly recommended that you limit the number of schema change operations. You can do
+this by using DDL batching in your migrations. See [the migrations examples](examples/snippets/migrations)
+for how to do this.
+
 ### Database Connection
 In Rails application `config/database.yml`, make the change as the following:
 

data/acceptance/cases/migration/change_schema_test.rb

@@ -120,6 +120,27 @@ module ActiveRecord
         end
       end
 
+      def test_create_table_with_column_default
+        testings_klass = Class.new ActiveRecord::Base
+        connection.ddl_batch do
+          connection.create_table :testings do |t|
+            t.string :name, null: false, default: "no name"
+            t.integer :age, null: false, default: 10
+          end
+          testings_klass.table_name = "testings"
+        end
+
+        testings_klass.reset_column_information
+        assert_equal false, testings_klass.columns_hash["name"].null
+        assert_equal false, testings_klass.columns_hash["age"].null
+
+        assert_nothing_raised {
+          testings_klass.connection.transaction {
+            testings_klass.connection.execute("insert into testings (id, name, age) values (#{generate_id}, DEFAULT, DEFAULT)")
+          }
+        }
+      end
+
       def test_create_table_with_limits
         connection.ddl_batch do
           connection.create_table :testings do |t|

data/lib/active_record/connection_adapters/spanner/schema_creation.rb

@@ -129,7 +129,7 @@ module ActiveRecord
             sql << " NOT NULL"
           end
           if options.key? :default
-            sql << " DEFAULT #{quote_default_expression options[:default], column}"
+            sql << " DEFAULT (#{quote_default_expression options[:default], column})"
           end
 
           if !options[:allow_commit_timestamp].nil? &&

data/lib/activerecord_spanner_adapter/version.rb

@@ -5,5 +5,5 @@
 # https://opensource.org/licenses/MIT.
 
 module ActiveRecordSpannerAdapter
-  VERSION = "1.4.0".freeze
+  VERSION = "1.4.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-spanner-adapter
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Google LLC
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-01-18 00:00:00.000000000 Z
+date: 2023-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-cloud-spanner