activerecord-spanner-adapter 0.3.0 → 1.0.0

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,40 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, and in the interest of
+fostering an open and welcoming community, we pledge to respect all people who
+contribute through reporting issues, posting feature requests, updating
+documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free
+experience for everyone, regardless of level of experience, gender, gender
+identity and expression, sexual orientation, disability, personal appearance,
+body size, race, ethnicity, age, religion, or nationality.
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery
+* Personal attacks
+* Trolling or insulting/derogatory comments
+* Public or private harassment
+* Publishing other's private information, such as physical or electronic
+  addresses, without explicit permission
+* Other unethical or unprofessional conduct.
+
+Project maintainers have the right and responsibility to remove, edit, or reject
+comments, commits, code, wiki edits, issues, and other contributions that are
+not aligned to this Code of Conduct. By adopting this Code of Conduct, project
+maintainers commit themselves to fairly and consistently applying these
+principles to every aspect of managing this project. Project maintainers who do
+not follow or enforce the Code of Conduct may be permanently removed from the
+project team.
+
+This code of conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by opening an issue or contacting one or more of the project
+maintainers.
+
+This Code of Conduct is adapted from the [Contributor
+Covenant](http://contributor-covenant.org), version 1.2.0, available at
+[http://contributor-covenant.org/version/1/2/0/](http://contributor-covenant.org/version/1/2/0/)

data/CONTRIBUTING.md

@@ -0,0 +1,79 @@
+# How to Contribute
+
+We'd love to accept your patches and contributions to this project. There are
+just a few small guidelines you need to follow.
+
+## Contributor License Agreement
+
+Contributions to this project must be accompanied by a Contributor License
+Agreement. You (or your employer) retain the copyright to your contribution;
+this simply gives us permission to use and redistribute your contributions as
+part of the project. Head over to <https://cla.developers.google.com/> to see
+your current agreements on file or to sign a new one.
+
+You generally only need to submit a CLA once, so if you've already submitted one
+(even if it was for a different project), you probably don't need to do it
+again.
+
+## Code reviews
+
+All submissions, including submissions by project members, require review. We
+use GitHub pull requests for this purpose. Consult
+[GitHub Help](https://help.github.com/articles/about-pull-requests/) for more
+information on using pull requests.
+
+## Community Guidelines
+
+This project follows [Google's Open Source Community
+Guidelines](https://opensource.google/conduct/).
+
+## Tests
+
+### Functional tests
+We have functional tests for individual components that can be run by
+```shell
+bundle exec rake test
+```
+
+### ActiveRecord integration tests
+We run full integration tests with continuous integration on Google Cloud Build with Kokoro.
+
+Command : `bundle exec rake acceptance[project,keyfile,instance]`
+
+Variable|Description|Comment
+---|---|---
+`project`|The project id of the Google Application credentials being used|For example `appdev-soda-spanner-staging`
+`keyfile`|The Google Application Credentials file|For example `~/Downloads/creds.json`
+`instance`|The Cloud Spanner instance to use, it MUST exist before running tests| For example
+`activerecord_tests`
+
+#### Example
+```shell
+bundle exec rake acceptance[appdev-soda-spanner-staging,/home/Downloads/creds.json,activerecord_tests]
+```
+
+## Coding Style
+
+Please follow the established coding style in the library. The style is is
+largely based on [The Ruby Style
+Guide](https://github.com/bbatsov/ruby-style-guide) with a few exceptions based
+on seattle-style:
+
+* Avoid parenthesis when possible, including in method definitions.
+* Always use double quotes strings. ([Option
+  B](https://github.com/bbatsov/ruby-style-guide#strings))
+
+You can check your code against these rules by running Rubocop like so:
+
+```sh
+$ cd ruby-spanner-activerecord
+$ bundle exec rubocop
+```
+
+The rubocop settings depend on [googleapis/ruby-style](https://github.com/googleapis/ruby-style/), in addition to [.rubocop.yml](https://github.com/googleapis/ruby-spanner-activerecord/blob/master/.rubocop.yml).
+
+## Code of Conduct
+
+Please note that this project is released with a Contributor Code of Conduct. By
+participating in this project you agree to abide by its terms. See
+{file:CODE_OF_CONDUCT.md Code of Conduct} for more information.

data/Gemfile

@@ -1,7 +1,12 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-# Specify your gem's dependencies in activerecord-spanner-adapter.gemspec
+# Specify your gem's dependencies in activerecord-spanner.gemspec
 gemspec
 
-gem 'pry'
-gem 'pry-byebug'
+gem "minitest", "~> 5.14.0"
+gem "pry", "~> 0.13.0"
+gem "pry-byebug", "~> 3.9.0"
+
+# Required for samples
+gem 'docker-api'
+gem "sinatra-activerecord"

data/LICENSE

@@ -1,6 +1,6 @@
-MIT License
+The MIT License (MIT)
 
-Copyright (c) 2017 Supership Inc.
+Copyright (c) 2020 Google LLC.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -9,13 +9,13 @@ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
 
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -1,59 +1,95 @@
-# ActiveRecord Spanner adapter
+# ActiveRecord Cloud Spanner Adapter
 
-The [Cloud Spanner](https://cloud.google.com/spanner/) adapter for ActiveRecord.
+[Google Cloud Spanner](https://cloud.google.com/spanner) adapter for ActiveRecord.
 
-## Status
-Proof of concept.
-You cannot expect that this gem is ready for production use -- many features are not supported.
+![rubocop](https://github.com/googleapis/ruby-spanner-activerecord/workflows/rubocop/badge.svg)
+
+This project provides a Cloud Spanner adapter for ActiveRecord. It supports the following versions:
+
+- ActiveRecord 6.0.x with Ruby 2.6 and 2.7.
+- ActiveRecord 6.1.x with Ruby 2.6 and higher.
+
+Known limitations are listed in the [Limitations](#limitations) section.
+Please report any problems that you might encounter by [creating a new issue](https://github.com/googleapis/ruby-spanner-activerecord/issues/new).
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'activerecord-spanner-adapter',
-  git: 'https://github.com/supership-jp/activerecord-spanner-adapter.git'
+gem 'activerecord-spanner-adapter'
 ```
 
-And then execute:
+If you would like to use latest adapter version from github then specify
 
-    $ bundle
+```ruby
+gem 'activerecord-spanner-adapter', :git => 'git@github.com:googleapis/ruby-spanner-activerecord.git'
+```
 
-Or install it yourself as:
+And then execute:
 
-    $ gem install activerecord-spanner-adapter
+    $ bundle
 
 ## Usage
 
-Add a configuration like this into your `database.yml`.
+### Database Connection
+In Rails application `config/database.yml`, make the change as the following:
 
-```yaml
-default:
-  adapter: spanner
-  project: your-gcp-project-name
-  instance: your-spanner-instance-name
-  database: your-spanner-database-name
-  keyfile: path/to/serivce-account-credential.json
+```
+development:
+  adapter: "spanner"
+  project: "<google project name>"
+  instance: "<google instance name>"
+  credentials: "<google credentails file path>"
+  database: "app-dev"
 ```
 
-*NOTE*: This adapter uses UUIDs as primary keys by default unlike other adapters.
-This is because monotonically increasing primary key restricts write performance in Spanner.
-
-c.f. https://cloud.google.com/spanner/docs/best-practices
-
+## Examples
+To get started with Rails, read the tutorial under {file:examples/rails/README.md examples/rails/README.md}.
 
-## Development
+You can also find a list of short self-contained code examples that show how
+to use ActiveRecord with Cloud Spanner under the directory [examples/snippets](examples/snippets). Each example is directly runnable without the need to setup a Cloud Spanner
+database, as all samples will automatically start a Cloud Spanner emulator in a Docker container and execute the sample
+code against that emulator. All samples can be executed by navigating to the sample directory on your local machine and
+then executing the command `bundle exec rake run`. Example:
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+```bash
+cd ruby-spanner-activerecord/examples/snippets/quickstart
+bundle exec rake run
+```
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+__NOTE__: You do need to have [Docker](https://docs.docker.com/get-docker/) installed on your local system to run these examples.
+
+Some noteworthy examples in the snippets directory:
+- [quickstart](examples/snippets/quickstart): A simple application that shows how to create and query a simple database containing two tables.
+- [migrations](examples/snippets/migrations): Shows a best-practice for executing migrations on Cloud Spanner.
+- [read-write-transactions](examples/snippets/read-write-transactions): Shows how to execute transactions on Cloud Spanner.
+- [read-only-transactions](examples/snippets/read-only-transactions): Shows how to execute read-only transactions on Cloud Spanner.
+- [bulk-insert](examples/snippets/bulk-insert): Shows the best way to insert a large number of new records.
+- [mutations](examples/snippets/mutations): Shows how you can use [mutations instead of DML](https://cloud.google.com/spanner/docs/dml-versus-mutations)
+  for inserting, updating and deleting data in a Cloud Spanner database. Mutations can have a significant performance
+  advantage compared to DML statements, but do not allow read-your-writes semantics during a transaction.
+- [array-data-type](examples/snippets/array-data-type): Shows how to work with `ARRAY` data types.
+
+## Limitations
+
+Limitation|Comment|Resolution
+---|---|---
+Lack of DEFAULT for columns [change_column_default](https://apidock.com/rails/v5.2.3/ActiveRecord/ConnectionAdapters/SchemaStatements/change_column_default)|Cloud Spanner does not support DEFAULT values for columns. The use of default must be enforced in your controller logic| Always set a value in your model or controller logic.
+Lack of sequential and auto-assigned IDs|Cloud Spanner doesn't autogenerate IDs and this integration instead creates UUID4 to avoid [hotspotting](https://cloud.google.com/spanner/docs/schema-design#uuid_primary_key) so you SHOULD NOT rely on IDs being sorted| UUID4s are automatically generated for primary keys.
+Table without Primary Key| Cloud Spanner support does not support tables without a primary key.| Always define a primary key for your table.
+Table names CANNOT have spaces within them whether back-ticked or not|Cloud Spanner DOES NOT support tables with spaces in them for example `Entity ID`|Ensure that your table names don't contain spaces.
+Table names CANNOT have punctuation marks and MUST contain valid UTF-8|Cloud Spanner DOES NOT support punctuation marks e.g. periods ".", question marks "?" in table names|Ensure that your table names don't contain punctuation marks.
+Index with fields length [add_index](https://apidock.com/rails/v5.2.3/ActiveRecord/ConnectionAdapters/SchemaStatements/add_index)|Cloud Spanner does not support index with fields length | Ensure that your database definition does not include index definitions with field lengths.
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/supership-jp/activerecord-spanner-adapter.
+Bug reports and pull requests are welcome on GitHub at https://github.com/googleapis/ruby-spanner-activerecord. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 ## License
-Copyright (c) 2017 Supership Inc.
 
-Licensed under MIT license.
+The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
+
+## Code of Conduct
 
+Everyone interacting in the Activerecord::Spanner project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/googleapis/ruby-spanner-activerecord/blob/master/CODE_OF_CONDUCT.md).

data/Rakefile

@@ -1,6 +1,82 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
 require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require "rake/testtask"
+require "securerandom"
+
+desc "Run tests."
+Rake::TestTask.new do |t|
+  t.libs << "test"
+  t.libs << "lib"
+  t.test_files = FileList["test/**/*_test.rb"]
+  t.warning = false
+end
+
+task :default => :test
+
+require "yard"
+require "yard/rake/yardoc_task"
+YARD::Rake::YardocTask.new do |y|
+  # y.options << "--fail-on-warning"
+end
+
+desc "Run the spanner connector acceptance tests."
+task :acceptance, [:project, :keyfile, :instance, :tests] do |t, args|
+  project = args[:project]
+  project ||= ENV["SPANNER_TEST_PROJECT"] || ENV["GCLOUD_TEST_PROJECT"]
+  emulator_host = args[:emulator_host]
+  emulator_host ||= ENV["SPANNER_EMULATOR_HOST"]
+  keyfile = args[:keyfile]
+  keyfile ||= ENV["SPANNER_TEST_KEYFILE"] || ENV["GCLOUD_TEST_KEYFILE"] || ENV["GOOGLE_APPLICATION_CREDENTIALS"]
+  if keyfile
+    keyfile = File.read keyfile
+  else
+    keyfile ||= ENV["SPANNER_TEST_KEYFILE_JSON"] || ENV["GCLOUD_TEST_KEYFILE_JSON"]
+  end
+  if project.nil? || (keyfile.nil? && emulator_host.nil?)
+    fail "You must provide a project and keyfile or emulator host name."
+  end
+  instance = args[:instance]
+  instance ||= ENV["SPANNER_TEST_INSTANCE"]
+  if instance.nil?
+    fail "You must provide an instance name"
+  end
+
+  # clear any env var already set
+  require "google/cloud/spanner/credentials"
+  Google::Cloud::Spanner::Credentials.env_vars.each do |path|
+    ENV[path] = nil
+  end
+
+  tests = args[:tests]
+  tests ||= "**"
+
+  # always overwrite when running tests
+  ENV["SPANNER_PROJECT"] = project
+  ENV["SPANNER_KEYFILE_JSON"] = keyfile
+  ENV["SPANNER_TEST_INSTANCE"] = instance
+  ENV["SPANNER_EMULATOR_HOST"] = emulator_host
+
+  Rake::TestTask.new :run do |t|
+    t.libs << "acceptance"
+    t.libs << "lib"
+    t.test_files = FileList["acceptance/#{tests}/*_test.rb"] unless tests.start_with? "exclude "
+    t.test_files = FileList.new("acceptance/**/*_test.rb") do |fl|
+      fl.exclude "acceptance/#{tests.split(" ")[1]}/*_test.rb"
+      puts "excluding acceptance/#{tests.split(" ")[1]}/*_test.rb"
+    end if tests.start_with? "exclude"
+    t.warning = false
+  end
 
-RSpec::Core::RakeTask.new("spec")
-task :default => :spec
+  Rake::Task["run"].invoke
+end
 
+desc +"Runs the `examples/snippets/quickstart` example on a Spanner emulator. See the directory `examples/snippets`"
+      "for more examples."
+task :example do
+  Dir.chdir("examples/snippets/quickstart") { sh "bundle exec rake run" }
+end

data/SECURITY.md

@@ -0,0 +1,7 @@
+# Security Policy
+
+To report a security issue, please use [g.co/vulnz](https://g.co/vulnz).
+
+The Google Security Team will respond within 5 working days of your report on g.co/vulnz.
+
+We use g.co/vulnz for our intake, and do coordination and disclosure here using GitHub Security Advisory to privately discuss and fix the issue.

data/acceptance/cases/associations/has_many_associations_test.rb

@@ -0,0 +1,119 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
+# frozen_string_literal: true
+
+require "test_helper"
+require "models/firm"
+require "models/account"
+require "models/transaction"
+require "models/department"
+require "models/customer"
+
+module ActiveRecord
+  module Associations
+    class HasManyTest < SpannerAdapter::TestCase
+      include SpannerAdapter::Associations::TestHelper
+
+      attr_accessor :customer
+
+      def setup
+        super
+
+        @customer = Customer.create name: "Customer - 1"
+
+        Account.create name: "Account - 1", customer: customer, credit_limit: 100
+        Account.create name: "Account - 2", customer: customer, credit_limit: 200
+      end
+
+      def teardown
+        Customer.destroy_all
+        Account.destroy_all
+      end
+
+      def test_has_many
+        assert_equal 2, customer.accounts.count
+        assert_equal customer.accounts.pluck(:credit_limit).sort, [100, 200]
+      end
+
+      def test_finding_using_associated_fields
+        assert_equal Account.where(customer_id: customer.id).to_a, customer.accounts.to_a
+      end
+
+      def test_successful_build_association
+        account = customer.accounts.build(name: "Account - 3", credit_limit: 1000)
+        assert account.save
+
+        customer.reload
+        assert_equal account, customer.accounts.find(account.id)
+      end
+
+      def test_create_and_destroy_associated_records
+        customer2 = Customer.new name: "Customer - 2"
+        customer2.accounts.build name: "Account - 11", credit_limit: 100
+        customer2.accounts.build name: "Account - 12", credit_limit: 200
+        customer2.save!
+
+        customer2.reload
+
+        assert_equal 2, customer2.accounts.count
+        assert_equal 4, Account.count
+
+        customer2.accounts.destroy_all
+        customer2.reload
+
+        assert_equal 0, customer2.accounts.count
+        assert_equal 2, Account.count
+      end
+
+      def test_create_and_delete_associated_records
+        customer2 = Customer.new name: "Customer - 2"
+        customer2.accounts.build name: "Account - 11", credit_limit: 100
+        customer2.accounts.build name: "Account - 12", credit_limit: 200
+        customer2.save!
+
+        customer2.reload
+
+        assert_equal 2, customer2.accounts.count
+        assert_equal 4, Account.count
+
+        assert_equal 2, customer2.accounts.delete_all
+        customer2.reload
+
+        assert_equal 0, customer2.accounts.count
+        assert_equal 2, Account.where(customer_id: nil).count
+      end
+
+      def test_update_associated_records
+        count = customer.accounts.update_all(name: "Account - Update", credit_limit: 1000)
+        assert_equal customer.accounts.count, count
+
+        customer.reload
+        customer.accounts.each do |account|
+          assert_equal "Account - Update", account.name
+          assert_equal 1000, account.credit_limit
+        end
+      end
+
+      def test_fetch_associated_record_with_order
+        accounts = customer.accounts.order(credit_limit: :desc)
+        assert_equal [200, 100], accounts.pluck(:credit_limit)
+
+        accounts = customer.accounts.order(credit_limit: :asc)
+        assert_equal [100, 200], accounts.pluck(:credit_limit)
+      end
+
+      def test_set_counter_cache
+        account = Account.first
+        account.transactions.create!(amount: 10)
+        account.transactions.create!(amount: 20)
+
+        account.reload
+        assert_equal 2, account.transactions_count
+      end
+    end
+  end
+end

data/acceptance/cases/associations/has_many_through_associations_test.rb

@@ -0,0 +1,63 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
+# frozen_string_literal: true
+
+require "test_helper"
+require "models/member"
+require "models/membership"
+require "models/member_type"
+require "models/club"
+
+module ActiveRecord
+  module Associations
+    class HasManyThroughTest < SpannerAdapter::TestCase
+      include SpannerAdapter::Associations::TestHelper
+
+      attr_accessor :club, :member_one, :member_two
+
+      def setup
+        super
+
+        @club = Club.create name:  "Club - 1"
+        @member_one = Member.create name: "Member - 1"
+        @member_two = Member.create name: "Member - 2"
+      end
+
+      def teardown
+        Member.destroy_all
+        Club.destroy_all
+      end
+
+      def test_has_many_through_create_record
+        assert club.members.create!(name: "Member - 3")
+      end
+
+      def test_through_association_with_joins
+        club.members = [member_one, member_two]
+        assert_equal [club, club], Club.where(id: club.id).joins(:members).to_a
+      end
+
+      def test_set_record_after_delete_association
+        club.members = [member_one, member_two]
+        club.reload
+        assert_equal 2, club.members.count
+
+        club.members = []
+        club.reload
+        assert_empty club.members
+      end
+
+      def test_has_many_through_eager_loading
+        club.members = [member_one, member_two]
+
+        clubs = Club.includes(:members).all.to_a
+        assert_equal 1, clubs.size
+        assert_not_nil assert_no_queries { clubs[0].members }
+      end
+    end
+  end
+end

data/acceptance/cases/associations/has_one_associations_test.rb

@@ -0,0 +1,79 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
+# frozen_string_literal: true
+
+require "test_helper"
+require "models/firm"
+require "models/account"
+require "models/department"
+
+
+module ActiveRecord
+  module Associations
+    class HasOneTest < SpannerAdapter::TestCase
+      include SpannerAdapter::Associations::TestHelper
+
+      attr_accessor :firm, :account
+
+      def setup
+        super
+
+        @account = Account.create name: "Account - #{rand 1000}", credit_limit: 100
+        @firm = Firm.create name: "Firm-#{rand 1000}", account: account
+
+        @account.reload
+        @firm.reload
+      end
+
+      def teardown
+        Firm.destroy_all
+        Account.destroy_all
+        Department.destroy_all
+      end
+
+      def test_has_one
+        assert_equal account, firm.account
+        assert_equal account.credit_limit, firm.account.credit_limit
+      end
+
+      def test_has_one_does_not_use_order_by
+        sql_log = capture_sql { firm.account }
+        assert sql_log.all? { |sql| !/order by/i.match?(sql) }, "ORDER BY was used in the query: #{sql_log}"
+      end
+
+      def test_finding_using_primary_key
+        assert_equal Account.find_by(firm_id: firm.id), firm.account
+      end
+
+      def test_successful_build_association
+        account = firm.build_account(credit_limit: 1000)
+        assert account.save
+
+        firm.reload
+        assert_equal account, firm.account
+      end
+
+      def test_delete_associated_records
+        assert_equal account, firm.account
+
+        firm.account.destroy
+        firm.reload
+        assert_nil firm.account
+      end
+
+      def test_polymorphic_association
+        assert_equal 0, firm.departments.count
+
+        firm.departments.create(name: "Department - 1")
+        firm.reload
+
+        assert_equal 1, firm.departments.count
+        assert_equal "Department - 1", firm.departments.first.name
+      end
+    end
+  end
+end