activerecord-spanner-adapter 0.3.0 → 0.5.0

data/acceptance/cases/migration/change_table_test.rb

@@ -0,0 +1,115 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
+# frozen_string_literal: true
+
+require "test_helper"
+
+module ActiveRecord
+  class Migration
+    class TableTest < SpannerAdapter::TestCase
+      include SpannerAdapter::Migration::TestHelper
+
+      def setup
+        skip_test_table_create!
+
+        super
+        @connection = Minitest::Mock.new
+      end
+
+      def teardown
+        assert @connection.verify
+      end
+
+      def with_change_table
+        yield ActiveRecord::Base.connection.update_table_definition(:delete_me, @connection)
+      end
+
+      def test_remove_references_column_type_with_polymorphic_removes_type
+        with_change_table do |t|
+          @connection.expect :remove_reference, nil, [:delete_me, :taggable, polymorphic: true]
+          t.remove_references :taggable, polymorphic: true
+        end
+      end
+
+      def test_references_column_type_with_polymorphic_and_options_null_is_false_adds_table_flag
+        with_change_table do |t|
+          @connection.expect :add_reference, nil, [:delete_me, :taggable, polymorphic: true, null: false]
+          t.references :taggable, polymorphic: true, null: false
+        end
+      end
+
+      def test_remove_references_column_type_with_polymorphic_and_options_null_is_false_removes_table_flag
+        with_change_table do |t|
+          @connection.expect :remove_reference, nil, [:delete_me, :taggable, polymorphic: true, null: false]
+          t.remove_references :taggable, polymorphic: true, null: false
+        end
+      end
+
+      def test_references_column_type_with_polymorphic_and_type
+        with_change_table do |t|
+          @connection.expect :add_reference, nil, [:delete_me, :taggable, polymorphic: true, type: :string]
+          t.references :taggable, polymorphic: true, type: :string
+        end
+      end
+
+      def test_remove_references_column_type_with_polymorphic_and_type
+        with_change_table do |t|
+          @connection.expect :remove_reference, nil, [:delete_me, :taggable, polymorphic: true, type: :string]
+          t.remove_references :taggable, polymorphic: true, type: :string
+        end
+      end
+
+      def test_timestamps_creates_updated_at_and_created_at
+        with_change_table do |t|
+          @connection.expect :add_timestamps, nil, [:delete_me, null: true]
+          t.timestamps null: true
+        end
+      end
+
+      def test_remove_timestamps_creates_updated_at_and_created_at
+        with_change_table do |t|
+          @connection.expect :remove_timestamps, nil, [:delete_me, { null: true }]
+          t.remove_timestamps(null: true)
+        end
+      end
+
+      def test_primary_key_creates_primary_key_column
+        with_change_table do |t|
+          @connection.expect :add_column, nil, [:delete_me, :id, :primary_key, primary_key: true, first: true]
+          t.primary_key :id, first: true
+        end
+      end
+
+      def test_index_exists
+        with_change_table do |t|
+          @connection.expect :index_exists?, nil, [:delete_me, :bar, {}]
+          t.index_exists?(:bar)
+        end
+      end
+
+      def test_index_exists_with_options
+        with_change_table do |t|
+          @connection.expect :index_exists?, nil, [:delete_me, :bar, { unique: true }]
+          t.index_exists?(:bar, unique: true)
+        end
+      end
+
+      def test_remove_drops_multiple_columns_when_column_options_are_given
+        with_change_table do |t|
+          @connection.expect :remove_columns, nil, [:delete_me, :bar, :baz, type: :string, null: false]
+          t.remove :bar, :baz, type: :string, null: false
+        end
+      end
+
+      def test_table_name_set
+        with_change_table do |t|
+          assert_equal :delete_me, t.name
+        end
+      end
+    end
+  end
+end

data/acceptance/cases/migration/column_attributes_test.rb

@@ -0,0 +1,122 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
+# frozen_string_literal: true
+
+require "test_helper"
+require "bigdecimal"
+
+module ActiveRecord
+  class Migration
+    class ColumnAttributesTest < SpannerAdapter::TestCase
+      include SpannerAdapter::Migration::TestHelper
+
+      def test_add_remove_single_field_using_string_arguments
+        assert_no_column TestModel, :last_name
+
+        add_column "test_models", "last_name", :string
+        assert_column TestModel, :last_name
+
+        remove_column "test_models", "last_name"
+        assert_no_column TestModel, :last_name
+      end
+
+      def test_add_remove_single_field_using_symbol_arguments
+        assert_no_column TestModel, :last_name
+
+        add_column :test_models, :last_name, :string
+        assert_column TestModel, :last_name
+
+        remove_column :test_models, :last_name
+        assert_no_column TestModel, :last_name
+      end
+
+      def test_add_column_without_limit
+        add_column :test_models, :description, :string, limit: nil
+        TestModel.reset_column_information
+        assert_equal "MAX", TestModel.columns_hash["description"].limit
+      end
+
+      # We specifically do a manual INSERT here, and then test only the SELECT
+      # functionality. This allows us to more easily catch INSERT being broken,
+      # but SELECT actually working fine.
+      def test_native_float_insert_manual_vs_automatic
+        correct_value = "0012345678901234567890.0123456789".to_f
+
+        connection.add_column "test_models", "wealth", :float
+
+        # Do a manual insertion
+        connection.transaction {
+          connection.execute "insert into test_models (id, wealth) values (#{generate_id}, 12345678901234567890.0123456789)"
+        }
+
+        # SELECT
+        row = TestModel.first
+        assert_kind_of Float, row.wealth
+
+        # If this assert fails, that means the SELECT is broken!
+        assert_equal correct_value, row.wealth
+
+        # Reset to old state
+        TestModel.delete_all
+
+        # Now use the Rails insertion
+        TestModel.create wealth: BigDecimal("12345678901234567890.0123456789")
+
+        # SELECT
+        row = TestModel.first
+        assert_kind_of Float, row.wealth
+
+        # If these asserts fail, that means the INSERT (create function, or cast to SQL) is broken!
+        assert_equal correct_value, row.wealth
+      end
+
+      def test_native_types
+        connection.ddl_batch do
+          add_column "test_models", "first_name", :string
+          add_column "test_models", "last_name", :string
+          add_column "test_models", "bio", :text
+          add_column "test_models", "age", :integer
+          add_column "test_models", "height", :float
+          add_column "test_models", "birthday", :datetime
+          add_column "test_models", "favorite_day", :date
+          add_column "test_models", "moment_of_truth", :datetime
+          add_column "test_models", "male", :boolean
+          add_column "test_models", "weight", :decimal
+        end
+
+        TestModel.create first_name: "bob", last_name: "bobsen",
+          bio: "I was born ....", age: 18, height: 1.78,
+          birthday: 18.years.ago, favorite_day: 10.days.ago,
+          moment_of_truth: "1782-10-10 21:40:18", male: true, weight: BigDecimal("75.6", 1)
+
+        bob = TestModel.first
+        assert_equal "bob", bob.first_name
+        assert_equal "bobsen", bob.last_name
+        assert_equal "I was born ....", bob.bio
+        assert_equal 18, bob.age
+        assert_equal 1.78, bob.height
+        assert_equal true, bob.male?
+        assert_equal BigDecimal("75.6", 1), bob.weight
+
+        assert_equal String, bob.first_name.class
+        assert_equal String, bob.last_name.class
+        assert_equal String, bob.bio.class
+        assert_kind_of Integer, bob.age
+        assert_equal Float, bob.height.class
+        assert_equal Time, bob.birthday.class
+        assert_equal Date, bob.favorite_day.class
+        assert_instance_of TrueClass, bob.male?
+        assert_equal BigDecimal, bob.weight.class
+      end
+
+      def test_add_column_and_ignore_limit
+        add_column :test_models, :integer_ignore_limit, :integer, limit: 10
+        assert_column TestModel, :integer_ignore_limit
+      end
+    end
+  end
+end

data/acceptance/cases/migration/column_positioning_test.rb

@@ -0,0 +1,48 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
+# frozen_string_literal: true
+
+require "test_helper"
+
+module ActiveRecord
+  class Migration
+    class ColumnPositioningTest < SpannerAdapter::TestCase
+      include SpannerAdapter::Migration::TestHelper
+
+      def setup
+        skip_test_table_create!
+        super
+
+        connection.ddl_batch do
+          connection.create_table :testing_columns_position, id: false, force: true do |t|
+            t.column :first, :integer
+            t.column :second, :integer
+            t.column :third, :integer
+          end
+        end
+      end
+
+      def teardown
+        connection.ddl_batch do
+          connection.drop_table :testing_columns_position
+        end rescue nil
+        ActiveRecord::Base.primary_key_prefix_type = nil
+      end
+
+      def test_column_positioning
+        assert_equal %w(first second third), connection.columns(:testing_columns_position).map(&:name)
+      end
+
+      def test_add_column_with_positioning
+        connection.ddl_batch do
+          connection.add_column :testing_columns_position, :fourth, :integer
+        end
+        assert_equal %w(first second third fourth), connection.columns(:testing_columns_position).map(&:name)
+      end
+    end
+  end
+end

data/acceptance/cases/migration/columns_test.rb

@@ -0,0 +1,201 @@
+# Copyright 2020 Google LLC
+#
+# Use of this source code is governed by an MIT-style
+# license that can be found in the LICENSE file or at
+# https://opensource.org/licenses/MIT.
+
+# frozen_string_literal: true
+
+require "test_helper"
+
+module ActiveRecord
+  class Migration
+    class ColumnsTest < SpannerAdapter::TestCase
+      include SpannerAdapter::Migration::TestHelper
+
+      def test_rename_column
+        connection.ddl_batch do
+          add_column "test_models", :hat_name, :string
+        end
+        assert_column TestModel, :hat_name
+
+        rename_column "test_models", :hat_name, :cap_name
+        assert_column TestModel, :cap_name
+      end
+
+      def test_change_column_default_value
+        error = assert_raise ActiveRecordSpannerAdapter::NotSupportedError do
+          change_column_default "test_models", :hat_name, "hat"
+        end
+
+        assert_equal "change column with default value not supported.", error.message
+      end
+
+      def test_remove_column_with_index
+        connection.ddl_batch do
+          add_column "test_models", :hat_name, :string
+          add_index :test_models, :hat_name
+        end
+
+        assert_equal 1, connection.indexes("test_models").size
+        connection.ddl_batch do
+          remove_column "test_models", "hat_name"
+        end
+        assert_equal 0, connection.indexes("test_models").size
+      end
+
+      def test_remove_column_with_multi_column_index
+        connection.ddl_batch do
+          add_column "test_models", :hat_size, :integer
+          add_column "test_models", :hat_style, :string, limit: 100
+          add_index "test_models", ["hat_style", "hat_size"], unique: true
+        end
+
+        assert_equal 1, connection.indexes("test_models").size
+        connection.ddl_batch do
+          remove_column "test_models", "hat_size"
+        end
+
+        assert_equal [], connection.indexes("test_models").map(&:name)
+      end
+
+      def test_change_type_of_not_null_column
+        connection.ddl_batch do
+          change_column "test_models", "updated_at", :datetime, null: false
+          change_column "test_models", "updated_at", :datetime, null: false
+        end
+
+        TestModel.reset_column_information
+        assert_equal false, TestModel.columns_hash["updated_at"].null
+      ensure
+        connection.ddl_batch do
+          change_column "test_models", "updated_at", :datetime, null: true
+        end
+      end
+
+      def test_change_column_nullability
+        connection.ddl_batch do
+          add_column "test_models", "funny", :boolean
+        end
+        assert TestModel.columns_hash["funny"].null, "Column 'funny' must initially allow nulls"
+
+        connection.ddl_batch do
+          change_column "test_models", "funny", :boolean, null: false
+        end
+
+        TestModel.reset_column_information
+        assert_not TestModel.columns_hash["funny"].null, "Column 'funny' must *not* allow nulls at this point"
+
+        connection.ddl_batch do
+          change_column "test_models", "funny", :boolean, null: true
+        end
+        TestModel.reset_column_information
+        assert TestModel.columns_hash["funny"].null, "Column 'funny' must allow nulls again at this point"
+      end
+
+      def test_change_column
+        # Only string and binary allows to change types
+        connection.ddl_batch do
+          add_column "test_models", "name", :string
+        end
+
+        old_columns = connection.columns TestModel.table_name
+
+        assert old_columns.find { |c| c.name == "name" && c.type == :string }
+
+        connection.ddl_batch do
+          change_column "test_models", "name", :binary
+        end
+
+        new_columns = connection.columns TestModel.table_name
+
+        assert_not new_columns.find { |c| c.name == "name" && c.type == :string }
+        assert new_columns.find { |c| c.name == "name" && c.type == :binary }
+      end
+
+      def test_change_column_with_custom_index_name
+        connection.ddl_batch do
+          add_column :test_models, :category, :string
+          add_index :test_models, :category, name: "test_models_categories_idx", order: { category: :desc}
+        end
+
+        assert_equal ["test_models_categories_idx"], connection.indexes("test_models").map(&:name)
+        connection.ddl_batch do
+          change_column "test_models", "category", :string, null: false
+        end
+
+        assert column_exists?(:test_models, :category, :string, null: false)
+        indexes = connection.indexes("test_models")
+        assert_equal ["test_models_categories_idx"], indexes.map(&:name)
+        assert_equal({ category: :desc }, indexes.first.orders)
+      end
+
+      def test_change_column_with_long_index_name
+        table_name_prefix = "test_models_"
+        long_index_name = table_name_prefix + ("x" * (connection.index_name_length - table_name_prefix.length))
+        connection.ddl_batch do
+          add_column "test_models", "category", :string
+          add_index :test_models, :category, name: long_index_name
+        end
+
+        connection.ddl_batch do
+          change_column "test_models", "category", :string, null: false
+        end
+
+        assert_equal [long_index_name], connection.indexes("test_models").map(&:name)
+      end
+
+      def test_remove_column_no_second_parameter_raises_exception
+        assert_raise(ArgumentError) { connection.remove_column("funny") }
+      end
+
+      def test_removing_column_preserves_custom_primary_key
+        connection.ddl_batch do
+          connection.create_table "my_table", primary_key: "my_table_id", force: true do |t|
+            t.integer "col_one"
+            t.string "col_two", limit: 128, null: false
+          end
+        end
+
+        connection.ddl_batch do
+          remove_column "my_table", "col_two"
+        end
+
+        assert_equal "my_table_id", connection.primary_key("my_table")
+
+        columns = connection.columns "my_table"
+        my_table_id = columns.detect { |c| c.name == "my_table_id" }
+        assert_equal "INT64", my_table_id.sql_type
+      ensure
+        connection.ddl_batch do
+          connection.drop_table :my_table rescue nil
+        end
+      end
+
+      def test_column_with_index
+        connection.ddl_batch do
+          connection.create_table "my_table", force: true do |t|
+            t.string :item_number, index: true
+          end
+        end
+
+        assert connection.index_exists?("my_table", :item_number, name: :index_my_table_on_item_number)
+      ensure
+        connection.ddl_batch do
+          connection.drop_table :my_table rescue nil
+        end
+      end
+
+      def test_add_column_without_column_name
+        e = assert_raise ArgumentError do
+          connection.create_table "my_table", force: true do |t|
+            t.timestamp
+          end
+        end
+        assert_equal "Missing column name(s) for timestamp", e.message
+      ensure
+        connection.drop_table :my_table, if_exists: true
+      end
+    end
+  end
+end