activerecord-sort 5.1.0 → 6.1.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 84044f4d2e6143480042232241610d5b0f6338b1
-  data.tar.gz: 6738849627c56faa780dcc7a6e0a740134580727
+SHA256:
+  metadata.gz: 1845764483eacf7b3cce0ee2b9b7f3d1cff6d3d1211518f12e54be59a7cccf9f
+  data.tar.gz: d4072a886aaeed64c12d01a5ede815db50efe30823731c0e8fb6c0c69fd8e762
 SHA512:
-  metadata.gz: e9fbde3f1d62240bfb453190b7f1195926873380347752e52ebc1740032f64f909a257e2ba5175ae619d2e1411091f53c4c418b48104ff59413a14210a2a12c2
-  data.tar.gz: 18647e51b72fff49310ffb6ac9a389522a840cb846bb547595eb5c0b93e9c66f19ff8f23eea714c9bf2d0b1673e0aa9d1561f14d4d8f7b6eeacfe470c92470f8
+  metadata.gz: 4356863599576c5a49c4a720eb6fd1be043235532d606cde9a1592d562ea643d1fe1abe906dcdc6c5fa6ef65155917605904ec780fdabb24858e0171364e4971
+  data.tar.gz: 104bdf59db87f9781f002af1faf40834373fa07fda6887f666f5d9324c25ee74b31f48b4f3d4ba2819d2f259907a89eede04f3e3ce61f8ebd7db0e234d050b78

data/README.md

@@ -1,4 +1,4 @@
-# ActiveRecord::sort
+# ActiveRecord::sort [![Travis CI](https://travis-ci.org/malomalo/activerecord-sort.svg?branch=master)](https://travis-ci.org/malomalo/activerecord-sort)
 
 `ActiveRecord::sort` provides and easy way to accept user input and order a query by the input.
 
@@ -13,34 +13,34 @@ Examples
 `ActiveRecord::sort` supports the following cases:
 
 ```ruby
-Property.order(:id).to_sql
+Property.sort(:id).to_sql
 # => "...ORDER BY properties.id ASC"
 
-Property.order(:id, :name).to_sql
+Property.sort(:id, :name).to_sql
 # => "...ORDER BY properties.id ASC, properties.name ASC"
 
-Property.order(:id => :desc).to_sql
+Property.sort(id: :desc).to_sql
 # => "...ORDER BY properties.id DESC"
 
-Property.order(:id => {:asc => :nulls_first})
+Property.sort(id: {asc: :nulls_first})
 # => "...ORDER BY properties.id ASC NULLS FIRST"
 
-Property.order(:id => {:asc => :nulls_last})
+Property.sort(id: {asc: :nulls_last})
 # => "...ORDER BY properties.id ASC NULLS LAST"
 ```
 
 It can also sort on relations:
 
 ```ruby
-Property.order(:addresses => :id).to_sql
+Property.sort(addresses: :id).to_sql
 # => "...INNER JOIN addresses ON addresses.property_id = properties.id
 # => "   ORDER BY addresses.id ASC"
 
-Property.order(:addresses => {:id => :desc}).to_sql
+Property.sort(addresses: {id: :desc}).to_sql
 # => "...INNER JOIN addresses ON addresses.property_id = properties.id
 # => "   ORDER BY addresses.id DESC"
 
-Property.order(:addresses => {:id => {:asc => :nulls_frist}}).to_sql
+Property.sort(addresses: {id: {asc: :nulls_frist}}).to_sql
 # => "...INNER JOIN addresses ON addresses.property_id = properties.id
 # => "   ORDER BY addresses.id ASC NULLS FIRST"
 ```

data/ext/active_record/base.rb

@@ -26,7 +26,7 @@ module ActiveRecord
           if column_or_relation.to_sym == :random
             resource = resource.random_sort
           elsif self.column_names.include?(column_or_relation.to_s)
-            resource = resource.sort_for_column(column_or_relation, options)
+            resource = resource.sort_for_column(self.arel_table[column_or_relation.to_s], options)
           elsif reflect_on_association(column_or_relation.to_sym)
             resource = resource.select(resource.klass.arel_table[Arel::Nodes::SqlLiteral.new('*')])
             resource = resource.sort_for_relation(column_or_relation.to_sym, options)
@@ -43,9 +43,9 @@ module ActiveRecord
       self.order(Arel::Nodes::RandomOrdering.new)
     end
 
+    # TODO: probably don't need to cast to sym
     def sort_for_column(column, options)
-      column = self.arel_table[column.to_s.underscore]
-      direction = (options.is_a?(Hash) ? options.keys.first.to_sym : options.to_s.downcase.to_sym)
+      direction = (options.is_a?(Hash) || options.class.name == "ActionController::Parameters" ? options.keys.first.to_sym : options.to_s.downcase.to_sym)
 
       nulls = (options.is_a?(Hash) ? options.values.first.to_sym : nil)
       if direction == :desc
@@ -67,7 +67,7 @@ module ActiveRecord
         options.each do |order|
           order = Array(order)
           order.each do |column, options|
-            column = relation.klass.arel_table[column]
+            column = Arel::Attributes::Relation.new(relation.klass.arel_table[column], relation.name)
             direction = (options.is_a?(Hash) ? options.keys.first.to_sym : options.to_s.downcase.to_sym)
 
             nulls = (options.is_a?(Hash) ? options.values.first.to_sym : nil)
@@ -110,7 +110,7 @@ module ActiveRecord
               order = Arel::Nodes::Descending.new(column, nulls)
             end
 
-            resource = resource.joins(relation.name)
+            resource = resource.left_outer_joins(relation.name)
             resource = resource.order(order)
           end
         end
@@ -120,4 +120,4 @@ module ActiveRecord
     end
 
   end
-end
+end

data/lib/active_record/sort.rb

@@ -1,10 +1,6 @@
 require 'active_record'
+require 'arel/extensions'
 
-require File.expand_path(File.join(__FILE__, '../../../ext/arel/order_predications'))
-require File.expand_path(File.join(__FILE__, '../../../ext/arel/nodes/ascending'))
-require File.expand_path(File.join(__FILE__, '../../../ext/arel/nodes/descending'))
-require File.expand_path(File.join(__FILE__, '../../../ext/arel/nodes/random'))
-require File.expand_path(File.join(__FILE__, '../../../ext/arel/visitors/postgresql'))
 require File.expand_path(File.join(__FILE__, '../../../ext/active_record/base'))
 
 ActiveRecord::Querying.delegate :sort, to: :all

data/lib/active_record/sort/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module Sort
-    VERSION = '5.1.0'
+    VERSION = '6.1.0.rc1'
   end
 end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sort
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 6.1.0.rc1
 platform: ruby
 authors:
 - Jon Bracy
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-08-28 00:00:00.000000000 Z
+date: 2020-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.1.0
+- !ruby/object:Gem::Dependency
+  name: arel-extensions
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: 6.1.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: 6.1.0.rc2
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -109,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -136,6 +150,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sunstone
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.1.0.rc1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.1.0.rc1
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A safe way to accept user parameters and order against your ActiveRecord
   Models
 email:
@@ -147,18 +189,13 @@ extra_rdoc_files:
 files:
 - README.md
 - ext/active_record/base.rb
-- ext/arel/nodes/ascending.rb
-- ext/arel/nodes/descending.rb
-- ext/arel/nodes/random.rb
-- ext/arel/order_predications.rb
-- ext/arel/visitors/postgresql.rb
 - lib/active_record/sort.rb
 - lib/active_record/sort/version.rb
 homepage: https://github.com/malomalo/activerecord-sort
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--main"
 - README.md
@@ -171,13 +208,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: A safe way to accept user parameters and order against your ActiveRecord
   Models

data/ext/arel/nodes/ascending.rb

@@ -1,14 +0,0 @@
-module Arel
-  module Nodes
-    class Ascending < Ordering
-
-      attr_accessor :nulls
-
-      def initialize expr, nulls=nil
-        super(expr)
-        @nulls = nulls
-      end
-
-    end
-  end
-end

data/ext/arel/nodes/descending.rb

@@ -1,15 +0,0 @@
-module Arel
-  module Nodes
-    class Descending < Ordering
-
-      attr_accessor :nulls
-
-      def initialize expr, nulls=nil
-        super(expr)
-        @nulls = nulls
-      end
-
-    end
-
-  end
-end

data/ext/arel/nodes/random.rb

@@ -1,7 +0,0 @@
-module Arel
-  module Nodes
-    class RandomOrdering < Arel::Nodes::Node
-
-    end
-  end
-end

data/ext/arel/order_predications.rb

@@ -1,14 +0,0 @@
-# Ordering with :nulls_last, :nulls_first options
-module Arel
-  module OrderPredications
-
-    def asc(nulls=nil)
-      Nodes::Ascending.new self, nulls
-    end
-
-    def desc(nulls=nil)
-      Nodes::Descending.new self, nulls
-    end
-
-  end
-end

data/ext/arel/visitors/postgresql.rb

@@ -1,28 +0,0 @@
-module Arel
-  module Visitors
-    class PostgreSQL
-      private
-      
-      def visit_Arel_Nodes_Ascending o, collector
-        case o.nulls
-        when :nulls_first then visit(o.expr, collector) << ' ASC NULLS FIRST'
-        when :nulls_last  then visit(o.expr, collector) << ' ASC NULLS LAST'
-        else visit(o.expr, collector) << ' ASC'
-        end
-      end
-
-      def visit_Arel_Nodes_Descending o, collector
-        case o.nulls
-        when :nulls_first then visit(o.expr, collector) << ' DESC NULLS FIRST'
-        when :nulls_last  then visit(o.expr, collector) << ' DESC NULLS LAST'
-        else visit(o.expr, collector) << ' DESC'
-        end
-      end
-      
-      def visit_Arel_Nodes_RandomOrdering o, collector
-        collector << "RANDOM()"
-      end
-      
-    end
-  end
-end