activerecord-slotted_counters 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff9187e867bfb86509d8303890fd3cdc1c93d0dc68463100bb43aafe2e15194d
-  data.tar.gz: 72aabf239bfb85122e3691e80ef8e6cef238b0630b6b2355416f75482b571725
+  metadata.gz: 94aead1f1be073e3dbf7548257d6db2b8eda15be09f2c199b6b3cdbf9b6ba0f3
+  data.tar.gz: ac2e1b977ab04501cd1139bd1d410b9f58b0b9395add905b1034eebb54fe4c86
 SHA512:
-  metadata.gz: 4bb48bae9e3567472423d670e9966c146f6004893cba795582a3e6f321ce8ce37c544d660b2b60480496dada50f04306a496fecfc454037ee6d013ca502d94ae
-  data.tar.gz: 59907136fb20a46b843e6944243def5fbcca00ccbed312ba687ff880edb2adfdadbaca8dc3c0f399abe385ed4d8748864c3dbad5fefd804861ea88fd25e44630
+  metadata.gz: ba74654e981dbc83043dc295296939e85053b2c7c8543ca3472d2f659523b9a3ea5be60ac15a87a492f7fa3758defac451382ff518a96f4feee573eb0f68ed26
+  data.tar.gz: 857ec7de346c584b1fcdd79bcb81becb7ecec9bb86b2087a8acf83d25ed13b55d25883439b6242b3f26bd726cc592897930ff9f1755c720b7aca41ed55d91503

data/CHANGELOG.md

@@ -2,9 +2,18 @@
 
 ## master
 
+## 0.1.2 (2023-03-28)
+
+- Fix preloading counters for multiple records [#12](https://github.com/evilmartians/activerecord-slotted_counters/pull/12) ([@LukinEgor][])
+
+## 0.1.1 (2023-01-17)
+
+- Fix prevent double increment/decrement of native counter caches [#10](https://github.com/evilmartians/activerecord-slotted_counters/pull/10) ([@danielwestendorf][])
+
 ## 0.1.0 (2022-11-29)
 
 - Initial release.
 
 [@palkan]: https://github.com/palkan
 [@LukinEgor]: https://github.com/LukinEgor
+[@danielwestendorf]: https://github.com/danielwestendorf

data/README.md

@@ -2,7 +2,7 @@
 
 # Active Record slotted counters
 
-This gem adds **slotted counters** support to [Active Record counter cache][counter-cache]. Slotted counters help to reduce contention on a single row update in case you many concurrent operations (like updating a page views counter during traffic spikes).
+This gem adds **slotted counters** support to [Active Record counter cache][counter-cache]. Slotted counters help to reduce contention on a single row update in case you have many concurrent operations (like updating a page views counter during traffic spikes).
 
 Read more about slotted counters in [this post](https://planetscale.com/blog/the-slotted-counter-pattern).
 

data/lib/activerecord_slotted_counters/has_slotted_counter.rb

@@ -5,15 +5,15 @@ require "activerecord_slotted_counters/utils"
 
 module ActiveRecordSlottedCounters
   class SlottedCounter < ::ActiveRecord::Base
-    scope :associated_records, ->(counter_name, id, klass) do
-      where(counter_name: counter_name, associated_record_id: id, associated_record_type: klass)
+    scope :associated_records, ->(counter_name, klass) do
+      where(counter_name: counter_name, associated_record_type: klass)
     end
   end
 
   module BelongsToAssociation
     def update_counters_via_scope(klass, foreign_key, by)
       counter_name = reflection.counter_cache_column
-      super unless klass.registered_slotted_counter? counter_name
+      return super unless klass.registered_slotted_counter? counter_name
 
       klass.update_counters(foreign_key, counter_name => by, :touch => reflection.options[:touch])
     end
@@ -38,7 +38,7 @@ module ActiveRecordSlottedCounters
         counter_name = slotted_counter_name(counter_type)
         association_name = slotted_counter_association_name(counter_type)
 
-        has_many association_name, ->(model) { associated_records(counter_name, model.id, model.class.to_s) }, **SLOTTED_COUNTERS_ASSOCIATION_OPTIONS
+        has_many association_name, ->(model) { associated_records(counter_name, model.class.to_s) }, **SLOTTED_COUNTERS_ASSOCIATION_OPTIONS
 
         scope :with_slotted_counters, ->(counter_type) do
           association_name = slotted_counter_association_name(counter_type)
@@ -182,7 +182,7 @@ module ActiveRecordSlottedCounters
     end
 
     def increment!(attribute, by = 1, touch: nil)
-      super unless self.class.registered_slotted_counter? attribute
+      return super unless self.class.registered_slotted_counter? attribute
 
       self.class.update_counters(id, attribute => by, :touch => touch)
     end
@@ -191,16 +191,8 @@ module ActiveRecordSlottedCounters
 
     def read_slotted_counter(counter_type)
       association_name = slotted_counter_association_name(counter_type)
-
-      if association_cached?(association_name)
-        scope = association(association_name).scope
-        counter = scope.sum(&:count)
-
-        return counter
-      end
-
-      scope = send(association_name)
-      scope.sum(:count)
+      scope = association(association_name).load_target
+      scope.sum(&:count)
     end
   end
 end

data/lib/activerecord_slotted_counters/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordSlottedCounters # :nodoc:
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-slotted_counters
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Egor Lukin
 - Vladimir Dementyev
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-29 00:00:00.000000000 Z
+date: 2023-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -95,6 +95,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-sqlimit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Active Record slotted counters support
 email:
 - dementiev.vm@gmail.com
@@ -121,7 +135,7 @@ metadata:
   documentation_uri: http://github.com/evilmartians/activerecord-slotted_counters
   homepage_uri: http://github.com/evilmartians/activerecord-slotted_counters
   source_code_uri: http://github.com/evilmartians/activerecord-slotted_counters
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -136,8 +150,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.11
-signing_key:
+rubygems_version: 3.3.3
+signing_key: 
 specification_version: 4
 summary: Active Record slotted counters support
 test_files: []