activerecord-slotted_counters 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff9187e867bfb86509d8303890fd3cdc1c93d0dc68463100bb43aafe2e15194d
-  data.tar.gz: 72aabf239bfb85122e3691e80ef8e6cef238b0630b6b2355416f75482b571725
+  metadata.gz: 5dcee16f487cc8b48e6fb4c4b84069cc97b9647d5e710fa8d8c2e25038620815
+  data.tar.gz: 43b9d1432b7aa8088c1508038d8927cf4aca1e8e33e3a159a3b915b7037f8084
 SHA512:
-  metadata.gz: 4bb48bae9e3567472423d670e9966c146f6004893cba795582a3e6f321ce8ce37c544d660b2b60480496dada50f04306a496fecfc454037ee6d013ca502d94ae
-  data.tar.gz: 59907136fb20a46b843e6944243def5fbcca00ccbed312ba687ff880edb2adfdadbaca8dc3c0f399abe385ed4d8748864c3dbad5fefd804861ea88fd25e44630
+  metadata.gz: 9783f3d0166756156a12e2337539acca146ebb8cbec1298d3b3b06a8721c2a23c18e61bc38c2944cd2fb999f798129e30ef608c4f862fad4e3d7628573cd49d3
+  data.tar.gz: a6a250dd5daed59fd0495954c9220e02de57e99232d2e19f7e159d9f838d4ad6b2a90acc3ece9f466a829afc99467ec4ef096130827be9d3ba13197c665cb367

data/CHANGELOG.md

@@ -2,9 +2,14 @@
 
 ## master
 
+## 0.1.1 (2023-01-17)
+
+- Fix prevent double increment/decrement of native counter caches [#10](https://github.com/evilmartians/activerecord-slotted_counters/pull/10) ([@danielwestendorf][])
+
 ## 0.1.0 (2022-11-29)
 
 - Initial release.
 
 [@palkan]: https://github.com/palkan
 [@LukinEgor]: https://github.com/LukinEgor
+[@danielwestendorf]: https://github.com/danielwestendorf

data/README.md

@@ -2,7 +2,7 @@
 
 # Active Record slotted counters
 
-This gem adds **slotted counters** support to [Active Record counter cache][counter-cache]. Slotted counters help to reduce contention on a single row update in case you many concurrent operations (like updating a page views counter during traffic spikes).
+This gem adds **slotted counters** support to [Active Record counter cache][counter-cache]. Slotted counters help to reduce contention on a single row update in case you have many concurrent operations (like updating a page views counter during traffic spikes).
 
 Read more about slotted counters in [this post](https://planetscale.com/blog/the-slotted-counter-pattern).
 

data/lib/activerecord_slotted_counters/has_slotted_counter.rb

@@ -13,7 +13,7 @@ module ActiveRecordSlottedCounters
   module BelongsToAssociation
     def update_counters_via_scope(klass, foreign_key, by)
       counter_name = reflection.counter_cache_column
-      super unless klass.registered_slotted_counter? counter_name
+      return super unless klass.registered_slotted_counter? counter_name
 
       klass.update_counters(foreign_key, counter_name => by, :touch => reflection.options[:touch])
     end
@@ -182,7 +182,7 @@ module ActiveRecordSlottedCounters
     end
 
     def increment!(attribute, by = 1, touch: nil)
-      super unless self.class.registered_slotted_counter? attribute
+      return super unless self.class.registered_slotted_counter? attribute
 
       self.class.update_counters(id, attribute => by, :touch => touch)
     end

data/lib/activerecord_slotted_counters/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordSlottedCounters # :nodoc:
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-slotted_counters
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Egor Lukin
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-29 00:00:00.000000000 Z
+date: 2023-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord