activerecord-reputation-system 2.0.1 → 2.0.2

data/README.md

@@ -71,14 +71,14 @@ Once reputation system is defined, evaluations for answers and questions can be
 
 Reputation value can be accessed as follow:
 ```ruby
-@answer.reptuation_for(:avg_rating) #=> 3
-@question.reptuation_for(:votes) #=> 1
-@user.reptuation_for(:karma)
+@answer.reputation_for(:avg_rating) #=> 3
+@question.reputation_for(:votes) #=> 1
+@user.reputation_for(:karma)
 ```
 
 You can query for records using reputation value:
 ```ruby
-@user.with_reputation(:karma).where('karma > 10')
+User.find_with_reputation(:karma, :all, { :condition => 'karma > 10' })
 ```
 
 You can get source records that have evaluated the target record:
@@ -93,13 +93,13 @@ Question.evaluated_by(:votes, @user) #=> [@question]
 
 ## Documentation
 
-Please refer [Wiki](https://github.com/twitter/activerecord-reputation-system/wiki) for available APIs.
+Please refer [Wiki](https://github.com/twitter/activerecord-reputation-system/wiki) for available APIs and more information.
 
 ## Authors
 
 Katsuya Noguchi
 * [http://twitter.com/kn](http://twitter.com/kn)
-* [http://github.com/katsuyan](http://github.com/katsuyan)
+* [http://github.com/kn](http://github.com/kn)
 
 ## Contributors
 

data/lib/reputation_system/models/evaluation.rb

@@ -32,7 +32,7 @@ module ReputationSystem
     validate :source_must_be_defined_for_reputation_in_network
 
     def self.find_by_reputation_name_and_source_and_target(reputation_name, source, target)
-      source_type = get_source_type_for_sti(source, target.class.name, reputation_name)
+      source_type = get_source_type_for_sti(source.class.name, target.class.name, reputation_name)
       ReputationSystem::Evaluation.find(:first,
                         :conditions => {:reputation_name => reputation_name.to_s,
                                         :source_id => source.id,
@@ -48,11 +48,23 @@ module ReputationSystem
                            :target_id => target.id, :target_type => target.class.name)
     end
 
+    # Override exists? class method.
+    class << self
+      alias :original_exists? :exists?
+
+      def exists?(options={})
+        if options[:source_type] && options[:target_type] && options[:reputation_name]
+          options[:source_type] = get_source_type_for_sti(options[:source_type], options[:target_type], options[:reputation_name])
+        end
+        original_exists? options
+      end
+    end
+
     protected
 
-      def self.get_source_type_for_sti(source, target_type, reputation_name)
+      def self.get_source_type_for_sti(source_type, target_type, reputation_name)
         valid_source_type = ReputationSystem::Network.get_reputation_def(target_type, reputation_name)[:source].to_s.camelize
-        source_class = source.class
+        source_class = source_type.constantize
         while source_class && valid_source_type != source_class.name && source_class.name != "ActiveRecord::Base"
           source_class = source_class.superclass
         end
@@ -60,7 +72,7 @@ module ReputationSystem
       end
 
       def set_source_type_for_sti
-        sti_source_type = self.class.get_source_type_for_sti(source, target_type, reputation_name)
+        sti_source_type = self.class.get_source_type_for_sti(source_type, target_type, reputation_name)
         self.source_type = sti_source_type if sti_source_type
       end
 

data/lib/reputation_system/version.rb

@@ -15,5 +15,5 @@
 ##
 
 module ReputationSystem
-  VERSION = "2.0.1"
+  VERSION = "2.0.2"
 end

data/spec/reputation_system/evaluation_methods_spec.rb

@@ -140,7 +140,7 @@ describe ReputationSystem::EvaluationMethods do
         lambda { answer.add_evaluation(:avg_rating, 3, @user) }.should_not raise_error
       end
 
-      context "With Scopes" do
+      context "with scopes" do
         it "should add evaluation on appropriate scope" do
           @phrase.add_evaluation(:difficulty_with_scope, 1, @user, :s1).should be_true
           @phrase.add_evaluation(:difficulty_with_scope, 2, @user, :s2).should be_true
@@ -171,7 +171,7 @@ describe ReputationSystem::EvaluationMethods do
         @question.reputation_for(:total_votes).should == 2
       end
 
-      context "With Scopes" do
+      context "with scopes" do
         it "should add evaluation on appropriate scope if it does not exist" do
           @phrase.add_or_update_evaluation(:difficulty_with_scope, 1, @user, :s1).should be_true
           @phrase.add_or_update_evaluation(:difficulty_with_scope, 2, @user, :s2).should be_true
@@ -190,6 +190,16 @@ describe ReputationSystem::EvaluationMethods do
           @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
       end
+
+      context "with STI" do
+        it "should be able to update evaluation by an object of a class with sti" do
+          @post = Post.create! :name => "Post1"
+          @designer = Designer.create! :name => "John"
+          @post.add_or_update_evaluation(:votes, 1, @designer)
+          @post.add_or_update_evaluation(:votes, -1, @designer)
+          @post.reputation_for(:votes).should == -1
+        end
+      end
     end
 
     describe "#update_evaluation" do

data/spec/spec_helper.rb

@@ -108,6 +108,11 @@ ActiveRecord::Schema.define do
     t.string :type
     t.timestamps
   end
+
+  create_table :posts do |t|
+    t.string :name
+    t.timestamps
+  end
 end
 
 class User < ActiveRecord::Base
@@ -193,6 +198,8 @@ class Translation < ActiveRecord::Base
     :source_of => { :reputation => :maturity, :of => :phrase, :scope => :locale}
 end
 
+# For STI Specs
+
 class Person < ActiveRecord::Base
   has_reputation :leadership,
     :source => :person,
@@ -204,3 +211,10 @@ end
 
 class Designer < Person
 end
+
+class Post < ActiveRecord::Base
+  belongs_to :person
+
+  has_reputation :votes,
+    :source => :person
+end

metadata

@@ -1,93 +1,120 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: activerecord-reputation-system
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 2.0.2
   prerelease: 
-  version: 2.0.1
 platform: ruby
-authors: 
+authors:
 - Katsuya Noguchi
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-10-05 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-12-01 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: activerecord
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rake
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 0.8.7
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.8.7
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        version: "2.8"
+      - !ruby/object:Gem::Version
+        version: '2.8'
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: rdoc
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.8'
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: database_cleaner
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: database_cleaner
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 0.7.1
   type: :development
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
-  name: sqlite3
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.1
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 1.3.5
   type: :development
-  version_requirements: *id006
-description: ActiveRecord Reputation System gem allows rails apps to compute and publish reputation scores for active record models.
-email: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.3.5
+description: ActiveRecord Reputation System gem allows rails apps to compute and publish
+  reputation scores for active record models.
+email:
 - katsuya@twitter.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - LICENSE
 - README.md
 - Rakefile
@@ -125,30 +152,27 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/twitter/activerecord-reputation-system
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
-summary: ActiveRecord Reputation System gem allows rails apps to compute and publish reputation scores for active record models
+summary: ActiveRecord Reputation System gem allows rails apps to compute and publish
+  reputation scores for active record models
 test_files: []
-