activerecord-precounter 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e486607a409dc25b776267ae02f8bd0ef8f801f5
-  data.tar.gz: 38667cea1241dc1820e77289185a6102b031af3e
+  metadata.gz: 8c85fec9116becd14760b8726df821d422085a4c
+  data.tar.gz: 5c216798df88c22adfe212b5695e4667600ded38
 SHA512:
-  metadata.gz: 98e0d0d94a90f233250936bb69ce3e5f9407f30687097c10afff7168710a05bb249de0611ca916700ac04400690f2c5187b694bd14b476a11d13a776a4530d03
-  data.tar.gz: 8c9bdebda2f932c1f7ed4b699020b4528d918a24b5335a7954a4a24bec269ababa1d6cb24484aeff4b0a6ede03f7ea17a50736b9c9b7742cf3de6c8d62f74cc6
+  metadata.gz: a472ba502fb21376132e0c8742a50d83c2ac4dc09b39115b592071d26fd2ef5ab20fe94cd2f76db66039e00ebea05504bb36e376d7222e49a1bc335d394cc95f
+  data.tar.gz: 5c6f1140da169bb55a909fb35b1cee56e5371a772b7c729324c353a992f646bd85730e1c225b3a613701bdd4aa51dc1d0ac1f0a38d7b2bbf52596f7e9bc03495

data/README.md

@@ -36,7 +36,7 @@ Like `preload`, it loads counts by multiple queries
 
 ```rb
 tweets = Tweet.all
-ActiveRecord::Precounter.new(tweets, :favorites).precount
+ActiveRecord::Precounter.new(tweets).precount(:favorites)
 tweets.each do |tweet|
   p tweet.favorites_count
 end
@@ -55,7 +55,7 @@ gem 'activerecord-precounter'
 ## Limitation
 
 Target `has_many` association must have inversed `belongs_to`.
-i.e. `ActiveRecord::Precounter.new(tweets, :favorites).precount` needs both `Tweet.has_many(:favorites)` and `Favorite.belongs_to(:tweet)`.
+i.e. `ActiveRecord::Precounter.new(tweets).precount(:favorites)` needs both `Tweet.has_many(:favorites)` and `Favorite.belongs_to(:tweet)`.
 
 Unlike [activerecord-precount](https://github.com/k0kubun/activerecord-precount), the cache store is not ActiveRecord association and it does not utilize ActiveRecord preloader.
 Thus you can't use `preload` to eager load counts for nested associations. And currently there's no JOIN support.

data/lib/active_record/precounter/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   class Precounter
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

data/lib/active_record/precounter.rb

@@ -5,19 +5,20 @@ module ActiveRecord
     class MissingInverseOf < StandardError; end
 
     # @param [ActiveRecord::Relation] relation - Parent resources relation.
-    # @param [Array<String,Symbol>] association_names - Eager loaded association names. e.g. `[:users, :likes]`
-    def initialize(relation, *association_names)
+    def initialize(relation)
       @relation = relation
-      @association_names = association_names.map(&:to_s)
     end
 
+    # @param [Array<String,Symbol>] association_names - Eager loaded association names. e.g. `[:users, :likes]`
     # @return [Array<ActiveRecord::Base>]
-    def precount
+    def precount(*association_names)
       records = @relation.to_a
       return if records.empty?
 
-      @association_names.each do |association_name|
+      association_names.each do |association_name|
+        association_name = association_name.to_s
         reflection = @relation.klass.reflections.fetch(association_name)
+
         if reflection.inverse_of.nil?
           raise MissingInverseOf.new(
             "`#{reflection.klass}` does not have inverse of `#{@relation.klass}##{reflection.name}`. "\

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-precounter
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Takashi Kokubun