activerecord-postgis-adapter 7.1.1 → 8.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40546b155985259941dab5c7fef8ec7f0d4959a29087044a133c4918929d7e2f
-  data.tar.gz: b80326260c605d158e4647caa361d07000c622140ae90e505f97a0576f2ce26a
+  metadata.gz: a24c165231e4b03b66bac3cc34446bc6683e960a7cfc5dd0e9cdc83aa9662b81
+  data.tar.gz: 1f8267c7469590eb14e12312e311e195c87504d3a1a64a9fe79392d50a9dab2f
 SHA512:
-  metadata.gz: 8b3aee9a59f53669fe3e44c1f471f30f3e37f20b0a18bb920ac46535e264f573492da49c268d04a037b959517018584aa69c6fe1d9f45b211b3a55ed8d19a1d2
-  data.tar.gz: af501e0d2e9e3cc0990c67812fa9fc1fc2202ba9f15ed5f6a69dfe4e73709ef4cc339c9846ee60a804e6f5f2a5bf754d6f4082508a1cbd17dfa3e7c9f985c5f2
+  metadata.gz: 976f8ee3f628fcacffea4e7890f5c4f29d2308c3aa28bb070d7d547931767dce49438286f0be1dcb1424b9e3f38f5fb260f6c51750062755b0124416f5387064
+  data.tar.gz: 2012d45e2fb4603c11657a9a7d9a907d93e3202200eddc990bedd1a6a0e73680d9064838d248dabbc7c244d4c70ae461e49aa6c74adc96605abbf5b444eae0ba

data/lib/active_record/connection_adapters/postgis/oid/date_time.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module ActiveRecord
+  module ConnectionAdapters
+    module PostGIS
+      module OID
+        module DateTime
+          protected
+
+          # Uses PostGIS instead of PostgreSQLAdapter
+          def real_type_unless_aliased(real_type)
+            ActiveRecord::ConnectionAdapters::PostGISAdapter.datetime_type == real_type ? :datetime : real_type
+          end
+        end
+
+        PostgreSQL::OID::DateTime.prepend(DateTime)
+      end
+    end
+  end
+end

data/lib/active_record/connection_adapters/postgis/oid/spatial.rb

@@ -9,7 +9,7 @@ module ActiveRecord
         # Accepts `geo_type`, `srid`, `has_z`, `has_m`, and `geographic` as parameters.
         # Responsible for parsing sql_types returned from the database and WKT features.
         class Spatial < Type::Value
-          def initialize(geo_type: 'geometry', srid: 0, has_z: false, has_m: false, geographic: false)
+          def initialize(geo_type: "geometry", srid: 0, has_z: false, has_m: false, geographic: false)
             @geo_type = geo_type
             @srid = srid
             @has_z = has_z

data/lib/active_record/connection_adapters/postgis/schema_statements.rb

@@ -5,18 +5,22 @@ module ActiveRecord
     module PostGIS
       module SchemaStatements
         # override
-        # https://github.com/rails/rails/blob/6-0-stable/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L624
+        # https://github.com/rails/rails/blob/7-0-stable/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L662
         # Create a SpatialColumn instead of a PostgreSQL::Column
         def new_column_from_field(table_name, field)
-          column_name, type, default, notnull, oid, fmod, collation, comment = field
+          column_name, type, default, notnull, oid, fmod, collation, comment, attgenerated = field
           type_metadata = fetch_type_metadata(column_name, type, oid.to_i, fmod.to_i)
           default_value = extract_value_from_default(default)
-          default_function = extract_default_function(default_value, default)
 
-          serial =
-            if (match = default_function&.match(/\Anextval\('"?(?<sequence_name>.+_(?<suffix>seq\d*))"?'::regclass\)\z/))
-              sequence_name_from_parts(table_name, column_name, match[:suffix]) == match[:sequence_name]
-            end
+          if attgenerated.present?
+            default_function = default
+          else
+            default_function = extract_default_function(default_value, default)
+          end
+
+          if match = default_function&.match(/\Anextval\('"?(?<sequence_name>.+_(?<suffix>seq\d*))"?'::regclass\)\z/)
+            serial = sequence_name_from_parts(table_name, column_name, match[:suffix]) == match[:sequence_name]
+          end
 
           # {:dimension=>2, :has_m=>false, :has_z=>false, :name=>"latlon", :srid=>0, :type=>"GEOMETRY"}
           spatial = spatial_column_info(table_name).get(column_name, type_metadata.sql_type)
@@ -30,49 +34,11 @@ module ActiveRecord
             collation: collation,
             comment: comment.presence,
             serial: serial,
+            generated: attgenerated,
             spatial: spatial
           )
         end
 
-        # override
-        # https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L544
-        #
-        # returns Postgresql sql type string
-        # examples:
-        #   "geometry(Point,4326)"
-        #   "geography(Point,4326)"
-        #
-        # note: type alone is not enough to detect the sql type,
-        # so `limit` is used to pass the additional information. :(
-        #
-        # type_to_sql(:geography, limit: "Point,4326")
-        # => "geography(Point,4326)"
-        def type_to_sql(type, limit: nil, precision: nil, scale: nil, array: nil, **)
-          case type.to_s
-          when "geometry", "geography"
-            "#{type}(#{limit})"
-          else
-            super
-          end
-        end
-
-        # override
-        def native_database_types
-          # Add spatial types
-          super.merge(
-            geography:           { name: "geography" },
-            geometry:            { name: "geometry" },
-            geometry_collection: { name: "geometry_collection" },
-            line_string:         { name: "line_string" },
-            multi_line_string:   { name: "multi_line_string" },
-            multi_point:         { name: "multi_point" },
-            multi_polygon:       { name: "multi_polygon" },
-            spatial:             { name: "geometry" },
-            st_point:            { name: "st_point" },
-            st_polygon:          { name: "st_polygon" }
-          )
-        end
-
         # override
         def create_table_definition(*args, **kwargs)
           PostGIS::TableDefinition.new(self, *args, **kwargs)
@@ -83,33 +49,6 @@ module ActiveRecord
           @spatial_column_info ||= {}
           @spatial_column_info[table_name.to_sym] ||= SpatialColumnInfo.new(self, table_name.to_s)
         end
-
-        def initialize_type_map(map = type_map)
-          %w(
-            geography
-            geometry
-            geometry_collection
-            line_string
-            multi_line_string
-            multi_point
-            multi_polygon
-            st_point
-            st_polygon
-          ).each do |geo_type|
-            map.register_type(geo_type) do |_, _, sql_type|
-              # sql_type is a string that comes from the database definition
-              # examples:
-              #   "geometry(Point,4326)"
-              #   "geography(Point,4326)"
-              #   "geometry(Polygon,4326) NOT NULL"
-              #   "geometry(Geography,4326)"
-              geo_type, srid, has_z, has_m, geographic = OID::Spatial.parse_sql_type(sql_type)
-              OID::Spatial.new(geo_type: geo_type, srid: srid, has_z: has_z, has_m: has_m, geographic: geographic)
-            end
-          end
-
-          super
-        end
       end
     end
   end

data/lib/active_record/connection_adapters/postgis/spatial_column.rb

@@ -9,7 +9,7 @@ module ActiveRecord  # :nodoc:
         #   "Geography(Point,4326)"
         def initialize(name, default, sql_type_metadata = nil, null = true,
                        default_function = nil, collation: nil, comment: nil,
-                       serial: nil, spatial: nil)
+                       serial: nil, generated: nil, spatial: nil)
           @sql_type_metadata = sql_type_metadata
           @geographic = !!(sql_type_metadata.sql_type =~ /geography\(/i)
           if spatial
@@ -31,14 +31,12 @@ module ActiveRecord  # :nodoc:
             build_from_sql_type(sql_type_metadata.sql_type)
           end
           super(name, default, sql_type_metadata, null, default_function,
-                collation: collation, comment: comment, serial: serial)
-          if spatial?
-            if @srid
-              @limit = { srid: @srid, type: to_type_name(geometric_type) }
-              @limit[:has_z] = true if @has_z
-              @limit[:has_m] = true if @has_m
-              @limit[:geographic] = true if @geographic
-            end
+                collation: collation, comment: comment, serial: serial, generated: generated)
+          if spatial? && @srid
+            @limit = { srid: @srid, type: to_type_name(geometric_type) }
+            @limit[:has_z] = true if @has_z
+            @limit[:has_m] = true if @has_m
+            @limit[:geographic] = true if @geographic
           end
         end
 
@@ -73,9 +71,10 @@ module ActiveRecord  # :nodoc:
 
         def to_type_name(geometric_type)
           name = geometric_type.type_name.underscore
-          if name == "point"
+          case name
+          when "point"
             "st_point"
-          elsif name == "polygon"
+          when "polygon"
             "st_polygon"
           else
             name

data/lib/active_record/connection_adapters/postgis/spatial_column_info.rb

@@ -21,7 +21,7 @@ module ActiveRecord  # :nodoc:
             dimension = row[1].to_i
             has_m = !!(type =~ /m$/i)
             type.sub!(/m$/, "")
-            has_z = dimension > 3 || dimension == 3 && !has_m
+            has_z = dimension > 3 || (dimension == 3 && !has_m)
             result[name] = {
               dimension: dimension,
               has_m:     has_m,

data/lib/active_record/connection_adapters/postgis/spatial_table_definition.rb

@@ -8,9 +8,15 @@ module ActiveRecord  # :nodoc:
 
         # super: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
         def new_column_definition(name, type, **options)
-          if (info = PostGISAdapter.spatial_column_options(type.to_sym))
-            if (limit = options.delete(:limit))
-              options.merge!(limit) if limit.is_a?(::Hash)
+          col_type = if type.to_sym == :virtual
+            options[:type]
+          else
+            type
+          end
+
+          if (info = PostGISAdapter.spatial_column_options(col_type))
+            if (limit = options.delete(:limit)) && limit.is_a?(::Hash)
+              options.merge!(limit)
             end
 
             geo_type = ColumnDefinitionUtils.geo_type(options[:type] || type || info[:type])

data/lib/active_record/connection_adapters/postgis/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module ConnectionAdapters
     module PostGIS
-      VERSION = "7.1.1"
+      VERSION = "8.0.3"
     end
   end
 end

data/lib/active_record/connection_adapters/postgis_adapter.rb

@@ -17,18 +17,10 @@ require "active_record/connection_adapters/postgis/spatial_column_info"
 require "active_record/connection_adapters/postgis/spatial_table_definition"
 require "active_record/connection_adapters/postgis/spatial_column"
 require "active_record/connection_adapters/postgis/arel_tosql"
-require "active_record/connection_adapters/postgis/setup"
 require "active_record/connection_adapters/postgis/oid/spatial"
+require "active_record/connection_adapters/postgis/oid/date_time"
 require "active_record/connection_adapters/postgis/type" # has to be after oid/*
 require "active_record/connection_adapters/postgis/create_connection"
-require "active_record/connection_adapters/postgis/postgis_database_tasks"
-
-ActiveRecord::ConnectionAdapters::PostGIS.initial_setup
-
-if defined?(Rails::Railtie)
-  require "active_record/connection_adapters/postgis/railtie"
-end
-
 # :startdoc:
 
 module ActiveRecord
@@ -72,6 +64,53 @@ module ActiveRecord
         DEFAULT_SRID
       end
 
+      class << self
+        def initialize_type_map(map = type_map)
+          %w[
+            geography
+            geometry
+            geometry_collection
+            line_string
+            multi_line_string
+            multi_point
+            multi_polygon
+            st_point
+            st_polygon
+          ].each do |geo_type|
+            map.register_type(geo_type) do |_, _, sql_type|
+              # sql_type is a string that comes from the database definition
+              # examples:
+              #   "geometry(Point,4326)"
+              #   "geography(Point,4326)"
+              #   "geometry(Polygon,4326) NOT NULL"
+              #   "geometry(Geography,4326)"
+              geo_type, srid, has_z, has_m, geographic = PostGIS::OID::Spatial.parse_sql_type(sql_type)
+              PostGIS::OID::Spatial.new(geo_type: geo_type, srid: srid, has_z: has_z, has_m: has_m, geographic: geographic)
+            end
+          end
+
+          super
+        end
+
+        def native_database_types
+          @native_database_types ||= begin
+            default_types = PostgreSQLAdapter.native_database_types
+            default_types.merge({
+              geography:           { name: "geography" },
+              geometry:            { name: "geometry" },
+              geometry_collection: { name: "geometry_collection" },
+              line_string:         { name: "line_string" },
+              multi_line_string:   { name: "multi_line_string" },
+              multi_point:         { name: "multi_point" },
+              multi_polygon:       { name: "multi_polygon" },
+              spatial:             { name: "geometry" },
+              st_point:            { name: "st_point" },
+              st_polygon:          { name: "st_polygon" }
+            })
+          end
+        end
+      end
+
       def srs_database_columns
         {
           auth_name_column: "auth_name",
@@ -115,6 +154,16 @@ module ActiveRecord
       end
     end
   end
+  SchemaDumper.ignore_tables |= %w[
+    geography_columns
+    geometry_columns
+    layer
+    raster_columns
+    raster_overviews
+    spatial_ref_sys
+    topology
+  ]
+  Tasks::DatabaseTasks.register_task(/postgis/, "ActiveRecord::Tasks::PostgreSQLDatabaseTasks")
 end
 
 # if using JRUBY, create ArJdbc::PostGIS module

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-postgis-adapter
 version: !ruby/object:Gem::Version
-  version: 7.1.1
+  version: 8.0.3
 platform: ruby
 authors:
 - Daniel Azuma
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-17 00:00:00.000000000 Z
+date: 2023-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: 7.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: 7.0.0
 - !ruby/object:Gem::Dependency
   name: rgeo-activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -82,19 +82,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: benchmark-ips
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.9.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.9.1
+- !ruby/object:Gem::Dependency
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.50'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.50'
 description: ActiveRecord connection adapter for PostGIS. It is based on the stock
   PostgreSQL adapter, and adds built-in support for the spatial extensions provided
   by PostGIS. It uses the RGeo library to represent spatial data in Ruby.
@@ -111,12 +125,9 @@ files:
 - lib/active_record/connection_adapters/postgis/column_methods.rb
 - lib/active_record/connection_adapters/postgis/create_connection.rb
 - lib/active_record/connection_adapters/postgis/database_statements.rb
-- lib/active_record/connection_adapters/postgis/databases.rake
+- lib/active_record/connection_adapters/postgis/oid/date_time.rb
 - lib/active_record/connection_adapters/postgis/oid/spatial.rb
-- lib/active_record/connection_adapters/postgis/postgis_database_tasks.rb
-- lib/active_record/connection_adapters/postgis/railtie.rb
 - lib/active_record/connection_adapters/postgis/schema_statements.rb
-- lib/active_record/connection_adapters/postgis/setup.rb
 - lib/active_record/connection_adapters/postgis/spatial_column.rb
 - lib/active_record/connection_adapters/postgis/spatial_column_info.rb
 - lib/active_record/connection_adapters/postgis/spatial_table_definition.rb
@@ -127,7 +138,8 @@ files:
 homepage: http://github.com/rgeo/activerecord-postgis-adapter
 licenses:
 - BSD-3-Clause
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -136,14 +148,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: ActiveRecord adapter for PostGIS, based on RGeo.

data/lib/active_record/connection_adapters/postgis/databases.rake

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-namespace :db do
-  namespace :gis do
-    desc 'Setup PostGIS data in the database'
-    task setup: [:load_config] do
-      environments = [Rails.env]
-      environments << 'test' if Rails.env.development?
-      environments.each do |environment|
-        ActiveRecord::Base.configurations
-                          .configs_for(env_name: environment)
-                          .reject { |env| env.configuration_hash[:database].blank? }
-                          .each do |env|
-          ActiveRecord::ConnectionAdapters::PostGIS::PostGISDatabaseTasks.new(env).setup_gis
-        end
-      end
-    end
-  end
-end

data/lib/active_record/connection_adapters/postgis/postgis_database_tasks.rb

@@ -1,142 +0,0 @@
-# frozen_string_literal: true
-
-module ActiveRecord  # :nodoc:
-  module ConnectionAdapters  # :nodoc:
-    module PostGIS  # :nodoc:
-      class PostGISDatabaseTasks < ::ActiveRecord::Tasks::PostgreSQLDatabaseTasks  # :nodoc:
-        def initialize(db_config)
-          super
-          ensure_installation_configs
-        end
-
-        def setup_gis
-          establish_su_connection
-          if extension_names
-            setup_gis_from_extension
-          end
-          establish_connection(db_config)
-        end
-
-        # Override to set the database owner and call setup_gis
-        def create(master_established = false)
-          establish_master_connection unless master_established
-          extra_configs = { encoding: encoding }
-          extra_configs[:owner] = username if has_su?
-          connection.create_database(db_config.database, configuration_hash.merge(extra_configs))
-          setup_gis
-        rescue ::ActiveRecord::StatementInvalid => error
-          if /database .* already exists/ === error.message
-            raise ::ActiveRecord::DatabaseAlreadyExists
-          else
-            raise
-          end
-        end
-
-        private
-
-        # Override to use su_username and su_password
-        def establish_master_connection
-          establish_connection(configuration_hash.merge(
-            database:           "postgres",
-            password:           su_password,
-            schema_search_path: "public",
-            username:           su_username
-          ))
-        end
-
-        def establish_su_connection
-          establish_connection(configuration_hash.merge(
-            password:           su_password,
-            schema_search_path: "public",
-            username:           su_username
-          ))
-        end
-
-        def username
-          @username ||= configuration_hash[:username]
-        end
-
-        def quoted_username
-          @quoted_username ||= ::ActiveRecord::Base.connection.quote_column_name(username)
-        end
-
-        def password
-          @password ||= configuration_hash[:password]
-        end
-
-        def su_username
-          @su_username ||= configuration_hash.fetch(:su_username, username)
-        end
-
-        def su_password
-          @su_password ||= configuration_hash.fetch(:su_password, password)
-        end
-
-        def has_su?
-          return @has_su if defined?(@has_su)
-
-          @has_su = configuration_hash.include?(:su_username)
-        end
-
-        def search_path
-          @search_path ||= configuration_hash[:schema_search_path].to_s.strip.split(",").map(&:strip)
-        end
-
-        def extension_names
-          @extension_names ||= begin
-            extensions = configuration_hash[:postgis_extension]
-            case extensions
-            when ::String
-              extensions.split(",")
-            when ::Array
-              extensions
-            else
-              ["postgis"]
-            end
-          end
-        end
-
-        def ensure_installation_configs
-          if configuration_hash[:setup] == "default" && !configuration_hash[:postgis_extension]
-            share_dir = `pg_config --sharedir`.strip rescue "/usr/share"
-            control_file = ::File.expand_path("extension/postgis.control", share_dir)
-            if ::File.readable?(control_file)
-              @configuration_hash = configuration_hash.merge(postgis_extension: "postgis").freeze
-            end
-          end
-        end
-
-        def setup_gis_from_extension
-          extension_names.each do |extname|
-            if extname == "postgis_topology"
-              unless search_path.include?("topology")
-                raise ArgumentError, "'topology' must be in schema_search_path for postgis_topology"
-              end
-              connection.execute("CREATE EXTENSION IF NOT EXISTS #{extname} SCHEMA topology")
-            else
-              if (postgis_schema = configuration_hash[:postgis_schema])
-                schema_clause = "WITH SCHEMA #{postgis_schema}"
-                unless schema_exists?(postgis_schema)
-                  connection.execute("CREATE SCHEMA #{postgis_schema}")
-                  connection.execute("GRANT ALL ON SCHEMA #{postgis_schema} TO PUBLIC")
-                end
-              else
-                schema_clause = ""
-              end
-
-              connection.execute("CREATE EXTENSION IF NOT EXISTS #{extname} #{schema_clause}")
-            end
-          end
-        end
-
-        def schema_exists?(schema_name)
-          connection.execute(
-            "SELECT schema_name FROM information_schema.schemata WHERE schema_name = '#{schema_name}'"
-          ).any?
-        end
-      end
-
-      ::ActiveRecord::Tasks::DatabaseTasks.register_task(/postgis/, PostGISDatabaseTasks)
-    end
-  end
-end

data/lib/active_record/connection_adapters/postgis/railtie.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module ActiveRecord  # :nodoc:
-  module ConnectionAdapters  # :nodoc:
-    module PostGIS  # :nodoc:
-      class Railtie < ::Rails::Railtie  # :nodoc:
-        rake_tasks do
-          load "active_record/connection_adapters/postgis/databases.rake"
-        end
-      end
-    end
-  end
-end

data/lib/active_record/connection_adapters/postgis/setup.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-module ActiveRecord  # :nodoc:
-  module ConnectionAdapters  # :nodoc:
-    module PostGIS  # :nodoc:
-      def self.initial_setup
-        ::ActiveRecord::SchemaDumper.ignore_tables |= %w(
-          geography_columns
-          geometry_columns
-          layer
-          raster_columns
-          raster_overviews
-          spatial_ref_sys
-          topology
-        )
-      end
-    end
-  end
-end