activerecord-polymorph 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52c2f6317a218c26936a2cc6b637b992cfddd239
-  data.tar.gz: dd2c70fc9f51e69f4bdf8813a910a6879913c5a2
+  metadata.gz: 5d1b99dbcba39839072dfd1f95466e9a9aa8249a
+  data.tar.gz: ba0a4138bda24d8f5dc2577390fa4bd27b35ab62
 SHA512:
-  metadata.gz: 1d004e0abd6224692cb789738c6c8fcb5552ab901bbc4c9423453c1db5aa8d559d775aac75945073dcdfae38be4a4e6637a53ae241e3917f7fde5822fd83ba57
-  data.tar.gz: 9a0a30ca6bcfd69db7bac4eecb2ca3970b6e7f9e48c65dff9edc9bb1017c0efc68e8652de7d51689b2f97a445c208e266d8a3ac81896f79c84eca214b27a01e0
+  metadata.gz: 23c12a901d994fa3c6cb58ad447db3cda94d8fa5471270fe9d76e93e72fb2971b9fb5202a0ffa34a3756ebc7ce812284838435fb130978ab785e04b314e0df2f
+  data.tar.gz: bbfec582d55ab7144b18b0e3ba171d6476c66378512d13bf06ee1fcdb0de00c3af587f6515cf65d1e296ca22a8fb5d4f019c5d4ca579b4458623558140f14cee

data/.gitignore

@@ -7,3 +7,5 @@
 /pkg/
 /spec/reports/
 /tmp/
+*.gem
+.byebug_history

data/README.md

@@ -89,13 +89,13 @@ polymorph :participants, through: :comments, source_types: [:users, :robots], fi
 If we want to call these 'participants', but our database columns are already set to 'commenter_id' and 'commenter_type', we can invoke the `source_column` method:
 
 ```ruby
-polymorph :commenters, through: :comments, source_types: [:users, :robots], source_column: :commenter
+polymorph :participants, through: :comments, source_types: [:users, :robots], source_column: :commenter
 ```
 
 If the ruby class cannot be inferred by the 'through' option, we can point it to the right place with `through_class`:
 
 ```ruby
-polymorph :commenters, through: :comments, source_types: [:users, :robots], through_class: Comments::Base
+polymorph :participants, through: :comments, source_types: [:users, :robots], through_class: Comments::Base
 ```
 
 NB that this relation has somewhat limited support for further querying! Currently, we support count, pluck, and simple where clauses on common keys:

data/activerecord-polymorph.gemspec

@@ -23,4 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.12"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "temping", "~> 3.7"
+  spec.add_development_dependency "sqlite3", "~> 1.3"
+  spec.add_development_dependency "byebug", "~> 9.0"
 end

data/lib/polymorph/methods.rb

@@ -1,5 +1,4 @@
 require "polymorph/relation"
-require "byebug"
 
 module Polymorph
   module Methods
@@ -17,7 +16,7 @@ module Polymorph
           source_types.map { |t| "#{t}.*" },
           source_types.product(fields).map { |a| "#{a[0]}.#{a[1]} AS #{a[0].to_s.singularize}_#{a[1]}" },
           "#{through}.#{source_column}_type",
-          "'true'::boolean as polymorph_query"
+          "'is_polymorph' as polymorph_query"
         ].flatten.join(', '))
 
         source_types.each do |type|
@@ -33,6 +32,7 @@ module Polymorph
 
       through_class.define_singleton_method :instantiate, ->(attrs, column_types) {
         super(attrs, column_types).tap do |record|
+          break unless attrs['polymorph_query'].present?
           transfer_fields = fields.map { |field| [field, attrs["#{attrs[source_type].downcase}_#{field}"]] }.to_h
           record.assign_attributes(transfer_fields)
         end

data/lib/polymorph/relation.rb

@@ -16,7 +16,7 @@ module Polymorph
 
     def where(hash = {})
       fields = hash.slice(*@fields)
-      fields.map do |field|
+      clause = fields.map do |field|
         %{(
           #{@source_types.map { |type| "#{type}.#{field[0]} = :#{field[0]}" }.join(" OR ")}
         )}

data/lib/polymorph/version.rb

@@ -1,3 +1,3 @@
 module Polymorph
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-polymorph
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - James Kiesel
@@ -66,6 +66,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: temping
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.7'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '9.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '9.0'
 description: 
 email:
 - james.kiesel@gmail.com