activerecord-originator 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa3749b460f4bf88f4ae707b69db1e2c32f41d7bfac6780ebafbc4e96375a730
-  data.tar.gz: b130e6f429f7cd6acc167715a08797f9816f16d06fa990fc1ddda22c4d17700b
+  metadata.gz: 293717934922e2684e5351b8f2c1abe48bb72f13706a3c3453496e92b501dd18
+  data.tar.gz: 0c445a63206b42a5742727875d51bb95385e48d086d637966b784397d9acc6ba
 SHA512:
-  metadata.gz: 30ce59ca0d48a39793d27a959db9a93dff186006ac83bb4fe220469cde766ac7627c9fe1e0b9f429ecb16e339481f95dbbc39ad7d656d82b1875ef88281f4216
-  data.tar.gz: c502f0bf40254b8d92484e4a9fa5e5bdc20eb28a096e4a265fb94616dcca7f3ce4dc6f37e9c2e9a740666f4aeac31e68886fcd50ceb16797c43abd46506480fd
+  metadata.gz: 6aada6e56b8c43b7f0fe9c6520ffedbb6c9cb099e817815cbc48a67b7473903cbb8cf9cb0fe899354d7de1f5808ee81d315b8b7e5b976989270dc0e3b97ddbce
+  data.tar.gz: 896311b48db01c18309b3d7d22c41b4dda6385c81cba5ff47fb3e568f6a569d82ff2d6fced94fe6a6996a688eef271a784008500e3ff183f020246b9783497c4

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+# CHANGELOG
+
+## v0.2.1 - 2024-03-20
+
+This release does not affect the behavior of the library. It changes only RBS files.
+
+* Avoid exposing Rails.backtrace_cleaner type [#19](https://github.com/pocke/activerecord-originator/pull/19)
+
+## v0.2.0 - 2024-03-16
+
+* Avoid modifying unnecessary nodes for performance. [#15](https://github.com/pocke/activerecord-originator/pull/15)
+
+## v0.1.0 - 2024-03-13
+
+* The first release!

data/Rakefile

@@ -14,3 +14,28 @@ task :steep do
 end
 
 task default: %i[rubocop steep spec]
+
+namespace :benchmark do
+  task :to_sql do
+    puts "# Benchmarking #to_sql mehtod"
+    puts
+    puts "## Wihtout AR::Originator"
+    sh 'ruby', 'benchmark/to_sql.rb'
+
+    puts
+    puts "## With AR::Originator"
+    sh 'ruby', '-r', 'activerecord/originator', 'benchmark/to_sql.rb'
+  end
+
+  task :select_query do
+    puts "# Benchmarking SELECT Query"
+    puts
+    puts "## Wihtout AR::Originator"
+    sh 'ruby', 'benchmark/select_query.rb'
+
+    puts
+    puts "## With AR::Originator"
+    sh 'ruby', '-r', 'activerecord/originator', 'benchmark/select_query.rb'
+  end
+end
+task benchmark: %i[benchmark:to_sql benchmark:select_query]

data/lib/activerecord/originator/arel_visitor_extension.rb

@@ -3,13 +3,7 @@
 module ActiveRecord
   module Originator
     module ArelVisitorExtension
-      def accept(object, collector)
-        super(object, CollectorProxy.new(collector))
-      end
-
-      private
-
-      %i[
+      TARGET_NODE_CLASSESS = %i[
         Ascending
         Descending
         Equality
@@ -21,7 +15,15 @@ module ActiveRecord
         LessThan
         LessThanOrEqual
         GreaterThanOrEqual
-      ].each do |klass_name|
+      ]
+
+      def accept(object, collector)
+        super(object, CollectorProxy.new(collector))
+      end
+
+      private
+
+      TARGET_NODE_CLASSESS.each do |klass_name|
         define_method(:"visit_Arel_Nodes_#{klass_name}") do |o, collector|
           __skip__ = begin
             comment = originator_comment(o)

data/lib/activerecord/originator/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Originator
-    VERSION = "0.1.0"
+    VERSION = "0.2.1"
   end
 end

data/lib/activerecord/originator.rb

@@ -10,7 +10,13 @@ require_relative "originator/arel_node_extension"
 require_relative "originator/arel_visitor_extension"
 require_relative "originator/collector_proxy"
 
-Arel::Nodes::Node.descendants.each do |klass|
+ActiveRecord::Originator::ArelVisitorExtension::TARGET_NODE_CLASSESS.each do |name|
+  begin
+    klass = Arel::Nodes.const_get(name)
+  rescue NameError
+    # Some classes are not defined in old arel
+    next
+  end
   klass.prepend ActiveRecord::Originator::ArelNodeExtension
 end
 Arel::Visitors::ToSql.prepend ActiveRecord::Originator::ArelVisitorExtension

data/rbs_collection.lock.yaml

@@ -6,7 +6,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 372c833bb52be1bc34aef5e2793ab47c35c0dba9
+    revision: be76a75932e8ed6ee91a95ba936cf88b674bf044
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: activerecord
@@ -14,7 +14,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 372c833bb52be1bc34aef5e2793ab47c35c0dba9
+    revision: be76a75932e8ed6ee91a95ba936cf88b674bf044
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: activesupport
@@ -22,7 +22,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 372c833bb52be1bc34aef5e2793ab47c35c0dba9
+    revision: be76a75932e8ed6ee91a95ba936cf88b674bf044
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: base64
@@ -38,7 +38,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 372c833bb52be1bc34aef5e2793ab47c35c0dba9
+    revision: be76a75932e8ed6ee91a95ba936cf88b674bf044
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: connection_pool
@@ -46,7 +46,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 372c833bb52be1bc34aef5e2793ab47c35c0dba9
+    revision: be76a75932e8ed6ee91a95ba936cf88b674bf044
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: date
@@ -62,7 +62,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 372c833bb52be1bc34aef5e2793ab47c35c0dba9
+    revision: be76a75932e8ed6ee91a95ba936cf88b674bf044
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: logger

data/rbs_collection.yaml

@@ -6,8 +6,3 @@ sources:
     repo_dir: gems
 
 path: .gem_rbs_collection
-
-gems:
-  - name: activerecord-originator
-    ignore: true
-  - name: activerecord

data/sig/_polyfill/rails.rbs

@@ -0,0 +1,3 @@
+module Rails
+  def self.backtrace_cleaner: () -> untyped
+end

data/sig/activerecord/originator/arel_visitor_extension.rbs

@@ -1,6 +1,7 @@
 module ActiveRecord
   module Originator
     module ArelVisitorExtension : _ArelVisitor
+      TARGET_NODE_CLASSESS: Array[Symbol]
       def accept: (untyped object, _Collector collector) -> untyped
 
       private

data/sig/{polyfill.rbs → interfaces.rbs}

@@ -1,7 +1,3 @@
-module Rails
-  def self.backtrace_cleaner: () -> untyped
-end
-
 module ActiveRecord::Originator
   interface _ArelVisitor
     def accept: (untyped, untyped) -> untyped

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-originator
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Masataka Pocke Kuwabara
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-13 00:00:00.000000000 Z
+date: 2024-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -48,6 +48,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".rubocop.yml"
+- CHANGELOG.md
 - LICENSE
 - README.md
 - Rakefile
@@ -60,12 +61,13 @@ files:
 - lib/activerecord/originator/version.rb
 - rbs_collection.lock.yaml
 - rbs_collection.yaml
+- sig/_polyfill/rails.rbs
 - sig/activerecord/originator.rbs
 - sig/activerecord/originator/arel_node_extension.rbs
 - sig/activerecord/originator/arel_visitor_extension.rbs
 - sig/activerecord/originator/collector_proxy.rbs
 - sig/activerecord/originator/version.rbs
-- sig/polyfill.rbs
+- sig/interfaces.rbs
 homepage: https://github.com/pocke/activerecord-originator
 licenses:
 - MIT