activerecord-oracle_enhanced-adapter 1.8.2 → 5.2.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 955c1c3d11ce8928038c4f64681234c4cf7ad304
-  data.tar.gz: c08040c3b024d62a76653409df2cda7e723a7ce6
+SHA256:
+  metadata.gz: 756277df9a862718b6a18af9b3ff476e12a2497c45d8bdcfdaf47d4be0ebff8b
+  data.tar.gz: e970bf14ed9a4eec4b85c67c50c804ffa6a4e52a788a0d95463dfd44b5453ce8
 SHA512:
-  metadata.gz: 758ddc44a6c42afe6a160142c5d6d489bb5c4f240333d1ce715e7434f4da57240a46f84207b1160fe831bd0489a76e23e21cea4515b159bc01ade69379cc1620
-  data.tar.gz: a95939add8ff9aebaf535aeb4d293f0466dcde14479e0ccf4fdbdcf54f37b23e34924f793b54975dc06e0e0e24ec24406b441a6106a071946f7dcf25bd4fb04c
+  metadata.gz: 750450b6486e4d3289e4131dd98e433eef87f37e23d20004729cb2fffe6564e98f476a08afe987cad7f673499ded21903300a31a19bed7f3ff0a18f735fd5de5
+  data.tar.gz: dead151bdc335ee36ac65e1c8b50679fedc1d1a388b314e3f71dce6a79186ebd893fb261e97018a9773c3e65820daf465e47177e5f9ed949a7c2c4fee4f2b837

data/History.md

@@ -1,3 +1,188 @@
+## 5.2.0.beta1 / 2017-11-27
+
+* Major changes and fixes
+
+  * Support Rails 5.2.0.beta1 [Not released yet but this history will be available when Rails 5.2.0.beta1 is available]
+  * Oracle enhanced adapter version follows Rails versioning [#1488]
+  * Handle `TIMESTAMP WITH TIMEZONE` separately from `TIMEZONE` [#1267]
+  * Support `timestamptz` and `timestampltz` for migrations #1285
+  * `supports_json?` returns false [#1562]
+  * Add synonyms in `data_sources` [#1380, #1567]
+  * Add sequence with settings to structure dump [#1354]
+  * Support for NCLOB datatype [#1428, #1440]
+  * Use conventional fixture load [#1366]
+  * Address `ORA-00905: missing keyword: EXPLAIN PLAN FOR` [#1384]
+  * Use new method name for active record dirty checks [#1406]
+  * check for schema name when validating table name [#1408, #1410]
+  * Prefer to place a table options before `force: :cascade` [#1457]
+  * Enable TCP keepalive for OCI connections [#1489]
+  * Do not expose `all_schema_indexes` [#1495]
+  * Using bind variables for dictionary access [#1498]
+  * Use bind variables for `table_comment` `column_comment` `foreign_keys` [#1502]
+  * Respect database instance `cursor_sharing` value `exact` by default [#1503, #1556]
+  * Address `CommentTest#test_change_table_comment_to_nil` failure [#1504]
+  * Address explain with binds errors [#908, #1386, #1538]
+  * Address `MigrationTest#test_create_table_with_query_from_relation` error [#1543]
+  * Follow the new interface of AR::ConnectionAdapters::IndexDefinition#initialize [#1295]
+  * Remove `lengths`, `where`, `using` from `IndexDefinition` [#1529]
+  * Arity change in insert method [#1382]
+  * Restore the ability that SQL with binds for `insert` [#1424]
+  * Restore `to_sql` to return only SQL [#1423]
+  * Signature fix for `select_one` `select_value` `select_values` [#1475]
+  * `columns` second argument does not exist in Abstract adapter [#1519]
+  * Arel::Nodes::BindParam#initialize introduced [#1383]
+  * Log the purpose of sql in `disable_referential_integrity` [#1550]
+  * Change log format of "Primary Key Trigger" to one line [#1551]
+  * Log multi lines SQL statements into one line [#1553]
+  * Log multi lines SQL statements into one line at `structure_dump.rb` [#1555]
+  * [ci skip] `open_cursors` value should be larger than `:statement_limit` [#1573]
+  * [skip ci] Add `schema` option in the comment [#1574]
+  * [skip ci] `emulate_booleans_from_strings` behavior changes [#1576]
+  * Restore calling `OCIConnection#bind_returning_param` [#1581]
+  * Add these errors to be recognized as `ActiveRecord::StatementInvalid` [#1584]
+  * Add `ORA-02289` to be recognized as `ActiveRecord::StatementInvalid` [#1586]
+  * Address `BasicsTest#test_clear_cache!` failure [#1587]
+  * Use Bundler 1.15 to workaround bundler/bundler#6072 [#1590]
+  * Translate `ORA-00060` into `ActiveRecord::Deadlocked` error [#1591]
+  * Add `ORA-02449` to be recognized as `ActiveRecord::StatementInvalid` [#1593, #1596]
+  * Support `discard!` method [#1598]
+
+* Deprecation or removing deprecated code
+
+  * Remove `OracleEnhancedAdapter.cache_columns` [#1490, #1492]
+  * Deprecate `supports_statement_cache?` [#1321]
+  * Remove `compress_lines` [#1327]
+  * Remove `OracleEnhanced::SchemaDumper::TableInspect` [#1400]
+  * Remove `remove_prefix_and_suffix` and specs from Oracle enhanced adapter [#1420]
+  * Remove unused returning value `stream` [#1438]
+  * Remove `OracleEnhancedAdapter.emulate_dates` [#1448]
+  * Remove `emulate_dates` and `emulate_dates_by_column_name` [#1450]
+  * Remove `emulate_integers_by_column_name` [#1451]
+  * Remove `@@do_not_prefetch_primary_key` class variable [#1496]
+  * Remove `string_to_date` which has been removed from Rails 4.2 [#1509]
+  * Remove `string_to_time` which has been removed from Rails 4.2 [#1510]
+  * Remove `guess_date_or_time` which has not been called [#1511]
+  * Remove unused `object_type?` and `object_type` ivar [#1512]
+  * Remove non-existent `:nchar` from `attr_reader` [#1513]
+  * Remove `ActiveRecord::ConnectionAdapter::OracleEnhanced::Column#lob?` [#1522]
+  * Remove `OracleEnhanced::Column#returning_id?` [#1523]
+  * Remove `attr_reader :table_name` [#1524]
+  * Remove `combine_bind_parameters` [#1527]
+  * Remove `OracleEnhancedAdapter.default_tablespaces[native_database_types[type][:name]]` [#1544]
+  * Remove unused `require "digest/sha1"` [#1545]
+  * Remove deprecations for 5.2 [#1548]
+  * Remove `OracleEnhanced::Connection#select_values` [#1558]
+  * Remove `@connection` from `@connection.oracle_downcase` and `@connection.select_value` [#1559]
+  * Rename `OracleEnhanced::Connection#select_value` to `_select_value` [#1563]
+  * Rename `OracleEnhanced::Connection#oracle_downcase` to `_oracle_downcase` [#1565]
+  * Remove `OCIConnection#typecast_result_value` handling `OraNumber` [#1578]
+  * [skip ci] Changing `NLS_DATE_FORMAT` and `NLS_TIMESTAMP_FORMAT` is not supported [#1575]
+  * [skip ci] Remove ruby versions in the comment [#1577]
+  * Remove `OCIConnection#returning_clause` and `JDBCConnection#returning_clause` [#1579]
+  * Remove `OCIConnection#exec_with_returning` and `JDBCConnection#exec_with_returning` [#1580]
+  * Update `JDBCConnection#bind_param` case condition [#1583]
+
+* Refactoring
+
+  * Refactor `SchemaDumper` to make it possible to adapter specific customization [#1430]
+  * Rename `SchemaDumper#indexes` to `SchemaDumper#_indexes` [#1399]
+  * Use ActiveRecord::Type::Json [#1352]
+  * Introduce module `DatabaseLimits` [#1322]
+  * Move `oracle_downcase` to `Quoting` module [#1328]
+  * Make `type_map` to private because it is only used in the connection adapter [#1381]
+  * Remove `add_runtime_dependency` with arel [#1385]
+  * Move methods for synonyms out of `SchemaStatementsExt` [#1387]
+  * Remove incorrect prepend to `ActiveRecord::ColumnDumper` [#1394]
+  * Handle `ActiveRecord::SchemaDumper` by `adapter_name` [#1395] 
+  * Rewrite `remove_prefix_and_suffix` to be similar with super #1401
+  * `remove_prefix_and_suffix` handles dollar sign by `Regexp#escape` [#1402]
+  * `prepare_column_options` is now private [#1429]
+  * Introduce `OracleEnhanced::SchemaStatements#table_options` [#1439]
+  * Extract `ActiveRecord::ConnectionAdapters::OracleEnhanced::Column` [#1445]
+  * Extract `ActiveRecord::ConnectionAdapters::OracleEnhanced::DbmsOutput` [#1446]
+  * Introduce `SchemaDumpingHelper#dump_table_schema` [#1455]
+  * Rename `OracleEnhancedConnection` to `OracleEnhanced::Connection` [#1477]
+  * Introduce `ActiveRecord::ConnectionAdapters::OracleEnhanced::TypeMetadata` [#1515]
+  * Change `schema_creation` to private [#1517]
+  * Change `create_table_definition` and `fetch_type_metadata` to private [#1518]
+  * Refactor `columns` [#1521]
+  * Let `ActiveRecord::ConnectionAdapters::OracleEnhanced::TypeMetadata` handle `virtual` type [#1526]
+  * Clean up `column_definitions` method [#1528]
+  * Remove unnecessary `ActiveRecord::ConnectionAdapters` [#1530]
+  * Rename `OracleEnhancedStructureDump` to `OracleEnhanced::StructureDump` [#1531]
+  * Move up require for types [#1533]
+  * These methods are private in `AbstractAdapter` or `PostgreSQLAdapter` [#1534]
+  * `ActiveRecord::ConnectionAdapters::AbstractAdapter#log` is a `private` [#1535]
+  * Move `self.default_sequence_start_value` method [#1536]
+  * Rename `ActiveRecord::OracleEnhanced::Type` to `ActiveRecord::Type::OracleEnhanced` [#1541]
+  * Move `write_lobs` under `OracleEnhanced::DatabaseStatements` module [#1546]
+  * Introduce `OracleEnhanced::Lob` not to modify `ActiveRecord::Base` directly [#1547]
+  * Use `ActiveSupport.on_load` to hook into `ActiveRecord::Base` [#1568]
+  * Call `virtual_columns_for` when `supports_virtual_columns?` returns true [#1554]
+  * Move `tables` and related methods into `OracleEnhanced::SchemaStatements` [#1557]
+  * Avoid using `OracleEnhanced::Connection#select_value` [#1560]
+  * Make `OracleEnhanced::Connection#describe` private [#1566]
+
+* Changes in specs
+
+  * Always generate `debug.log` for unit tests [#1476]
+  * Use Rails migration for creating table at "using offset and limit" [#1276]
+  * Use Rails migration for creating table at `valid_type?` [#1277]
+  * Clean up before(:each) and after(:each) at "rename tables and sequences" [#1278]
+  * Use Rails migration for creating table at `BINARY_FLOAT columns" specs [#1280]
+  * Use Rails migration for creating table at "handling of BLOB columns" [#1282]
+  * Use Rails migration for creating table at "handling of CLOB columns" [#1283]
+  * Use Rails migration for creating table at "assign string to :date and :datetime columns" [#1284]
+  * Use Rails migration for creating table at "table columns" [#1287]
+  * Use Rails migration for creating table at procedure specs [#1288]
+  * Use Rails migration for creating table at database tasks specs [#1290]
+  * Suppress `warning: assigned but unused variable - poolable_connection_factory` [#1292]
+  * Suppress `warning: assigned but unused variable - post` [#1293]
+  * Move spec files under `oracle_enhanced` directory [#1441]
+  * Move spec files under `emulation` directory [#1442]
+  * Move schema_dumper_spec under `oracle_enhanced` directory [#1443]
+  * Rename spec/active_record/connection_adapters/oracle_enhanced_dirty_spec.rb [#1447]
+  * Remove `set_boolean_columns` from `oracle_enhanced_data_types_spec.rb` [#1452]
+  * Remove `set_string_columns` from `oracle_enhanced_data_types_spec.rb` [#1454]
+  * Use `drop_table` if_exists: true` to avoid rescue nil [#1456]
+  * Extract JSON data type specs [#1459]
+  * Extract NationalCharacterString data type specs [#1460]
+  * Extract RAW data type specs [#1461]
+  * Extract TEXT data type specs [#1462]
+  * Extract INTEGER data type specs [#1463]
+  * Remove redundant `type` from spec files [#1464]
+  * Extract boolean data type specs [#1465]
+  * Extract NationalCharacterText data type specs [#1466]
+  * Extract specs for `OracleEnhanced::Quoting` [#1469]
+  * Extract TIMPSTAMP, TIMESTAMPTZ and TIMESTAMPLTZ specs [#1480]
+  * Extract FLOAT type specs [#1482]
+  * Use `SchemaDumpingHelper#dump_table_schema` at `context_index_spec` [#1491]
+  * Remove unused `fk_name` [#1514]
+  * Show correct bind value information in debug.log [#1537]
+  * rubocop 0.48.1 [#1281]
+
+* Changes for CI and builds
+
+  * Use `rubocop-0-51` channel on Code Climate [#1589]
+  * Use `rubocop-0-50` channel on Code Climate [#1539]
+  * Use `rubocop-0-49` channel to run rubocop 0.49 [#1478]
+  * Bump ruby versions to 2.4.2, 2.3.5 and 2.2.8 at Travis [#1484]
+  * CI against JRuby 9.1.14.0 [#1592]
+  * CI against JRuby 9.1.13.0 [#1471]
+  * set `open_cursor` value to `1200` [#1431]
+  * Use bundler 1.16.0.preX and update rubygems to the latest [#1532]
+  * [ci skip] Create an issue template [#1317]
+  * [ci skip] Add Oracle enhanced adapter version to the issue template [#1319]
+  * [ci skip] Remove `self.emulate_integers_by_column_name = true` [#1494]
+  * Remove leftover comments [ci skip] [#1520]
+  * Move issue template to github sub directory [skip ci] [#1320]
+  * Replace :github source with https [#1499]
+  * Simplify `git_source` in Gemfile [#1500]
+  * Enable and apply `Style/Semicolon` [#1570]
+  * Enable and apply Style/RedundantReturn [#1571]
+  * Enable `Style/DefWithParentheses` rubocop rule [#1597]
+  * bundler 1.16.0 is out, no more --pre [#1572]
+
 ## 1.8.2 / 2017-08-24
 
 * Changes and bug fixes
@@ -10,7 +195,7 @@
   * Bump ruby versions [#1346]
   * rubocop namespace changes from `Style` to `Layout` [#1347, #1351]
 
-* Changes and bug fixes
+* Known issues
   * No changes since 1.8.0.rc3
 
 ## 1.8.1 / 2017-05-11
@@ -579,7 +764,7 @@
  * Address undefined method `cast_type' [#805]
  * Better fix to support "Relation#count does not support finder options anymore in Rails [#788, #787]
  * ActiveRecord::Calculations#count no longer accepts an options hash argument #754
- * Supress WARNINGs using `raise_error` without specific errors [#724]
+ * Suppress WARNINGs using `raise_error` without specific errors [#724]
  * Use RSpec 3 [#707]
  * Update "OracleEnhancedAdapter boolean type detection based on string column types and names" [#873]
  * Update "OracleEnhancedAdapter integer type detection based on column names" [#871]
@@ -866,7 +1051,7 @@
  * Update README to support assignment methods [#365]
  * Remove add_limit_offset! method [#369]
  * Update Gemfile to use `bundle config --local` [#370]
- * `describe` does not try super when no datbase link and ORA-4043 returned [#375]
+ * `describe` does not try super when no database link and ORA-4043 returned [#375]
  * Support `remove_columns` [#377]
  * Dump views in alphabetical order and add `FORCE` option [#378]
 
@@ -1251,10 +1436,10 @@
 * Forked from original activerecord-oracle-adapter-1.0.0.9216
 * Renamed oracle adapter to oracle_enhanced adapter
   * Added "enhanced" to method and class definitions so that oracle_enhanced and original oracle adapter
-    could be used simultaniously
+    could be used simultaneously
   * Added Rails rake tasks as a copy from original oracle tasks
 * Enhancements:
-  * Improved perfomance of schema dump methods when used on large data dictionaries
+  * Improved performance of schema dump methods when used on large data dictionaries
   * Added LOB writing callback for sessions stored in database
   * Added emulate_dates_by_column_name option
   * Added emulate_integers_by_column_name option

data/README.md

@@ -239,12 +239,6 @@ ENV['TZ'] = 'UTC'
 
 ActiveSupport.on_load(:active_record) do
   ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.class_eval do
-    # id columns and columns which end with _id will always be converted to integers
-    self.emulate_integers_by_column_name = true
-
-    # DATE columns which include "date" in name will be converted to Date, otherwise to Time
-    self.emulate_dates_by_column_name = true
-
     # true and false will be stored as 'Y' and 'N'
     self.emulate_booleans_from_strings = true
 
@@ -481,7 +475,7 @@ Post.contains(:all_text, "aaa within title")
 Post.contains(:all_text, "bbb within comment_author")
 ```
 
-Please note that `index_column` must be a real column in your database and it's value will be overriden every time your `index_column_trigger_on` columns are changed. So, _do not use columns with real data as `index_column`_.
+Please note that `index_column` must be a real column in your database and it's value will be overridden every time your `index_column_trigger_on` columns are changed. So, _do not use columns with real data as `index_column`_.
 
 Index column can be created as:
 
@@ -639,14 +633,20 @@ development:
   )"
 ```
 
+### Schema cache
+
+`rails db:schema:cache:dump` generates `db/schema_cache.yml` to avoid queries for Oracle database dictionary, which could help your application response time if it takes time to look up database structure.
+
+if any database structure changed by migrations, execute `rails db:schema:cache:dump` again and restart Rails server to reflect changes.
+
 UPGRADE
 ---------------
 ### Upgrade Rails 5.0 or older version to Rails 5.1
 
 If your application gets `ORA-01000: maximum open cursors exceeded`
-after upgrading to Rails 5.1
-check these two values and configure `:statement_limit` value at database.yml
-is larger than `open_cursors` at Oracle database instance.
+after upgrading to Rails 5.1,
+check these two values and configure `open_cursors` parameter value
+at Oracle database instance is larger than `:statement_limit` value at database.yml.
 
 * `open_cursors` value at Oracle database instance
 

data/VERSION

@@ -1 +1 @@
-1.8.2
+5.2.0.beta1

data/lib/active_record/connection_adapters/emulation/oracle_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ActiveRecord::ConnectionAdapters::OracleAdapter < ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter #:nodoc:
   def adapter_name
     "Oracle"

data/lib/active_record/connection_adapters/oracle_enhanced/column.rb

@@ -1,81 +1,19 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters #:nodoc:
-    class OracleEnhancedColumn < Column
-      attr_reader :table_name, :nchar, :virtual_column_data_default, :returning_id #:nodoc:
+    module OracleEnhanced
+      class Column < ActiveRecord::ConnectionAdapters::Column
+        delegate :virtual, to: :sql_type_metadata, allow_nil: true
 
-      def initialize(name, default, sql_type_metadata = nil, null = true, table_name = nil, virtual = false, returning_id = nil, comment = nil) #:nodoc:
-        @virtual = virtual
-        @virtual_column_data_default = default.inspect if virtual
-        @returning_id = returning_id
-        if virtual
-          default_value = nil
-        else
-          default_value = self.class.extract_value_from_default(default)
-        end
-        super(name, default_value, sql_type_metadata, null, table_name, comment: comment)
-        # Is column NCHAR or NVARCHAR2 (will need to use N'...' value quoting for these data types)?
-        # Define only when needed as adapter "quote" method will check at first if instance variable is defined.
-        if sql_type_metadata
-          @object_type = sql_type_metadata.sql_type.include? "."
+        def initialize(name, default, sql_type_metadata = nil, null = true, table_name = nil, comment = nil) #:nodoc:
+          super(name, default, sql_type_metadata, null, table_name, comment: comment)
         end
-        # TODO: Need to investigate when `sql_type` becomes nil
-      end
-
-      def virtual?
-        @virtual
-      end
-
-      def returning_id?
-        @returning_id
-      end
-
-      def lob?
-        self.sql_type =~ /LOB$/i
-      end
-
-      def object_type?
-        @object_type
-      end
 
-      # convert something to a boolean
-      # added y as boolean value
-      def self.value_to_boolean(value) #:nodoc:
-        if value == true || value == false
-          value
-        elsif value.is_a?(String) && value.blank?
-          nil
-        else
-          %w(true t 1 y +).include?(value.to_s.downcase)
+        def virtual?
+          virtual
         end
       end
-
-      # convert Time or DateTime value to Date for :date columns
-      def self.string_to_date(string) #:nodoc:
-        return string.to_date if string.is_a?(Time) || string.is_a?(DateTime)
-        super
-      end
-
-      # convert Date value to Time for :datetime columns
-      def self.string_to_time(string) #:nodoc:
-        return string.to_time if string.is_a?(Date) && !OracleEnhancedAdapter.emulate_dates
-        super
-      end
-
-      private
-
-        def self.extract_value_from_default(default)
-          case default
-          when String
-            default.gsub(/''/, "'")
-            else
-            default
-          end
-        end
-
-        def guess_date_or_time(value)
-          value.respond_to?(:hour) && ((value.hour == 0) && (value.min == 0) && (value.sec == 0)) ?
-            Date.new(value.year, value.month, value.day) : value
-        end
     end
   end
 end

data/lib/active_record/connection_adapters/oracle_enhanced/connection.rb

@@ -1,49 +1,43 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     # interface independent methods
-    class OracleEnhancedConnection #:nodoc:
-      def self.create(config)
-        case ORACLE_ENHANCED_CONNECTION
-        when :oci
-          OracleEnhancedOCIConnection.new(config)
-        when :jdbc
-          OracleEnhancedJDBCConnection.new(config)
-        else
-          nil
+    module OracleEnhanced
+      class Connection #:nodoc:
+        def self.create(config)
+          case ORACLE_ENHANCED_CONNECTION
+          when :oci
+            OracleEnhanced::OCIConnection.new(config)
+          when :jdbc
+            OracleEnhanced::JDBCConnection.new(config)
+          else
+            nil
+          end
         end
-      end
 
-      attr_reader :raw_connection
+        attr_reader :raw_connection
 
-      # Oracle column names by default are case-insensitive, but treated as upcase;
-      # for neatness, we'll downcase within Rails. EXCEPT that folks CAN quote
-      # their column names when creating Oracle tables, which makes then case-sensitive.
-      # I don't know anybody who does this, but we'll handle the theoretical case of a
-      # camelCase column name. I imagine other dbs handle this different, since there's a
-      # unit test that's currently failing test_oci.
-      def oracle_downcase(column_name)
-        return nil if column_name.nil?
-        column_name =~ /[a-z]/ ? column_name : column_name.downcase
-      end
+        private
 
-      # Used always by JDBC connection as well by OCI connection when describing tables over database link
-      def describe(name)
-        name = name.to_s
-        if name.include?("@")
-          name, db_link = name.split("@")
-          default_owner = select_value("SELECT username FROM all_db_links WHERE db_link = '#{db_link.upcase}'")
-          db_link = "@#{db_link}"
-        else
-          db_link = nil
-          default_owner = @owner
-        end
-        real_name = ActiveRecord::ConnectionAdapters::OracleEnhanced::Quoting.valid_table_name?(name) ? name.upcase : name
-        if real_name.include?(".")
-          table_owner, table_name = real_name.split(".")
-        else
-          table_owner, table_name = default_owner, real_name
-        end
-        sql = <<-SQL
+          # Used always by JDBC connection as well by OCI connection when describing tables over database link
+          def describe(name)
+            name = name.to_s
+            if name.include?("@")
+              name, db_link = name.split("@")
+              default_owner = _select_value("SELECT username FROM all_db_links WHERE db_link = '#{db_link.upcase}'")
+              db_link = "@#{db_link}"
+            else
+              db_link = nil
+              default_owner = @owner
+            end
+            real_name = OracleEnhanced::Quoting.valid_table_name?(name) ? name.upcase : name
+            if real_name.include?(".")
+              table_owner, table_name = real_name.split(".")
+            else
+              table_owner, table_name = default_owner, real_name
+            end
+            sql = <<-SQL.strip.gsub(/\s+/, " ")
           SELECT owner, table_name, 'TABLE' name_type
           FROM all_tables#{db_link}
           WHERE owner = '#{table_owner}'
@@ -64,46 +58,63 @@ module ActiveRecord
           WHERE owner = 'PUBLIC'
             AND synonym_name = '#{real_name}'
         SQL
-        if result = select_one(sql)
-          case result["name_type"]
-          when "SYNONYM"
-            describe("#{result['owner'] && "#{result['owner']}."}#{result['table_name']}#{db_link}")
-          else
-            db_link ? [result["owner"], result["table_name"], db_link] : [result["owner"], result["table_name"]]
+            if result = _select_one(sql)
+              case result["name_type"]
+              when "SYNONYM"
+                describe("#{result['owner'] && "#{result['owner']}."}#{result['table_name']}#{db_link}")
+              else
+                db_link ? [result["owner"], result["table_name"], db_link] : [result["owner"], result["table_name"]]
+              end
+            else
+              raise OracleEnhanced::ConnectionException, %Q{"DESC #{name}" failed; does it exist?}
+            end
           end
-        else
-          raise OracleEnhancedConnectionException, %Q{"DESC #{name}" failed; does it exist?}
-        end
-      end
 
-      # Returns a record hash with the column names as keys and column values
-      # as values.
-      def select_one(sql)
-        result = select(sql)
-        result.first if result
-      end
+          # Oracle column names by default are case-insensitive, but treated as upcase;
+          # for neatness, we'll downcase within Rails. EXCEPT that folks CAN quote
+          # their column names when creating Oracle tables, which makes then case-sensitive.
+          # I don't know anybody who does this, but we'll handle the theoretical case of a
+          # camelCase column name. I imagine other dbs handle this different, since there's a
+          # unit test that's currently failing test_oci.
+          #
+          # `_oracle_downcase` is expected to be called only from
+          # `ActiveRecord::ConnectionAdapters::OracleEnhanced::OCIConnection`
+          # or `ActiveRecord::ConnectionAdapters::OracleEnhanced::JDBCConnection`.
+          # Other method should call `ActiveRecord:: ConnectionAdapters::OracleEnhanced::Quoting#oracle_downcase`
+          # since this is kind of quoting, not connection.
+          # To avoid it is called from anywhere else, added _ at the beginning of the method name.
+          def _oracle_downcase(column_name)
+            return nil if column_name.nil?
+            column_name =~ /[a-z]/ ? column_name : column_name.downcase
+          end
 
-      # Returns a single value from a record
-      def select_value(sql)
-        if result = select_one(sql)
-          result.values.first
-        end
-      end
+          # _select_one and _select_value methods are expected to be called
+          # only from `ActiveRecord::ConnectionAdapters::OracleEnhanced::Connection#describe`
+          # Other methods should call `ActiveRecord::ConnectionAdapters::DatabaseStatements#select_one`
+          # and  `ActiveRecord::ConnectionAdapters::DatabaseStatements#select_value`
+          # To avoid called from its subclass added a underscore in each method.
 
-      # Returns an array of the values of the first column in a select:
-      #   select_values("SELECT id FROM companies LIMIT 3") => [1,2,3]
-      def select_values(sql, name = nil)
-        result = select(sql, name = nil)
-        result.map { |r| r.values.first }
-      end
-    end
+          # Returns a record hash with the column names as keys and column values
+          # as values.
+          def _select_one(arel, name = nil, binds = [])
+            result = select(arel)
+            result.first if result
+          end
 
-    # Returns array with major and minor version of database (e.g. [12, 1])
-    def database_version
-      raise NoMethodError, "Not implemented for this raw driver"
-    end
+          # Returns a single value from a record
+          def _select_value(arel, name = nil, binds = [])
+            if result = _select_one(arel)
+              result.values.first
+            end
+          end
+      end
 
-    class OracleEnhancedConnectionException < StandardError #:nodoc:
+      # Returns array with major and minor version of database (e.g. [12, 1])
+      def database_version
+        raise NoMethodError, "Not implemented for this raw driver"
+      end
+      class ConnectionException < StandardError #:nodoc:
+      end
     end
   end
 end