activerecord-oracle_enhanced-adapter 1.8.2 → 5.2.0.beta1

data/spec/active_record/oracle_enhanced/type/text_spec.rb

@@ -0,0 +1,229 @@
+# frozen_string_literal: true
+
+describe "OracleEnhancedAdapter handling of CLOB columns" do
+  include SchemaSpecHelper
+
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+    schema_define do
+      create_table :test_employees, force: true do |t|
+        t.string  :first_name, limit: 20
+        t.string  :last_name, limit: 25
+        t.text    :comments
+      end
+      create_table :test2_employees, force: true do |t|
+        t.string  :first_name, limit: 20
+        t.string  :last_name, limit: 25
+        t.text    :comments
+      end
+      create_table :test_serialize_employees, force: true do |t|
+        t.string  :first_name, limit: 20
+        t.string  :last_name, limit: 25
+      end
+      add_column :test_serialize_employees, :comments, :text
+    end
+
+    @char_data = (0..127).to_a.pack("C*") * 800
+    @char_data2 = ((1..127).to_a.pack("C*") + "\0") * 800
+
+    class ::TestEmployee < ActiveRecord::Base; end
+    class ::Test2Employee < ActiveRecord::Base
+      serialize :comments
+    end
+    class ::TestEmployeeReadOnlyClob < ActiveRecord::Base
+      self.table_name = "test_employees"
+      attr_readonly :comments
+    end
+    class ::TestSerializeEmployee < ActiveRecord::Base
+      serialize :comments
+      attr_readonly :comments
+    end
+  end
+
+  after(:all) do
+    @conn.drop_table :test_employees, if_exists: true
+    @conn.drop_table :test2_employees, if_exists: true
+    @conn.drop_table :test_serialize_employees, if_exists: true
+    Object.send(:remove_const, "TestEmployee")
+    Object.send(:remove_const, "Test2Employee")
+    Object.send(:remove_const, "TestEmployeeReadOnlyClob")
+    Object.send(:remove_const, "TestSerializeEmployee")
+    ActiveRecord::Base.clear_cache!
+  end
+
+  it "should create record without CLOB data when attribute is serialized" do
+    @employee = Test2Employee.create!(
+      first_name: "First",
+      last_name: "Last"
+    )
+    expect(@employee).to be_valid
+    @employee.reload
+    expect(@employee.comments).to be_nil
+  end
+
+  it "should accept Symbol value for CLOB column" do
+    @employee = TestEmployee.create!(
+      comments: :test_comment
+    )
+    expect(@employee).to be_valid
+  end
+
+  it "should respect attr_readonly setting for CLOB column" do
+    @employee = TestEmployeeReadOnlyClob.create!(
+      first_name: "First",
+      comments: "initial"
+    )
+    expect(@employee).to be_valid
+    @employee.reload
+    expect(@employee.comments).to eq("initial")
+    @employee.comments = "changed"
+    expect(@employee.save).to eq(true)
+    @employee.reload
+    expect(@employee.comments).to eq("initial")
+  end
+
+  it "should work for serialized readonly CLOB columns", serialized: true do
+    @employee = TestSerializeEmployee.new(
+      first_name: "First",
+      comments: nil
+    )
+    expect(@employee.comments).to be_nil
+    expect(@employee.save).to eq(true)
+    expect(@employee).to be_valid
+    @employee.reload
+    expect(@employee.comments).to be_nil
+    @employee.comments = {}
+    expect(@employee.save).to eq(true)
+    @employee.reload
+    #should not set readonly
+    expect(@employee.comments).to be_nil
+  end
+
+  it "should create record with CLOB data" do
+    @employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last",
+      comments: @char_data
+    )
+    @employee.reload
+    expect(@employee.comments).to eq(@char_data)
+  end
+
+  it "should update record with CLOB data" do
+    @employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last"
+    )
+    @employee.reload
+    expect(@employee.comments).to be_nil
+    @employee.comments = @char_data
+    @employee.save!
+    @employee.reload
+    expect(@employee.comments).to eq(@char_data)
+  end
+
+  it "should update record with zero-length CLOB data" do
+    @employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last"
+    )
+    @employee.reload
+    expect(@employee.comments).to be_nil
+    @employee.comments = ""
+    @employee.save!
+    @employee.reload
+    expect(@employee.comments).to eq("")
+  end
+
+  it "should update record that has existing CLOB data with different CLOB data" do
+    @employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last",
+      comments: @char_data
+    )
+    @employee.reload
+    @employee.comments = @char_data2
+    @employee.save!
+    @employee.reload
+    expect(@employee.comments).to eq(@char_data2)
+  end
+
+  it "should update record that has existing CLOB data with nil" do
+    @employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last",
+      comments: @char_data
+    )
+    @employee.reload
+    @employee.comments = nil
+    @employee.save!
+    @employee.reload
+    expect(@employee.comments).to be_nil
+  end
+
+  it "should update record that has existing CLOB data with zero-length CLOB data" do
+    @employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last",
+      comments: @char_data
+    )
+    @employee.reload
+    @employee.comments = ""
+    @employee.save!
+    @employee.reload
+    expect(@employee.comments).to eq("")
+  end
+
+  it "should update record that has zero-length CLOB data with non-empty CLOB data" do
+    @employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last",
+      comments: ""
+    )
+    @employee.reload
+    expect(@employee.comments).to eq("")
+    @employee.comments = @char_data
+    @employee.save!
+    @employee.reload
+    expect(@employee.comments).to eq(@char_data)
+  end
+
+  it "should store serializable ruby data structures" do
+    ruby_data1 = { "arbitrary1" => ["ruby", :data, 123] }
+    ruby_data2 = { "arbitrary2" => ["ruby", :data, 123] }
+    @employee = Test2Employee.create!(
+      comments: ruby_data1
+    )
+    @employee.reload
+    expect(@employee.comments).to eq(ruby_data1)
+    @employee.comments = ruby_data2
+    @employee.save
+    @employee.reload
+    expect(@employee.comments).to eq(ruby_data2)
+  end
+
+  it "should keep unchanged serialized data when other columns changed" do
+    @employee = Test2Employee.create!(
+      first_name: "First",
+      last_name: "Last",
+      comments: "initial serialized data"
+    )
+    @employee.first_name = "Steve"
+    @employee.save
+    @employee.reload
+    expect(@employee.comments).to eq("initial serialized data")
+  end
+
+  it "should keep serialized data after save" do
+    @employee = Test2Employee.new
+    @employee.comments = { length: { is: 1 } }
+    @employee.save
+    @employee.reload
+    expect(@employee.comments).to eq(length: { is: 1 })
+    @employee.comments = { length: { is: 2 } }
+    @employee.save
+    @employee.reload
+    expect(@employee.comments).to eq(length: { is: 2 })
+  end
+end

data/spec/active_record/oracle_enhanced/type/timestamp_spec.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+describe "OracleEnhancedAdapter timestamp with timezone support" do
+  include SchemaSpecHelper
+
+  before(:all) do
+    ActiveRecord::Base.default_timezone = :local
+    ActiveRecord::Base.establish_connection(CONNECTION_WITH_TIMEZONE_PARAMS)
+    @conn = ActiveRecord::Base.connection
+    schema_define do
+      create_table :test_employees, force: true do |t|
+        t.string        :first_name,  limit: 20
+        t.string        :last_name,  limit: 25
+        t.string        :email, limit: 25
+        t.string        :phone_number, limit: 20
+        t.date          :hire_date
+        t.decimal       :job_id, scale: 0, precision: 6
+        t.decimal       :salary, scale: 2, precision: 8
+        t.decimal       :commission_pct, scale: 2, precision: 2
+        t.decimal       :manager_id, scale: 0, precision: 6
+        t.decimal       :department_id, scale: 0, precision: 4
+        t.timestamp     :created_at
+        t.timestamptz   :created_at_tz
+        t.timestampltz  :created_at_ltz
+      end
+    end
+  end
+
+  after(:all) do
+    @conn.drop_table :test_employees, if_exists: true
+    ActiveRecord::Base.default_timezone = :utc
+  end
+
+  describe "/ TIMESTAMP WITH TIME ZONE values from ActiveRecord model" do
+    before(:all) do
+      class ::TestEmployee < ActiveRecord::Base
+      end
+    end
+
+    after(:all) do
+      Object.send(:remove_const, "TestEmployee")
+      ActiveRecord::Base.clear_cache!
+    end
+
+    it "should return Time value from TIMESTAMP columns" do
+      @now = Time.local(2008, 5, 26, 23, 11, 11, 0)
+      @employee = TestEmployee.create(
+        created_at: @now,
+        created_at_tz: @now,
+        created_at_ltz: @now
+      )
+      @employee.reload
+      [:created_at, :created_at_tz, :created_at_ltz].each do |c|
+        expect(@employee.send(c).class).to eq(Time)
+        expect(@employee.send(c).to_f).to eq(@now.to_f)
+      end
+    end
+
+    it "should return Time value with fractional seconds from TIMESTAMP columns" do
+      @now = Time.local(2008, 5, 26, 23, 11, 11, 10)
+      @employee = TestEmployee.create(
+        created_at: @now,
+        created_at_tz: @now,
+        created_at_ltz: @now
+      )
+      @employee.reload
+      [:created_at, :created_at_tz, :created_at_ltz].each do |c|
+        expect(@employee.send(c).class).to eq(Time)
+        expect(@employee.send(c).to_f).to eq(@now.to_f)
+      end
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "simplecov"
 SimpleCov.start
 require "rubygems"
@@ -115,6 +117,18 @@ module SchemaSpecHelper
   end
 end
 
+module SchemaDumpingHelper
+  def dump_table_schema(table, connection = ActiveRecord::Base.connection)
+    old_ignore_tables = ActiveRecord::SchemaDumper.ignore_tables
+    ActiveRecord::SchemaDumper.ignore_tables = connection.data_sources - [table]
+    stream = StringIO.new
+    ActiveRecord::SchemaDumper.dump(ActiveRecord::Base.connection, stream)
+    stream.string
+  ensure
+    ActiveRecord::SchemaDumper.ignore_tables = old_ignore_tables
+  end
+end
+
 DATABASE_NAME         = config["database"]["name"]         || ENV["DATABASE_NAME"]         || "orcl"
 DATABASE_HOST         = config["database"]["host"]         || ENV["DATABASE_HOST"]         || "127.0.0.1"
 DATABASE_PORT         = config["database"]["port"]         || ENV["DATABASE_PORT"]         || 1521
@@ -177,4 +191,4 @@ DATABASE_NON_DEFAULT_TABLESPACE = config["database"]["non_default_tablespace"] |
 # which will be used to set session time zone
 ENV["TZ"] ||= config["timezone"] || "Europe/Riga"
 
-# ActiveRecord::Base.logger = Logger.new(STDOUT)
+ActiveRecord::Base.logger = ActiveSupport::Logger.new("debug.log", 0, 100 * 1024 * 1024)

data/spec/support/alter_system_set_open_cursors.sql

@@ -0,0 +1 @@
+alter system set open_cursors = 1200 scope = both;

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 1.8.2
+  version: 5.2.0.beta1
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-24 00:00:00.000000000 Z
+date: 2017-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,28 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: 5.2.0.beta
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.1.0
-- !ruby/object:Gem::Dependency
-  name: arel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '8.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '8.0'
+        version: 5.2.0.beta
 - !ruby/object:Gem::Dependency
   name: ruby-plsql
   requirement: !ruby/object:Gem::Requirement
@@ -67,13 +53,15 @@ files:
 - VERSION
 - lib/active_record/connection_adapters/emulation/oracle_adapter.rb
 - lib/active_record/connection_adapters/oracle_enhanced/column.rb
-- lib/active_record/connection_adapters/oracle_enhanced/column_dumper.rb
 - lib/active_record/connection_adapters/oracle_enhanced/connection.rb
 - lib/active_record/connection_adapters/oracle_enhanced/context_index.rb
+- lib/active_record/connection_adapters/oracle_enhanced/database_limits.rb
 - lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb
 - lib/active_record/connection_adapters/oracle_enhanced/database_tasks.rb
+- lib/active_record/connection_adapters/oracle_enhanced/dbms_output.rb
 - lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb
 - lib/active_record/connection_adapters/oracle_enhanced/jdbc_quoting.rb
+- lib/active_record/connection_adapters/oracle_enhanced/lob.rb
 - lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb
 - lib/active_record/connection_adapters/oracle_enhanced/oci_quoting.rb
 - lib/active_record/connection_adapters/oracle_enhanced/procedures.rb
@@ -84,31 +72,46 @@ files:
 - lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb
 - lib/active_record/connection_adapters/oracle_enhanced/schema_statements_ext.rb
 - lib/active_record/connection_adapters/oracle_enhanced/structure_dump.rb
+- lib/active_record/connection_adapters/oracle_enhanced/type_metadata.rb
 - lib/active_record/connection_adapters/oracle_enhanced/version.rb
 - lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
-- lib/active_record/oracle_enhanced/type/boolean.rb
-- lib/active_record/oracle_enhanced/type/integer.rb
-- lib/active_record/oracle_enhanced/type/json.rb
-- lib/active_record/oracle_enhanced/type/national_character_string.rb
-- lib/active_record/oracle_enhanced/type/raw.rb
-- lib/active_record/oracle_enhanced/type/string.rb
-- lib/active_record/oracle_enhanced/type/text.rb
-- lib/active_record/oracle_enhanced/type/timestamptz.rb
+- lib/active_record/type/oracle_enhanced/boolean.rb
+- lib/active_record/type/oracle_enhanced/integer.rb
+- lib/active_record/type/oracle_enhanced/json.rb
+- lib/active_record/type/oracle_enhanced/national_character_string.rb
+- lib/active_record/type/oracle_enhanced/national_character_text.rb
+- lib/active_record/type/oracle_enhanced/raw.rb
+- lib/active_record/type/oracle_enhanced/string.rb
+- lib/active_record/type/oracle_enhanced/text.rb
+- lib/active_record/type/oracle_enhanced/timestampltz.rb
+- lib/active_record/type/oracle_enhanced/timestamptz.rb
 - lib/activerecord-oracle_enhanced-adapter.rb
+- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_connection_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_database_tasks_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_dbms_output_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_dirty_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_emulate_oracle_adapter_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_structure_dump_spec.rb
+- spec/active_record/oracle_enhanced/type/binary_spec.rb
+- spec/active_record/oracle_enhanced/type/boolean_spec.rb
+- spec/active_record/oracle_enhanced/type/dirty_spec.rb
+- spec/active_record/oracle_enhanced/type/float_spec.rb
+- spec/active_record/oracle_enhanced/type/integer_spec.rb
+- spec/active_record/oracle_enhanced/type/json_spec.rb
+- spec/active_record/oracle_enhanced/type/national_character_string_spec.rb
+- spec/active_record/oracle_enhanced/type/national_character_text_spec.rb
+- spec/active_record/oracle_enhanced/type/raw_spec.rb
+- spec/active_record/oracle_enhanced/type/text_spec.rb
+- spec/active_record/oracle_enhanced/type/timestamp_spec.rb
 - spec/spec_config.yaml.template
 - spec/spec_helper.rb
+- spec/support/alter_system_set_open_cursors.sql
 - spec/support/alter_system_user_password.sql
 - spec/support/create_oracle_enhanced_users.sql
 homepage: http://github.com/rsim/oracle-enhanced
@@ -131,24 +134,36 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.8.11
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.2
 signing_key: 
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord
 test_files:
 - spec/support/create_oracle_enhanced_users.sql
+- spec/support/alter_system_set_open_cursors.sql
 - spec/support/alter_system_user_password.sql
 - spec/spec_config.yaml.template
 - spec/spec_helper.rb
-- spec/active_record/connection_adapters/oracle_enhanced_database_tasks_spec.rb
+- spec/active_record/oracle_enhanced/type/integer_spec.rb
+- spec/active_record/oracle_enhanced/type/national_character_text_spec.rb
+- spec/active_record/oracle_enhanced/type/timestamp_spec.rb
+- spec/active_record/oracle_enhanced/type/raw_spec.rb
+- spec/active_record/oracle_enhanced/type/dirty_spec.rb
+- spec/active_record/oracle_enhanced/type/json_spec.rb
+- spec/active_record/oracle_enhanced/type/float_spec.rb
+- spec/active_record/oracle_enhanced/type/boolean_spec.rb
+- spec/active_record/oracle_enhanced/type/national_character_string_spec.rb
+- spec/active_record/oracle_enhanced/type/binary_spec.rb
+- spec/active_record/oracle_enhanced/type/text_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_structure_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_connection_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_dirty_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_emulate_oracle_adapter_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_dbms_output_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
+- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb