activerecord-oracle_enhanced-adapter 8.1.0-java

data/spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb

@@ -0,0 +1,362 @@
+# frozen_string_literal: true
+
+require "ruby-plsql"
+
+describe "OracleEnhancedAdapter custom methods for create, update and destroy" do
+  include LoggerSpecHelper
+  include SchemaSpecHelper
+
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+    plsql.activerecord_class = ActiveRecord::Base
+    schema_define do
+      create_table :test_employees, force: true do |t|
+        t.string  :first_name, limit: 20
+        t.string  :last_name, limit: 25
+        t.date    :hire_date
+        t.decimal :salary, scale: 2, precision: 8
+        t.text    :description
+        t.decimal :version, scale: 0, precision: 15
+        t.date    :create_time
+        t.date    :update_time
+        t.timestamps null: true
+      end
+    end
+    @conn.execute <<~SQL
+      CREATE OR REPLACE PACKAGE test_employees_pkg IS
+        PROCEDURE create_employee(
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2,
+            p_employee_id   OUT NUMBER);
+        PROCEDURE update_employee(
+            p_employee_id   NUMBER,
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2);
+        PROCEDURE delete_employee(
+            p_employee_id   NUMBER);
+      END;
+    SQL
+    @conn.execute <<~SQL
+      CREATE OR REPLACE PACKAGE BODY test_employees_pkg IS
+        PROCEDURE create_employee(
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2,
+            p_employee_id   OUT NUMBER)
+        IS
+        BEGIN
+          SELECT test_employees_seq.NEXTVAL INTO p_employee_id FROM dual;
+          INSERT INTO test_employees (id, first_name, last_name, hire_date, salary, description,
+                                      version, create_time, update_time)
+          VALUES (p_employee_id, p_first_name, p_last_name, p_hire_date, p_salary, p_description,
+                                      1, SYSDATE, SYSDATE);
+        END create_employee;
+
+        PROCEDURE update_employee(
+            p_employee_id   NUMBER,
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2)
+        IS
+            v_version       NUMBER;
+        BEGIN
+          SELECT version INTO v_version FROM test_employees WHERE id = p_employee_id FOR UPDATE;
+          UPDATE test_employees
+          SET first_name = p_first_name, last_name = p_last_name,
+              hire_date = p_hire_date, salary = p_salary, description = p_description,
+              version = v_version + 1, update_time = SYSDATE
+          WHERE id = p_employee_id;
+        END update_employee;
+
+        PROCEDURE delete_employee(
+            p_employee_id   NUMBER)
+        IS
+        BEGIN
+          DELETE FROM test_employees WHERE id = p_employee_id;
+        END delete_employee;
+      END;
+    SQL
+  end
+
+  after(:all) do
+    @conn = ActiveRecord::Base.connection
+    @conn.drop_table :test_employees, if_exists: true
+    @conn.execute "DROP PACKAGE test_employees_pkg"
+  end
+
+  before(:each) do
+    class ::TestEmployee < ActiveRecord::Base
+      include ActiveRecord::OracleEnhancedProcedures
+
+      validates_presence_of :first_name, :last_name, :hire_date
+
+      # should return ID of new record
+      set_create_method do
+        plsql.test_employees_pkg.create_employee(
+          p_first_name: first_name,
+          p_last_name: last_name,
+          p_hire_date: hire_date,
+          p_salary: salary,
+          p_description: "#{first_name} #{last_name}",
+          p_employee_id: nil
+        )[:p_employee_id]
+      end
+
+      # return value is ignored
+      set_update_method do
+        plsql.test_employees_pkg.update_employee(
+          p_employee_id: id,
+          p_first_name: first_name,
+          p_last_name: last_name,
+          p_hire_date: hire_date,
+          p_salary: salary,
+          p_description: "#{first_name} #{last_name}"
+        )
+      end
+
+      # return value is ignored
+      set_delete_method do
+        plsql.test_employees_pkg.delete_employee(
+          p_employee_id: id
+        )
+      end
+
+      private
+        def raise_make_transaction_rollback
+          raise "Make the transaction rollback"
+        end
+    end
+
+    @today = Date.new(2008, 6, 28)
+    @buffer = StringIO.new
+  end
+
+  after(:each) do
+    Object.send(:remove_const, "TestEmployee")
+    ActiveRecord::Base.clear_cache!
+  end
+
+  it "should create record" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.reload
+    expect(@employee.first_name).to eq("First")
+    expect(@employee.last_name).to eq("Last")
+    expect(@employee.hire_date).to eq(@today)
+    expect(@employee.description).to eq("First Last")
+    expect(@employee.create_time).not_to be_nil
+    expect(@employee.update_time).not_to be_nil
+  end
+
+  it "should rollback record when exception is raised in after_create callback" do
+    TestEmployee.after_create :raise_make_transaction_rollback
+
+    @employee = TestEmployee.new(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    employees_count = TestEmployee.count
+    expect {
+      @employee.save
+    }.to raise_error("Make the transaction rollback")
+    expect(@employee.new_record?).to be_truthy
+    expect(TestEmployee.count).to eq(employees_count)
+  end
+
+  it "should update record" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today,
+      description: "description"
+    )
+    @employee.reload
+    @employee.first_name = "Second"
+    @employee.save!
+    @employee.reload
+    expect(@employee.description).to eq("Second Last")
+  end
+
+  it "should rollback record when exception is raised in after_update callback" do
+    TestEmployee.after_update :raise_make_transaction_rollback
+
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today,
+      description: "description"
+    )
+    @employee.reload
+    @employee.first_name = "Second"
+    expect {
+      @employee.save
+    }.to raise_error("Make the transaction rollback")
+    @employee.reload
+    expect(@employee.first_name).to eq("First")
+  end
+
+  it "should not update record if nothing is changed and partial updates are enabled" do
+    TestEmployee.partial_updates = true
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.reload
+    @employee.save!
+    @employee.reload
+    expect(@employee.version).to eq(1)
+  end
+
+  it "should update record if nothing is changed and partial updates are disabled" do
+    TestEmployee.partial_updates = false
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.reload
+    @employee.save!
+    @employee.reload
+    expect(@employee.version).to eq(2)
+  end
+
+  it "should delete record" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.reload
+    empl_id = @employee.id
+    @employee.destroy
+    expect(@employee).to be_frozen
+    expect(TestEmployee.find_by_id(empl_id)).to be_nil
+  end
+
+  it "should delete record and set destroyed flag" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.reload
+    @employee.destroy
+    expect(@employee).to be_destroyed
+  end
+
+  it "should rollback record when exception is raised in after_destroy callback" do
+    set_logger
+    TestEmployee.after_destroy :raise_make_transaction_rollback
+
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.reload
+    empl_id = @employee.id
+    expect {
+      @employee.destroy
+    }.to raise_error("Make the transaction rollback")
+    expect(@employee.id).to eq(empl_id)
+    expect(TestEmployee.find_by_id(empl_id)).not_to be_nil
+    clear_logger
+  end
+
+  it "should set timestamps when creating record" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    expect(@employee.created_at).not_to be_nil
+    expect(@employee.updated_at).not_to be_nil
+  end
+
+  it "should set timestamps when updating record" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.reload
+    expect(@employee.created_at).to be_nil
+    expect(@employee.updated_at).to be_nil
+    @employee.first_name = "Second"
+    @employee.save!
+    expect(@employee.created_at).to be_nil
+    expect(@employee.updated_at).not_to be_nil
+  end
+
+  it "should log create record" do
+    set_logger
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    expect(@logger.logged(:debug).last).to match(/^TestEmployee Create \(\d+\.\d+(ms)?\)  custom create method$/)
+    clear_logger
+  end
+
+  it "should log update record" do
+    (TestEmployee.partial_updates = false) rescue nil
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    set_logger
+    @employee.save!
+    expect(@logger.logged(:debug).last).to match(/^TestEmployee Update \(\d+\.\d+(ms)?\)  custom update method with id=#{@employee.id}$/)
+    clear_logger
+  end
+
+  it "should log delete record" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    set_logger
+    @employee.destroy
+    expect(@logger.logged(:debug).last).to match(/^TestEmployee Destroy \(\d+\.\d+(ms)?\)  custom delete method with id=#{@employee.id}$/)
+    clear_logger
+  end
+
+  it "should validate new record before creation" do
+    @employee = TestEmployee.new(
+      last_name: "Last",
+      hire_date: @today
+    )
+    expect(@employee.save).to be_falsey
+    expect(@employee.errors[:first_name]).not_to be_blank
+  end
+
+  it "should validate existing record before update" do
+    @employee = TestEmployee.create(
+      first_name: "First",
+      last_name: "Last",
+      hire_date: @today
+    )
+    @employee.first_name = nil
+    expect(@employee.save).to be_falsey
+    expect(@employee.errors[:first_name]).not_to be_blank
+  end
+end

data/spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb

@@ -0,0 +1,181 @@
+# frozen_string_literal: true
+
+describe "OracleEnhancedAdapter quoting" do
+  include LoggerSpecHelper
+  include SchemaSpecHelper
+
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+  end
+
+  describe "reserved words column quoting" do
+    before(:all) do
+      schema_define do
+        create_table :test_reserved_words do |t|
+          t.string      :varchar2
+          t.integer     :integer
+          t.text        :comment
+        end
+      end
+      class ::TestReservedWord < ActiveRecord::Base; end
+    end
+
+    after(:all) do
+      schema_define do
+        drop_table :test_reserved_words
+      end
+      Object.send(:remove_const, "TestReservedWord")
+      ActiveRecord::Base.table_name_prefix = nil
+      ActiveRecord::Base.clear_cache!
+    end
+
+    before(:each) do
+      set_logger
+    end
+
+    after(:each) do
+      clear_logger
+    end
+
+    it "should create table" do
+      [:varchar2, :integer, :comment].each do |attr|
+        expect(TestReservedWord.columns_hash[attr.to_s].name).to eq(attr.to_s)
+      end
+    end
+
+    it "should create record" do
+      attrs = {
+        varchar2: "dummy",
+        integer: 1,
+        comment: "dummy"
+      }
+      record = TestReservedWord.create!(attrs)
+      record.reload
+      attrs.each do |k, v|
+        expect(record.send(k)).to eq(v)
+      end
+    end
+
+    it "should remove double quotes in column quoting" do
+      expect(ActiveRecord::Base.connection.quote_column_name('aaa "bbb" ccc')).to eq('"aaa bbb ccc"')
+    end
+  end
+
+  describe "valid table names" do
+    before(:all) do
+      @adapter = ActiveRecord::ConnectionAdapters::OracleEnhanced::Quoting
+    end
+
+    it "should be valid with letters and digits" do
+      expect(@adapter.valid_table_name?("abc_123")).to be_truthy
+    end
+
+    it "should be valid with schema name" do
+      expect(@adapter.valid_table_name?("abc_123.def_456")).to be_truthy
+    end
+
+    it "should be valid with schema name and object name in different case" do
+      expect(@adapter.valid_table_name?("TEST_DBA.def_456")).to be_truthy
+    end
+
+    it "should be valid with $ in name" do
+      expect(@adapter.valid_table_name?("sys.v$session")).to be_truthy
+    end
+
+    it "should be valid with upcase schema name" do
+      expect(@adapter.valid_table_name?("ABC_123.DEF_456")).to be_truthy
+    end
+
+    it "should not be valid with two dots in name" do
+      expect(@adapter.valid_table_name?("abc_123.def_456.ghi_789")).to be_falsey
+    end
+
+    it "should not be valid with invalid characters" do
+      expect(@adapter.valid_table_name?("warehouse-things")).to be_falsey
+    end
+
+    it "should not be valid with for camel-case" do
+      expect(@adapter.valid_table_name?("Abc")).to be_falsey
+      expect(@adapter.valid_table_name?("aBc")).to be_falsey
+      expect(@adapter.valid_table_name?("abC")).to be_falsey
+    end
+
+    it "should not be valid for names > 30 characters" do
+      expect(@adapter.valid_table_name?("a" * 31)).to be_falsey
+    end
+
+    it "should not be valid for schema names > 30 characters" do
+      expect(@adapter.valid_table_name?(("a" * 31) + ".validname")).to be_falsey
+    end
+
+    it "should not be valid for names that do not begin with alphabetic characters" do
+      expect(@adapter.valid_table_name?("1abc")).to be_falsey
+      expect(@adapter.valid_table_name?("_abc")).to be_falsey
+      expect(@adapter.valid_table_name?("abc.1xyz")).to be_falsey
+      expect(@adapter.valid_table_name?("abc._xyz")).to be_falsey
+    end
+  end
+
+  describe "table quoting" do
+    def create_warehouse_things_table
+      ActiveRecord::Schema.define do
+        suppress_messages do
+          create_table "warehouse-things" do |t|
+            t.string      :name
+            t.integer     :foo
+          end
+        end
+      end
+    end
+
+    def create_camel_case_table
+      ActiveRecord::Schema.define do
+        suppress_messages do
+          create_table "CamelCase" do |t|
+            t.string      :name
+            t.integer     :foo
+          end
+        end
+      end
+    end
+
+    before(:all) do
+      @conn = ActiveRecord::Base.connection
+    end
+
+    after(:each) do
+      ActiveRecord::Schema.define do
+        suppress_messages do
+          drop_table "warehouse-things", if_exists: true
+          drop_table "CamelCase", if_exists: true
+        end
+      end
+      Object.send(:remove_const, "WarehouseThing") rescue nil
+      Object.send(:remove_const, "CamelCase") rescue nil
+    end
+
+    it "should allow creation of a table with non alphanumeric characters" do
+      create_warehouse_things_table
+      class ::WarehouseThing < ActiveRecord::Base
+        self.table_name = "warehouse-things"
+      end
+
+      wh = WarehouseThing.create!(name: "Foo", foo: 2)
+      expect(wh.id).not_to be_nil
+
+      expect(@conn.tables).to include("warehouse-things")
+    end
+
+    it "should allow creation of a table with CamelCase name" do
+      create_camel_case_table
+      class ::CamelCase < ActiveRecord::Base
+        self.table_name = "CamelCase"
+      end
+
+      cc = CamelCase.create!(name: "Foo", foo: 2)
+      expect(cc.id).not_to be_nil
+
+      expect(@conn.tables).to include("CamelCase")
+    end
+  end
+end