activerecord-oracle_enhanced-adapter 7.0.3 → 7.1.0.beta1

data/spec/active_record/oracle_enhanced/type/integer_spec.rb

@@ -87,5 +87,13 @@ describe "OracleEnhancedAdapter integer type detection based on attribute settin
       create_employee2
       expect(@employee2.is_manager).to be_a(Integer)
     end
+
+    it "should return Integer value from NUMBER(1) column if emulate_booleans is set to false" do
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans = false
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.clear_type_map!
+      ActiveRecord::Base.clear_cache!
+      create_employee2
+      expect(@employee2.is_manager).to be_a(Integer)
+    end
   end
 end

data/spec/active_record/oracle_enhanced/type/national_character_text_spec.rb

@@ -79,7 +79,7 @@ describe "OracleEnhancedAdapter handling of NCLOB columns" do
     @employee.reload
     expect(@employee.comments).to eq(@nclob_data)
     @employee.comments = @nclob_data2
-    expect(@employee.save).to eq(true)
+    expect(@employee.save).to be(true)
     @employee.reload
     expect(@employee.comments).to eq(@nclob_data)
   end
@@ -90,12 +90,12 @@ describe "OracleEnhancedAdapter handling of NCLOB columns" do
       comments: nil
     )
     expect(@employee.comments).to be_nil
-    expect(@employee.save).to eq(true)
+    expect(@employee.save).to be(true)
     expect(@employee).to be_valid
     @employee.reload
     expect(@employee.comments).to be_nil
     @employee.comments = {}
-    expect(@employee.save).to eq(true)
+    expect(@employee.save).to be(true)
     @employee.reload
     # should not set readonly
     expect(@employee.comments).to be_nil

data/spec/active_record/oracle_enhanced/type/raw_spec.rb

@@ -119,4 +119,19 @@ describe "OracleEnhancedAdapter handling of RAW columns" do
     @employee.reload
     expect(@employee.binary_data).to eq(@binary_data)
   end
+
+  it "should allow equality on select" do
+    TestEmployee.delete_all
+    TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last",
+      binary_data: @binary_data,
+    )
+    TestEmployee.create!(
+      first_name: "First1",
+      last_name: "Last1",
+      binary_data: @binary_data2,
+    )
+    expect(TestEmployee.where(binary_data: @binary_data)).to have_attributes(count: 1)
+  end
 end

data/spec/active_record/oracle_enhanced/type/text_spec.rb

@@ -78,7 +78,7 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
     @employee.reload
     expect(@employee.comments).to eq("initial")
     @employee.comments = "changed"
-    expect(@employee.save).to eq(true)
+    expect(@employee.save).to be(true)
     @employee.reload
     expect(@employee.comments).to eq("initial")
   end
@@ -89,12 +89,12 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
       comments: nil
     )
     expect(@employee.comments).to be_nil
-    expect(@employee.save).to eq(true)
+    expect(@employee.save).to be(true)
     expect(@employee).to be_valid
     @employee.reload
     expect(@employee.comments).to be_nil
     @employee.comments = {}
-    expect(@employee.save).to eq(true)
+    expect(@employee.save).to be(true)
     @employee.reload
     # should not set readonly
     expect(@employee.comments).to be_nil
@@ -226,4 +226,19 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
     @employee.reload
     expect(@employee.comments).to eq(length: { is: 2 })
   end
+
+  it "should allow equality on select" do
+    search_data = "text search CLOB"
+    Test2Employee.create!(
+      first_name: "First",
+      last_name: "Last",
+      comments: search_data,
+    )
+    Test2Employee.create!(
+      first_name: "First1",
+      last_name: "Last1",
+      comments: "other data",
+    )
+    expect(Test2Employee.where(comments: search_data)).to have_attributes(count: 1)
+  end
 end

data/spec/active_record/oracle_enhanced/type/timestamp_spec.rb

@@ -4,6 +4,10 @@ describe "OracleEnhancedAdapter timestamp with timezone support" do
   include SchemaSpecHelper
 
   before(:all) do
+    skip if ENV["DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH"] == "true"
+    if ENV["DATABASE_VERSION"] == "11.2.0.2" && ENV["ORACLE_HOME"] == "/usr/lib/oracle/21/client64"
+      skip
+    end
     ActiveRecord.default_timezone = :local
     ActiveRecord::Base.establish_connection(CONNECTION_WITH_TIMEZONE_PARAMS)
     @conn = ActiveRecord::Base.connection
@@ -27,7 +31,7 @@ describe "OracleEnhancedAdapter timestamp with timezone support" do
   end
 
   after(:all) do
-    @conn.drop_table :test_employees, if_exists: true
+    @conn.drop_table :test_employees, if_exists: true rescue nil
     ActiveRecord.default_timezone = :utc
   end
 

data/spec/spec_config.yaml.template

@@ -1,11 +1,11 @@
 # copy this file to spec/spec_config.yaml and set appropriate values
 # you can also use environment variables, see spec_helper.rb
 database:
-  name:         'orcl'
+  name:         'FREEPDB1'
   host:         '127.0.0.1'
   port:         1521
   user:         'oracle_enhanced'
   password:     'oracle_enhanced'
-  sys_password: 'admin'
+  sys_password: 'oracle'
   non_default_tablespace: 'SYSTEM'
 timezone: 'Europe/Riga'

data/spec/spec_helper.rb

@@ -57,6 +57,8 @@ module LoggerSpecHelper
   end
 
   class MockLogger
+    LEVELS = %i[debug info warn error fatal unknown]
+
     attr_reader :flush_count
 
     def initialize
@@ -64,13 +66,22 @@ module LoggerSpecHelper
       @logged = Hash.new { |h, k| h[k] = [] }
     end
 
-    # used in AtiveRecord 2.x
+    # used in ActiveRecord 2.x
     def debug?
       true
     end
 
-    def method_missing(level, message)
-      @logged[level] << message
+    def level
+      0
+    end
+
+    def method_missing(*args)
+      if LEVELS.include?(args[0])
+        level, message  = args
+        @logged[level] << message
+      else
+        super
+      end
     end
 
     def logged(level)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 7.0.3
+  version: 7.1.0.beta1
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-10 00:00:00.000000000 Z
+date: 2024-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.0
+        version: 7.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.0
+        version: 7.1.0
 - !ruby/object:Gem::Dependency
   name: ruby-plsql
   requirement: !ruby/object:Gem::Requirement
@@ -102,6 +102,7 @@ files:
 - lib/activerecord-oracle_enhanced-adapter.rb
 - lib/arel/visitors/oracle.rb
 - lib/arel/visitors/oracle12.rb
+- lib/arel/visitors/oracle_common.rb
 - spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
@@ -136,7 +137,8 @@ files:
 homepage: http://github.com/rsim/oracle-enhanced
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -152,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.8.11
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord