activerecord-oracle_enhanced-adapter 5.2.0 → 5.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5c56a2903f50e1f4d29ebce73f1d3ecfb8ccc20fdff51530358068c99e74182
-  data.tar.gz: 1230afe509076a53d1f797ccbdba4d74b29647fdc263f60849d1ae34145e6116
+  metadata.gz: aa24e2267bec0862bb898b8f03c11af04a34543d38f75e8b39a5b46000009437
+  data.tar.gz: '0485525d25c1f4307c1e9b958cd2f1b286bc5d10542e2fd8615e499a00c989c2'
 SHA512:
-  metadata.gz: ba4c22c74b3da5cd8768681df7c57aa0b07d1037d13efeecd3588a3487543f79b2d0eea2e7c0fe7fd947aa66d0f339c39ff263bf680831b603c74052fa38e990
-  data.tar.gz: cc928edfef4189c8ce3ed0e1d1643b2b13369ef052467b21fa7223c03d4a31925b45572e3d60e2ec3b108d12365d601f3e17884eda599586cd869789841c4895
+  metadata.gz: e70d58d735fec37fd8e19122f37b284397f152c911e3baf8127d8828cefd7b9f139d1acf2f3e147def7c82be26decd7e4f4eb10e85e63489ef6933ab089f83b7
+  data.tar.gz: 5651ab5ab00219a433b7281959d51068ea47dcd33648761cd4dc4f22c69f285dd79a8c73e262fdabe81042e9751dcb02021392c472649f7662b593daf1187d60

data/History.md

@@ -1,3 +1,63 @@
+## 5.2.8 / 2019-12-25
+
+* Changes and bug fixes
+  * Uninstall SimpleCov [#1968 #1970]
+
+## 5.2.7 / 2019-12-20
+
+* Changes and bug fixes
+  * Address undefined local variable or method sql' [#1932 #1962 #1964]
+  * CI against Ruby 2.6.4 and Ruby 2.5.6 [#1922]
+  * Lock simplecov version for Ruby 2.2 and 2.3 [#1902]
+
+## 5.2.6 / 2019-05-17
+
+* Changes and bug fixes
+  * Add TCP keepalive and TCP keepalive time configurations [#1874 #1878]
+  * CI against Ruby 2.6.2 and 2.5.5 #1849
+  * CI against Ruby 2.4.6 #1858
+
+## 5.2.5 / 2019-03-05
+
+* Changes and bug fixes
+  * `references` column type should be :integer, not :bigint [#1831 #1832 #1835]
+  * CI against Ruby 2.6.1 [#1821 #1822]
+  * CI against JRuby 9.2.6.0 [#1824 #1828]
+  * CI against Ruby 2.6 and bump other Ruby versions [#1806 #1807]
+  * Install bundler and fallback to 1.7.3 if Bundler 2 is not available [#1811]
+  * Use i18n 1.2 for JRuby now [#1804 #1805]
+  * Add `allow_railures` for jruby-head until #1833 resolved [#1834 #1836]
+
+## 5.2.4 / 2018-11-29
+
+* Changes and bug fixes
+  * Stop using NativeException [#1666 #1761 #1762]
+
+## 5.2.3 / 2018-08-08
+
+* Changes and bug fixes
+  * Introduce column cache per connection [#1744 #1750]
+  * Use `cursor_sharing` = force by default again [#1745 #1748]
+  * Add `table_name` search condition to `indexes(table_name)` method [#1747 #1749]
+  * Suppress warning `BigDecimal.new` is deprecated [#1742 #1743]
+  * Do not install bundler explicitly [#1725 #1726]
+  * Add `allow_railures` for jruby-head until #1737 resolved [#1739 #1740]
+  * CI against JRuby 9.2.0.0 [#1728 #1741]
+  * Do not run CI against older version of JRuby [#1741]
+
+## 5.2.2 / 2018-04-28
+
+* Changes and bug fixes
+  * Use SQL literals for `column_definitions` and `pk_and_sequence_for` [#1678 #1713 #1714]
+  * Memoize if the table needs to prefetch primary key[#1673 #1699 #1700]
+  * CI with JRuby 9.1.17.0 [#1710]
+  * Remove `rails/arel` from Gemfile [#1711 #1712]
+
+## 5.2.1 / 2018-04-15
+
+* Changes and bug fixes
+  * Memoize if the table needs to prefetch primary key[#1673 #1699 #1700]
+
 ## 5.2.0 / 2018-04-10
 
 * Major changes and fixes

data/VERSION

@@ -1 +1 @@
-5.2.0
+5.2.8

data/lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb

@@ -263,7 +263,7 @@ module ActiveRecord
               value = klass.attribute_types[col.name].serialize(value)
             end
             uncached do
-              unless lob_record = select_one(<<-SQL.strip.gsub(/\s+/, " "), "Writable Large Object")
+              unless lob_record = select_one(sql = <<-SQL.strip.gsub(/\s+/, " "), "Writable Large Object")
                 SELECT #{quote_column_name(col.name)} FROM #{quote_table_name(table_name)}
                 WHERE #{quote_column_name(klass.primary_key)} = #{id} FOR UPDATE
               SQL

data/lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb

@@ -150,7 +150,7 @@ module ActiveRecord
             # @raw_connection.setDefaultRowPrefetch(prefetch_rows) if prefetch_rows
           end
 
-          cursor_sharing = config[:cursor_sharing]
+          cursor_sharing = config[:cursor_sharing] || "force"
           exec "alter session set cursor_sharing = #{cursor_sharing}" if cursor_sharing
 
           # Initialize NLS parameters
@@ -209,13 +209,9 @@ module ActiveRecord
         def ping
           exec_no_retry("select 1 from dual")
           @active = true
-        rescue NativeException => e
+        rescue Java::JavaSql::SQLException => e
           @active = false
-          if e.message =~ /^java\.sql\.SQL(Recoverable)?Exception/
-            raise OracleEnhanced::ConnectionException, e.message
-          else
-            raise
-          end
+          raise OracleEnhanced::ConnectionException, e.message
         end
 
         # Resets connection, by logging off and creating a new connection.
@@ -224,13 +220,9 @@ module ActiveRecord
           begin
             new_connection(@config)
             @active = true
-          rescue NativeException => e
+          rescue Java::JavaSql::SQLException => e
             @active = false
-            if e.message =~ /^java\.sql\.SQL(Recoverable)?Exception/
-              raise OracleEnhanced::ConnectionException, e.message
-            else
-              raise
-            end
+            raise OracleEnhanced::ConnectionException, e.message
           end
         end
 
@@ -239,8 +231,8 @@ module ActiveRecord
           should_retry = auto_retry? && autocommit?
           begin
             yield if block_given?
-          rescue NativeException => e
-            raise unless e.message =~ /^java\.sql\.SQL(Recoverable)?Exception: (Closed Connection|Io exception:|No more data to read from socket|IO Error:)/
+          rescue Java::JavaSql::SQLException => e
+            raise unless e.message =~ /^(Closed Connection|Io exception:|No more data to read from socket|IO Error:)/
             @active = false
             raise unless should_retry
             should_retry = false
@@ -455,11 +447,9 @@ module ActiveRecord
           super
         end
 
-        # Return NativeException / java.sql.SQLException error code
+        # Return java.sql.SQLException error code
         def error_code(exception)
           case exception
-          when NativeException
-            exception.cause.getErrorCode
           when Java::JavaSql::SQLException
             exception.getErrorCode
           else
@@ -476,7 +466,7 @@ module ActiveRecord
             elsif d.isInt
               Integer(d.stringValue)
             else
-              BigDecimal.new(d.stringValue)
+              BigDecimal(d.stringValue)
             end
           when :BINARY_FLOAT
             rset.getFloat(i)

data/lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb

@@ -124,7 +124,7 @@ module ActiveRecord
             when Type::OracleEnhanced::Raw
               @raw_cursor.bind_param(position, OracleEnhanced::Quoting.encode_raw(value))
             when ActiveModel::Type::Decimal
-              @raw_cursor.bind_param(position, BigDecimal.new(value.to_s))
+              @raw_cursor.bind_param(position, BigDecimal(value.to_s))
             when NilClass
               @raw_cursor.bind_param(position, nil, String)
             else
@@ -285,6 +285,8 @@ module ActiveRecord
       # The OracleEnhancedOCIFactory factors out the code necessary to connect and
       # configure an Oracle/OCI connection.
       class OracleEnhancedOCIFactory #:nodoc:
+        DEFAULT_TCP_KEEPALIVE_TIME = 600
+
         def self.new_connection(config)
           # to_s needed if username, password or database is specified as number in database.yml file
           username = config[:username] && config[:username].to_s
@@ -295,7 +297,7 @@ module ActiveRecord
           privilege = config[:privilege] && config[:privilege].to_sym
           async = config[:allow_concurrency]
           prefetch_rows = config[:prefetch_rows] || 100
-          cursor_sharing = config[:cursor_sharing]
+          cursor_sharing = config[:cursor_sharing] || "force"
           # get session time_zone from configuration or from TZ environment variable
           time_zone = config[:time_zone] || ENV["TZ"]
 
@@ -314,11 +316,13 @@ module ActiveRecord
           else
             database
           end
-          OCI8.properties[:tcp_keepalive] = true
+
+          OCI8.properties[:tcp_keepalive] = config[:tcp_keepalive] == false ? false : true
           begin
-            OCI8.properties[:tcp_keepalive_time] = 600
+            OCI8.properties[:tcp_keepalive_time] = config[:tcp_keepalive_time] || DEFAULT_TCP_KEEPALIVE_TIME
           rescue NotImplementedError
           end
+
           conn = OCI8.new username, password, connection_string, privilege
           conn.autocommit = true
           conn.non_blocking = true if async

data/lib/active_record/connection_adapters/oracle_enhanced/schema_definitions.rb

@@ -66,6 +66,11 @@ module ActiveRecord
           end
           super
         end
+
+        def references(*args, **options)
+          super(*args, type: :integer, **options)
+        end
+        alias :belongs_to :references
       end
 
       class AlterTable < ActiveRecord::ConnectionAdapters::AlterTable

data/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb

@@ -83,7 +83,7 @@ module ActiveRecord
           (owner, table_name, db_link) = @connection.describe(table_name)
           default_tablespace_name = default_tablespace
 
-          result = select_all(<<-SQL.strip.gsub(/\s+/, " "), "indexes", [bind_string("owner", owner), bind_string("owner", owner)])
+          result = select_all(<<-SQL.strip.gsub(/\s+/, " "), "indexes", [bind_string("owner", owner), bind_string("owner", owner), bind_string("table_name", table_name)])
             SELECT LOWER(i.table_name) AS table_name, LOWER(i.index_name) AS index_name, i.uniqueness,
               i.index_type, i.ityp_owner, i.ityp_name, i.parameters,
               LOWER(i.tablespace_name) AS tablespace_name,
@@ -97,6 +97,7 @@ module ActiveRecord
                 c.column_name = atc.column_name AND i.owner = atc.owner AND atc.hidden_column = 'NO'
             WHERE i.owner = :owner
                AND i.table_owner = :owner
+               AND i.table_name = :table_name
                AND NOT EXISTS (SELECT uc.index_name FROM all_constraints uc
                 WHERE uc.index_name = i.index_name AND uc.owner = i.owner AND uc.constraint_type = 'P')
             ORDER BY i.index_name, c.column_position
@@ -152,6 +153,14 @@ module ActiveRecord
           all_schema_indexes.select { |i| i.table == table_name }
         end
 
+        def columns(table_name)
+          table_name = table_name.to_s
+          if @columns_cache[table_name]
+            @columns_cache[table_name]
+          else
+            @columns_cache[table_name] = super(table_name)
+          end
+        end
         # Additional options for +create_table+ method in migration files.
         #
         # You can specify individual starting value in table creation migration file, e.g.:
@@ -248,6 +257,8 @@ module ActiveRecord
           execute "DROP SEQUENCE #{quote_table_name(seq_name)}" rescue nil
         rescue ActiveRecord::StatementInvalid => e
           raise e unless options[:if_exists]
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def insert_versions_sql(versions) # :nodoc:
@@ -398,6 +409,8 @@ module ActiveRecord
           execute add_column_sql
           create_sequence_and_trigger(table_name, options) if type && type.to_sym == :primary_key
           change_column_comment(table_name, column_name, options[:comment]) if options.key?(:comment)
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def aliased_types(name, fallback)
@@ -407,6 +420,8 @@ module ActiveRecord
         def change_column_default(table_name, column_name, default_or_changes) #:nodoc:
           default = extract_new_default_value(default_or_changes)
           execute "ALTER TABLE #{quote_table_name(table_name)} MODIFY #{quote_column_name(column_name)} DEFAULT #{quote(default)}"
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def change_column_null(table_name, column_name, null, default = nil) #:nodoc:
@@ -439,15 +454,21 @@ module ActiveRecord
           execute(change_column_sql)
 
           change_column_comment(table_name, column_name, options[:comment]) if options.key?(:comment)
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def rename_column(table_name, column_name, new_column_name) #:nodoc:
           execute "ALTER TABLE #{quote_table_name(table_name)} RENAME COLUMN #{quote_column_name(column_name)} to #{quote_column_name(new_column_name)}"
           rename_column_indexes(table_name, column_name, new_column_name)
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def remove_column(table_name, column_name, type = nil, options = {}) #:nodoc:
           execute "ALTER TABLE #{quote_table_name(table_name)} DROP COLUMN #{quote_column_name(column_name)} CASCADE CONSTRAINTS"
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def change_table_comment(table_name, comment)

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -115,6 +115,8 @@ module ActiveRecord
     # * <tt>:time_zone</tt> - database session time zone
     #   (it is recommended to set it using ENV['TZ'] which will be then also used for database session time zone)
     # * <tt>:schema</tt> - database schema which holds schema objects.
+    # * <tt>:tcp_keepalive</tt> - TCP keepalive is enabled for OCI client, defaults to true
+    # * <tt>:tcp_keepalive_time</tt> - TCP keepalive time for OCI client, defaults to 600
     #
     # Optionals NLS parameters:
     #
@@ -212,6 +214,8 @@ module ActiveRecord
         super(connection, logger, config)
         @statements = StatementPool.new(self.class.type_cast_config_to_integer(config[:statement_limit]))
         @enable_dbms_output = false
+        @do_not_prefetch_primary_key = {}
+        @columns_cache = {}
       end
 
       ADAPTER_NAME = "OracleEnhanced".freeze
@@ -427,8 +431,11 @@ module ActiveRecord
       def prefetch_primary_key?(table_name = nil)
         return true if table_name.nil?
         table_name = table_name.to_s
-        owner, desc_table_name, db_link = @connection.describe(table_name)
-        do_not_prefetch = !has_primary_key?(table_name, owner, desc_table_name, db_link) || has_primary_key_trigger?(table_name, owner, desc_table_name, db_link)
+        do_not_prefetch = @do_not_prefetch_primary_key[table_name]
+        if do_not_prefetch.nil?
+          owner, desc_table_name, db_link = @connection.describe(table_name)
+          @do_not_prefetch_primary_key [table_name] = do_not_prefetch = !has_primary_key?(table_name, owner, desc_table_name, db_link) || has_primary_key_trigger?(table_name, owner, desc_table_name, db_link)
+        end
         !do_not_prefetch
       end
 
@@ -514,7 +521,7 @@ module ActiveRecord
       def column_definitions(table_name)
         (owner, desc_table_name, db_link) = @connection.describe(table_name)
 
-        select_all(<<-SQL.strip.gsub(/\s+/, " "), "Column definitions", [bind_string("owner", owner), bind_string("table_name", desc_table_name)])
+        select_all(<<-SQL.strip.gsub(/\s+/, " "), "Column definitions")
           SELECT cols.column_name AS name, cols.data_type AS sql_type,
                  cols.data_default, cols.nullable, cols.virtual_column, cols.hidden_column,
                  cols.data_type_owner AS sql_type_owner,
@@ -527,8 +534,8 @@ module ActiveRecord
                  DECODE(data_type, 'NUMBER', data_scale, NULL) AS scale,
                  comments.comments as column_comment
             FROM all_tab_cols#{db_link} cols, all_col_comments#{db_link} comments
-           WHERE cols.owner      = :owner
-             AND cols.table_name = :table_name
+           WHERE cols.owner      = '#{owner}'
+             AND cols.table_name = #{quote(desc_table_name)}
              AND cols.hidden_column = 'NO'
              AND cols.owner = comments.owner
              AND cols.table_name = comments.table_name
@@ -537,24 +544,28 @@ module ActiveRecord
         SQL
       end
 
+      def clear_table_columns_cache(table_name)
+        @columns_cache[table_name.to_s] = nil
+      end
+
       # Find a table's primary key and sequence.
       # *Note*: Only primary key is implemented - sequence will be nil.
       def pk_and_sequence_for(table_name, owner = nil, desc_table_name = nil, db_link = nil) #:nodoc:
         (owner, desc_table_name, db_link) = @connection.describe(table_name) unless owner
 
-        seqs = select_values(<<-SQL.strip.gsub(/\s+/, " "), "Sequence", [bind_string("owner", owner), bind_string("sequence_name", default_sequence_name(desc_table_name).upcase)])
+        seqs = select_values(<<-SQL.strip.gsub(/\s+/, " "), "Sequence")
           select us.sequence_name
           from all_sequences#{db_link} us
-          where us.sequence_owner = :owner
-          and us.sequence_name = :sequence_name
+          where us.sequence_owner = '#{owner}'
+          and us.sequence_name = upper(#{quote(default_sequence_name(desc_table_name))})
         SQL
 
         # changed back from user_constraints to all_constraints for consistency
-        pks = select_values(<<-SQL.strip.gsub(/\s+/, " "), "Primary Key", [bind_string("owner", owner), bind_string("table_name", desc_table_name)])
+        pks = select_values(<<-SQL.strip.gsub(/\s+/, " "), "Primary Key")
           SELECT cc.column_name
             FROM all_constraints#{db_link} c, all_cons_columns#{db_link} cc
-           WHERE c.owner = :owner
-             AND c.table_name = :table_name
+           WHERE c.owner = '#{owner}'
+             AND c.table_name = #{quote(desc_table_name)}
              AND c.constraint_type = 'P'
              AND cc.owner = c.owner
              AND cc.constraint_name = c.constraint_name

data/spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb

@@ -31,15 +31,15 @@ describe "OracleEnhancedAdapter establish connection" do
     expect(ActiveRecord::Base.connection).to be_active
   end
 
-  it "should use database default cursor_sharing parameter value exact by default" do
+  it "should use database default cursor_sharing parameter value force by default" do
     # Use `SYSTEM_CONNECTION_PARAMS` to query v$parameter
     ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS)
-    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("EXACT")
+    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("FORCE")
   end
 
-  it "should use modified cursor_sharing value force" do
-    ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS.merge(cursor_sharing: :force))
-    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("FORCE")
+  it "should use modified cursor_sharing value exact" do
+    ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS.merge(cursor_sharing: :exact))
+    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("EXACT")
   end
 end
 
@@ -122,6 +122,34 @@ describe "OracleEnhancedConnection" do
     end
   end
 
+  if defined?(OCI8)
+    describe "with TCP keepalive parameters" do
+      it "should use database default `tcp_keepalive` value true by default" do
+        ActiveRecord::ConnectionAdapters::OracleEnhanced::Connection.create(CONNECTION_PARAMS)
+
+        expect(OCI8.properties[:tcp_keepalive]).to be true
+      end
+
+      it "should use modified `tcp_keepalive` value false" do
+        ActiveRecord::ConnectionAdapters::OracleEnhanced::Connection.create(CONNECTION_PARAMS.dup.merge(tcp_keepalive: false))
+
+        expect(OCI8.properties[:tcp_keepalive]).to be false
+      end
+
+      it "should use database default `tcp_keepalive_time` value 600 by default" do
+        ActiveRecord::ConnectionAdapters::OracleEnhanced::Connection.create(CONNECTION_PARAMS)
+
+        expect(OCI8.properties[:tcp_keepalive_time]).to eq(600)
+      end
+
+      it "should use modified `tcp_keepalive_time` value 3000" do
+        ActiveRecord::ConnectionAdapters::OracleEnhanced::Connection.create(CONNECTION_PARAMS.dup.merge(tcp_keepalive_time: 3000))
+
+        expect(OCI8.properties[:tcp_keepalive_time]).to eq(3000)
+      end
+    end
+  end
+
   describe "with non-string parameters" do
     before(:all) do
       params = CONNECTION_PARAMS.dup
@@ -381,7 +409,7 @@ describe "OracleEnhancedConnection" do
       ActiveRecord::Base.connection.auto_retry = false
       kill_current_session
       if defined?(RUBY_ENGINE) && RUBY_ENGINE == "jruby"
-        expect { @conn.exec("SELECT * FROM dual") }.to raise_error(NativeException)
+        expect { @conn.exec("SELECT * FROM dual") }.to raise_error(Java::JavaSql::SQLRecoverableException)
       else
         expect { @conn.exec("SELECT * FROM dual") }.to raise_error(OCIError)
       end
@@ -399,7 +427,7 @@ describe "OracleEnhancedConnection" do
       ActiveRecord::Base.connection.auto_retry = false
       kill_current_session
       if defined?(RUBY_ENGINE) && RUBY_ENGINE == "jruby"
-        expect { @conn.select("SELECT * FROM dual") }.to raise_error(NativeException)
+        expect { @conn.select("SELECT * FROM dual") }.to raise_error(Java::JavaSql::SQLRecoverableException)
       else
         expect { @conn.select("SELECT * FROM dual") }.to raise_error(OCIError)
       end

data/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb

@@ -67,15 +67,16 @@ describe "OracleEnhancedAdapter" do
       end
 
       it "should get columns from database at first time" do
+        @conn.clear_table_columns_cache(:test_employees)
         expect(TestEmployee.connection.columns("test_employees").map(&:name)).to eq(@column_names)
         expect(@logger.logged(:debug).last).to match(/select .* from all_tab_cols/im)
       end
 
-      it "should get columns from database at second time" do
+      it "should not get columns from database at second time" do
         TestEmployee.connection.columns("test_employees")
         @logger.clear(:debug)
         expect(TestEmployee.connection.columns("test_employees").map(&:name)).to eq(@column_names)
-        expect(@logger.logged(:debug).last).to match(/select .* from all_tab_cols/im)
+        expect(@logger.logged(:debug).last).not_to match(/select .* from all_tab_cols/im)
       end
 
       it "should get primary key from database at first time" do
@@ -96,6 +97,14 @@ describe "OracleEnhancedAdapter" do
           expect(TestEmployee2.columns.map(&:sql_type)).to eq(@column_sql_types)
         end
       end
+
+      it "should get sequence value at next time" do
+        TestEmployee.create!
+        expect(@logger.logged(:debug).first).not_to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im)
+        @logger.clear(:debug)
+        TestEmployee.create!
+        expect(@logger.logged(:debug).first).to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im)
+      end
     end
   end
 
@@ -129,6 +138,7 @@ describe "OracleEnhancedAdapter" do
       @conn.execute "DROP DATABASE LINK #{@db_link}" rescue nil
       @sys_conn.drop_table :test_posts, if_exists: true
       Object.send(:remove_const, "TestPost") rescue nil
+      @conn.clear_table_columns_cache(:test_posts)
       ActiveRecord::Base.clear_cache!
     end
 
@@ -524,7 +534,7 @@ describe "OracleEnhancedAdapter" do
     it "should return array from indexes with bind usage" do
       expect(@conn.indexes("TEST_POSTS").class).to eq Array
       expect(@logger.logged(:debug).last).to match(/:owner/)
-      expect(@logger.logged(:debug).last).to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["owner", "#{DATABASE_USER.upcase}"\]\]/)
+      expect(@logger.logged(:debug).last).to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["owner", "#{DATABASE_USER.upcase}"\], \["table_name", "TEST_POSTS"\]\]/)
     end
 
     it "should not have primary key trigger with bind usage" do
@@ -534,17 +544,17 @@ describe "OracleEnhancedAdapter" do
       expect(@logger.logged(:debug).last).to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["trigger_name", "TEST_POSTS_PKT"\], \["owner", "#{DATABASE_USER.upcase}"\], \["table_name", "TEST_POSTS"\]\]/)
     end
 
-    it "should return content from columns with bind usage" do
+    it "should return content from columns without bind usage" do
       expect(@conn.columns("TEST_POSTS").length).to be > 0
-      expect(@logger.logged(:debug).last).to match(/:owner/)
-      expect(@logger.logged(:debug).last).to match(/:table_name/)
-      expect(@logger.logged(:debug).last).to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["table_name", "TEST_POSTS"\]\]/)
+      expect(@logger.logged(:debug).last).not_to match(/:owner/)
+      expect(@logger.logged(:debug).last).not_to match(/:table_name/)
+      expect(@logger.logged(:debug).last).not_to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["table_name", "TEST_POSTS"\]\]/)
     end
 
-    it "should return pk and sequence from pk_and_sequence_for with bind usage" do
+    it "should return pk and sequence from pk_and_sequence_for without bind usage" do
       expect(@conn.pk_and_sequence_for("TEST_POSTS").length).to eq 2
-      expect(@logger.logged(:debug).last).to match(/:owner/)
-      expect(@logger.logged(:debug).last).to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["table_name", "TEST_POSTS"\]\]/)
+      expect(@logger.logged(:debug).last).not_to match(/:owner/)
+      expect(@logger.logged(:debug).last).not_to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["table_name", "TEST_POSTS"\]\]/)
     end
 
     it "should return pk from primary_keys with bind usage" do

data/spec/spec_helper.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "simplecov"
-SimpleCov.start
 require "rubygems"
 require "bundler"
 require "yaml"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.2.8
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-09 00:00:00.000000000 Z
+date: 2019-12-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -133,37 +133,36 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.8.11
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord
 test_files:
-- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
+- spec/spec_helper.rb
 - spec/active_record/oracle_enhanced/type/integer_spec.rb
-- spec/active_record/oracle_enhanced/type/national_character_text_spec.rb
-- spec/active_record/oracle_enhanced/type/timestamp_spec.rb
-- spec/active_record/oracle_enhanced/type/binary_spec.rb
-- spec/active_record/oracle_enhanced/type/national_character_string_spec.rb
 - spec/active_record/oracle_enhanced/type/raw_spec.rb
 - spec/active_record/oracle_enhanced/type/float_spec.rb
+- spec/active_record/oracle_enhanced/type/boolean_spec.rb
 - spec/active_record/oracle_enhanced/type/dirty_spec.rb
+- spec/active_record/oracle_enhanced/type/binary_spec.rb
+- spec/active_record/oracle_enhanced/type/timestamp_spec.rb
+- spec/active_record/oracle_enhanced/type/national_character_text_spec.rb
 - spec/active_record/oracle_enhanced/type/json_spec.rb
 - spec/active_record/oracle_enhanced/type/text_spec.rb
-- spec/active_record/oracle_enhanced/type/boolean_spec.rb
-- spec/spec_config.yaml.template
-- spec/spec_helper.rb
-- spec/support/create_oracle_enhanced_users.sql
+- spec/active_record/oracle_enhanced/type/national_character_string_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb
+- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
 - spec/support/alter_system_user_password.sql
+- spec/support/create_oracle_enhanced_users.sql
 - spec/support/alter_system_set_open_cursors.sql
+- spec/spec_config.yaml.template