activerecord-oracle_enhanced-adapter 5.2.0.beta1 → 5.2.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 756277df9a862718b6a18af9b3ff476e12a2497c45d8bdcfdaf47d4be0ebff8b
-  data.tar.gz: e970bf14ed9a4eec4b85c67c50c804ffa6a4e52a788a0d95463dfd44b5453ce8
+  metadata.gz: 8e19195d88863e1aee0c0455835a4b147089cf1d63f186313781c7a873971584
+  data.tar.gz: b00a09707c748ce35f909a8bd9130236384e8b93fd968f44db018500dfecd957
 SHA512:
-  metadata.gz: 750450b6486e4d3289e4131dd98e433eef87f37e23d20004729cb2fffe6564e98f476a08afe987cad7f673499ded21903300a31a19bed7f3ff0a18f735fd5de5
-  data.tar.gz: dead151bdc335ee36ac65e1c8b50679fedc1d1a388b314e3f71dce6a79186ebd893fb261e97018a9773c3e65820daf465e47177e5f9ed949a7c2c4fee4f2b837
+  metadata.gz: '08d0dafa1bd9ab6babb68da03bdb4d72b0d5778c60065afbfaca1cd58b765705d6b3794343bae0d4d3c423f26206c776a54a20922aaa610d2f758af57e827729'
+  data.tar.gz: 0fe5601895d3c5bee38f624908a89c8bbd2b3717f63769abb9c5169536e1aacdbc9a6fea490b8a30a5ad6a02964063a7182dbbefd76375d9a40f561341ec287e

data/History.md

@@ -2,7 +2,7 @@
 
 * Major changes and fixes
 
-  * Support Rails 5.2.0.beta1 [Not released yet but this history will be available when Rails 5.2.0.beta1 is available]
+  * Support Rails 5.2.0.beta1
   * Oracle enhanced adapter version follows Rails versioning [#1488]
   * Handle `TIMESTAMP WITH TIMEZONE` separately from `TIMEZONE` [#1267]
   * Support `timestamptz` and `timestampltz` for migrations #1285

data/VERSION

@@ -1 +1 @@
-5.2.0.beta1
+5.2.0.rc1

data/lib/active_record/connection_adapters/oracle_enhanced/context_index.rb

@@ -231,7 +231,7 @@ module ActiveRecord
               default_clause = case clause
                                when "R_TABLE_CLAUSE"; "LOB(DATA) STORE AS (CACHE) "
                                when "I_INDEX_CLAUSE"; "COMPRESS 2 "
-              else ""
+                               else ""
               end
               sql << "CTX_DDL.SET_ATTRIBUTE('#{storage_name}', '#{clause}', '#{default_clause}TABLESPACE #{tablespace}');\n"
             end
@@ -248,7 +248,7 @@ module ActiveRecord
                             when true; "'YES'"
                             when false; "'NO'"
                             when nil; "NULL"
-              else value
+                            else value
               end
               sql << "CTX_DDL.SET_ATTRIBUTE('#{lexer_name}', '#{key}', #{plsql_value});\n"
             end
@@ -265,7 +265,7 @@ module ActiveRecord
                             when true; "'YES'"
                             when false; "'NO'"
                             when nil; "NULL"
-              else value
+                            else value
               end
               sql << "CTX_DDL.SET_ATTRIBUTE('#{wordlist_name}', '#{key}', #{plsql_value});\n"
             end

data/lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb

@@ -224,11 +224,27 @@ module ActiveRecord
 
         # fallback to non bulk fixture insert
         def insert_fixtures(fixtures, table_name)
+          ActiveSupport::Deprecation.warn(<<-MSG.squish)
+            `insert_fixtures` is deprecated and will be removed in the next version of Rails.
+            Consider using `insert_fixtures_set` for performance improvement.
+          MSG
           fixtures.each do |fixture|
             insert_fixture(fixture, table_name)
           end
         end
 
+        def insert_fixtures_set(fixture_set, tables_to_delete = [])
+          disable_referential_integrity do
+            transaction(requires_new: true) do
+              tables_to_delete.each { |table| delete "DELETE FROM #{quote_table_name(table)}", "Fixture Delete" }
+
+              fixture_set.each do |table_name, rows|
+                rows.each { |row| insert_fixture(row, table_name) }
+              end
+            end
+          end
+        end
+
         # Oracle Database does not support this feature
         # Refer https://community.oracle.com/ideas/13845 and consider to vote
         # if you need this feature.

data/lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb

@@ -269,7 +269,7 @@ module ActiveRecord
                                                      [value.year, value.month, value.day, value.hour, value.min, value.sec, value.usec]
                                                    when OraDate
                                                      [value.year, value.month, value.day, value.hour, value.minute, value.second, 0]
-          else
+                                                   else
                                                      [value.year, value.month, value.day, value.hour, value.min, value.sec, 0]
           end
           # code from Time.time_with_datetime_fallback

data/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb

@@ -128,7 +128,7 @@ module ActiveRecord
                 row["index_name"],
                 row["uniqueness"] == "UNIQUE",
                 [],
-                nil,
+                {},
                 row["index_type"] == "DOMAIN" ? "#{row['ityp_owner']}.#{row['ityp_name']}" : nil,
                 row["parameters"],
                 statement_parameters,
@@ -290,7 +290,7 @@ module ActiveRecord
           index_name = options[:name].to_s if options.key?(:name)
           tablespace = tablespace_for(:index, options[:tablespace])
           max_index_length = options.fetch(:internal, false) ? index_name_length : allowed_index_name_length
-          #TODO: This option is used for NOLOGGING, needs better argumetn name
+          # TODO: This option is used for NOLOGGING, needs better argumetn name
           index_options = options[:options]
 
           if index_name.to_s.length > max_index_length
@@ -308,7 +308,7 @@ module ActiveRecord
         # Gives warning if index does not exist
         def remove_index(table_name, options = {}) #:nodoc:
           index_name = index_name_for_remove(table_name, options)
-          #TODO: It should execute only when index_type == "UNIQUE"
+          # TODO: It should execute only when index_type == "UNIQUE"
           execute "ALTER TABLE #{quote_table_name(table_name)} DROP CONSTRAINT #{quote_column_name(index_name)}" rescue nil
           execute "DROP INDEX #{quote_column_name(index_name)}"
         end

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -646,11 +646,7 @@ module ActiveRecord
           end
 
           if OracleEnhancedAdapter.emulate_booleans
-            if OracleEnhancedAdapter.emulate_booleans_from_strings
-              m.register_type %r(^VARCHAR2\(1\))i, Type::OracleEnhanced::Boolean.new
-            else
-              m.register_type %r(^NUMBER\(1\))i, Type::Boolean.new
-            end
+            m.register_type %r(^NUMBER\(1\))i, Type::Boolean.new
           end
         end
 

data/lib/active_record/type/oracle_enhanced/national_character_text.rb

@@ -11,7 +11,7 @@ module ActiveRecord
         end
 
         def changed_in_place?(raw_old_value, new_value)
-          #TODO: Needs to find a way not to cast here.
+          # TODO: Needs to find a way not to cast here.
           raw_old_value = cast(raw_old_value)
           super
         end

data/lib/active_record/type/oracle_enhanced/text.rb

@@ -7,7 +7,7 @@ module ActiveRecord
     module OracleEnhanced
       class Text < ActiveRecord::Type::Text # :nodoc:
         def changed_in_place?(raw_old_value, new_value)
-          #TODO: Needs to find a way not to cast here.
+          # TODO: Needs to find a way not to cast here.
           raw_old_value = cast(raw_old_value)
           super
         end

data/spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb

@@ -394,15 +394,15 @@ describe "OracleEnhancedAdapter structure dump" do
       @conn.create_table :full_drop_test_temp, temporary: true do |t|
         t.string :foo
       end
-      #view
+      # view
       @conn.execute <<-SQL
         create or replace view full_drop_test_view (foo) as select id as "foo" from full_drop_test
       SQL
-      #materialized view
+      # materialized view
       @conn.execute <<-SQL
         create materialized view full_drop_test_mview (foo) as select id as "foo" from full_drop_test
       SQL
-      #package
+      # package
       @conn.execute <<-SQL
         create or replace package full_drop_test_package as
           function test_func return varchar2;
@@ -416,7 +416,7 @@ describe "OracleEnhancedAdapter structure dump" do
           end test_func;
         end test_package;
       SQL
-      #function
+      # function
       @conn.execute <<-SQL
         create or replace function full_drop_test_function
           return varchar2
@@ -426,7 +426,7 @@ describe "OracleEnhancedAdapter structure dump" do
           return('foo');
         end;
       SQL
-      #procedure
+      # procedure
       @conn.execute <<-SQL
         create or replace procedure full_drop_test_procedure
         begin
@@ -436,11 +436,11 @@ describe "OracleEnhancedAdapter structure dump" do
           dbms_output.put_line('foo');
         end;
       SQL
-      #synonym
+      # synonym
       @conn.execute <<-SQL
         create or replace synonym full_drop_test_synonym for full_drop_test
       SQL
-      #type
+      # type
       @conn.execute <<-SQL
         create or replace type full_drop_test_type as table of number
       SQL

data/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb

@@ -573,6 +573,7 @@ describe "OracleEnhancedAdapter" do
     end
 
     it "Raises Deadlocked when a deadlock is encountered" do
+      skip "Skip temporary due to #1599" if ActiveRecord::Base.connection.supports_fetch_first_n_rows_and_offset?
       expect {
         barrier = Concurrent::CyclicBarrier.new(2)
 

data/spec/active_record/oracle_enhanced/type/boolean_spec.rb

@@ -190,6 +190,7 @@ describe "OracleEnhancedAdapter boolean support when emulate_booleans_from_strin
 
   before(:each) do
     class ::Post < ActiveRecord::Base
+      attribute :is_default, :boolean
     end
   end
 

data/spec/active_record/oracle_enhanced/type/national_character_text_spec.rb

@@ -97,7 +97,7 @@ describe "OracleEnhancedAdapter handling of NCLOB columns" do
     @employee.comments = {}
     expect(@employee.save).to eq(true)
     @employee.reload
-    #should not set readonly
+    # should not set readonly
     expect(@employee.comments).to be_nil
   end
 

data/spec/active_record/oracle_enhanced/type/text_spec.rb

@@ -96,7 +96,7 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
     @employee.comments = {}
     expect(@employee.save).to eq(true)
     @employee.reload
-    #should not set readonly
+    # should not set readonly
     expect(@employee.comments).to be_nil
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 5.2.0.beta1
+  version: 5.2.0.rc1
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-27 00:00:00.000000000 Z
+date: 2018-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0.beta
+        version: 5.2.0.rc
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0.beta
+        version: 5.2.0.rc
 - !ruby/object:Gem::Dependency
   name: ruby-plsql
   requirement: !ruby/object:Gem::Requirement
@@ -134,36 +134,36 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.8.11
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.2
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord
 test_files:
-- spec/support/create_oracle_enhanced_users.sql
-- spec/support/alter_system_set_open_cursors.sql
-- spec/support/alter_system_user_password.sql
-- spec/spec_config.yaml.template
-- spec/spec_helper.rb
+- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
 - spec/active_record/oracle_enhanced/type/integer_spec.rb
 - spec/active_record/oracle_enhanced/type/national_character_text_spec.rb
 - spec/active_record/oracle_enhanced/type/timestamp_spec.rb
+- spec/active_record/oracle_enhanced/type/binary_spec.rb
+- spec/active_record/oracle_enhanced/type/national_character_string_spec.rb
 - spec/active_record/oracle_enhanced/type/raw_spec.rb
+- spec/active_record/oracle_enhanced/type/float_spec.rb
 - spec/active_record/oracle_enhanced/type/dirty_spec.rb
 - spec/active_record/oracle_enhanced/type/json_spec.rb
-- spec/active_record/oracle_enhanced/type/float_spec.rb
-- spec/active_record/oracle_enhanced/type/boolean_spec.rb
-- spec/active_record/oracle_enhanced/type/national_character_string_spec.rb
-- spec/active_record/oracle_enhanced/type/binary_spec.rb
 - spec/active_record/oracle_enhanced/type/text_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
-- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
+- spec/active_record/oracle_enhanced/type/boolean_spec.rb
+- spec/spec_config.yaml.template
+- spec/spec_helper.rb
+- spec/support/create_oracle_enhanced_users.sql
+- spec/support/alter_system_user_password.sql
+- spec/support/alter_system_set_open_cursors.sql