activerecord-oracle_enhanced-adapter 1.7.0.beta7 → 1.7.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b5ecb4fcf3be4949760d12a99a2c06a89a44fea
-  data.tar.gz: d3d9a6418c0ee745bc8d41185aed6eaaef63a0ef
+  metadata.gz: 766d556c9fdb716de4aecfd9856f94187f11ea9f
+  data.tar.gz: 3e0df68d291259d67fbc4b020b10c0aa876204d9
 SHA512:
-  metadata.gz: 4c01bacb2da9176ff7c2217b93a8aa35f0420b3f282a7a77fc6ac7bd710c535e70d0ef9598a46e8553d29ace8a838407aab09fea084b221eda1929babc3c3a14
-  data.tar.gz: 0f61c5cd4ed438a14b81c82c3d3fde2514da3b4692820c049778c4469c877cd022b1356622abc4f215040ea28033740d7ae2f26b54f6183fb25e2b8f0d6b5986
+  metadata.gz: 073a8f2e716f1090227ce6296b6cbdc0f489fa77b158a5d0bb03011f24ea1c2f2d643c560ba87afa6007547961924a2ca9984658dc36f1a547ef7509126a548e
+  data.tar.gz: 1fb80f53dc9a0398ef762b5d96c20230c331435371b7237d2241b6eb32784716366feeb4e7f304c0aeaf0f1f116f4746225679108de748380fc4ffd43d6cd927

data/History.md

@@ -1,3 +1,25 @@
+## 1.7.0.rc1 / 2016-08-02
+
+* Changes and bug fixes
+
+ * Support `emulate_booleans_from_strings` in Rails 5 [#953, #942]
+ * Deprecate `self.is_boolean_column?` [#949]
+ * Deprecate `self.is_date_column?` and `is_date_column?` [#950]
+ * Deprecate `set_type_for_columns`, `set_type_for_columns` and `clear_types_for_columns` [#951]
+ * Deprecate `self.is_integer_column?` [#952]
+
+* Known issues
+
+ - Only with JRuby
+ * Rails 5 : explain should explain query with binds got Java::JavaSql::SQLException: Invalid column index [#908]
+    * Workaround: execute explain without bind or use CRuby
+ - CRuby and JRuby
+ * Rails 5 : custom methods for create record when exception is raised in after_create callback fails [#944]
+ * Rails 5 : specs need update to emulate_booleans_from_strings [#942]
+ * Rails 5 : undefined method `to_i' for #<Arel::Nodes::BindParam:0x00000002c92910> [#848, rails/arel#438]
+    * #848 reproduces when database version is 11gR2 or older, it does not reproduce with 12c
+    * One of the units test skipped when database version is 11gR2 or lower. [#946]
+
 ## 1.7.0.beta7 / 2016-08-01
 
 * Changes and bug fixes

data/README.md

@@ -18,7 +18,7 @@ Oracle enhanced adapter Rails 5 support is still in beta release, so use with ca
 
 ```ruby
 # Use oracle as the database for Active Record
-gem 'activerecord-oracle_enhanced-adapter', '~> 1.7.0.beta7'
+gem 'activerecord-oracle_enhanced-adapter', '~> 1.7.0.rc1'
 ```
 
 ### Rails 4.2

data/VERSION

@@ -1 +1 @@
-1.7.0.beta7
+1.7.0.rc1

data/activerecord-oracle_enhanced-adapter.gemspec

@@ -1,12 +1,12 @@
 Gem::Specification.new do |s|
   s.name = %q{activerecord-oracle_enhanced-adapter}
-  s.version = "1.7.0.beta7"
+  s.version = "1.7.0.rc1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.required_ruby_version     = '>= 2.2.2'
   s.license = 'MIT'
   s.authors = [%q{Raimonds Simanovskis}]
-  s.date = %q{2016-08-01}
+  s.date = %q{2016-08-02}
   s.description = %q{Oracle "enhanced" ActiveRecord adapter contains useful additional methods for working with new and legacy Oracle databases.
 This adapter is superset of original ActiveRecord Oracle adapter.
 }

data/lib/active_record/connection_adapters/oracle_enhanced/quoting.rb

@@ -106,11 +106,21 @@ module ActiveRecord
           "1"
         end
 
+        def unquoted_true #:nodoc:
+          return "#{self.class.boolean_to_string(true)}" if emulate_booleans_from_strings
+          "1".freeze
+        end
+
         def quoted_false #:nodoc:
           return "'#{self.class.boolean_to_string(false)}'" if emulate_booleans_from_strings
           "0"
         end
 
+        def unquoted_false #:nodoc:
+          return "#{self.class.boolean_to_string(false)}" if emulate_booleans_from_strings
+          "0".freeze
+        end
+
         def quote_date_with_to_date(value) #:nodoc:
           ActiveSupport::Deprecation.warn(<<-MSG.squish)
             `quote_date_with_to_date` will be deprecated in future version of Oracle enhanced adapter.
@@ -138,13 +148,6 @@ module ActiveRecord
 
         def _type_cast(value)
           case value
-          when true, false
-            #if emulate_booleans_from_strings || column && column.type == :string
-            if emulate_booleans_from_strings
-              self.class.boolean_to_string(value)
-            else
-              value ? 1 : 0
-            end
           when Date, Time
             if value.acts_like?(:time)
               zone_conversion_method = ActiveRecord::Base.default_timezone == :utc ? :getutc : :getlocal

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -303,19 +303,27 @@ module ActiveRecord
       # Is used if +emulate_dates_by_column_name+ option is set to +true+.
       # Override this method definition in initializer file if different Date column recognition is needed.
       def self.is_date_column?(name, table_name = nil)
-        name =~ /(^|_)date(_|$)/i
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+          `self.is_date_column?` has been deprecated. Please use Rails attribute API.
+        MSG
+        return false
+        # name =~ /(^|_)date(_|$)/i
       end
 
       # instance method uses at first check if column type defined at class level
       def is_date_column?(name, table_name = nil) #:nodoc:
-        case get_type_for_column(table_name, name)
-        when nil
-          self.class.is_date_column?(name, table_name)
-        when :date
-          true
-        else
-          false
-        end
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+          `is_date_column?` has been deprecated. Please use Rails attribute API.
+        MSG
+        return false
+        #case get_type_for_column(table_name, name)
+        #when nil
+        #  self.class.is_date_column?(name, table_name)
+        #when :date
+        #  true
+        #else
+        #  false
+        #end
       end
 
       ##
@@ -333,7 +341,10 @@ module ActiveRecord
       # Is used if +emulate_integers_by_column_name+ option is set to +true+.
       # Override this method definition in initializer file if different Integer column recognition is needed.
       def self.is_integer_column?(name, table_name = nil)
-        name =~ /(^|_)id$/i
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+          `is_integer_column?` has been deprecated. Please use Rails attribute API.
+        MSG
+        return false
       end
 
       ##
@@ -349,8 +360,12 @@ module ActiveRecord
       # Is used if +emulate_booleans_from_strings+ option is set to +true+.
       # Override this method definition in initializer file if different boolean column recognition is needed.
       def self.is_boolean_column?(name, sql_type, table_name = nil)
-        return true if ["CHAR(1)","VARCHAR2(1)"].include?(sql_type)
-        sql_type =~ /^VARCHAR2/ && (name =~ /_flag$/i || name =~ /_yn$/i)
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+          `is_boolean_column?` has been deprecated. Please use Rails attribute API.
+        MSG
+        return false
+        # return true if ["CHAR(1)","VARCHAR2(1)"].include?(sql_type)
+        # sql_type =~ /^VARCHAR2/ && (name =~ /_flag$/i || name =~ /_yn$/i)
       end
 
       # How boolean value should be quoted to String.
@@ -880,20 +895,22 @@ module ActiveRecord
 
       # set explicit type for specified table columns
       def set_type_for_columns(table_name, column_type, *args) #:nodoc:
-        @@table_column_type ||= {}
-        @@table_column_type[table_name] ||= {}
-        args.each do |col|
-          @@table_column_type[table_name][col.to_s.downcase] = column_type
-        end
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+          `set_type_for_columns` has been deprecated. Please use Rails attribute API.
+        MSG
       end
 
       def get_type_for_column(table_name, column_name) #:nodoc:
-        @@table_column_type && @@table_column_type[table_name] && @@table_column_type[table_name][column_name.to_s.downcase]
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+          `get_type_for_columns` has been deprecated. Please use Rails attribute API.
+        MSG
       end
 
       # used just in tests to clear column data type definitions
       def clear_types_for_columns #:nodoc:
-        @@table_column_type = nil
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+          `clear_types_for_columns` has been deprecated. Please use Rails attribute API.
+        MSG
       end
 
       # check if table has primary key trigger with _pkt suffix
@@ -1176,7 +1193,13 @@ module ActiveRecord
           end
         end
 
-        m.register_type %r(^NUMBER\(1\))i, Type::Boolean.new if OracleEnhancedAdapter.emulate_booleans
+        if OracleEnhancedAdapter.emulate_booleans
+          if OracleEnhancedAdapter.emulate_booleans_from_strings
+            m.register_type %r(^VARCHAR2\(1\))i, Type::Boolean.new
+          else
+            m.register_type %r(^NUMBER\(1\))i, Type::Boolean.new
+          end
+        end
       end
 
       def extract_limit(sql_type) #:nodoc:

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -58,7 +58,6 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
     after(:each) do
       # @employee.destroy if @employee
       Object.send(:remove_const, "TestEmployee")
-      @conn.clear_types_for_columns
       ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
 
@@ -186,7 +185,6 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
     
     after(:each) do
       Object.send(:remove_const, "Test2Employee")
-      @conn.clear_types_for_columns
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans = true
       ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
@@ -312,14 +310,13 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
 
   after(:each) do
     Object.send(:remove_const, "Test3Employee")
-    @conn.clear_types_for_columns
     ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
   end
 
   describe "default values in new records" do
     context "when emulate_booleans_from_strings is false" do
       before do
-        # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
+        ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
       end
 
       it "are Y or N" do
@@ -331,7 +328,7 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
 
     context "when emulate_booleans_from_strings is true" do
       before do
-        #ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
+        ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
       end
 
       it "are True or False" do
@@ -347,18 +344,17 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
   end
 
   it "should translate boolean type to NUMBER(1) if emulate_booleans_from_strings is false" do
-    # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
+    ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
     expect(ActiveRecord::Base.connection.type_to_sql(
       :boolean, nil, nil, nil)).to eq("NUMBER(1)")
   end
 
   describe "/ VARCHAR2 boolean values from ActiveRecord model" do
     before(:each) do
-      # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
     end
 
     after(:each) do
-      @conn.clear_types_for_columns
       ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
 
@@ -377,7 +373,7 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
     end
 
     it "should return String value from VARCHAR2 boolean column if emulate_booleans_from_strings is false" do
-      # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
       create_employee3
       %w(has_email has_phone active_flag manager_yn).each do |col|
         expect(@employee3.send(col.to_sym).class).to eq(String)
@@ -404,7 +400,7 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
     end
 
     it "should return string value from VARCHAR2 column if it is not boolean column and emulate_booleans_from_strings is true" do
-      # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
       create_employee3
       expect(@employee3.first_name.class).to eq(String)
     end
@@ -430,7 +426,7 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
     end
 
     it "should return string value from VARCHAR2 column with boolean column name but is specified in set_string_columns" do
-      # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
       # Test3Employee.set_string_columns :active_flag
       class ::Test3Employee < ActiveRecord::Base
         attribute :active_flag, :string

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 1.7.0.beta7
+  version: 1.7.0.rc1
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-01 00:00:00.000000000 Z
+date: 2016-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord