activerecord-oracle_enhanced-adapter 1.3.2 → 1.4.0

data/spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb

@@ -78,6 +78,7 @@ describe "OracleEnhancedAdapter context index" do
     after(:all) do
       drop_table_posts
       Object.send(:remove_const, "Post")
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
 
     after(:each) do
@@ -157,6 +158,17 @@ describe "OracleEnhancedAdapter context index" do
       Post.contains(:title, "ACE").all.should == [@post]
       @conn.remove_context_index :posts, :title
     end
+
+    it "should create transactional index and sync index within transaction on inserts and updates" do
+      @conn.add_context_index :posts, :title, :transactional => true
+      Post.transaction do
+        @post = Post.create(:title => "abc")
+        Post.contains(:title, "abc").all.should == [@post]
+        @post.update_attributes!(:title => "ghi")
+        Post.contains(:title, "ghi").all.should == [@post]
+      end
+      @conn.remove_context_index :posts, :title
+    end
   end
 
   describe "on multiple tables" do
@@ -176,6 +188,7 @@ describe "OracleEnhancedAdapter context index" do
       drop_tables
       Object.send(:remove_const, "Comment")
       Object.send(:remove_const, "Post")
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
 
     after(:each) do
@@ -200,6 +213,28 @@ describe "OracleEnhancedAdapter context index" do
       @conn.remove_context_index :posts, :name => 'post_and_comments_index'
     end
 
+    it "should create multiple table index with specified main index column (when subquery has newlines)" do
+      @conn.add_context_index :posts,
+        [:title, :body,
+         # specify aliases always with AS keyword
+         %{ SELECT
+             comments.author AS comment_author,
+             comments.body AS comment_body
+            FROM comments
+            WHERE comments.post_id = :id }
+        ],
+        :name => 'post_and_comments_index',
+        :index_column => :all_text, :index_column_trigger_on => [:updated_at, :comments_count],
+        :sync => 'ON COMMIT'
+      @post = Post.create!(:title => "aaa", :body => "bbb")
+      @post.comments.create!(:author => "ccc", :body => "ddd")
+      @post.comments.create!(:author => "eee", :body => "fff")
+      ["aaa", "bbb", "ccc", "ddd", "eee", "fff"].each do |word|
+        Post.contains(:all_text, word).all.should == [@post]
+      end
+      @conn.remove_context_index :posts, :name => 'post_and_comments_index'
+    end
+
     it "should find by search term within specified field" do
       @post = Post.create!(:title => "aaa", :body => "bbb")
       @post.comments.create!(:author => "ccc", :body => "ddd")
@@ -238,6 +273,7 @@ describe "OracleEnhancedAdapter context index" do
     after(:all) do
       drop_table_posts
       Object.send(:remove_const, "Post")
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
 
     after(:each) do
@@ -303,13 +339,38 @@ describe "OracleEnhancedAdapter context index" do
         options = {
           :name => 'post_and_comments_index',
           :index_column => :all_text, :index_column_trigger_on => :updated_at,
+          :transactional => true,
+          :sync => 'ON COMMIT'
+        }
+        sub_query = "SELECT comments.author AS comment_author, comments.body AS comment_body FROM comments WHERE comments.post_id = :id"
+        @conn.add_context_index :posts, [:title, :body, sub_query], options
+        standard_dump.should =~ /add_context_index "posts", \[:title, :body, "#{sub_query}"\], #{options.inspect[1..-2]}$/
+        @conn.remove_context_index :posts, :name => 'post_and_comments_index'
+      end
+
+      it "should dump definition of multiple table index with options (when definition is larger than 4000 bytes)" do
+        options = {
+          :name => 'post_and_comments_index',
+          :index_column => :all_text, :index_column_trigger_on => :updated_at,
+          :transactional => true,
+          :sync => 'ON COMMIT'
+        }
+        sub_query = "SELECT comments.author AS comment_author, comments.body AS comment_body FROM comments WHERE comments.post_id = :id#{' AND 1=1' * 500}"
+        @conn.add_context_index :posts, [:title, :body, sub_query], options
+        standard_dump.should =~ /add_context_index "posts", \[:title, :body, "#{sub_query}"\], #{options.inspect[1..-2]}$/
+        @conn.remove_context_index :posts, :name => 'post_and_comments_index'
+      end
+
+      it "should dump definition of multiple table index with options (when subquery has newlines)" do
+        options = {
+          :name => 'post_and_comments_index',
+          :index_column => :all_text, :index_column_trigger_on => :updated_at,
+          :transactional => true,
           :sync => 'ON COMMIT'
         }
-        @conn.add_context_index :posts,
-          [:title, :body,
-          "SELECT comments.author AS comment_author, comments.body AS comment_body FROM comments WHERE comments.post_id = :id"
-          ], options
-        standard_dump.should =~ /add_context_index "posts", \[:title, :body, "SELECT comments.author AS comment_author, comments.body AS comment_body FROM comments WHERE comments.post_id = :id"\], #{options.inspect[1..-2]}$/
+        sub_query = "SELECT comments.author AS comment_author, comments.body AS comment_body\nFROM comments\nWHERE comments.post_id = :id"
+        @conn.add_context_index :posts, [:title, :body, sub_query], options
+        standard_dump.should =~ /add_context_index "posts", \[:title, :body, "#{sub_query.gsub(/\n/, ' ')}"\], #{options.inspect[1..-2]}$/
         @conn.remove_context_index :posts, :name => 'post_and_comments_index'
       end
 

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -107,6 +107,7 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
       # @employee.destroy if @employee
       Object.send(:remove_const, "TestEmployee")
       @conn.clear_types_for_columns
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
 
     it "should return Time value from DATE column if emulate_dates_by_column_name is false" do
@@ -191,6 +192,7 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
   before(:all) do
     ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
+    @conn.execute "DROP TABLE test2_employees" rescue nil
     @conn.execute <<-SQL
       CREATE TABLE test2_employees (
         id            NUMBER PRIMARY KEY,
@@ -208,6 +210,7 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
         created_at    DATE
       )
     SQL
+    @conn.execute "DROP SEQUENCE test2_employees_seq" rescue nil
     @conn.execute <<-SQL
       CREATE SEQUENCE test2_employees_seq  MINVALUE 1
         INCREMENT BY 1 START WITH 10040 CACHE 20 NOORDER NOCYCLE
@@ -266,6 +269,7 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
       Object.send(:remove_const, "Test2Employee")
       @conn.clear_types_for_columns
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans = true
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
     
     def create_employee2
@@ -445,6 +449,7 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
     after(:each) do
       Object.send(:remove_const, "Test3Employee")
       @conn.clear_types_for_columns
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
     
     def create_employee3(params={})
@@ -564,6 +569,7 @@ describe "OracleEnhancedAdapter timestamp with timezone support" do
 
     after(:all) do
       Object.send(:remove_const, "TestEmployee")
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end
 
     it "should return Time value from TIMESTAMP columns" do
@@ -647,6 +653,7 @@ describe "OracleEnhancedAdapter date and timestamp with different NLS date forma
 
   after(:each) do
     Object.send(:remove_const, "TestEmployee")    
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
   end
   
   def create_test_employee
@@ -742,6 +749,7 @@ describe "OracleEnhancedAdapter assign string to :date and :datetime columns" do
     Object.send(:remove_const, "TestEmployee")
     @conn.execute "DROP TABLE test_employees"
     @conn.execute "DROP SEQUENCE test_employees_seq"
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
   end
 
   before(:each) do
@@ -862,7 +870,7 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test_employees (
-        employee_id   NUMBER(6,0) PRIMARY KEY,
+        id            NUMBER(6,0) PRIMARY KEY,
         first_name    VARCHAR2(20),
         last_name     VARCHAR2(25),
         comments      CLOB
@@ -872,28 +880,39 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
       CREATE SEQUENCE test_employees_seq  MINVALUE 1
         INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
     SQL
+    @conn.execute <<-SQL
+      CREATE TABLE test2_employees (
+        id            NUMBER(6,0) PRIMARY KEY,
+        first_name    VARCHAR2(20),
+        last_name     VARCHAR2(25),
+        comments      CLOB
+      )
+    SQL
+    @conn.execute <<-SQL
+      CREATE SEQUENCE test2_employees_seq  MINVALUE 1
+        INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
+    SQL
     @char_data = (0..127).to_a.pack("C*") * 800
     @char_data2 = ((1..127).to_a.pack("C*") + "\0") * 800
-  end
-  
-  after(:all) do
-    @conn.execute "DROP TABLE test_employees"
-    @conn.execute "DROP SEQUENCE test_employees_seq"
-  end
 
-  before(:each) do
-    class ::TestEmployee < ActiveRecord::Base
-      set_primary_key :employee_id
+    class ::TestEmployee < ActiveRecord::Base; end
+    class ::Test2Employee < ActiveRecord::Base
+      serialize :comments
     end
   end
 
-  after(:each) do
+  after(:all) do
+    @conn.execute "DROP TABLE test_employees"
+    @conn.execute "DROP SEQUENCE test_employees_seq"
+    @conn.execute "DROP TABLE test2_employees"
+    @conn.execute "DROP SEQUENCE test2_employees_seq"
     Object.send(:remove_const, "TestEmployee")
+    Object.send(:remove_const, "Test2Employee")
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
   end
 
   it "should create record without CLOB data when attribute is serialized" do
-    TestEmployee.serialize :comments
-    @employee = TestEmployee.create!(
+    @employee = Test2Employee.create!(
       :first_name => "First",
       :last_name => "Last"
     )
@@ -989,6 +1008,7 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
       :comments => ''
     )
     @employee.reload
+    @employee.comments.should == ''
     @employee.comments = @char_data
     @employee.save!
     @employee.reload
@@ -1029,6 +1049,7 @@ describe "OracleEnhancedAdapter handling of BLOB columns" do
   
   after(:each) do
     Object.send(:remove_const, "TestEmployee")
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
   end
   
   it "should create record with BLOB data" do
@@ -1107,6 +1128,132 @@ describe "OracleEnhancedAdapter handling of BLOB columns" do
   end
 
   it "should update record that has zero-length BLOB data with non-empty BLOB data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => ''
+    )
+    @employee.reload
+    @employee.binary_data.should == ''
+    @employee.binary_data = @binary_data
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should == @binary_data
+  end
+end
+
+describe "OracleEnhancedAdapter handling of RAW columns" do
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+    @conn.execute <<-SQL
+      CREATE TABLE test_employees (
+        employee_id   NUMBER(6,0) PRIMARY KEY,
+        first_name    VARCHAR2(20),
+        last_name     VARCHAR2(25),
+        binary_data   RAW(1024)
+      )
+    SQL
+    @conn.execute <<-SQL
+      CREATE SEQUENCE test_employees_seq  MINVALUE 1
+        INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
+    SQL
+    @binary_data = "\0\1\2\3\4\5\6\7\8\9"*100
+    @binary_data2 = "\1\2\3\4\5\6\7\8\9\0"*100
+  end
+
+  after(:all) do
+    @conn.execute "DROP TABLE test_employees"
+    @conn.execute "DROP SEQUENCE test_employees_seq"
+  end
+
+  before(:each) do
+    class ::TestEmployee < ActiveRecord::Base
+      set_primary_key :employee_id
+    end
+  end
+
+  after(:each) do
+    Object.send(:remove_const, "TestEmployee")
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
+  end
+
+  it "should create record with RAW data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => @binary_data
+    )
+    @employee.reload
+    @employee.binary_data.should == @binary_data
+  end
+
+  it "should update record with RAW data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last"
+    )
+    @employee.reload
+    @employee.binary_data.should be_nil
+    @employee.binary_data = @binary_data
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should == @binary_data
+  end
+
+  it "should update record with zero-length RAW data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last"
+    )
+    @employee.reload
+    @employee.binary_data.should be_nil
+    @employee.binary_data = ''
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should.nil?
+  end
+
+  it "should update record that has existing RAW data with different RAW data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => @binary_data
+    )
+    @employee.reload
+    @employee.binary_data = @binary_data2
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should == @binary_data2
+  end
+
+  it "should update record that has existing RAW data with nil" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => @binary_data
+    )
+    @employee.reload
+    @employee.binary_data = nil
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should be_nil
+  end
+
+  it "should update record that has existing RAW data with zero-length RAW data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => @binary_data
+    )
+    @employee.reload
+    @employee.binary_data = ''
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should.nil?
+  end
+
+  it "should update record that has zero-length BLOB data with non-empty RAW data" do
     @employee = TestEmployee.create!(
       :first_name => "First",
       :last_name => "Last",
@@ -1120,6 +1267,7 @@ describe "OracleEnhancedAdapter handling of BLOB columns" do
   end
 end
 
+
 describe "OracleEnhancedAdapter quoting of NCHAR and NVARCHAR2 columns" do
   before(:all) do
     ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
@@ -1148,6 +1296,7 @@ describe "OracleEnhancedAdapter quoting of NCHAR and NVARCHAR2 columns" do
 
   after(:each) do
     Object.send(:remove_const, "TestItem")
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
   end
 
   it "should set nchar instance variable" do

data/spec/active_record/connection_adapters/oracle_enhanced_dirty_spec.rb

@@ -30,6 +30,7 @@ if ActiveRecord::Base.instance_methods.include?('changed?')
       Object.send(:remove_const, "TestEmployee")
       @conn.execute "DROP TABLE test_employees"
       @conn.execute "DROP SEQUENCE test_employees_seq"
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
     end  
 
     it "should not mark empty string (stored as NULL) as changed when reassigning it" do

data/spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb

@@ -155,6 +155,7 @@ describe "OracleEnhancedAdapter custom methods for create, update and destroy" d
 
   after(:each) do
     Object.send(:remove_const, "TestEmployee")
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
   end
 
   it "should create record" do

data/spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb

@@ -6,6 +6,7 @@ describe "OracleEnhancedAdapter schema dump" do
   before(:all) do
     ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
+    @oracle11g = !! @conn.select_value("SELECT * FROM v$version WHERE banner LIKE 'Oracle%11g%'")
   end
 
   def standard_dump(options = {})
@@ -85,12 +86,24 @@ describe "OracleEnhancedAdapter schema dump" do
       standard_dump.should =~ /create_table "test_posts".*add_index "test_posts"/m
     end
 
+    it "should remove table prefix with $ sign in schema dump" do
+      ActiveRecord::Base.table_name_prefix = 'xxx$'
+      create_test_posts_table
+      standard_dump.should =~ /create_table "test_posts".*add_index "test_posts"/m
+    end
+
     it "should remove table suffix in schema dump" do
       ActiveRecord::Base.table_name_suffix = '_xxx'
       create_test_posts_table
       standard_dump.should =~ /create_table "test_posts".*add_index "test_posts"/m
     end
 
+    it "should remove table suffix with $ sign in schema dump" do
+      ActiveRecord::Base.table_name_suffix = '$xxx'
+      create_test_posts_table
+      standard_dump.should =~ /create_table "test_posts".*add_index "test_posts"/m
+    end
+
     it "should not include schema_migrations table with prefix in schema dump" do
       ActiveRecord::Base.table_name_prefix = 'xxx_'
       @conn.initialize_schema_migrations_table
@@ -332,5 +345,35 @@ describe "OracleEnhancedAdapter schema dump" do
     end
   end
 
+  describe 'virtual columns' do
+    before(:all) do
+      schema_define do
+        create_table :test_names, :force => true do |t|
+          t.string :first_name
+          t.string :last_name
+          t.virtual :full_name, :default=>"first_name || ', ' || last_name" if @oracle11g
+        end
+      end
+    end
+    before(:each) do
+      class ::TestName < ActiveRecord::Base
+        set_table_name "test_names"
+      end
+    end
+
+    after(:all) do
+      schema_define do
+        drop_table :test_names
+      end
+    end
+
+    it 'should dump correctly' do
+      pending "Not supported in this database version" unless @oracle11g
+      standard_dump.should =~ /t.virtual "full_name",(\s*):limit => 512,(\s*):default => "/
+    end
+
+  end
+
+
 end