activerecord-oracle_enhanced-adapter 1.2.1 → 1.2.2

data/spec/active_record/connection_adapters/oracle_enhanced_connection_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe "OracleEnhancedConnection create connection" do
 
@@ -38,6 +38,42 @@ describe "OracleEnhancedConnection create connection" do
 
 end
 
+if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby'
+
+  describe "OracleEnhancedConnection create JDBC connection" do
+    after(:each) do
+      @conn.logoff if @conn.active?
+    end
+
+    it "should create new connection using :url" do
+      params = CONNECTION_PARAMS.dup
+      params[:url] = "jdbc:oracle:thin:@#{DATABASE_HOST}:#{DATABASE_PORT}:#{DATABASE_NAME}"
+      params[:host] = nil
+      params[:database] = nil
+      @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(params)
+      @conn.should be_active
+    end
+
+    it "should create new connection using :url and tnsnames alias" do
+      params = CONNECTION_PARAMS.dup
+      params[:url] = "jdbc:oracle:thin:@#{DATABASE_NAME}"
+      params[:host] = nil
+      params[:database] = nil
+      @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(params)
+      @conn.should be_active
+    end
+
+    it "should create new connection using just tnsnames alias" do
+      params = CONNECTION_PARAMS.dup
+      params[:host] = nil
+      @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(params)
+      @conn.should be_active
+    end
+
+  end
+
+end
+
 describe "OracleEnhancedConnection SQL execution" do
 
   before(:all) do

data/spec/active_record/connection_adapters/oracle_enhanced_core_ext_spec.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe "OracleEnhancedAdapter to_d method" do
   it "BigDecimal#to_d returns the same decimal number" do

data/spec/active_record/connection_adapters/oracle_enhanced_cpk_spec.rb

@@ -1,4 +1,6 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+unless defined?(NO_COMPOSITE_PRIMARY_KEYS)
 
 describe "OracleEnhancedAdapter composite_primary_keys support" do
 
@@ -100,4 +102,6 @@ describe "OracleEnhancedAdapter composite_primary_keys support" do
   
   # Other testing was done based on composite_primary_keys tests
 
-end
+end
+
+end

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe "OracleEnhancedAdapter date type detection based on column names" do
   before(:all) do
@@ -83,11 +83,9 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
 
   describe "/ DATE values from ActiveRecord model" do
     before(:each) do
-      ActiveRecord::Base.connection.clear_types_for_columns
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = false
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates = false
       class ::TestEmployee < ActiveRecord::Base
-        set_table_name "hr.test_employees"
         set_primary_key :employee_id
       end
     end
@@ -107,6 +105,7 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
     after(:each) do
       # @employee.destroy if @employee
       Object.send(:remove_const, "TestEmployee")
+      ActiveRecord::Base.connection.clear_types_for_columns
     end
 
     it "should return Time value from DATE column if emulate_dates_by_column_name is false" do
@@ -151,6 +150,16 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
       @employee.hire_date.class.should == Date
     end
 
+    it "should see set_date_columns values in different connection" do
+      class ::TestEmployee < ActiveRecord::Base
+        set_date_columns :hire_date
+      end
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = false
+      # establish other connection
+      other_conn = ActiveRecord::Base.oracle_enhanced_connection(CONNECTION_PARAMS)
+      other_conn.get_type_for_column('test_employees', 'hire_date').should == :date
+    end
+
     it "should return Time value from DATE column if emulate_dates_by_column_name is true but column is defined as datetime" do
       class ::TestEmployee < ActiveRecord::Base
         set_datetime_columns :hire_date
@@ -837,6 +846,7 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
       :last_name => "Last"
     )
     @employee.should be_valid
+    TestEmployee.serialized_attributes.delete('comments')
   end
 
   it "should order by CLOB column" do
@@ -852,7 +862,14 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
     TestEmployee.find(:all, :order => :comments).should_not be_empty
     TestEmployee.find(:all, :order => "  first_name DESC,  last_name   ASC   ").should_not be_empty
   end
-  
+
+  it "should accept Symbol value for CLOB column" do
+    @employee = TestEmployee.create!(
+      :comments => :test_comment
+    )
+    @employee.should be_valid
+  end
+
 end
 
 describe "OracleEnhancedAdapter handling of BLOB columns" do

data/spec/active_record/connection_adapters/oracle_enhanced_dbms_output_spec.rb

@@ -0,0 +1,63 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe "OracleEnhancedAdapter logging dbms_output from plsql" do
+  include LoggerSpecHelper
+
+  before(:all) do
+    @buffer = StringIO.new
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    ActiveRecord::Base.connection.execute <<-SQL
+    CREATE or REPLACE
+    FUNCTION MORE_THAN_FIVE_CHARACTERS_LONG (some_text VARCHAR2) RETURN INTEGER
+    AS
+      longer_than_five INTEGER;
+    BEGIN
+      dbms_output.put_line('before the if -' || some_text || '-');
+      IF length(some_text) > 5 THEN
+        dbms_output.put_line('it is longer than 5');
+        longer_than_five := 1;
+      ELSE
+        dbms_output.put_line('it is 5 or shorter');
+        longer_than_five := 0;
+      END IF;
+      dbms_output.put_line('about to return: ' || longer_than_five);
+      RETURN longer_than_five;
+    END;
+    SQL
+  end
+
+  before(:each) do
+    @buffer = StringIO.new
+    log_to @buffer
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+  end
+
+  it "should NOT log dbms output when dbms output is disabled" do
+    @conn.disable_dbms_output
+
+    @conn.select_all("select more_than_five_characters_long('hi there') is_it_long from dual").should == [{'is_it_long'=>1}]
+    
+    @buffer.string.should_not match(/^DBMS_OUTPUT/)
+  end
+
+  it "should log dbms output lines to the rails log" do
+    @conn.enable_dbms_output
+
+    @conn.select_all("select more_than_five_characters_long('hi there') is_it_long from dual").should == [{'is_it_long'=>1}]
+    
+    @buffer.string.should match(/^DBMS_OUTPUT: before the if -hi there-$/)
+    @buffer.string.should match(/^DBMS_OUTPUT: it is longer than 5$/)
+    @buffer.string.should match(/^DBMS_OUTPUT: about to return: 1$/)
+  end
+
+  it "should log dbms output lines to the rails log" do
+    @conn.enable_dbms_output
+
+    @conn.select_all("select more_than_five_characters_long('short') is_it_long from dual").should == [{'is_it_long'=>0}]
+    
+    @buffer.string.should match(/^DBMS_OUTPUT: before the if -short-$/)
+    @buffer.string.should match(/^DBMS_OUTPUT: it is 5 or shorter$/)
+    @buffer.string.should match(/^DBMS_OUTPUT: about to return: 0$/)
+  end
+end

data/spec/active_record/connection_adapters/oracle_enhanced_dirty_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 if ActiveRecord::Base.instance_methods.include?('changed?')
 

data/spec/active_record/connection_adapters/oracle_enhanced_emulate_oracle_adapter_spec.rb

@@ -1,6 +1,4 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe "OracleEnhancedAdapter emulate OracleAdapter" do
 

data/spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe "OracleEnhancedAdapter custom methods for create, update and destroy" do
   include LoggerSpecHelper

data/spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb

@@ -0,0 +1,255 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe "OracleEnhancedAdapter original schema dump" do
+
+  before(:all) do
+    if !defined?(RUBY_ENGINE)
+      if ActiveRecord::Base.respond_to?(:oracle_connection)
+        @old_conn = ActiveRecord::Base.oracle_connection(CONNECTION_PARAMS)
+        @old_conn.class.should == ActiveRecord::ConnectionAdapters::OracleAdapter
+      end
+    elsif RUBY_ENGINE == 'jruby'
+      @old_conn = ActiveRecord::Base.jdbc_connection(JDBC_CONNECTION_PARAMS)
+      @old_conn.class.should == ActiveRecord::ConnectionAdapters::JdbcAdapter
+    end
+
+    @new_conn = ActiveRecord::Base.oracle_enhanced_connection(CONNECTION_PARAMS)
+    @new_conn.class.should == ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter
+  end
+
+  after(:all) do
+    # Workaround for undefining callback that was defined by JDBC adapter
+    if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby'
+      ActiveRecord::Base.class_eval do
+        def after_save_with_oracle_lob
+          nil
+        end
+      end
+    end
+  end
+
+  if !defined?(RUBY_ENGINE) && ActiveRecord::Base.respond_to?(:oracle_connection) || defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby'
+    it "should return the same tables list as original oracle adapter" do
+      @new_conn.tables.sort.should == @old_conn.tables.sort
+    end
+
+    it "should return the same index list as original oracle adapter" do
+      @new_conn.indexes('employees').sort_by(&:name).should == @old_conn.indexes('employees').sort_by(&:name)
+    end
+
+    it "should return the same pk_and_sequence_for as original oracle adapter" do
+      if @old_conn.respond_to?(:pk_and_sequence_for)
+        @new_conn.tables.each do |t|
+          @new_conn.pk_and_sequence_for(t).should == @old_conn.pk_and_sequence_for(t)
+        end
+      end
+    end
+
+    it "should return the same structure dump as original oracle adapter" do
+      @new_conn.structure_dump.split(";\n\n").sort.should == @old_conn.structure_dump.split(";\n\n").sort
+    end
+
+    it "should return the same structure drop as original oracle adapter" do
+      @new_conn.structure_drop.split(";\n\n").sort.should == @old_conn.structure_drop.split(";\n\n").sort
+    end
+  end
+
+end
+
+describe "OracleEnhancedAdapter schema dump" do
+  include SchemaSpecHelper
+
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+  end
+
+  def standard_dump
+    stream = StringIO.new
+    ActiveRecord::SchemaDumper.ignore_tables = []
+    ActiveRecord::SchemaDumper.dump(ActiveRecord::Base.connection, stream)
+    stream.string
+  end
+
+  def create_test_posts_table(options = {})
+    options.merge! :force => true
+    schema_define do
+      create_table :test_posts, options do |t|
+        t.string :title
+      end
+      add_index :test_posts, :title
+    end
+  end
+
+  def drop_test_posts_table
+    schema_define do
+      drop_table :test_posts
+    end
+  rescue
+    nil
+  end
+
+  describe "table prefixes and suffixes" do
+    after(:each) do
+      drop_test_posts_table
+      @conn.drop_table(ActiveRecord::Migrator.schema_migrations_table_name) if @conn.table_exists?(ActiveRecord::Migrator.schema_migrations_table_name)
+      ActiveRecord::Base.table_name_prefix = ''
+      ActiveRecord::Base.table_name_suffix = ''
+    end
+
+    it "should remove table prefix in schema dump" do
+      ActiveRecord::Base.table_name_prefix = 'xxx_'
+      create_test_posts_table
+      standard_dump.should =~ /create_table "test_posts".*add_index "test_posts"/m
+    end
+
+    it "should remove table suffix in schema dump" do
+      ActiveRecord::Base.table_name_suffix = '_xxx'
+      create_test_posts_table
+      standard_dump.should =~ /create_table "test_posts".*add_index "test_posts"/m
+    end
+
+    it "should not include schema_migrations table with prefix in schema dump" do
+      ActiveRecord::Base.table_name_prefix = 'xxx_'
+      @conn.initialize_schema_migrations_table
+      standard_dump.should_not =~ /schema_migrations/
+    end
+
+    it "should not include schema_migrations table with suffix in schema dump" do
+      ActiveRecord::Base.table_name_suffix = '_xxx'
+      @conn.initialize_schema_migrations_table
+      standard_dump.should_not =~ /schema_migrations/
+    end
+
+  end
+
+  describe "table with non-default primary key" do
+    after(:each) do
+      drop_test_posts_table
+    end
+
+    it "should include non-default primary key in schema dump" do
+      create_test_posts_table(:primary_key => 'post_id')
+      standard_dump.should =~ /create_table "test_posts", :primary_key => "post_id"/
+    end
+
+  end
+
+  describe "table with primary key trigger" do
+
+    after(:each) do
+      drop_test_posts_table
+    end
+
+    it "should include primary key trigger in schema dump" do
+      create_test_posts_table(:primary_key_trigger => true)
+      standard_dump.should =~ /create_table "test_posts".*add_primary_key_trigger "test_posts"/m
+    end
+
+    it "should include primary key trigger with non-default primary key in schema dump" do
+      create_test_posts_table(:primary_key_trigger => true, :primary_key => 'post_id')
+      standard_dump.should =~ /create_table "test_posts", :primary_key => "post_id".*add_primary_key_trigger "test_posts", :primary_key => "post_id"/m
+    end
+
+  end
+
+  describe "foreign key constraints" do
+    before(:all) do
+      schema_define do
+        create_table :test_posts, :force => true do |t|
+          t.string :title
+        end
+        create_table :test_comments, :force => true do |t|
+          t.string :body, :limit => 4000
+          t.references :test_post
+        end
+      end
+    end
+    
+    after(:each) do
+      schema_define do
+        remove_foreign_key :test_comments, :test_posts
+      end
+    end
+    after(:all) do
+      schema_define do
+        drop_table :test_comments rescue nil
+        drop_table :test_posts rescue nil
+      end
+    end
+
+    it "should include foreign key in schema dump" do
+      schema_define do
+        add_foreign_key :test_comments, :test_posts
+      end
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", :name => "test_comments_test_post_id_fk"/
+    end
+
+    it "should include foreign key with delete dependency in schema dump" do
+      schema_define do
+        add_foreign_key :test_comments, :test_posts, :dependent => :delete
+      end
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", :name => "test_comments_test_post_id_fk", :dependent => :delete/
+    end
+
+    it "should include foreign key with nullify dependency in schema dump" do
+      schema_define do
+        add_foreign_key :test_comments, :test_posts, :dependent => :nullify
+      end
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", :name => "test_comments_test_post_id_fk", :dependent => :nullify/
+    end
+
+  end
+
+  describe "synonyms" do
+    after(:each) do
+      schema_define do
+        remove_synonym :test_synonym
+      end
+    end
+
+    it "should include synonym to other schema table in schema dump" do
+      schema_define do
+        add_synonym :test_synonym, "schema_name.table_name", :force => true
+      end
+      standard_dump.should =~ /add_synonym "test_synonym", "schema_name.table_name", :force => true/
+    end
+
+    it "should include synonym to other database table in schema dump" do
+      schema_define do
+        add_synonym :test_synonym, "table_name@link_name", :force => true
+      end
+      standard_dump.should =~ /add_synonym "test_synonym", "table_name@link_name", :force => true/
+    end
+
+  end
+
+end
+
+describe "OracleEnhancedAdapter structure dump" do
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+  end
+
+  describe "database stucture dump extentions" do
+    before(:all) do
+      @conn.execute <<-SQL
+        CREATE TABLE nvarchartable (
+          unq_nvarchar  NVARCHAR2(255) DEFAULT NULL
+        )
+      SQL
+    end
+
+    after(:all) do
+      @conn.execute "DROP TABLE nvarchartable"
+    end
+
+    it "should return the character size of nvarchar fields" do
+      if /.*unq_nvarchar nvarchar2\((\d+)\).*/ =~ @conn.structure_dump
+         "#$1".should == "255"
+      end
+    end
+  end
+
+end