activerecord-oracle_enhanced-adapter 1.1.9 → 1.2.0

data/spec/active_record/connection_adapters/oracle_enhanced_connection_spec.rb

@@ -0,0 +1,170 @@
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
+
+describe "OracleEnhancedConnection create connection" do
+
+  before(:all) do
+    @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(CONNECTION_PARAMS)
+  end
+  
+  before(:each) do
+    @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(CONNECTION_PARAMS) unless @conn.active?
+  end
+
+  after(:all) do
+    @conn.logoff if @conn.active?
+  end
+
+  it "should create new connection" do
+    @conn.should be_active
+  end
+
+  it "should ping active connection" do
+    @conn.ping.should be_true
+  end
+
+  it "should not ping inactive connection" do
+    @conn.logoff
+    lambda { @conn.ping }.should raise_error(ActiveRecord::ConnectionAdapters::OracleEnhancedConnectionException)
+  end
+
+  it "should reset active connection" do
+    @conn.reset!
+    @conn.should be_active
+  end
+
+  it "should be in autocommit mode after connection" do
+    @conn.should be_autocommit
+  end
+
+end
+
+describe "OracleEnhancedConnection SQL execution" do
+
+  before(:all) do
+    @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(CONNECTION_PARAMS)
+  end
+  
+  before(:each) do
+    @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(CONNECTION_PARAMS) unless @conn.active?
+  end
+
+  after(:all) do
+    @conn.logoff if @conn.active?
+  end
+
+  it "should execute SQL statement" do
+    @conn.exec("SELECT * FROM dual").should_not be_nil
+  end
+
+  it "should execute SQL select" do
+    @conn.select("SELECT * FROM dual").should == [{'dummy' => 'X'}]
+  end
+
+  it "should execute SQL select and return also columns" do
+    @conn.select("SELECT * FROM dual", nil, true).should == [ [{'dummy' => 'X'}], ['dummy'] ]
+  end
+
+end
+
+describe "OracleEnhancedConnection auto reconnection" do
+
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection.instance_variable_get("@connection")
+    @sys_conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(SYS_CONNECTION_PARAMS)
+  end
+  
+  before(:each) do
+    ActiveRecord::Base.connection.reconnect! unless @conn.active?
+  end
+
+  after(:all) do
+    ActiveRecord::Base.connection.disconnect! if @conn.active?
+  end
+
+  def kill_current_session
+    audsid = @conn.select("SELECT userenv('sessionid') audsid FROM dual").first['audsid']
+    sid_serial = @sys_conn.select("SELECT s.sid||','||s.serial# sid_serial
+        FROM   v$session s
+        WHERE  audsid = '#{audsid}'").first['sid_serial']
+    @sys_conn.exec "ALTER SYSTEM KILL SESSION '#{sid_serial}' IMMEDIATE"
+  end
+
+  it "should reconnect and execute SQL statement if connection is lost and auto retry is enabled" do
+    # @conn.auto_retry = true
+    ActiveRecord::Base.connection.auto_retry = true
+    kill_current_session
+    @conn.exec("SELECT * FROM dual").should_not be_nil
+  end
+
+  it "should not reconnect and execute SQL statement if connection is lost and auto retry is disabled" do
+    # @conn.auto_retry = false
+    ActiveRecord::Base.connection.auto_retry = false
+    kill_current_session
+    lambda { @conn.exec("SELECT * FROM dual") }.should raise_error
+  end
+
+  it "should reconnect and execute SQL select if connection is lost and auto retry is enabled" do
+    # @conn.auto_retry = true
+    ActiveRecord::Base.connection.auto_retry = true
+    kill_current_session
+    @conn.select("SELECT * FROM dual").should == [{'dummy' => 'X'}]
+  end
+
+  it "should not reconnect and execute SQL select if connection is lost and auto retry is disabled" do
+    # @conn.auto_retry = false
+    ActiveRecord::Base.connection.auto_retry = false
+    kill_current_session
+    lambda { @conn.select("SELECT * FROM dual") }.should raise_error
+  end
+
+end
+
+describe "OracleEnhancedConnection describe table" do
+
+  before(:all) do
+    @conn = ActiveRecord::ConnectionAdapters::OracleEnhancedConnection.create(CONNECTION_PARAMS)
+    @owner = CONNECTION_PARAMS[:username].upcase
+  end
+  
+  after(:all) do
+    @conn.logoff if @conn.active?
+  end
+
+  it "should describe existing table" do
+    @conn.exec "CREATE TABLE test_employees (first_name VARCHAR2(20))" rescue nil
+    @conn.describe("test_employees").should == [@owner, "TEST_EMPLOYEES"]
+    @conn.exec "DROP TABLE test_employees" rescue nil
+  end
+
+  it "should not describe non-existing table" do
+    lambda { @conn.describe("test_xxx") }.should raise_error(ActiveRecord::ConnectionAdapters::OracleEnhancedConnectionException)
+  end
+
+  it "should describe table in other schema" do
+    @conn.describe("sys.dual").should == ["SYS", "DUAL"]
+  end
+
+  it "should describe existing view" do
+    @conn.exec "CREATE TABLE test_employees (first_name VARCHAR2(20))" rescue nil
+    @conn.exec "CREATE VIEW test_employees_v AS SELECT * FROM test_employees" rescue nil
+    @conn.describe("test_employees_v").should == [@owner, "TEST_EMPLOYEES_V"]
+    @conn.exec "DROP VIEW test_employees_v" rescue nil
+    @conn.exec "DROP TABLE test_employees" rescue nil
+  end
+
+  it "should describe view in other schema" do
+    @conn.describe("sys.v_$version").should == ["SYS", "V_$VERSION"]
+  end
+
+  it "should describe existing private synonym" do
+    @conn.exec "CREATE SYNONYM test_dual FOR sys.dual" rescue nil
+    @conn.describe("test_dual").should == ["SYS", "DUAL"]
+    @conn.exec "DROP SYNONYM test_dual" rescue nil
+  end
+
+  it "should describe existing public synonym" do
+    @conn.describe("all_tables").should == ["SYS", "ALL_TABLES"]
+  end
+
+end

data/spec/active_record/connection_adapters/oracle_enhanced_core_ext_spec.rb

@@ -0,0 +1,40 @@
+# encoding: utf-8
+
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
+
+describe "OracleEnhancedAdapter to_d method" do
+  it "BigDecimal#to_d returns the same decimal number" do
+    d = BigDecimal.new("12345678901234567890.0123456789")
+    d.to_d.should == d
+  end
+  
+  it "Bignum#to_d translates large integer to decimal" do
+    n = 12345678901234567890
+    n.to_d.should == BigDecimal.new(n.to_s)
+  end
+
+  it "Fixnum#to_d translates small integer to decimal" do
+    n = 123456
+    n.to_d.should == BigDecimal.new(n.to_s)
+  end
+end
+
+if ENV['RAILS_GEM_VERSION'] >= '2.3'
+
+  describe "OracleEnhancedAdapter Unicode aware upcase and downcase" do
+    before(:all) do
+      @down = "āčēģīķļņšūž"
+      @up = "ĀČĒĢĪĶĻŅŠŪŽ"
+    end
+
+    it "should translate Unicode string to upcase" do
+      @down.mb_chars.upcase.to_s.should == @up
+    end
+
+    it "should translate Unicode string to downcase" do
+      @up.mb_chars.downcase.to_s.should == @down
+    end
+  
+  end
+
+end

data/spec/active_record/connection_adapters/oracle_enhanced_cpk_spec.rb

@@ -3,12 +3,13 @@ require File.dirname(__FILE__) + '/../../spec_helper.rb'
 describe "OracleEnhancedAdapter composite_primary_keys support" do
 
   before(:all) do
-    require "composite_primary_keys"
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
-    class JobHistory < ActiveRecord::Base
+    if defined?(ActiveRecord::ConnectionAdapters::OracleAdapter)
+      @old_oracle_adapter = ActiveRecord::ConnectionAdapters::OracleAdapter
+      ActiveRecord::ConnectionAdapters.send(:remove_const, :OracleAdapter)
+    end
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    require 'composite_primary_keys'
+    class ::JobHistory < ActiveRecord::Base
       set_table_name "job_history"
       set_primary_keys :employee_id, :start_date
     end
@@ -17,6 +18,10 @@ describe "OracleEnhancedAdapter composite_primary_keys support" do
   after(:all) do
     Object.send(:remove_const, 'CompositePrimaryKeys') if defined?(CompositePrimaryKeys)
     Object.send(:remove_const, 'JobHistory') if defined?(JobHistory)
+    if @old_oracle_adapter
+      ActiveRecord::ConnectionAdapters.send(:remove_const, :OracleAdapter)
+      ActiveRecord::ConnectionAdapters::OracleAdapter = @old_oracle_adapter
+    end
   end
 
   it "should tell ActiveRecord that count distinct is not supported" do

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -2,10 +2,7 @@ require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
 describe "OracleEnhancedAdapter date type detection based on column names" do
   before(:all) do
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test_employees (
@@ -82,7 +79,7 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
       ActiveRecord::Base.connection.clear_types_for_columns
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = false
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates = false
-      class TestEmployee < ActiveRecord::Base
+      class ::TestEmployee < ActiveRecord::Base
         set_table_name "hr.test_employees"
         set_primary_key :employee_id
       end
@@ -124,7 +121,7 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
     end
 
     it "should return Date value from DATE column if emulate_dates_by_column_name is false but column is defined as date" do
-      class TestEmployee < ActiveRecord::Base
+      class ::TestEmployee < ActiveRecord::Base
         set_date_columns :hire_date
       end
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = false
@@ -133,7 +130,7 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
     end
 
     it "should return Time value from DATE column if emulate_dates_by_column_name is true but column is defined as datetime" do
-      class TestEmployee < ActiveRecord::Base
+      class ::TestEmployee < ActiveRecord::Base
         set_datetime_columns :hire_date
       end
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = true
@@ -160,10 +157,7 @@ end
 
 describe "OracleEnhancedAdapter integer type detection based on column names" do
   before(:all) do
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test2_employees (
@@ -231,7 +225,7 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
 
   describe "/ NUMBER values from ActiveRecord model" do
     before(:each) do
-      class Test2Employee < ActiveRecord::Base
+      class ::Test2Employee < ActiveRecord::Base
       end
     end
     
@@ -273,10 +267,7 @@ end
 
 describe "OracleEnhancedAdapter boolean type detection based on string column types and names" do
   before(:all) do
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test3_employees (
@@ -293,9 +284,9 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
         department_id NUMBER(4,0),
         created_at    DATE,
         has_email     CHAR(1),
-        has_phone     VARCHAR2(1),
+        has_phone     VARCHAR2(1) DEFAULT 'Y',
         active_flag   VARCHAR2(2),
-        manager_yn    VARCHAR2(3),
+        manager_yn    VARCHAR2(3) DEFAULT 'N',
         test_boolean  VARCHAR2(3)
       )
     SQL
@@ -367,11 +358,18 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
     ActiveRecord::Base.connection.type_to_sql(
       :boolean, nil, nil, nil).should == "NUMBER(1)"
   end
+
+  it "should get default value from VARCHAR2 boolean column if emulate_booleans_from_strings is true" do
+    ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
+    columns = @conn.columns('test3_employees')
+    columns.detect{|c| c.name == 'has_phone'}.default.should be_true
+    columns.detect{|c| c.name == 'manager_yn'}.default.should be_false
+  end
   
   describe "/ VARCHAR2 boolean values from ActiveRecord model" do
     before(:each) do
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
-      class Test3Employee < ActiveRecord::Base
+      class ::Test3Employee < ActiveRecord::Base
       end
     end
     
@@ -422,7 +420,7 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
 
     it "should return boolean value from VARCHAR2 boolean column if column specified in set_boolean_columns" do
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
-      class Test3Employee < ActiveRecord::Base
+      class ::Test3Employee < ActiveRecord::Base
         set_boolean_columns :test_boolean
       end
       create_employee3(:test_boolean => true)
@@ -431,6 +429,12 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
       create_employee3(:test_boolean => false)
       @employee3.test_boolean.class.should == FalseClass
       @employee3.test_boolean_before_type_cast.should == "N"
+      create_employee3(:test_boolean => nil)
+      @employee3.test_boolean.class.should == NilClass
+      @employee3.test_boolean_before_type_cast.should == nil
+      create_employee3(:test_boolean => "")
+      @employee3.test_boolean.class.should == NilClass
+      @employee3.test_boolean_before_type_cast.should == nil
     end
   
   end
@@ -439,10 +443,7 @@ end
 
 describe "OracleEnhancedAdapter timestamp with timezone support" do
   before(:all) do
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test_employees (
@@ -481,7 +482,7 @@ describe "OracleEnhancedAdapter timestamp with timezone support" do
 
   describe "/ TIMESTAMP WITH TIME ZONE values from ActiveRecord model" do
     before(:all) do
-      class TestEmployee < ActiveRecord::Base
+      class ::TestEmployee < ActiveRecord::Base
         set_primary_key :employee_id
       end
     end
@@ -505,18 +506,35 @@ describe "OracleEnhancedAdapter timestamp with timezone support" do
       end
     end
 
-    it "should return Time value without fractional seconds from TIMESTAMP columns" do
-      # currently fractional seconds are not retrieved from database
-      @now = Time.local(2008,5,26,23,11,11,10)
-      @employee = TestEmployee.create(
-        :created_at => @now,
-        :created_at_tz => @now,
-        :created_at_ltz => @now
-      )
-      @employee.reload
-      [:created_at, :created_at_tz, :created_at_ltz].each do |c|
-        @employee.send(c).class.should == Time
-        @employee.send(c).to_f.should == @now.to_f.to_i.to_f # remove fractional seconds
+    if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby'
+      it "should return Time value with fractional seconds from TIMESTAMP columns" do
+        # currently fractional seconds are not retrieved from database
+        @now = Time.local(2008,5,26,23,11,11,10)
+        @employee = TestEmployee.create(
+          :created_at => @now,
+          :created_at_tz => @now,
+          :created_at_ltz => @now
+        )
+        @employee.reload
+        [:created_at, :created_at_tz, :created_at_ltz].each do |c|
+          @employee.send(c).class.should == Time
+          @employee.send(c).to_f.should == @now.to_f
+        end
+      end
+    else
+      it "should return Time value without fractional seconds from TIMESTAMP columns" do
+        # currently fractional seconds are not retrieved from database
+        @now = Time.local(2008,5,26,23,11,11,10)
+        @employee = TestEmployee.create(
+          :created_at => @now,
+          :created_at_tz => @now,
+          :created_at_ltz => @now
+        )
+        @employee.reload
+        [:created_at, :created_at_tz, :created_at_ltz].each do |c|
+          @employee.send(c).class.should == Time
+          @employee.send(c).to_f.should == @now.to_f.to_i.to_f # remove fractional seconds
+        end
       end
     end
 
@@ -527,10 +545,7 @@ end
 
 describe "OracleEnhancedAdapter date and timestamp with different NLS date formats" do
   before(:all) do
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test_employees (
@@ -567,7 +582,7 @@ describe "OracleEnhancedAdapter date and timestamp with different NLS date forma
   before(:each) do
     ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates = false
     ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = false
-    class TestEmployee < ActiveRecord::Base
+    class ::TestEmployee < ActiveRecord::Base
       set_primary_key :employee_id
     end
     @today = Date.new(2008,6,28)
@@ -626,7 +641,7 @@ describe "OracleEnhancedAdapter date and timestamp with different NLS date forma
   end
 
   it "should quote Time values with TO_TIMESTAMP" do
-    @ts = Time.at(@now.to_f + 0.1)
+    @ts = @now + 0.1
     @conn.quote(@ts).should == "TO_TIMESTAMP('#{@ts.year}-#{"%02d" % @ts.month}-#{"%02d" % @ts.day} "+
                                 "#{"%02d" % @ts.hour}:#{"%02d" % @ts.min}:#{"%02d" % @ts.sec}.100000','YYYY-MM-DD HH24:MI:SS.FF6')"
   end
@@ -635,10 +650,7 @@ end
 
 describe "OracleEnhancedAdapter assign string to :date and :datetime columns" do
   before(:all) do
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test_employees (
@@ -654,7 +666,7 @@ describe "OracleEnhancedAdapter assign string to :date and :datetime columns" do
       CREATE SEQUENCE test_employees_seq  MINVALUE 1
         INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
     SQL
-    class TestEmployee < ActiveRecord::Base
+    class ::TestEmployee < ActiveRecord::Base
       set_primary_key :employee_id
     end
   end
@@ -768,10 +780,7 @@ end
 
 describe "OracleEnhancedAdapter handling of CLOB columns" do
   before(:all) do
-    ActiveRecord::Base.establish_connection(:adapter => "oracle_enhanced",
-                                            :database => "xe",
-                                            :username => "hr",
-                                            :password => "hr")
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
     @conn.execute <<-SQL
       CREATE TABLE test_employees (
@@ -785,7 +794,7 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
       CREATE SEQUENCE test_employees_seq  MINVALUE 1
         INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
     SQL
-    class TestEmployee < ActiveRecord::Base
+    class ::TestEmployee < ActiveRecord::Base
       set_primary_key :employee_id
     end
   end
@@ -824,3 +833,89 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
   
 end
 
+describe "OracleEnhancedAdapter handling of BLOB columns" do
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+    @conn.execute <<-SQL
+      CREATE TABLE test_employees (
+        employee_id   NUMBER(6,0),
+        first_name    VARCHAR2(20),
+        last_name     VARCHAR2(25),
+        binary_data   BLOB
+      )
+    SQL
+    @conn.execute <<-SQL
+      CREATE SEQUENCE test_employees_seq  MINVALUE 1
+        INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
+    SQL
+    @binary_data = "\0\1\2\3\4\5\6\7\8\9"*10000
+    @binary_data2 = "\1\2\3\4\5\6\7\8\9\0"*10000
+  end
+  
+  after(:all) do
+    @conn.execute "DROP TABLE test_employees"
+    @conn.execute "DROP SEQUENCE test_employees_seq"
+  end
+
+  before(:each) do
+    class ::TestEmployee < ActiveRecord::Base
+      set_primary_key :employee_id
+    end
+  end
+  
+  after(:each) do
+    Object.send(:remove_const, "TestEmployee")
+  end
+  
+  it "should create record with BLOB data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => @binary_data
+    )
+    @employee.reload
+    @employee.binary_data.should == @binary_data
+  end
+  
+  it "should update record with BLOB data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last"
+    )
+    @employee.reload
+    @employee.binary_data.should be_nil
+    @employee.binary_data = @binary_data
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should == @binary_data
+  end
+
+  it "should update record that has existing BLOB data with different BLOB data" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => @binary_data
+    )
+    @employee.reload
+    @employee.binary_data = @binary_data2
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should == @binary_data2
+  end
+
+  it "should update record that has existing BLOB data with nil" do
+    @employee = TestEmployee.create!(
+      :first_name => "First",
+      :last_name => "Last",
+      :binary_data => @binary_data
+    )
+    @employee.reload
+    @employee.binary_data = nil
+    @employee.save!
+    @employee.reload
+    @employee.binary_data.should be_nil
+  end
+  
+end
+