activerecord-nuodb-adapter 1.0.3 → 1.0.4

data/test/cases/migration/columns_test.rb

@@ -0,0 +1,279 @@
+require "cases/migration/helper"
+
+module ActiveRecord
+  class Migration
+    class ColumnsTest < ActiveRecord::TestCase
+      include ActiveRecord::Migration::TestHelper
+
+      self.use_transactional_fixtures = false
+
+      # FIXME: this is more of an integration test with AR::Base and the
+      # schema modifications.  Maybe we should move this?
+      def test_add_rename
+        add_column "test_models", "girlfriend", :string
+        TestModel.reset_column_information
+
+        TestModel.create :girlfriend => 'bobette'
+
+        rename_column "test_models", "girlfriend", "exgirlfriend"
+
+        TestModel.reset_column_information
+        bob = TestModel.first
+
+        assert_equal "bobette", bob.exgirlfriend
+      end
+
+      # FIXME: another integration test.  We should decouple this from the
+      # AR::Base implementation.
+      def test_rename_column_using_symbol_arguments
+        add_column :test_models, :first_name, :string
+
+        TestModel.create :first_name => 'foo'
+
+        rename_column :test_models, :first_name, :nick_name
+        TestModel.reset_column_information
+        assert TestModel.column_names.include?("nick_name")
+        assert_equal ['foo'], TestModel.all.map(&:nick_name)
+      end
+
+      # FIXME: another integration test.  We should decouple this from the
+      # AR::Base implementation.
+      def test_rename_column
+        add_column "test_models", "first_name", "string"
+
+        TestModel.create :first_name => 'foo'
+
+        rename_column "test_models", "first_name", "nick_name"
+        TestModel.reset_column_information
+        assert TestModel.column_names.include?("nick_name")
+        assert_equal ['foo'], TestModel.all.map(&:nick_name)
+      end
+
+      def test_rename_column_preserves_default_value_not_null
+        add_column 'test_models', 'salary', :integer, :default => 70000
+
+        default_before = connection.columns("test_models").find { |c| c.name == "salary" }.default
+        assert_equal 70000, default_before
+
+        rename_column "test_models", "salary", "annual_salary"
+
+        assert TestModel.column_names.include?("annual_salary")
+        default_after = connection.columns("test_models").find { |c| c.name == "annual_salary" }.default
+        assert_equal 70000, default_after
+      end
+
+      if current_adapter?(:MysqlAdapter, :Mysql2Adapter)
+        def test_mysql_rename_column_preserves_auto_increment
+          rename_column "test_models", "id", "id_test"
+          assert_equal "auto_increment", connection.columns("test_models").find { |c| c.name == "id_test" }.extra
+        end
+      end
+
+      def test_rename_nonexistent_column
+        exception = if current_adapter?(:PostgreSQLAdapter, :OracleAdapter)
+                      ActiveRecord::StatementInvalid
+                    else
+                      ActiveRecord::ActiveRecordError
+                    end
+        assert_raise(exception) do
+          rename_column "test_models", "nonexistent", "should_fail"
+        end
+      end
+
+      def test_rename_column_with_sql_reserved_word
+        add_column 'test_models', 'first_name', :string
+        rename_column "test_models", "first_name", "group"
+
+        assert TestModel.column_names.include?("group")
+      end
+
+      def test_rename_column_with_an_index
+        add_column "test_models", :hat_name, :string
+        add_index :test_models, :hat_name
+
+        assert_equal 1, connection.indexes('test_models').size
+        rename_column "test_models", "hat_name", "name"
+
+        assert_equal ['index_test_models_on_name'], connection.indexes('test_models').map(&:name)
+      end
+
+      def test_rename_column_with_multi_column_index
+        add_column "test_models", :hat_size, :integer
+        add_column "test_models", :hat_style, :string, limit: 100
+        add_index "test_models", ["hat_style", "hat_size"], unique: true
+
+        rename_column "test_models", "hat_size", 'size'
+        if current_adapter? :OracleAdapter
+          assert_equal ['i_test_models_hat_style_size'], connection.indexes('test_models').map(&:name)
+        else
+          assert_equal ['index_test_models_on_hat_style_and_size'], connection.indexes('test_models').map(&:name)
+        end
+
+        rename_column "test_models", "hat_style", 'style'
+        if current_adapter? :OracleAdapter
+          assert_equal ['i_test_models_style_size'], connection.indexes('test_models').map(&:name)
+        else
+          assert_equal ['index_test_models_on_style_and_size'], connection.indexes('test_models').map(&:name)
+        end
+      end
+
+      def test_rename_column_does_not_rename_custom_named_index
+        add_column "test_models", :hat_name, :string
+        add_index :test_models, :hat_name, :name => 'idx_hat_name'
+
+        assert_equal 1, connection.indexes('test_models').size
+        rename_column "test_models", "hat_name", "name"
+        assert_equal ['idx_hat_name'], connection.indexes('test_models').map(&:name)
+      end
+
+      def test_remove_column_with_index
+        add_column "test_models", :hat_name, :string
+        add_index :test_models, :hat_name
+
+        assert_equal 1, connection.indexes('test_models').size
+        remove_column("test_models", "hat_name")
+        assert_equal 0, connection.indexes('test_models').size
+      end
+
+      def test_remove_column_with_multi_column_index
+        add_column "test_models", :hat_size, :integer
+        add_column "test_models", :hat_style, :string, :limit => 100
+        add_index "test_models", ["hat_style", "hat_size"], :unique => true
+
+        assert_equal 1, connection.indexes('test_models').size
+        remove_column("test_models", "hat_size")
+
+        # Every database and/or database adapter has their own behavior
+        # if it drops the multi-column index when any of the indexed columns dropped by remove_column.
+        if current_adapter?(:PostgreSQLAdapter, :OracleAdapter)
+          assert_equal [], connection.indexes('test_models').map(&:name)
+        else
+          assert_equal ['index_test_models_on_hat_style_and_hat_size'], connection.indexes('test_models').map(&:name)
+        end
+      end
+
+      def test_change_type_of_not_null_column
+        change_column "test_models", "updated_at", :datetime, :null => false
+        change_column "test_models", "updated_at", :datetime, :null => false
+
+        TestModel.reset_column_information
+        assert_equal false, TestModel.columns_hash['updated_at'].null
+      ensure
+        change_column "test_models", "updated_at", :datetime, :null => true
+      end
+
+      def test_change_column_nullability
+        add_column "test_models", "funny", :boolean
+        assert TestModel.columns_hash["funny"].null, "Column 'funny' must initially allow nulls"
+
+        change_column "test_models", "funny", :boolean, :null => false, :default => true
+
+        TestModel.reset_column_information
+        assert_not TestModel.columns_hash["funny"].null, "Column 'funny' must *not* allow nulls at this point"
+
+        change_column "test_models", "funny", :boolean, :null => true
+        TestModel.reset_column_information
+        assert TestModel.columns_hash["funny"].null, "Column 'funny' must allow nulls again at this point"
+      end
+
+      def test_change_column
+        add_column 'test_models', 'age', :integer
+        add_column 'test_models', 'approved', :boolean, :default => true
+
+        old_columns = connection.columns(TestModel.table_name)
+
+        assert old_columns.find { |c| c.name == 'age' && c.type == :integer }
+
+        change_column "test_models", "age", :string
+
+        new_columns = connection.columns(TestModel.table_name)
+
+        assert_not new_columns.find { |c| c.name == 'age' and c.type == :integer }
+        assert new_columns.find { |c| c.name == 'age' and c.type == :string }
+
+        old_columns = connection.columns(TestModel.table_name)
+        assert old_columns.find { |c|
+          c.name == 'approved' && c.type == :boolean && c.default == true
+        }
+
+        change_column :test_models, :approved, :boolean, :default => false
+        new_columns = connection.columns(TestModel.table_name)
+
+        assert_not new_columns.find { |c| c.name == 'approved' and c.type == :boolean and c.default == true }
+        assert new_columns.find { |c| c.name == 'approved' and c.type == :boolean and c.default == false }
+        change_column :test_models, :approved, :boolean, :default => true
+      end
+
+      def test_change_column_with_nil_default
+        add_column "test_models", "contributor", :boolean, :default => true
+        assert TestModel.new.contributor?
+
+        change_column "test_models", "contributor", :boolean, :default => nil
+        TestModel.reset_column_information
+        assert_not TestModel.new.contributor?
+        assert_nil TestModel.new.contributor
+      end
+
+      def test_change_column_with_new_default
+        add_column "test_models", "administrator", :boolean, :default => true
+        assert TestModel.new.administrator?
+
+        change_column "test_models", "administrator", :boolean, :default => false
+        TestModel.reset_column_information
+        assert_not TestModel.new.administrator?
+      end
+
+      def test_change_column_with_custom_index_name
+        add_column "test_models", "category", :string
+        add_index :test_models, :category, name: 'test_models_categories_idx'
+
+        assert_equal ['test_models_categories_idx'], connection.indexes('test_models').map(&:name)
+        change_column "test_models", "category", :string, null: false, default: 'article'
+
+        assert_equal ['test_models_categories_idx'], connection.indexes('test_models').map(&:name)
+      end
+
+      def test_change_column_with_long_index_name
+        table_name_prefix = 'test_models_'
+        long_index_name = table_name_prefix + ('x' * (connection.allowed_index_name_length - table_name_prefix.length))
+        add_column "test_models", "category", :string
+        add_index :test_models, :category, name: long_index_name
+
+        change_column "test_models", "category", :string, null: false, default: 'article'
+
+        assert_equal [long_index_name], connection.indexes('test_models').map(&:name)
+      end
+
+      def test_change_column_default
+        add_column "test_models", "first_name", :string
+        connection.change_column_default "test_models", "first_name", "Tester"
+
+        assert_equal "Tester", TestModel.new.first_name
+      end
+
+      def test_change_column_default_to_null
+        add_column "test_models", "first_name", :string
+        connection.change_column_default "test_models", "first_name", nil
+        assert_nil TestModel.new.first_name
+      end
+
+      def test_remove_column_no_second_parameter_raises_exception
+        assert_raise(ArgumentError) { connection.remove_column("funny") }
+      end
+
+      def test_removing_and_renaming_column_preserves_custom_primary_key
+        connection.create_table "my_table", primary_key: "my_table_id", force: true do |t|
+          t.integer "col_one"
+          t.string "col_two", limit: 128, null: false
+        end
+
+        remove_column("my_table", "col_two")
+        rename_column("my_table", "col_one", "col_three")
+
+        assert_equal 'my_table_id', connection.primary_key('my_table')
+      ensure
+        connection.drop_table(:my_table) rescue nil
+      end
+    end
+  end
+end

data/test/cases/migration/command_recorder_test.rb

@@ -0,0 +1,247 @@
+require "cases/helper"
+
+module ActiveRecord
+  class Migration
+    class CommandRecorderTest < ActiveRecord::TestCase
+      def setup
+        @recorder = CommandRecorder.new
+      end
+
+      def test_respond_to_delegates
+        recorder = CommandRecorder.new(Class.new {
+          def america; end
+        }.new)
+        assert recorder.respond_to?(:america)
+      end
+
+      def test_send_calls_super
+        assert_raises(NoMethodError) do
+          @recorder.send(:non_existing_method, :horses)
+        end
+      end
+
+      def test_send_delegates_to_record
+        recorder = CommandRecorder.new(Class.new {
+          def create_table(name); end
+        }.new)
+        assert recorder.respond_to?(:create_table), 'respond_to? create_table'
+        recorder.send(:create_table, :horses)
+        assert_equal [[:create_table, [:horses], nil]], recorder.commands
+      end
+
+      def test_unknown_commands_delegate
+        recorder = CommandRecorder.new(stub(:foo => 'bar'))
+        assert_equal 'bar', recorder.foo
+      end
+
+      def test_inverse_of_raise_exception_on_unknown_commands
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.inverse_of :execute, ['some sql']
+        end
+      end
+
+      def test_irreversible_commands_raise_exception
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.revert{ @recorder.execute 'some sql' }
+        end
+      end
+
+      def test_record
+        @recorder.record :create_table, [:system_settings]
+        assert_equal 1, @recorder.commands.length
+      end
+
+      def test_inverted_commands_are_reversed
+        @recorder.revert do
+          @recorder.record :create_table, [:hello]
+          @recorder.record :create_table, [:world]
+        end
+        tables = @recorder.commands.map{|_cmd, args, _block| args}
+        assert_equal [[:world], [:hello]], tables
+      end
+
+      def test_revert_order
+        block = Proc.new{|t| t.string :name }
+        @recorder.instance_eval do
+          create_table("apples", &block)
+          revert do
+            create_table("bananas", &block)
+            revert do
+              create_table("clementines", &block)
+              create_table("dates")
+            end
+            create_table("elderberries")
+          end
+          revert do
+            create_table("figs", &block)
+            create_table("grapes")
+          end
+        end
+        assert_equal [[:create_table, ["apples"], block], [:drop_table, ["elderberries"], nil],
+                      [:create_table, ["clementines"], block], [:create_table, ["dates"], nil],
+                      [:drop_table, ["bananas"], block], [:drop_table, ["grapes"], nil],
+                      [:drop_table, ["figs"], block]], @recorder.commands
+      end
+
+      def test_invert_change_table
+        @recorder.revert do
+          @recorder.change_table :fruits do |t|
+            t.string :name
+            t.rename :kind, :cultivar
+          end
+        end
+        assert_equal [
+          [:rename_column, [:fruits, :cultivar, :kind]],
+          [:remove_column, [:fruits, :name, :string, {}], nil],
+        ], @recorder.commands
+
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.revert do
+            @recorder.change_table :fruits do |t|
+              t.remove :kind
+            end
+          end
+        end
+      end
+
+      def test_invert_create_table
+        @recorder.revert do
+          @recorder.record :create_table, [:system_settings]
+        end
+        drop_table = @recorder.commands.first
+        assert_equal [:drop_table, [:system_settings], nil], drop_table
+      end
+
+      def test_invert_create_table_with_options_and_block
+        block = Proc.new{}
+        drop_table = @recorder.inverse_of :create_table, [:people_reminders, id: false], &block
+        assert_equal [:drop_table, [:people_reminders, id: false], block], drop_table
+      end
+
+      def test_invert_drop_table
+        block = Proc.new{}
+        create_table = @recorder.inverse_of :drop_table, [:people_reminders, id: false], &block
+        assert_equal [:create_table, [:people_reminders, id: false], block], create_table
+      end
+
+      def test_invert_drop_table_without_a_block_nor_option
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.inverse_of :drop_table, [:people_reminders]
+        end
+      end
+
+      def test_invert_create_join_table
+        drop_join_table = @recorder.inverse_of :create_join_table, [:musics, :artists]
+        assert_equal [:drop_join_table, [:musics, :artists], nil], drop_join_table
+      end
+
+      def test_invert_create_join_table_with_table_name
+        drop_join_table = @recorder.inverse_of :create_join_table, [:musics, :artists, table_name: :catalog]
+        assert_equal [:drop_join_table, [:musics, :artists, table_name: :catalog], nil], drop_join_table
+      end
+
+      def test_invert_drop_join_table
+        block = Proc.new{}
+        create_join_table = @recorder.inverse_of :drop_join_table, [:musics, :artists, table_name: :catalog], &block
+        assert_equal [:create_join_table, [:musics, :artists, table_name: :catalog], block], create_join_table
+      end
+
+      def test_invert_rename_table
+        rename = @recorder.inverse_of :rename_table, [:old, :new]
+        assert_equal [:rename_table, [:new, :old]], rename
+      end
+
+      def test_invert_add_column
+        remove = @recorder.inverse_of :add_column, [:table, :column, :type, {}]
+        assert_equal [:remove_column, [:table, :column, :type, {}], nil], remove
+      end
+
+      def test_invert_remove_column
+        add = @recorder.inverse_of :remove_column, [:table, :column, :type, {}]
+        assert_equal [:add_column, [:table, :column, :type, {}], nil], add
+      end
+
+      def test_invert_remove_column_without_type
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.inverse_of :remove_column, [:table, :column]
+        end
+      end
+
+      def test_invert_rename_column
+        rename = @recorder.inverse_of :rename_column, [:table, :old, :new]
+        assert_equal [:rename_column, [:table, :new, :old]], rename
+      end
+
+      def test_invert_add_index
+        remove = @recorder.inverse_of :add_index, [:table, [:one, :two], options: true]
+        assert_equal [:remove_index, [:table, {column: [:one, :two], options: true}]], remove
+      end
+
+      def test_invert_add_index_with_name
+        remove = @recorder.inverse_of :add_index, [:table, [:one, :two], name: "new_index"]
+        assert_equal [:remove_index, [:table, {column: [:one, :two], name: "new_index"}]], remove
+      end
+
+      def test_invert_add_index_with_no_options
+        remove = @recorder.inverse_of :add_index, [:table, [:one, :two]]
+        assert_equal [:remove_index, [:table, {column: [:one, :two]}]], remove
+      end
+
+      def test_invert_remove_index
+        add = @recorder.inverse_of :remove_index, [:table, {column: [:one, :two], options: true}]
+        assert_equal [:add_index, [:table, [:one, :two], options: true]], add
+      end
+
+      def test_invert_remove_index_with_name
+        add = @recorder.inverse_of :remove_index, [:table, {column: [:one, :two], name: "new_index"}]
+        assert_equal [:add_index, [:table, [:one, :two], name: "new_index"]], add
+      end
+
+      def test_invert_remove_index_with_no_special_options
+        add = @recorder.inverse_of :remove_index, [:table, {column: [:one, :two]}]
+        assert_equal [:add_index, [:table, [:one, :two], {}]], add
+      end
+
+      def test_invert_remove_index_with_no_column
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.inverse_of :remove_index, [:table, name: "new_index"]
+        end
+      end
+
+      def test_invert_rename_index
+        rename = @recorder.inverse_of :rename_index, [:table, :old, :new]
+        assert_equal [:rename_index, [:table, :new, :old]], rename
+      end
+
+      def test_invert_add_timestamps
+        remove = @recorder.inverse_of :add_timestamps, [:table]
+        assert_equal [:remove_timestamps, [:table], nil], remove
+      end
+
+      def test_invert_remove_timestamps
+        add = @recorder.inverse_of :remove_timestamps, [:table]
+        assert_equal [:add_timestamps, [:table], nil], add
+      end
+
+      def test_invert_add_reference
+        remove = @recorder.inverse_of :add_reference, [:table, :taggable, { polymorphic: true }]
+        assert_equal [:remove_reference, [:table, :taggable, { polymorphic: true }], nil], remove
+      end
+
+      def test_invert_add_belongs_to_alias
+        remove = @recorder.inverse_of :add_belongs_to, [:table, :user]
+        assert_equal [:remove_reference, [:table, :user], nil], remove
+      end
+
+      def test_invert_remove_reference
+        add = @recorder.inverse_of :remove_reference, [:table, :taggable, { polymorphic: true }]
+        assert_equal [:add_reference, [:table, :taggable, { polymorphic: true }], nil], add
+      end
+
+      def test_invert_remove_belongs_to_alias
+        add = @recorder.inverse_of :remove_belongs_to, [:table, :user]
+        assert_equal [:add_reference, [:table, :user], nil], add
+      end
+    end
+  end
+end