activerecord-nulldb-adapter 0.7.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9b442065de1ab8b6f9a1b9a4c887b4446a50ac777c8a3800f07dc7bd7806d95
-  data.tar.gz: 0ccc56568e9610f033361f6229e096966d242edec12e30cfe674bba268da7dc8
+  metadata.gz: 0da8a5f679279b76c36a80995783db057cf0bbc680d4006209619d068c55fbf3
+  data.tar.gz: eb7c91fe3bd86f1d8787cd2dc394aeecc1b8c0950e7133fb4a21f74f6e596a8d
 SHA512:
-  metadata.gz: daa0faddba9520e94ee32f169054623ca1276c2a137e8ee9f329f8c1e3a1ad60f7f08cf3febb1b3a96b71bc5955d7d89c11944f15dc77a9b2ddc555a25d7200e
-  data.tar.gz: 3c58d754ec1aeb41c0296e5d1b9d298581588dd40a67701e1eabd12e9c7b1d589bec39774afbf098fadaa19a02f04c902826f80bdaea42d47d6054e90ff6a29d
+  metadata.gz: 87e4cb3496818735480c034bb2444bec7cdd60eb6032332d78875d3f1cd8bb769f256d70d8a80b254cc11d9c91564b76f32fe8f863d65dba5d13427a4d6f74d1
+  data.tar.gz: ae332ef581de6f46f46940d2f4c6a0011606abbe2432e258a88b7ab9b5c0be50af03a9b140b630c4e79228c3ed65d4569ae50f9e828ad37d3b64dc031de9bcbf

data/.github/workflows/ruby.yml

@@ -10,18 +10,31 @@ jobs:
             activerecord_5.2,
             activerecord_6.0,
             activerecord_6.1,
+            activerecord_7.0,
             activerecord_master,
           ]
-        ruby: ["2.5", "2.6", "2.7", "3.0", "jruby-9.2.13.0"]
+        ruby: ["2.5", "2.6", "2.7", "3.0", "jruby-9.3.1.0"]
         exclude:
           - ruby: "3.0"
             gemfile: activerecord_5.2
 
-          - ruby: "jruby-9.2.13.0"
-            gemfile: activerecord_6.1
+          - ruby: "2.5"
+            gemfile: "activerecord_master"
 
-          - ruby: "jruby-9.2.13.0"
-            gemfile: activerecord_master
+          - ruby: "2.6"
+            gemfile: "activerecord_master"
+
+          - ruby: "2.5"
+            gemfile: "activerecord_7.0"
+
+          - ruby: "2.6"
+            gemfile: "activerecord_7.0"
+
+          - ruby: "jruby-9.3.1.0"
+            gemfile: "activerecord_7.0"
+
+          - ruby: "jruby-9.3.1.0"
+            gemfile: "activerecord_master"
 
     runs-on: ubuntu-latest
     env:

data/Appraisals

@@ -6,6 +6,10 @@ appraise "activerecord-6.0" do
   gem "activerecord", "~> 6.0.0"
 end
 
+appraise "activerecord-7.0" do
+  gem "activerecord", "~> 7.0.0"
+end
+
 appraise "activerecord-master" do
-  gem "activerecord", github: 'rails/rails'
+  gem "activerecord", github: 'rails/rails', branch: :main
 end

data/CHANGES.md

@@ -1,6 +1,19 @@
 Unreleased
 ----------
 
+0.9.0 (2023-03-10)
+-----------
+
+- Add support to BigSerial #119
+- Add support to hstore #118
+- Support Postgres type modifiers #117
+
+
+0.8.0 (2022-10-28)
+-----------
+
+- Add support for Rails 7. #111 #112
+
 0.7.0 (2021-01-18)
 -----------
 

data/Gemfile

@@ -7,7 +7,6 @@ group :development, :test do
   gem 'rspec', '>= 1.2.9'
   gem 'rake'
   gem 'rdoc'
-  gem 'pry-byebug'
 end
 
 group :development do

data/README.md

@@ -0,0 +1,157 @@
+[<img src="https://badge.fury.io/rb/activerecord-nulldb-adapter.png" alt="Gem
+Version" />](http://badge.fury.io/rb/activerecord-nulldb-adapter) [<img
+src="https://codeclimate.com/github/nulldb/nulldb.png"
+/>](https://codeclimate.com/github/nulldb/nulldb) [<img
+src="https://github.com/nulldb/nulldb/workflows/build/badge.svg?branch=master"
+alt="Build Status" />](https://github.com/nulldb/nulldb/actions)
+
+# The NullDB Connection Adapter Plugin
+
+## What
+
+NullDB is the Null Object pattern as applied to ActiveRecord database
+adapters.  It is a database backend that translates database interactions into
+no-ops.  Using NullDB enables you to test your model business logic -
+including `after_save` hooks - without ever touching a real database.
+
+## Compatibility
+
+### Ruby
+Currently supported Ruby versions: MRI 2.5.x, 2.6.x, 2.7.x, 3.X.
+
+Experimental support provided for: JRuby
+
+### ActiveRecord
+Any version of ActiveRecord >= 5.2
+
+It is tested against AR 5.2, 6.0, 6.1 and master branch.
+
+## Installation
+
+    gem install activerecord-nulldb-adapter
+
+## How
+
+Once installed, NullDB can be used much like any other ActiveRecord database
+adapter:
+
+    ActiveRecord::Base.establish_connection :adapter => :nulldb
+
+NullDB needs to know where you keep your schema file in order to reflect table
+metadata.  By default it looks in RAILS_ROOT/db/schema.rb.  You can override
+that by setting the `schema` option:
+
+    ActiveRecord::Base.establish_connection :adapter => :nulldb,
+                                            :schema  => 'foo/myschema.rb'
+
+NullDB comes with RSpec integration.  To replace the database with NullDB in
+all of your specs, put the following in your spec/rails_helper:
+
+    require 'nulldb_rspec'
+    include NullDB::RSpec::NullifiedDatabase
+
+after you load your rails environment
+
+    require File.expand_path('../config/environment', __dir__)
+
+otherwise you will encounter issues such as
+([bug)](https://github.com/nulldb/nulldb/pull/90#issuecomment-496690958).
+
+Or if you just want to use NullDB in a specific spec context, you can include
+the same module inside a context:
+
+    require 'nulldb_rspec'
+
+    describe Employee, "with access to the database" do
+      fixtures :employees
+      # ...
+    end
+
+    describe Employee, "with NullDB" do
+      include NullDB::RSpec::NullifiedDatabase
+      # ...
+    end
+
+If you want to have NullDB enabled by default but disabled for particular
+contexts then (see this
+[post)](https://web.archive.org/web/20120419204019/http://andywaite.com/2011/5
+/18/rspec-disable-nulldb)
+
+NullDB::Rspec provides some custom matcher support for verifying expectations
+about interactions with the database:
+
+    describe Employee do
+      include NullDB::RSpec::NullifiedDatabase
+
+      it "should cause an insert statement to be executed" do
+        Employee.create!
+        Employee.connection.should have_executed(:insert)
+      end
+    end
+
+UnitRecord-style verification that no database calls have been made at all can
+be achieved by using the special `:anything` symbol:
+
+    describe "stuff that shouldn't touch the database" do
+      after :each do
+        Employee.connection.should_not have_executed(:anything)
+      end
+      # ...
+    end
+
+You can also experiment with putting NullDB in your database.yml:
+
+    unit_test:
+      adapter: nulldb
+
+However, due to the way Rails hard-codes specific database adapters into its
+standard Rake tasks, you may find that this generates unexpected and
+difficult-to-debug behavior.  Workarounds for this are under development.
+
+## Why
+
+There are a number of advantages to writing unit tests that never touch the
+database.  The biggest is probably speed of execution - unit tests must be
+fast for test-driven development to be practical. Another is separation of
+concerns: unit tests should be exercising only the business logic contained in
+your models, not ActiveRecord. For more on why testing-sans-database is a good
+idea, see:
+http://www.dcmanges.com/blog/rails-unit-record-test-without-the-database.
+
+NullDB is one way to separate your unit tests from the database.  It was
+inspired by the [ARBS](http://arbs.rubyforge.org/) and
+[UnitRecord](http://unit-test-ar.rubyforge.org/) libraries.  It differs from
+them in that rather than modifying parts of ActiveRecord, it implements the
+same [semi-]well-documented public interface that the other standard database
+adapters, like MySQL and SQLServer, implement. This has enabled it to evolve
+to support new ActiveRecord versions relatively easily.
+
+One concrete advantage of this null-object pattern design is that it is
+possible with NullDB to test `after_save` hooks.  With NullDB, you can call
+`#save` and all of the usual callbacks will be called - but nothing will be
+saved.
+
+## Limitations
+
+*   It is **not** an in-memory database.  Finds will not work.  Neither will
+    `reload`, currently.  Test fixtures won't work either, for obvious
+    reasons.
+*   It has only the most rudimentery schema/migration support.  Complex
+    migrations will probably break it.
+*   Lots of other things probably don't work.  Patches welcome!
+
+
+## Who
+
+NullDB was originally written by Avdi Grimm <mailto:avdi@avdi.org>. It is
+currently maintained by [Danilo Cabello](https://github.com/cabello).
+Previously maintained by: [Bram de Vries](https://github.com/blaet).
+
+## Where
+
+*   Homepage: https://github.com/nulldb/nulldb
+
+
+## License
+
+See the LICENSE file for licensing information.

data/Rakefile

@@ -9,6 +9,6 @@ task :default => :spec
 
 require 'rdoc/task'
 Rake::RDocTask.new do |rd|
-  rd.main = "README.rdoc"
-  rd.rdoc_files.include("README.rdoc", "LICENSE", "lib/**/*.rb")
+  rd.main = "README.md"
+  rd.rdoc_files.include("README.md", "LICENSE", "lib/**/*.rb")
 end

data/activerecord-nulldb-adapter.gemspec

@@ -14,13 +14,13 @@ Gem::Specification.new do |s|
   s.email = "cabello@users.noreply.github.com"
   s.extra_rdoc_files = [
     "LICENSE",
-    "README.rdoc"
+    "README.md"
   ]
   s.files    = `git ls-files`.split($/)
   s.homepage = "https://github.com/nulldb/nulldb"
   s.licenses = ["MIT"]
 
-  s.add_runtime_dependency 'activerecord', '>= 5.2.0', '< 6.3'
+  s.add_runtime_dependency 'activerecord', '>= 5.2.0', '< 7.1'
   s.add_development_dependency 'spec'
   s.add_development_dependency 'rdoc'
   s.add_development_dependency 'rspec'

data/gemfiles/activerecord_7.0.gemfile

@@ -0,0 +1,17 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 7.0.0"
+
+group :development, :test do
+  gem "spec"
+  gem "rspec", ">= 1.2.9"
+  gem "rake"
+  gem "rdoc"
+end
+
+group :development do
+  gem "appraisal"
+  gem "simplecov", require: false
+end

data/gemfiles/activerecord_master.gemfile

@@ -2,7 +2,7 @@
 
 source "https://rubygems.org"
 
-gem "activerecord", github: "rails/rails"
+gem "activerecord", github: "rails/rails", branch: :main
 
 group :development, :test do
   gem "spec"

data/lib/active_record/connection_adapters/nulldb_adapter/core.rb

@@ -98,7 +98,7 @@ class ActiveRecord::ConnectionAdapters::NullDBAdapter < ActiveRecord::Connection
   end
 
   # Rails 6.1+
-  if ActiveRecord::VERSION::MAJOR >= 6 and ActiveRecord::VERSION::MINOR > 0
+  if ActiveRecord::VERSION::MAJOR >= 7 || (ActiveRecord::VERSION::MAJOR >= 6 and ActiveRecord::VERSION::MINOR > 0)
     def remove_index(table_name, column_name = nil, **options )
       index_name = index_name_for_remove(table_name, column_name, options)
       index = @indexes[table_name].reject! { |index| index.name == index_name }
@@ -264,7 +264,7 @@ class ActiveRecord::ConnectionAdapters::NullDBAdapter < ActiveRecord::Connection
 
   protected
 
-  def select(statement, name = nil, binds = [])
+  def select(statement, name = nil, binds = [], prepare: nil, async: nil)
     EmptyResult.new.tap do |r|
       r.bind_column_meta(columns_for(name))
       self.execution_log << Statement.new(entry_point, statement)
@@ -313,7 +313,7 @@ class ActiveRecord::ConnectionAdapters::NullDBAdapter < ActiveRecord::Connection
 
   def new_table_definition(adapter = nil, table_name = nil, is_temporary = nil, options = {})
     case ::ActiveRecord::VERSION::MAJOR
-    when 6
+    when 6, 7
       TableDefinition.new(self, table_name, temporary: is_temporary, options: options.except(:id))
     when 5
       TableDefinition.new(table_name, is_temporary, options.except(:id), nil)
@@ -343,13 +343,37 @@ class ActiveRecord::ConnectionAdapters::NullDBAdapter < ActiveRecord::Connection
     [nil, @logger, @config]
   end
 
+  # Register types only once to avoid ActiveRecord::TypeConflictError
+  # in ActiveRecord::Type::Registration#<=>
+  REGISTRATION_MUTEX = Mutex.new
+
   def register_types
-    require 'active_model/type'
+    REGISTRATION_MUTEX.synchronize do
+      return if self.class.types_registered
+
+      self.class.types_registered = true
+    end
+
     ActiveRecord::Type.register(
       :primary_key,
       ActiveModel::Type::Integer,
       adapter: adapter_name,
       override: true
     )
+
+    ActiveRecord::Type.add_modifier({ array: true }, DummyOID, adapter: :nulldb)
+    ActiveRecord::Type.add_modifier({ range: true }, DummyOID, adapter: :nulldb)
+  end
+
+  class << self
+    attr_accessor :types_registered
+  end
+
+  class DummyOID < ActiveModel::Type::Value
+    attr_reader :subtype
+
+    def initialize(*args)
+      @subtype = args.first
+    end
   end
 end

data/lib/active_record/connection_adapters/nulldb_adapter/table_definition.rb

@@ -6,6 +6,10 @@ class ActiveRecord::ConnectionAdapters::NullDBAdapter
     alias_method :citext, :text
     alias_method :interval, :text
     alias_method :geometry, :text
+    alias_method :serial, :integer
+    alias_method :bigserial, :integer
+    alias_method :inet, :string
     alias_method :jsonb, :json if method_defined? :json
+    alias_method :hstore, :json
   end
 end

data/lib/nulldb/version.rb

@@ -1,3 +1,3 @@
 module NullDB
-  VERSION = "0.7.0"
+  VERSION = "0.9.0"
 end

data/spec/nulldb_spec.rb

@@ -490,6 +490,7 @@ describe 'adapter-specific extensions' do
           t.interval :time_interval
           t.geometry :feature_geometry, srid: 4326, type: "multi_polygon"
           t.jsonb :jsonb_column
+          t.hstore :hstore_column
         end
       end
     }.to_not raise_error
@@ -503,6 +504,20 @@ describe 'adapter-specific extensions' do
     should_have_column(ExtendedModel, :jsonb_column, :json)
   end
 
+  it 'supports ActiveModel attributes with postgres modifiers' do
+    class ExtendedModel < ActiveRecord::Base
+      attribute :strings, :string, array: true
+      attribute :size, :integer, range: true
+    end
+
+    expect(ExtendedModel.type_for_attribute(:strings))
+      .to be_a ActiveRecord::ConnectionAdapters::NullDBAdapter::DummyOID
+    expect(ExtendedModel.new(strings: %w[a b]).strings).to eq %w[a b]
+    expect(ExtendedModel.type_for_attribute(:size))
+      .to be_a ActiveRecord::ConnectionAdapters::NullDBAdapter::DummyOID
+    expect(ExtendedModel.new(size: 1..5).size).to eq 1..5
+  end
+
   it 'registers a primary_key type' do
     expect(ActiveRecord::Type.lookup(:primary_key, adapter: 'NullDB'))
       .to be_a(ActiveModel::Type::Integer)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-nulldb-adapter
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Avdi Grimm
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-18 00:00:00.000000000 Z
+date: 2023-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -21,7 +21,7 @@ dependencies:
         version: 5.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.3'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -31,7 +31,7 @@ dependencies:
         version: 5.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.3'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: spec
   requirement: !ruby/object:Gem::Requirement
@@ -138,7 +138,7 @@ executables: []
 extensions: []
 extra_rdoc_files:
 - LICENSE
-- README.rdoc
+- README.md
 files:
 - ".github/workflows/ruby.yml"
 - ".gitignore"
@@ -146,12 +146,13 @@ files:
 - CHANGES.md
 - Gemfile
 - LICENSE
-- README.rdoc
+- README.md
 - Rakefile
 - activerecord-nulldb-adapter.gemspec
 - gemfiles/activerecord_5.2.gemfile
 - gemfiles/activerecord_6.0.gemfile
 - gemfiles/activerecord_6.1.gemfile
+- gemfiles/activerecord_7.0.gemfile
 - gemfiles/activerecord_master.gemfile
 - lib/active_record/connection_adapters/nulldb_adapter.rb
 - lib/active_record/connection_adapters/nulldb_adapter/checkpoint.rb
@@ -194,7 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: The Null Object pattern as applied to ActiveRecord database adapters

data/README.rdoc

@@ -1,154 +0,0 @@
-{<img src="https://badge.fury.io/rb/activerecord-nulldb-adapter.png" alt="Gem Version" />}[http://badge.fury.io/rb/activerecord-nulldb-adapter]
-{<img src="https://codeclimate.com/github/nulldb/nulldb.png" />}[https://codeclimate.com/github/nulldb/nulldb]
-{<img src="https://github.com/nulldb/nulldb/workflows/build/badge.svg?branch=master" alt="Build Status" />}[https://github.com/nulldb/nulldb/actions]
-
-
-= The NullDB Connection Adapter Plugin
-
-== What
-
-NullDB is the Null Object pattern as applied to ActiveRecord database
-adapters.  It is a database backend that translates database
-interactions into no-ops.  Using NullDB enables you to test your model
-business logic - including +after_save+ hooks - without ever touching
-a real database.
-
-== Compatibility
-
-=== Ruby
-Currently supported Ruby versions: MRI 2.5.x, 2.6.x, 2.7.x, 3.X.
-
-Experimental support provided for: JRuby
-
-=== ActiveRecord
-Any version of ActiveRecord >= 5.2
-
-It is tested against AR 5.2, 6.0, 6.1 and master branch.
-
-== Installation
-
-  gem install activerecord-nulldb-adapter
-
-== How
-
-Once installed, NullDB can be used much like any other ActiveRecord
-database adapter:
-
-  ActiveRecord::Base.establish_connection :adapter => :nulldb
-
-NullDB needs to know where you keep your schema file in order to
-reflect table metadata.  By default it looks in
-RAILS_ROOT/db/schema.rb.  You can override that by setting the
-+schema+ option:
-
-  ActiveRecord::Base.establish_connection :adapter => :nulldb,
-                                          :schema  => 'foo/myschema.rb'
-
-NullDB comes with RSpec integration.  To replace the database with
-NullDB in all of your specs, put the following in your
-spec/rails_helper:
-
-  require 'nulldb_rspec'
-  include NullDB::RSpec::NullifiedDatabase
-
-after you load your rails environment
-
-  require File.expand_path('../config/environment', __dir__)
-
-otherwise you will encounter issues such as (bug)[https://github.com/nulldb/nulldb/pull/90#issuecomment-496690958].
-
-Or if you just want to use NullDB in a specific spec context, you can
-include the same module inside a context:
-
-  require 'nulldb_rspec'
-
-  describe Employee, "with access to the database" do
-    fixtures :employees
-    # ...
-  end
-
-  describe Employee, "with NullDB" do
-    include NullDB::RSpec::NullifiedDatabase
-    # ...
-  end
-
-If you want to have NullDB enabled by default but disabled for particular contexts then (see this post)[https://web.archive.org/web/20120419204019/http://andywaite.com/2011/5/18/rspec-disable-nulldb]
-
-NullDB::Rspec provides some custom matcher support for verifying
-expectations about interactions with the database:
-
-  describe Employee do
-    include NullDB::RSpec::NullifiedDatabase
-
-    it "should cause an insert statement to be executed" do
-      Employee.create!
-      Employee.connection.should have_executed(:insert)
-    end
-  end
-
-UnitRecord-style verification that no database calls have been made at
-all can be achieved by using the special +:anything+ symbol:
-
-  describe "stuff that shouldn't touch the database" do
-    after :each do
-      Employee.connection.should_not have_executed(:anything)
-    end
-    # ...
-  end
-
-You can also experiment with putting NullDB in your database.yml:
-
-  unit_test:
-    adapter: nulldb
-
-However, due to the way Rails hard-codes specific database adapters
-into its standard Rake tasks, you may find that this generates
-unexpected and difficult-to-debug behavior.  Workarounds for this are
-under development.
-
-== Why
-
-There are a number of advantages to writing unit tests that never
-touch the database.  The biggest is probably speed of execution - unit
-tests must be fast for test-driven development to be practical.
-Another is separation of concerns: unit tests should be exercising
-only the business logic contained in your models, not ActiveRecord.
-For more on why testing-sans-database is a good idea, see:
-http://www.dcmanges.com/blog/rails-unit-record-test-without-the-database.
-
-NullDB is one way to separate your unit tests from the database.  It
-was inspired by the ARBS[http://arbs.rubyforge.org/] and
-UnitRecord[http://unit-test-ar.rubyforge.org/] libraries.  It differs
-from them in that rather than modifying parts of ActiveRecord, it
-implements the same [semi-]well-documented public interface that the
-other standard database adapters, like MySQL and SQLServer,
-implement. This has enabled it to evolve to support new ActiveRecord
-versions relatively easily.
-
-One concrete advantage of this null-object pattern design is that it
-is possible with NullDB to test +after_save+ hooks.  With NullDB, you
-can call +#save+ and all of the usual callbacks will be called - but
-nothing will be saved.
-
-== Limitations
-
-* It is *not* an in-memory database.  Finds will not work.  Neither
-  will +reload+, currently.  Test fixtures won't work either, for
-  obvious reasons.
-* It has only the most rudimentery schema/migration support.  Complex
-  migrations will probably break it.
-* Lots of other things probably don't work.  Patches welcome!
-
-== Who
-
-NullDB was originally written by Avdi Grimm <mailto:avdi@avdi.org>.
-It is currently maintained by {Danilo Cabello}[https://github.com/cabello].
-Previously maintained by: {Bram de Vries}[https://github.com/blaet].
-
-== Where
-
-* Homepage: https://github.com/nulldb/nulldb
-
-== License
-
-See the LICENSE file for licensing information.