activerecord-null 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61c6b213e7c4c8f5cbeab18700a2eebc46803592fb34b3677ed93da0a6c49c92
-  data.tar.gz: 698f74dbdf03af5dbdc7e35111f20a478363c832028258c77cc14fdf0061b8b0
+  metadata.gz: 7367e3edc8eb1a5d3a539c08cb3ac8bc18a7334d36725edd397ca121adcd143c
+  data.tar.gz: 8e86346fcf08e650daeaacc39a70c213dce6cf63119317742fb0ecd5ffbdc142
 SHA512:
-  metadata.gz: 3e8fd9f3d1c8c130a997e3c66c6560b82e18b2ff782a2772832de7e4344abb59f0a6ef0efcaae67cb2a47dd221076b1113be2a0f520bc0c267a6ecb137c3b7eb
-  data.tar.gz: 9848bd89df1f1cb2ded9dcecd27f478aacbac6ed1586f56ecd7b17446b3755bceec6fbef8b0858b58be7996da11617c1d2f056517c0a55a03aff26a79ee483e5
+  metadata.gz: 2ec01aaa257aebaf1e5f9773e9d9d54431a0ffedf51adba02426b18552dc1bd20e1f64f3a1613a797fe69330c510526383e295650db1720e50b66b67715d6d25
+  data.tar.gz: eaf8a7c1df7a95fb2a48f44f519a81f5961d5ab681daa93933e47f80f88a3bfe335061642da59ad14456245363af478e5f62bbc9ecb616a610273b54ec88f287

data/CHANGELOG.md

@@ -5,24 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.3] - 2025-11-18
+## [0.1.4] - 2025-11-19
 
 ### Changed
 
-- Use git trailers to track changelog entries. (d296851)
-- Implement [] method to access attributes with string/symbol keys (1dc4f95)
+- Only initialize attributes when table exists (dba2ace)
 
-### Removed
-
-- CodeClimate access on CI runs. (2dbf5bc)
-
-## [0.1.3] - 2025-11-18
+## [0.1.4] - 2025-11-19
 
 ### Changed
 
-- Use git trailers to track changelog entries. (d296851)
-- Implement [] method to access attributes with string/symbol keys (1dc4f95)
-
-### Removed
-
-- CodeClimate access on CI runs. (2dbf5bc)
+- Only initialize attributes when table exists (dba2ace)

data/lib/activerecord/null/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Null
-    VERSION = "0.1.3"
+    VERSION = "0.1.4"
   end
 end

data/lib/activerecord/null.rb

@@ -45,7 +45,12 @@ module ActiveRecord
 
         include Singleton
 
+        # Store assignments for lazy initialization
+        @_null_assignments = assignments
+
         class << self
+          attr_reader :_null_assignments
+
           def method_missing(method, ...)
             mimic_model_class.respond_to?(method) ? mimic_model_class.send(method, ...) : super
           end
@@ -53,18 +58,42 @@ module ActiveRecord
           def respond_to_missing?(method, include_private = false)
             mimic_model_class.respond_to?(method, include_private) || super
           end
+
+          # Override instance to initialize attributes lazily
+          def instance
+            initialize_attribute_methods unless @_attributes_initialized
+            super
+          end
+
+          private
+
+          def initialize_attribute_methods
+            # Only initialize if table exists
+            return unless mimic_model_class.table_exists?
+
+            # Define custom assignment methods first
+            if _null_assignments.any?
+              _null_assignments.each do |attributes, value|
+                define_attribute_methods(attributes, value:)
+              end
+            end
+
+            # Then define database attributes
+            nil_assignments = mimic_model_class.attribute_names
+            # Remove custom assignments from database attributes
+            if _null_assignments.any?
+              _null_assignments.each do |attributes, _|
+                nil_assignments -= attributes
+              end
+            end
+            define_attribute_methods(nil_assignments) if nil_assignments.any?
+
+            @_attributes_initialized = true
+          end
         end
       end
       null_class.class_eval(&) if block_given?
 
-      nil_assignments = inherit.attribute_names
-      if assignments.any?
-        assignments.each do |attributes, value|
-          nil_assignments -= attributes
-          null_class.define_attribute_methods(attributes, value:)
-        end
-      end
-      null_class.define_attribute_methods(nil_assignments)
       inherit.const_set(:Null, null_class)
 
       inherit.define_singleton_method(:null) { null_class.instance }

data/test/activerecord/test_lazy_loading.rb

@@ -0,0 +1,141 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+# Test that Null classes can be defined without database access
+class LazyLoadingTest < Minitest::Spec
+  describe "Lazy attribute loading" do
+    it "allows Null class definition without database access" do
+      # Create a new model class with a fake table_exists? check
+      table_available = false
+
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "TestModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          table_available
+        end
+
+        define_singleton_method(:attribute_names) do
+          ["id", "name", "email"]
+        end
+      end
+
+      # Extend with Null - this should NOT require database
+      test_class.extend ActiveRecord::Null
+
+      # Define the Null class - this should also NOT require database
+      # This is the key fix - Null() doesn't call attribute_names
+      assert_silent do
+        test_class.Null([:name] => "Unknown")
+      end
+
+      # The Null class constant should exist
+      assert test_class.const_defined?(:Null)
+
+      # Now make table available
+      table_available = true
+
+      # When we call .null with table available, attributes get loaded
+      null_instance = test_class.null
+      assert_instance_of test_class::Null, null_instance
+      assert_equal "Unknown", null_instance.name
+      assert_nil null_instance.email
+    end
+
+    it "initializes attributes only once" do
+      call_count = 0
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "CountingModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          true
+        end
+
+        define_singleton_method(:attribute_names) do
+          call_count += 1
+          ["id", "value"]
+        end
+      end
+
+      test_class.extend ActiveRecord::Null
+      test_class.Null
+
+      # Calling .null multiple times should only initialize once
+      assert_equal 0, call_count
+      test_class.null
+      assert_equal 1, call_count
+      test_class.null
+      assert_equal 1, call_count
+      test_class.null
+      assert_equal 1, call_count
+    end
+
+    it "handles missing database gracefully" do
+      # Create a model that simulates a missing database
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "MissingDbModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          false
+        end
+
+        define_singleton_method(:attribute_names) do
+          raise ActiveRecord::NoDatabaseError, "Database 'test' does not exist"
+        end
+      end
+
+      test_class.extend ActiveRecord::Null
+
+      # Should be able to define Null class without database
+      assert_silent do
+        test_class.Null([:name] => "Unknown")
+      end
+
+      # Accessing .null returns the instance (but no attributes are defined yet)
+      null_instance = test_class.null
+      assert_instance_of test_class::Null, null_instance
+
+      # Without a table, no attributes work (not even custom ones)
+      # This is fine - in CI, you wouldn't call .null before running migrations
+      assert_raises(NoMethodError) { null_instance.name }
+    end
+
+    it "handles missing table gracefully" do
+      # Create a model that simulates a missing table
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "MissingTableModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          false
+        end
+
+        define_singleton_method(:attribute_names) do
+          raise ActiveRecord::StatementInvalid, "Table 'missing_table_models' doesn't exist"
+        end
+      end
+
+      test_class.extend ActiveRecord::Null
+
+      # Should be able to define Null class without table
+      assert_silent do
+        test_class.Null([:status] => "inactive")
+      end
+
+      # Accessing .null returns the instance
+      null_instance = test_class.null
+      assert_instance_of test_class::Null, null_instance
+
+      # Without a table, attributes don't work
+      assert_raises(NoMethodError) { null_instance.status }
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-null
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Jim Gay
@@ -39,6 +39,7 @@ files:
 - lib/activerecord/null.rb
 - lib/activerecord/null/mimic.rb
 - lib/activerecord/null/version.rb
+- test/activerecord/test_lazy_loading.rb
 - test/activerecord/test_null.rb
 - test/support/schema.rb
 - test/test_helper.rb