activerecord-null 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5da1cf27cad7e88a6c6696874f43ea35670baea4ba390b6d19d2ab9f044d842
-  data.tar.gz: fd69ad9dfe3b66e186aecb8b6b8411d814fad60ad908d2816e0e9a0ac2ad0a39
+  metadata.gz: 7367e3edc8eb1a5d3a539c08cb3ac8bc18a7334d36725edd397ca121adcd143c
+  data.tar.gz: 8e86346fcf08e650daeaacc39a70c213dce6cf63119317742fb0ecd5ffbdc142
 SHA512:
-  metadata.gz: 5c9f845b168b47184197bfc10367fc4a7b93bec34e9f31e01a81a88c64b4a55e7b1d09e911ed08cf19eb562738cc9255f43e43a03d5a832ced57d295e642fcca
-  data.tar.gz: a7fb4fe100e29d9151d2fefd5696db658171f4c061a0ded77424b7c1d2e947db4fec50c4c5d6cb0132a56463b22bfddc0da98ce064670d02c1713b159b1042bf
+  metadata.gz: 2ec01aaa257aebaf1e5f9773e9d9d54431a0ffedf51adba02426b18552dc1bd20e1f64f3a1613a797fe69330c510526383e295650db1720e50b66b67715d6d25
+  data.tar.gz: eaf8a7c1df7a95fb2a48f44f519a81f5961d5ab681daa93933e47f80f88a3bfe335061642da59ad14456245363af478e5f62bbc9ecb616a610273b54ec88f287

data/CHANGELOG.md

@@ -5,16 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.2] - 2025-06-17
+## [0.1.4] - 2025-11-19
 
-## [0.1.1] - 2024-10-25
+### Changed
 
-### Added
+- Only initialize attributes when table exists (dba2ace)
 
-- `null?` method to both parent class objects and null objects
-- Null objects now have default nil values for attributes of the mimic model class
-- `Null()` method can now accept a hash of attribute names and values to assign to the null object
-- `has_query_constraints?` method to null objects
-- `respond_to?` method to null objects
-- `_read_attribute` method to null objects
-- Null class now return false for `composite_primary_key?`
+## [0.1.4] - 2025-11-19
+
+### Changed
+
+- Only initialize attributes when table exists (dba2ace)

data/Rakefile

@@ -3,7 +3,9 @@
 require "bundler/gem_tasks"
 require "minitest/test_task"
 
-Minitest::TestTask.create
+Minitest::TestTask.create do |t|
+  t.test_prelude = 'require "test_helper"'
+end
 
 task default: :test
 
@@ -11,4 +13,5 @@ require "reissue/gem"
 
 Reissue::Task.create :reissue do |task|
   task.version_file = "lib/activerecord/null/version.rb"
+  task.fragment = :git
 end

data/lib/activerecord/null/mimic.rb

@@ -35,7 +35,13 @@ module ActiveRecord
 
       attr_reader :id
 
-      def [](*)
+      def [](key)
+        normalized_key = key.to_sym
+        association_names = mimic_model_class.reflect_on_all_associations.map(&:name)
+
+        return nil if association_names.include?(normalized_key)
+
+        respond_to?(normalized_key) ? send(normalized_key) : nil
       end
 
       def is_a?(klass)

data/lib/activerecord/null/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Null
-    VERSION = "0.1.2"
+    VERSION = "0.1.4"
   end
 end

data/lib/activerecord/null.rb

@@ -40,11 +40,17 @@ module ActiveRecord
       end
       null_class = Class.new do
         include ::ActiveRecord::Null::Mimic
+
         mimics inherit
 
         include Singleton
 
+        # Store assignments for lazy initialization
+        @_null_assignments = assignments
+
         class << self
+          attr_reader :_null_assignments
+
           def method_missing(method, ...)
             mimic_model_class.respond_to?(method) ? mimic_model_class.send(method, ...) : super
           end
@@ -52,18 +58,42 @@ module ActiveRecord
           def respond_to_missing?(method, include_private = false)
             mimic_model_class.respond_to?(method, include_private) || super
           end
+
+          # Override instance to initialize attributes lazily
+          def instance
+            initialize_attribute_methods unless @_attributes_initialized
+            super
+          end
+
+          private
+
+          def initialize_attribute_methods
+            # Only initialize if table exists
+            return unless mimic_model_class.table_exists?
+
+            # Define custom assignment methods first
+            if _null_assignments.any?
+              _null_assignments.each do |attributes, value|
+                define_attribute_methods(attributes, value:)
+              end
+            end
+
+            # Then define database attributes
+            nil_assignments = mimic_model_class.attribute_names
+            # Remove custom assignments from database attributes
+            if _null_assignments.any?
+              _null_assignments.each do |attributes, _|
+                nil_assignments -= attributes
+              end
+            end
+            define_attribute_methods(nil_assignments) if nil_assignments.any?
+
+            @_attributes_initialized = true
+          end
         end
       end
       null_class.class_eval(&) if block_given?
 
-      nil_assignments = inherit.attribute_names
-      if assignments.any?
-        assignments.each do |attributes, value|
-          nil_assignments -= attributes
-          null_class.define_attribute_methods(attributes, value:)
-        end
-      end
-      null_class.define_attribute_methods(nil_assignments)
       inherit.const_set(:Null, null_class)
 
       inherit.define_singleton_method(:null) { null_class.instance }

data/test/activerecord/test_lazy_loading.rb

@@ -0,0 +1,141 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+# Test that Null classes can be defined without database access
+class LazyLoadingTest < Minitest::Spec
+  describe "Lazy attribute loading" do
+    it "allows Null class definition without database access" do
+      # Create a new model class with a fake table_exists? check
+      table_available = false
+
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "TestModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          table_available
+        end
+
+        define_singleton_method(:attribute_names) do
+          ["id", "name", "email"]
+        end
+      end
+
+      # Extend with Null - this should NOT require database
+      test_class.extend ActiveRecord::Null
+
+      # Define the Null class - this should also NOT require database
+      # This is the key fix - Null() doesn't call attribute_names
+      assert_silent do
+        test_class.Null([:name] => "Unknown")
+      end
+
+      # The Null class constant should exist
+      assert test_class.const_defined?(:Null)
+
+      # Now make table available
+      table_available = true
+
+      # When we call .null with table available, attributes get loaded
+      null_instance = test_class.null
+      assert_instance_of test_class::Null, null_instance
+      assert_equal "Unknown", null_instance.name
+      assert_nil null_instance.email
+    end
+
+    it "initializes attributes only once" do
+      call_count = 0
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "CountingModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          true
+        end
+
+        define_singleton_method(:attribute_names) do
+          call_count += 1
+          ["id", "value"]
+        end
+      end
+
+      test_class.extend ActiveRecord::Null
+      test_class.Null
+
+      # Calling .null multiple times should only initialize once
+      assert_equal 0, call_count
+      test_class.null
+      assert_equal 1, call_count
+      test_class.null
+      assert_equal 1, call_count
+      test_class.null
+      assert_equal 1, call_count
+    end
+
+    it "handles missing database gracefully" do
+      # Create a model that simulates a missing database
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "MissingDbModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          false
+        end
+
+        define_singleton_method(:attribute_names) do
+          raise ActiveRecord::NoDatabaseError, "Database 'test' does not exist"
+        end
+      end
+
+      test_class.extend ActiveRecord::Null
+
+      # Should be able to define Null class without database
+      assert_silent do
+        test_class.Null([:name] => "Unknown")
+      end
+
+      # Accessing .null returns the instance (but no attributes are defined yet)
+      null_instance = test_class.null
+      assert_instance_of test_class::Null, null_instance
+
+      # Without a table, no attributes work (not even custom ones)
+      # This is fine - in CI, you wouldn't call .null before running migrations
+      assert_raises(NoMethodError) { null_instance.name }
+    end
+
+    it "handles missing table gracefully" do
+      # Create a model that simulates a missing table
+      test_class = Class.new(ApplicationRecord) do
+        def self.name
+          "MissingTableModel"
+        end
+
+        define_singleton_method(:table_exists?) do
+          false
+        end
+
+        define_singleton_method(:attribute_names) do
+          raise ActiveRecord::StatementInvalid, "Table 'missing_table_models' doesn't exist"
+        end
+      end
+
+      test_class.extend ActiveRecord::Null
+
+      # Should be able to define Null class without table
+      assert_silent do
+        test_class.Null([:status] => "inactive")
+      end
+
+      # Accessing .null returns the instance
+      null_instance = test_class.null
+      assert_instance_of test_class::Null, null_instance
+
+      # Without a table, attributes don't work
+      assert_raises(NoMethodError) { null_instance.status }
+    end
+  end
+end

data/test/activerecord/test_null.rb

@@ -124,6 +124,68 @@ class ActiveRecord::TestNull < Minitest::Spec
     it "responds to mimic methods" do
       expect(Post.null.respond_to?(:description)).must_equal true
     end
+
+    describe "bracket access" do
+      describe "with attributes" do
+        it "accesses attribute with symbol key" do
+          expect(User.null[:name]).must_equal "None"
+        end
+
+        it "accesses attribute with string key" do
+          expect(User.null["name"]).must_equal "None"
+        end
+
+        it "returns same value for string and symbol keys" do
+          expect(User.null[:team_name]).must_equal User.null["team_name"]
+          expect(User.null[:team_name]).must_equal "Unknown"
+        end
+
+        it "returns custom attribute values" do
+          expect(User.null[:name]).must_equal "None"
+        end
+
+        it "returns static assigned attribute values" do
+          expect(User.null[:team_name]).must_equal "Unknown"
+          expect(User.null[:other]).must_equal "Unknown"
+        end
+
+        it "returns callable attribute values" do
+          expect(Post.null[:description]).must_equal "From the callable!"
+          expect(Post.null["description"]).must_equal "From the callable!"
+        end
+
+        it "returns nil for default attributes" do
+          expect(User.null[:id]).must_be_nil
+          expect(Post.null[:title]).must_be_nil
+        end
+      end
+
+      describe "with associations" do
+        it "returns nil for belongs_to association" do
+          expect(User.null[:business]).must_be_nil
+          expect(Post.null[:user]).must_be_nil
+        end
+
+        it "returns nil for has_many association" do
+          expect(User.null[:posts]).must_be_nil
+        end
+
+        it "still allows dot notation for associations" do
+          expect(User.null.business).must_be_instance_of Business::Null
+          expect(User.null.posts).must_be_kind_of ActiveRecord::Relation
+        end
+      end
+
+      describe "with non-existent keys" do
+        it "returns nil for unknown symbol key" do
+          expect(User.null[:nonexistent]).must_be_nil
+        end
+
+        it "returns nil for unknown string key" do
+          expect(User.null["nonexistent"]).must_be_nil
+        end
+      end
+    end
   end
 
   describe "Parent class object" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-null
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
 platform: ruby
 authors:
 - Jim Gay
@@ -39,6 +39,7 @@ files:
 - lib/activerecord/null.rb
 - lib/activerecord/null/mimic.rb
 - lib/activerecord/null/version.rb
+- test/activerecord/test_lazy_loading.rb
 - test/activerecord/test_null.rb
 - test/support/schema.rb
 - test/test_helper.rb
@@ -62,7 +63,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.7.2
 specification_version: 4
 summary: Null Objects for ActiveRecord
 test_files: []