activerecord-mysql-unsigned 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 28887c8744010284c741bf409074d986e2e04092
-  data.tar.gz: 054d6bc7e97203547459bc040f05d362f14083db
+  metadata.gz: 5fc6191d31871ae48741ed325d6bc3540ebc7ee2
+  data.tar.gz: b40d32872ba7ddec346904003b3a609d53feffaf
 SHA512:
-  metadata.gz: 3f47eeeea032def664defb3990a04c78cb181e1b3a813999d12d3a0f8320f3d52c11c31d94978f3deb87beef30129d39aa0950e78b2051119574ff5edd911c7a
-  data.tar.gz: 3ecd003fd8ce4dbd6158dffe52129d54622e950752c009dbedd094005ccdf8f3dbdfbef38f34ca57ed358ba3777dfd61b7101825f832be401bf8cc81963c8654
+  metadata.gz: e731e9b545386d2e1d7137311fa5f82a518930493a052dc385a5d70873bdb4d09b0a7d7aee86cff1c0047232c70089d0c9e07dc7a80a1b69c082af836b8322df
+  data.tar.gz: f97831d2ca2f5cd753baf50deff5443a5c4b2155d95165b71a948e9b6e0b3a4ddedb2e7b5d61937f1683d9cafca544f23183d2e343a413350fd37de74af160f2

data/lib/activerecord-mysql-unsigned/active_record/v4/connection_adapters/abstract_mysql_adapter.rb

@@ -10,9 +10,11 @@ module ActiveRecord
       class SchemaCreation < AbstractAdapter::SchemaCreation
         def visit_AddColumn(o)
           sql_type = type_to_sql(o.type.to_sym, o.limit, o.precision, o.scale, o.unsigned)
-          sql = "ADD #{quote_column_name(o.name)} #{sql_type}"
-          add_column_options!(sql, column_options(o)) unless o.type.to_sym == :primary_key
-          add_column_position!(sql, column_options(o))
+          add_column_sql = "ADD #{quote_column_name(o.name)} #{sql_type}"
+          add_column_options!(add_column_sql, column_options(o)) unless o.type.to_sym == :primary_key
+          add_column_position!(add_column_sql, column_options(o))
+
+          add_column_sql
         end
 
         def visit_ChangeColumnDefinition(o)
@@ -22,12 +24,15 @@ module ActiveRecord
           change_column_sql = "CHANGE #{quote_column_name(column.name)} #{quote_column_name(options[:name])} #{sql_type}"
           add_column_options!(change_column_sql, options.merge(column: column)) unless o.type.to_sym == :primary_key
           add_column_position!(change_column_sql, options)
+
+          change_column_sql
         end
 
         def visit_ColumnDefinition(o)
           sql_type = type_to_sql(o.type.to_sym, o.limit, o.precision, o.scale, o.unsigned)
           column_sql = "#{quote_column_name(o.name)} #{sql_type}"
           add_column_options!(column_sql, column_options(o)) unless o.type.to_sym == :primary_key
+
           column_sql
         end
 

data/lib/activerecord-mysql-unsigned/version.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module Mysql
     module Unsigned
-      VERSION = "0.3.0"
+      VERSION = "0.3.1"
     end
   end
 end

data/spec/unsigned_spec.rb

@@ -52,6 +52,16 @@ describe "INT/Decimal column" do
     expect(unsigned_int_col.unsigned?).to be_truthy
   end
 
+  it "signed column has 'unsigned' attribute after changed" do
+    will_unsigned_int_col = User.columns[4]
+    expect(will_unsigned_int_col.unsigned?).to be_truthy
+  end
+
+  it "unsigned column has 'signed' attribute after changed" do
+    will_signed_int_col = User.columns[5]
+    expect(will_signed_int_col.unsigned?).to be_falsey
+  end
+
   it "allowed minus value of signed decimal" do
     @user.signed_decimal = -10.0
     @user.save

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-mysql-unsigned
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - yo_waka