activerecord-mysql-enum 0.1.0 → 0.1.4.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 731be1b698830840960df66c633230838cc5a12a
-  data.tar.gz: 0546d381f19f95569f6b44aa9c63ec2e5aa53cf1
+  metadata.gz: 65f091ec84ca56cc57327fc3ed102b44d5144186
+  data.tar.gz: 93580fa1fe7b02bb89852aad0fe8f78114934bd4
 SHA512:
-  metadata.gz: 03b00f78790935c06f5fca8979e25618a73e81a9e7f5c8c3bd7745834054b63303414769dc17374e1f482ec5aeaa2b30b470ec03eafe943f8b4046614cd3ae21
-  data.tar.gz: 94b3cf153dfc170e391914761b6286002806ff405bdaabf9877e57294218363714f38f1af9d32b6696d6a205a469e22aef969183888799d072aa74d108a1f61a
+  metadata.gz: 51727f428f088f3a4984566760a0634eeec7651982b8e587f8ca347e29a23edff865922d92c5c3fe68e359976692d1aa47d8921e6fe78cef756d48636e77ad9d
+  data.tar.gz: bf39dcfcfa03f9d0ead9b94da25fa762f1b2c438abea2f319504fbc43d0657d3f7fd33c9086518d56887a98eeca8c482181f709eef04045403e033793b4a1798

data/CHANGELOG.md

@@ -4,6 +4,23 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.4] - Unreleased
+### Fixed
+- Fixed bug in `mysql_adapter` where optional arguments being passed to `type_to_sql` would cause
+  an unexpected error
+
+## [0.1.3] - 2020-08-19
+### Changed
+- refactor mysql adapter
+
+## [0.1.2] - 2020-08-18
+### Changed
+- fixed frozen string to reassign value instead of append
+
+## [0.1.1] - 2020-08-18
+### Added
+- extended activerecord dependency to '>= 4.2', '< 7'
+
 ## [0.1.0] - 2020-08-17
 ### Added
 - Backwards compatibility with Rails 4
@@ -11,4 +28,8 @@ Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0
 ### Changed
 - Renamed the gem from `enum_column3` to `activerecord-mysql-enum`
 
-[0.1.0]: https://github.com/Invoca/activerecord-mysql-enum/tree/0.1.0
+[0.1.4]: https://github.com/Invoca/activerecord-mysql-enum/compare/v0.1.3...v0.1.4
+[0.1.3]: https://github.com/Invoca/activerecord-mysql-enum/compare/v0.1.2...v0.1.3
+[0.1.2]: https://github.com/Invoca/activerecord-mysql-enum/compare/v0.1.1...v0.1.2
+[0.1.1]: https://github.com/Invoca/activerecord-mysql-enum/compare/v0.1.0...v0.1.1
+[0.1.0]: https://github.com/Invoca/activerecord-mysql-enum/tree/v0.1.0

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    activerecord-mysql-enum (0.1.0)
-      activerecord (>= 4.2, < 6)
+    activerecord-mysql-enum (0.1.4.pre.1)
+      activerecord (>= 4.2, < 7)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -17,7 +17,7 @@ Currently this has been manually tested with Rails version 4 and 5, and works wi
 ## Installation
 In your `Gemfile` add the following snippet
 ```ruby
-gem 'activerecord-mysql-enum', '~> 0.1', require: 'active_support/mysql/enum'
+gem 'activerecord-mysql-enum', '~> 0.1', require: 'active_record/mysql/enum'
 ```
 
 ## Usage

data/enum_column.gemspec

@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
   end
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'activerecord', '>= 4.2', '< 6'
+  spec.add_dependency 'activerecord', '>= 4.2', '< 7'
 end

data/lib/active_record/mysql/enum/mysql_adapter.rb

@@ -28,29 +28,37 @@ module ActiveRecord
         #
         # will generate enum('a', 'b', 'c') for :limit => [:a, :b, :c]
         if Rails::VERSION::MAJOR < 5
-          def type_to_sql(type, limit = nil, precision = nil, scale = nil, unsigned = nil, **_options) # :nodoc:
+          def type_to_sql(type, limit = nil, precision = nil, scale = nil, **_options)
             if type.to_s == 'enum'
-              native = native_database_types[type]
-              column_type_sql = (native || {})[:name] || 'enum'
+              column_type_sql =
+                if (native_database_type = native_database_types[type])
+                  native_database_type[:name]
+                else
+                  'enum'
+                end
 
-              column_type_sql << "(#{limit.map { |v| quote(v) }.join(',')})"
+              quoted_values = limit.map { |v| quote(v) }.join(',')
 
-              column_type_sql
+              "#{column_type_sql}(#{quoted_values})"
             else
-              super(type, limit, precision, scale, unsigned)
+              super
             end
           end
         else
           def type_to_sql(type, limit: nil, precision: nil, scale: nil, unsigned: nil, **_options) # :nodoc:
             if type.to_s == 'enum'
-              native = native_database_types[type]
-              column_type_sql = (native || {})[:name] || 'enum'
+              column_type_sql =
+                if (native_database_type = native_database_types[type])
+                  native_database_type[:name]
+                else
+                  'enum'
+                end
 
-              column_type_sql << "(#{limit.map { |v| quote(v) }.join(',')})"
+              quoted_values = limit.map { |v| quote(v) }.join(',')
 
-              column_type_sql
+              "#{column_type_sql}(#{quoted_values})"
             else
-              super(type, limit: limit, precision: precision, scale: scale, unsigned: unsigned)
+              super
             end
           end
         end

data/lib/active_record/mysql/enum/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module Mysql
     module Enum
-      VERSION = "0.1.0"
+      VERSION = "0.1.4.pre.1"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-mysql-enum
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.4.pre.1
 platform: ruby
 authors:
 - Nick Pohodnya
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-17 00:00:00.000000000 Z
+date: 2020-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -20,7 +20,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -30,7 +30,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '7'
 description: Enable enum type for the MySQL Adapter in ActiveRecord
 email:
 - development@invoca.com
@@ -76,9 +76,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.13