activerecord-minimizer 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d267d90b4e0fb5fa138099d607c877642be888d811836e9a01ba5d902805f62
-  data.tar.gz: 0b5835ae5a2ed8290e2a1cfbce79be67e5a5a088339aba4531c38679f8bbe560
+  metadata.gz: 765a2a713e6c6e2582ea3710affccdbfcae87fc798c40a8687f32856b24d2d6b
+  data.tar.gz: 32d4267611a306b162b1a3c47d082c29b6a080d30ae066d3dfd1a6db1d4a69a7
 SHA512:
-  metadata.gz: 225301a99201d5b86bc759bd0aed0fb2b52ee410036ca844be740a013036639c94e9e58ffb71aca19aae5c17a364ba35e634500053a68b9f6b718838534bd2b9
-  data.tar.gz: ca8f655b05effb30eeaa8558463467ea42e96ddd0694842d90b18c170419ed7137791c83b98c4050665e34aeefcbb8272bda170fd9fde4ce7b96cc3fc2c08a1d
+  metadata.gz: 67faf17cd90cfd3583be2eefbc532423e75628270a198f1f55834c2881b62c3428db9c83b272e6ccfb4ffd5d1ecfe8f0233b8b2ce14cbc9f4a2671458d5cb923
+  data.tar.gz: 8b9fafd7a79f04d9dda376491def78b8441003e9b948955c8a7e07d7a3bf06669842bdb7b3f2922509ec54932f580fe79110ac3779ca4be01cb3fdb090fffb83

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 0.1.2 (2026-10-18)
+
+- Strict mode no longer breaks what gems and Rails call by name, so a keep
+  list is only needed for an app's own names:
+  - `<attr>_in_database` and `clear_<attr>_change` are generated on first
+    call: `increment!`/`decrement!`, and so counter caches, raised before.
+  - Devise models keep every attribute method of the columns Devise uses
+    (email, encrypted_password, unconfirmed_email and the configured keys).
+    Recoverable asks `respond_to?("will_save_change_to_<key>?")` before
+    clearing the reset password token, so without these an old reset link
+    kept working after a password change.
+  - Active Storage blobs and Action Mailbox inbound emails keep the methods
+    those frameworks call.
+
 ## 0.1.1 (2026-10-18)
 
 - Small records work on Rails main, whose attribute sets take a `default_keys` argument and get a fresh `{}` from Rails; the association cache Rails main leaves `nil` until used is left alone.

data/README.md

@@ -26,18 +26,25 @@ name_changed? was removed by activerecord-minimizer's strict mode; use attribute
 ```
 
 [rubocop-minify](../rubocop-minify) rewrites those calls in your Ruby and ERB.
-Gems that call them by name (Devise's `will_save_change_to_email?`, Active
-Storage's `service_name_changed?`, counter caches) get them back from a keep
-list, `config/ar_minimizer_keep.txt`, one `name` or `Model#name` per line.
-To find what to put there, run the test suite with `strict = false` and
+What other gems and your own code call by name goes in a keep list,
+`config/ar_minimizer_keep.txt`, one `name` or `Model#name` per line. To find
+what to put there, run the test suite with `strict = false` and
 `AR_MINIMIZER_PROFILE=tmp/ar_minimizer`, then `bin/rails ar_minimizer:profile`.
 
-Rails itself still gets what it needs:
+Rails and common gems still get what they call by name, without a keep list:
 
 * `<attr>_before_type_cast` and `<attr>_came_from_user?` answer `respond_to?`
   and are generated on first call. Form fields and numericality validation ask
   before calling them, and quietly do something else when told no (a form
   would show the cast value, `"abc"` would validate as 0).
+* `<attr>_in_database` and `clear_<attr>_change` are generated on first call:
+  `increment!`/`decrement!`, and so counter caches, use them.
+* Devise models keep every attribute method of the columns Devise uses (email,
+  encrypted_password, unconfirmed_email and the configured keys). Recoverable
+  asks `respond_to?` before clearing the reset password token on a password
+  or email change.
+* Active Storage blobs and Action Mailbox inbound emails keep what those
+  frameworks call (`service_name_changed?`, `status_previously_changed?`, ...).
 * `<enum>_for_database` and `updated_at_before_type_cast`/`_came_from_user?`
   are generated up front: Rails calls them on hot paths.
 * Aliases (`alias_attribute`, Rails' own `id_value`), partial selects
@@ -47,6 +54,9 @@ Rails itself still gets what it needs:
 `config.ar_minimizer.strict = false` keeps the removed methods working: the
 first call to one generates it on that model.
 
+Turn `slim` on in development and tests as well as production: the
+errors then show up while you work and in CI. Slim follows code reloads.
+
 ## Compiling call sites
 
 Calls whose receiver is known to be a record of a model with that column are

data/lib/ar_minimizer/slim.rb

@@ -17,11 +17,35 @@ module ArMinimizer
 
     MATCH = ActiveModel::AttributeMethods::ClassMethods::AttributeMethodPattern::AttributeMethod
 
-    # Rails asks respond_to? before calling these, and quietly does something
-    # else when the answer is no: form fields show the cast value instead of
-    # what the user typed, numericality validates the cast value ("abc" -> 0).
-    # Strict mode keeps them answering, generated on first call.
-    PROBED = { "_before_type_cast" => "attribute_before_type_cast", "_came_from_user?" => "attribute_came_from_user?" }.freeze
+    # [prefix, suffix, proxy] of the patterns Rails itself calls by name, for
+    # any attribute. Strict mode generates them on first call instead of
+    # removing them:
+    # - _before_type_cast, _came_from_user?: Rails asks respond_to? first and
+    #   quietly does something else when told no (form fields would show the
+    #   cast value, numericality would validate it: "abc" -> 0).
+    # - _in_database, clear_..._change: increment!/decrement!, and so every
+    #   counter cache, call them on the attribute they change.
+    ON_DEMAND = [
+      ["", "_before_type_cast", "attribute_before_type_cast"],
+      ["", "_came_from_user?", "attribute_came_from_user?"],
+      ["", "_in_database", "attribute_in_database"],
+      ["clear_", "_change", "clear_attribute_change"],
+    ].freeze
+    ON_DEMAND_PROXIES = ON_DEMAND.map(&:last).freeze
+
+    # Methods Rails' own models call by name.
+    FRAMEWORK_KEEP = {
+      "ActiveStorage::Blob" => %w[content_type_previously_changed? metadata_previously_changed? metadata_changed? service_name_changed?],
+      "ActionMailbox::InboundEmail" => %w[status_previously_changed?],
+    }.freeze
+
+    # Columns Devise works with on a model, besides its configured keys: it
+    # calls their dirty-tracking methods by name, some behind respond_to?
+    # (Recoverable clears the reset password token only when it's told the
+    # password or an authentication key will change).
+    DEVISE_COLUMNS = %w[email encrypted_password unconfirmed_email].freeze
+    DEVISE_KEYS = %i[authentication_keys reset_password_keys confirmation_keys unlock_keys
+                     case_insensitive_keys strip_whitespace_keys].freeze
 
     class << self
       attr_reader :keep, :keep_methods
@@ -86,6 +110,7 @@ module ArMinimizer
         return false if Thread.current[:ar_minimizer_generating] == name
         return false if keep.include?(pattern.proxy_target)
         return false if keep_methods.include?(name) || keep_methods.include?("#{model.name}##{name}")
+        return false if FRAMEWORK_KEEP[model.name]&.include?(name)
 
         !framework_calls?(model, pattern.proxy_target, attr_name.to_s)
       end
@@ -145,8 +170,21 @@ module ArMinimizer
         # every enum predicate (`published?`) and enum scope calls status_for_database
         when "attribute_for_database" then model.defined_enums.key?(attr)
         # cache_version, on every cache key with recyclable cache keys
-        when "attribute_before_type_cast", "attribute_came_from_user?" then attr == "updated_at"
-        else false
+        when "attribute_before_type_cast", "attribute_came_from_user?" then attr == "updated_at" || devise_column?(model, attr)
+        else devise_column?(model, attr)
+        end
+      end
+
+      # All of a Devise model's attribute methods for the columns Devise uses.
+      def devise_column?(model, attr)
+        return false unless model.respond_to?(:devise_modules)
+        return true if DEVISE_COLUMNS.include?(attr)
+
+        DEVISE_KEYS.any? do |config|
+          next false unless model.respond_to?(config)
+
+          keys = model.public_send(config)
+          (keys.is_a?(Hash) ? keys.keys : Array(keys)).any? { it.to_s == attr }
         end
       end
     end
@@ -190,7 +228,7 @@ module ArMinimizer
       # without this `user.method(:name_changed?)` raises NameError.
       def respond_to_missing?(name, include_private = false)
         # Strict: matched_attribute_method only matches readers, writers and
-        # the PROBED patterns.
+        # the ON_DEMAND patterns.
         super || (Slim.enabled? && !matched_attribute_method(name.to_s).nil?)
       end
 
@@ -209,7 +247,7 @@ module ArMinimizer
           return super
         end
 
-        Slim.generate(self.class, name.name, match) if Slim.lazy? || Slim::PROBED.value?(match.proxy_target)
+        Slim.generate(self.class, name.name, match) if Slim.lazy? || Slim::ON_DEMAND_PROXIES.include?(match.proxy_target)
         attribute_missing(match, ...)
       end
 
@@ -219,10 +257,10 @@ module ArMinimizer
       def matched_attribute_method(method_name)
         return super unless Slim.strict?
 
-        Slim::PROBED.each do |suffix, proxy|
-          next unless method_name.end_with?(suffix)
+        Slim::ON_DEMAND.each do |prefix, suffix, proxy|
+          next unless method_name.length > prefix.length + suffix.length && method_name.start_with?(prefix) && method_name.end_with?(suffix)
 
-          attr = method_name.delete_suffix(suffix)
+          attr = method_name[prefix.length...-suffix.length]
           klass = self.class
           return Slim::MATCH.new(proxy, attr) if klass._has_attribute?(attr) || klass.attribute_aliases.key?(attr) || @attributes&.key?(attr)
         end

data/lib/ar_minimizer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ArMinimizer
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-minimizer
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Sampo Kuokkanen