activerecord-jdbcas400-adapter 1.3.9 → 1.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aa4ffdd7241e533ca058a550299fd74f7540045b
-  data.tar.gz: 8054ecb61e7a29c63172fdc4a70c88fd015511d6
+  metadata.gz: c2c2d5e512ff9f9dc96f2cae3918cb358ccf8285
+  data.tar.gz: 39ce06e01993e31cd1eea228ffb5c5c7b9efadb0
 SHA512:
-  metadata.gz: ab3ca543c1912dcc6faeb0314cbd29e28ce987abcfd129a0fd8a34952e11b76ee01d233fae61487e445eace73b521a86fcd778b4c7a8b2511f0de324f8cf8685
-  data.tar.gz: fe598ce868542fab9e3d016040c882163eacb12fc6b6ef57e3d2c3bc9e57801b54a532cc410182ab73db8fa916239334810e69bad8e27b28356e7d52cbca8a03
+  metadata.gz: 58c0d0c0684ba5b27906c21235fcac6e901fc2ab7ac905b1e9b83fbe5bd37de7b88870f518fa9d60f53a74a6509821d8f45d48f52ae29be219cbc0a0a361da81
+  data.tar.gz: 3a6ffbb7e5d08eb1e0049c3e4e19d25a4daf539c989a3da0f0dd1cf29391a212350dccbfe6ce68e8c64b54283b24277a8763fc9809859f49a0e452f8c3f415c2

data/README.md

@@ -113,4 +113,4 @@ It requires JDBC 4.0 driver and Java 6.
 
 ## Dependency
 
-You can embed the JTOpen driver in your application. It is distributed in a separate gem : 'as400-jdbc'
+You can embed the JTOpen driver in your application. It is distributed in a separate gem : '[jdbc-as400](http://rubygems.org/gems/jdbc-as400)'

data/Rakefile

@@ -1,2 +1,10 @@
 require 'bundler/gem_helper'
 Bundler::GemHelper.install_tasks
+
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs = ['lib', 'test']
+  t.test_files = FileList['test/*_test.rb']
+  t.verbose = true
+end

data/lib/arjdbc/as400/adapter.rb

@@ -48,13 +48,16 @@ module ArJdbc
       db2_schema
     end
 
-    # Return only migrated tables
-    def tables
-      if current_library
-        @connection.tables(nil, current_library)
-      else
-        @connection.tables(nil, schema)
+    def tables(name = nil)
+      # Do not perform search on all system
+      if system_naming?
+        name ||= current_library
+        unless name
+          raise StandardError.new('Unable to retrieve tables without current library')
+        end
       end
+
+      @connection.tables(nil, name)
     end
 
     # Prevent migration in QGPL
@@ -72,6 +75,9 @@ module ArJdbc
     # @override
     def rename_column(table_name, column_name, new_column_name)
       column = columns(table_name, column_name).find { |column| column.name == column_name.to_s}
+      unless column
+        raise ActiveRecord::ActiveRecordError, "No such column: #{table_name}.#{column_name}"
+      end
       add_column(table_name, new_column_name, column.type, column.instance_values)
       execute("UPDATE #{quote_table_name(table_name)} SET #{quote_column_name(new_column_name)} = #{quote_column_name(column_name)} WITH NC")
       remove_column(table_name, column_name)

data/test/{test_adapter.rb → adapter_test.rb}

@@ -43,6 +43,10 @@ class TestAdapter < Test::Unit::TestCase
       connection.execute('CREATE TABLE test_table (test_column INTEGER)')
       connection.execute('INSERT INTO test_table(test_column) VALUES(1)')
 
+      assert_raise do
+        connection.rename_column('test_table', 'no_column', '')
+      end
+
       connection.rename_column('test_table', 'test_column', 'new_test_column')
       assert_not_nil(connection.columns('test_table').find { |column| column.name == 'new_test_column' })
       assert_equal(connection.select_one('SELECT new_test_column FROM test_table')['new_test_column'], 1)
@@ -55,4 +59,4 @@ class TestAdapter < Test::Unit::TestCase
     assert_equal(connection.transaction_isolation_levels.fetch(:no_commit), 'NO COMMIT')
   end
 
-end
+end

metadata

@@ -1,85 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-jdbcas400-adapter
 version: !ruby/object:Gem::Version
-  version: 1.3.9
+  version: 1.3.10
 platform: ruby
 authors:
 - Nick Sieger, Ola Bini, Pierrick Rouxel and JRuby contributors
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-10-03 00:00:00.000000000 Z
+date: 2014-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activerecord-jdbc-adapter
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 1.3.9
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.9
+  name: activerecord-jdbc-adapter
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: bundler
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: 1.3.9
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
+  name: bundler
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: rake
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.5'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: rake
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: test-unit
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: test-unit
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency
-  name: jdbc-as400
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: jdbc-as400
   prerelease: false
   type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Install this gem to use AS/400 with JRuby on Rails.
 email: nick@nicksieger.com, ola.bini@gmail.com
 executables: []
@@ -96,10 +96,10 @@ files:
 - lib/arjdbc/as400/adapter.rb
 - lib/arjdbc/as400/connection_methods.rb
 - lib/arjdbc/as400/system.rb
-- test/test_adapter.rb
-- test/test_database_tasks.rb
+- test/adapter_test.rb
+- test/database_tasks_test.rb
+- test/system_test.rb
 - test/test_helper.rb
-- test/test_system.rb
 homepage: https://github.com/pierrickrouxel/activerecord-jdbcas400-adapter
 licenses:
 - ''
@@ -125,7 +125,7 @@ signing_key:
 specification_version: 4
 summary: AS/400 JDBC adapter for JRuby on Rails.
 test_files:
-- test/test_adapter.rb
-- test/test_database_tasks.rb
+- test/adapter_test.rb
+- test/database_tasks_test.rb
+- test/system_test.rb
 - test/test_helper.rb
-- test/test_system.rb